Re: [openstack-dev] [all] Changes to Zuul role checkouts

2018-04-10 Thread Andrea Frittoli
On Mon, Apr 9, 2018 at 5:55 PM James E. Blair  wrote:

> Hi,
>
> We recently fixed a subtle but important bug related to how Zuul checks
> out repositories it uses to find Ansible roles for jobs.
>

\o/


>
> This may result in a behavior change, or even an error, for jobs which
> use roles defined in projects with multiple branches.
>
> Previously, Zuul would (with some exceptions) generally check out the
> 'master' branch of any repository which appeared in the 'roles:' stanza
> in the job definition.  Now Zuul will follow its usual procedure of
> trying to find the most appropriate branch to check out.  That means it
> tries the project override-checkout branch first, then the job
> override-checkout branch, then the branch of the change, and finally the
> default branch of the project.
>
> This should produce more predictable behavior which matches the
> checkouts of all other projects involved in a job.
>
> If you find that the wrong branch of a role is being checked out,
> depending on circumstances, you may need to set a job or project
> override-checkout value to force the correct one, or you may need to
> backport a role to an older branch.
>
> If you encounter any problems related to this, please chat with us in
> #openstack-infra.
>
>
Thanks a lot Jim for fixing this!

With this in place I can now continue the work on devstack, tempest and
grenade base roles and jobs for zuul v3.
Next steps (in order of dependency):
- backport ansible devstack changes to queens and pike
- start using the "orchestrate-devstack" role in the "devstack-tempest" base
  job - so that it can be used for multinode jobs as well
- continue the work on setting up a grenade zuulv3 job

Andrea Frittoli (andreaf)



> Thanks,
>
> Jim
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [all] Changes to Zuul role checkouts

2018-04-09 Thread David Moreau Simard
If you're not familiar with the "override-checkout" configuration, you
can find the documentation about it here [1] and some example usage
here [2].

[1]: https://zuul-ci.org/docs/zuul/user/config.html#attr-job.override-checkout
[2]: http://codesearch.openstack.org/?q=override-checkout

David Moreau Simard
Senior Software Engineer | OpenStack RDO

dmsimard = [irc, github, twitter]


On Mon, Apr 9, 2018 at 12:55 PM, James E. Blair  wrote:
> Hi,
>
> We recently fixed a subtle but important bug related to how Zuul checks
> out repositories it uses to find Ansible roles for jobs.
>
> This may result in a behavior change, or even an error, for jobs which
> use roles defined in projects with multiple branches.
>
> Previously, Zuul would (with some exceptions) generally check out the
> 'master' branch of any repository which appeared in the 'roles:' stanza
> in the job definition.  Now Zuul will follow its usual procedure of
> trying to find the most appropriate branch to check out.  That means it
> tries the project override-checkout branch first, then the job
> override-checkout branch, then the branch of the change, and finally the
> default branch of the project.
>
> This should produce more predictable behavior which matches the
> checkouts of all other projects involved in a job.
>
> If you find that the wrong branch of a role is being checked out,
> depending on circumstances, you may need to set a job or project
> override-checkout value to force the correct one, or you may need to
> backport a role to an older branch.
>
> If you encounter any problems related to this, please chat with us in
> #openstack-infra.
>
> Thanks,
>
> Jim
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [all] Changes to Zuul role checkouts

2018-04-09 Thread James E. Blair
Hi,

We recently fixed a subtle but important bug related to how Zuul checks
out repositories it uses to find Ansible roles for jobs.

This may result in a behavior change, or even an error, for jobs which
use roles defined in projects with multiple branches.

Previously, Zuul would (with some exceptions) generally check out the
'master' branch of any repository which appeared in the 'roles:' stanza
in the job definition.  Now Zuul will follow its usual procedure of
trying to find the most appropriate branch to check out.  That means it
tries the project override-checkout branch first, then the job
override-checkout branch, then the branch of the change, and finally the
default branch of the project.

This should produce more predictable behavior which matches the
checkouts of all other projects involved in a job.

If you find that the wrong branch of a role is being checked out,
depending on circumstances, you may need to set a job or project
override-checkout value to force the correct one, or you may need to
backport a role to an older branch.

If you encounter any problems related to this, please chat with us in
#openstack-infra.

Thanks,

Jim

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev