Re: [openstack-dev] [horizon] FFE Request for Queens
Thanks Akihiro I will bring it up on today's meeting. Regards Lajos On 2018-01-31 10:39, Akihiro Motoki wrote: +1 for FFE. I can support it. We need a final ack from our PTL. Akihiro 2018-01-30 5:13 GMT+09:00 Lajos Katona: Hi, I would like to ask for FFE on the neutron-trunk-ui blueprint to let the admin panel for trunks be accepted for Queens. Based on discussion on IRC (http://eavesdrop.openstack.org/irclogs/%23openstack-horizon/%23openstack-horizon.2018-01-29.log.html#t2018-01-29T14:36:58 ) the remaining part of the blueprint neutron-trunk-ui (https://blueprints.launchpad.net/horizon/+spec/neutron-trunk-ui) should be handled separately: The admin panel (https://review.openstack.org/516657) should be part of the Queens release, as now that is not dependent on the ngDetails patches. With this the blueprint should be set to implemented. The links (https://review.openstack.org/524619) for the ports details (trunk parent and subports) from the trunk panel should be handled in a bug report: https://bugs.launchpad.net/horizon/+bug/1746082 Regards Lajos Katona __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] FFE Request for Queens
+1 for FFE. I can support it. We need a final ack from our PTL. Akihiro 2018-01-30 5:13 GMT+09:00 Lajos Katona: > Hi, > > I would like to ask for FFE on the neutron-trunk-ui blueprint to let the > admin panel for trunks be accepted for Queens. > > Based on discussion on IRC > (http://eavesdrop.openstack.org/irclogs/%23openstack-horizon/%23openstack-horizon.2018-01-29.log.html#t2018-01-29T14:36:58 > ) the remaining part of the blueprint neutron-trunk-ui > (https://blueprints.launchpad.net/horizon/+spec/neutron-trunk-ui) should be > handled separately: > > The admin panel (https://review.openstack.org/516657) should be part of the > Queens release, as now that is not dependent on the ngDetails patches. With > this the blueprint should be set to implemented. > The links (https://review.openstack.org/524619) for the ports details (trunk > parent and subports) from the trunk panel should be handled in a bug report: > > https://bugs.launchpad.net/horizon/+bug/1746082 > > Regards > Lajos Katona > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [horizon] FFE Request for Queens
Hi, I would like to ask for FFE on the neutron-trunk-ui blueprint to let the admin panel for trunks be accepted for Queens. Based on discussion on IRC (http://eavesdrop.openstack.org/irclogs/%23openstack-horizon/%23openstack-horizon.2018-01-29.log.html#t2018-01-29T14:36:58 ) the remaining part of the blueprint neutron-trunk-ui (https://blueprints.launchpad.net/horizon/+spec/neutron-trunk-ui) should be handled separately: * The admin panel (https://review.openstack.org/516657) should be part of the Queens release, as now that is not dependent on the ngDetails patches. With this the blueprint should be set to implemented. * The links (https://review.openstack.org/524619) for the ports details (trunk parent and subports) from the trunk panel should be handled in a bug report: o https://bugs.launchpad.net/horizon/+bug/1746082 Regards Lajos Katona __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] FFE Request
On Thu, Jan 26, 2017 at 9:37 PM, Rob Cresswellwrote: > I'll put up Security Groups and Floating IPs once they start moving > (maintaining huge patch chains is a waste of time) Huge +1! Cheers, Lingxian Kong (Larry) __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] FFE Request
Yeah, I'll 1+ the patch. The move is an easy one once the bug is resolved.I'm quite amused by the bug, and that someone else filed the same bug a couple of hours right before me (and I missed it). Will review his fix.Looking forward to your other two patches.On 26/01/2017 9:37 PM, Rob Cresswell <robert.cressw...@outlook.com> wrote: Wow, lots of replies. Thanks for the FFE. I'd request that we proceed with the panel separation now, and resolve the final location when any bug fixes have merged. I don't really want to hold up a whole chain of patches over a one line path change. API Access and Key Pairs are done, and I'll put up Security Groups and Floating IPs once they start moving (maintaining huge patch chains is a waste of time) Rob On 26 January 2017 at 02:09, Adrian Turjak <adri...@catalyst.net.nz> wrote: I've posted some comments on the API Access patch. The blueprint was saying that 'API Access' would be both at the Project level, but the way panel groups worked meant that setting the 'default' panel group didn't work when that dashboard already had panel groups, since the default panel group was annoyingly hidden away because of somewhat odd template logic. I submitted a bug report here: https://bugs.launchpad.net/horizon/+bug/1659456 And proposed a fix for that here: https://review.openstack.org/#/c/425486 With that change the default group panels are not hidden, and displayed at the same level as the other panel groups. This then allows us to move API Access to the top level where the blueprint says. This makes much more sense since API Access isn't a compute only thing. On 26/01/17 12:02, Fox, Kevin M wrote: Big Thanks! from me too. The old UI here was very unintuitive, so I had to field a lot of questions related to it. This is great. :) Kevin From: Lingxian Kong [anlin.k...@gmail.com] Sent: Wednesday, January 25, 2017 2:23 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [horizon] FFE Request Hi, Rob, First, thanks for your work! What's your plan for the other two tabs (security group, floatingip)? I could see the split is very helpful no matter from performance perspective and both useful from end user's perspective. BTW, a huge +1 for this FFE! Cheers, Lingxian Kong (Larry) On Thu, Jan 26, 2017 at 9:01 AM, Adrian Turjak <adri...@catalyst.net.nz> wrote: +1 We very much need this as the performance of that panel is awful. This solves that problem while being a fairly minor code change which also provides much better UX. On 26/01/2017 8:07 AM, Rob Cresswell <robert.cressw...@outlook.com> wrote: o/ I'd like to request an FFE on https://blueprints.launchpad.net/horizon/+spec/reorganise-access-and-security. This blueprint splits up the access and security tabs into 4 distinct panels. The first two patches are https://review.openstack.org/#/c/408247 and https://review.openstack.org/#/c/425345/ It's low risk; no API layer changes, mostly just moving code around. Rob __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] FFE Request
Wow, lots of replies. Thanks for the FFE. I'd request that we proceed with the panel separation now, and resolve the final location when any bug fixes have merged. I don't really want to hold up a whole chain of patches over a one line path change. API Access and Key Pairs are done, and I'll put up Security Groups and Floating IPs once they start moving (maintaining huge patch chains is a waste of time) Rob On 26 January 2017 at 02:09, Adrian Turjak <adri...@catalyst.net.nz<mailto:adri...@catalyst.net.nz>> wrote: I've posted some comments on the API Access patch. The blueprint was saying that 'API Access' would be both at the Project level, but the way panel groups worked meant that setting the 'default' panel group didn't work when that dashboard already had panel groups, since the default panel group was annoyingly hidden away because of somewhat odd template logic. I submitted a bug report here: https://bugs.launchpad.net/horizon/+bug/1659456 And proposed a fix for that here: https://review.openstack.org/#/c/425486 With that change the default group panels are not hidden, and displayed at the same level as the other panel groups. This then allows us to move API Access to the top level where the blueprint says. This makes much more sense since API Access isn't a compute only thing. On 26/01/17 12:02, Fox, Kevin M wrote: Big Thanks! from me too. The old UI here was very unintuitive, so I had to field a lot of questions related to it. This is great. :) Kevin From: Lingxian Kong [anlin.k...@gmail.com<mailto:anlin.k...@gmail.com>] Sent: Wednesday, January 25, 2017 2:23 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [horizon] FFE Request Hi, Rob, First, thanks for your work! What's your plan for the other two tabs (security group, floatingip)? I could see the split is very helpful no matter from performance perspective and both useful from end user's perspective. BTW, a huge +1 for this FFE! Cheers, Lingxian Kong (Larry) On Thu, Jan 26, 2017 at 9:01 AM, Adrian Turjak <adri...@catalyst.net.nz<mailto:adri...@catalyst.net.nz>> wrote: +1 We very much need this as the performance of that panel is awful. This solves that problem while being a fairly minor code change which also provides much better UX. On 26/01/2017 8:07 AM, Rob Cresswell <<mailto:robert.cressw...@outlook.com>robert.cressw...@outlook.com<mailto:robert.cressw...@outlook.com>> wrote: o/ I'd like to request an FFE on <https://blueprints.launchpad.net/horizon/+spec/reorganise-access-and-security> https://blueprints.launchpad.net/horizon/+spec/<http://launchpad.net/horizon/+spec/>reorganise-access-and-security. This blueprint splits up the access and security tabs into 4 distinct panels. The first two patches are <https://review.openstack.org/#/c/408247> https://review.openstack.org/#/c/408247 and https://review.openstack.org/#/c/425345/ It's low risk; no API layer changes, mostly just moving code around. Rob __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe<http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe<mailto:openstack-dev-requ...@lists.openstack.org?subject:unsubscribe> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] FFE Request
I've posted some comments on the API Access patch. The blueprint was saying that 'API Access' would be both at the Project level, but the way panel groups worked meant that setting the 'default' panel group didn't work when that dashboard already had panel groups, since the default panel group was annoyingly hidden away because of somewhat odd template logic. I submitted a bug report here: https://bugs.launchpad.net/horizon/+bug/1659456 And proposed a fix for that here: https://review.openstack.org/#/c/425486 With that change the default group panels are not hidden, and displayed at the same level as the other panel groups. This then allows us to move API Access to the top level where the blueprint says. This makes much more sense since API Access isn't a compute only thing. On 26/01/17 12:02, Fox, Kevin M wrote: > Big Thanks! from me too. The old UI here was very unintuitive, so I > had to field a lot of questions related to it. This is great. :) > > Kevin > > *From:* Lingxian Kong [anlin.k...@gmail.com] > *Sent:* Wednesday, January 25, 2017 2:23 PM > *To:* OpenStack Development Mailing List (not for usage questions) > *Subject:* Re: [openstack-dev] [horizon] FFE Request > > Hi, Rob, > > First, thanks for your work! > > What's your plan for the other two tabs (security group, floatingip)? > I could see the split is very helpful no matter from performance > perspective and both useful from end user's perspective. > > BTW, a huge +1 for this FFE! > > > > > Cheers, > Lingxian Kong (Larry) > > On Thu, Jan 26, 2017 at 9:01 AM, Adrian Turjak > <adri...@catalyst.net.nz <mailto:adri...@catalyst.net.nz>> wrote: > > +1 > > We very much need this as the performance of that panel is awful. > This solves that problem while being a fairly minor code change > which also provides much better UX. > > > On 26/01/2017 8:07 AM, Rob Cresswell <robert.cressw...@outlook.com > <mailto:robert.cressw...@outlook.com>> wrote: > > o/ > > I'd like to request an FFE > on > https://blueprints.launchpad.net/horizon/+spec/reorganise-access-and-security > > <https://blueprints.launchpad.net/horizon/+spec/reorganise-access-and-security>. > This blueprint splits up the access and security tabs into 4 > distinct panels. The first two patches > are https://review.openstack.org/#/c/408247 > <https://review.openstack.org/#/c/408247> > and https://review.openstack.org/#/c/425345/ > <https://review.openstack.org/#/c/425345/> > > It's low risk; no API layer changes, mostly just moving code > around. > > Rob > > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > <http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev> > > > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] FFE Request
Big Thanks! from me too. The old UI here was very unintuitive, so I had to field a lot of questions related to it. This is great. :) Kevin From: Lingxian Kong [anlin.k...@gmail.com] Sent: Wednesday, January 25, 2017 2:23 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [horizon] FFE Request Hi, Rob, First, thanks for your work! What's your plan for the other two tabs (security group, floatingip)? I could see the split is very helpful no matter from performance perspective and both useful from end user's perspective. BTW, a huge +1 for this FFE! Cheers, Lingxian Kong (Larry) On Thu, Jan 26, 2017 at 9:01 AM, Adrian Turjak <adri...@catalyst.net.nz<mailto:adri...@catalyst.net.nz>> wrote: +1 We very much need this as the performance of that panel is awful. This solves that problem while being a fairly minor code change which also provides much better UX. On 26/01/2017 8:07 AM, Rob Cresswell <robert.cressw...@outlook.com<mailto:robert.cressw...@outlook.com>> wrote: o/ I'd like to request an FFE on https://blueprints.launchpad.net/horizon/+spec/reorganise-access-and-security. This blueprint splits up the access and security tabs into 4 distinct panels. The first two patches are https://review.openstack.org/#/c/408247 and https://review.openstack.org/#/c/425345/ It's low risk; no API layer changes, mostly just moving code around. Rob __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe<http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] FFE Request
Hi Rob, FFE granted for those two in-flight patches. On 26 January 2017 at 09:23, Lingxian Kongwrote: > Hi, Rob, > > First, thanks for your work! > > What's your plan for the other two tabs (security group, floatingip)? I > could see the split is very helpful no matter from performance perspective > and both useful from end user's perspective. > > BTW, a huge +1 for this FFE! > > > > > Cheers, > Lingxian Kong (Larry) > > On Thu, Jan 26, 2017 at 9:01 AM, Adrian Turjak > wrote: >> >> +1 >> >> We very much need this as the performance of that panel is awful. This >> solves that problem while being a fairly minor code change which also >> provides much better UX. >> >> >> On 26/01/2017 8:07 AM, Rob Cresswell wrote: >> >> o/ >> >> I'd like to request an FFE on >> https://blueprints.launchpad.net/horizon/+spec/reorganise-access-and-security. >> This blueprint splits up the access and security tabs into 4 distinct >> panels. The first two patches are https://review.openstack.org/#/c/408247 >> and https://review.openstack.org/#/c/425345/ >> >> It's low risk; no API layer changes, mostly just moving code around. >> >> Rob >> >> >> >> __ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] FFE Request
Hi, Rob, First, thanks for your work! What's your plan for the other two tabs (security group, floatingip)? I could see the split is very helpful no matter from performance perspective and both useful from end user's perspective. BTW, a huge +1 for this FFE! Cheers, Lingxian Kong (Larry) On Thu, Jan 26, 2017 at 9:01 AM, Adrian Turjakwrote: > +1 > > We very much need this as the performance of that panel is awful. This > solves that problem while being a fairly minor code change which also > provides much better UX. > > > On 26/01/2017 8:07 AM, Rob Cresswell wrote: > > o/ > > I'd like to request an FFE on https://blueprints. > launchpad.net/horizon/+spec/reorganise-access-and-security. This > blueprint splits up the access and security tabs into 4 distinct panels. > The first two patches are https://review.openstack.org/#/c/408247 and > https://review.openstack.org/#/c/425345/ > > It's low risk; no API layer changes, mostly just moving code around. > > Rob > > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [horizon] FFE Request
+1We very much need this as the performance of that panel is awful. This solves that problem while being a fairly minor code change which also provides much better UX.On 26/01/2017 8:07 AM, Rob Cresswellwrote: o/ I'd like to request an FFE on https://blueprints.launchpad.net/horizon/+spec/reorganise-access-and-security. This blueprint splits up the access and security tabs into 4 distinct panels. The first two patches are https://review.openstack.org/#/c/408247 and https://review.openstack.org/#/c/425345/ It's low risk; no API layer changes, mostly just moving code around. Rob __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [horizon] FFE Request
o/ I'd like to request an FFE on https://blueprints.launchpad.net/horizon/+spec/reorganise-access-and-security. This blueprint splits up the access and security tabs into 4 distinct panels. The first two patches are https://review.openstack.org/#/c/408247 and https://review.openstack.org/#/c/425345/ It's low risk; no API layer changes, mostly just moving code around. Rob __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [horizon] FFE request
Hi. I would like to request a FFE for the following change request https://review.openstack.org/#/c/158715/ https://review.openstack.org/#/c/158715/ The blueprint for it has been approved for kilo. This change has a dependency on a change in python-saharaclient which has been recently merged. The code has passed a few review iterations. At the moment all the comments have been addressed. Best Regards, Nikita Konovalov Mirantis, Inc __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Horizon] FFE request for Firewall Router insertion BP
Dear Horizon community, I would like to request an FFE for the review we have out currently for the firewall feature in the project dashboard. The review is at - https://review.openstack.org/#/c/162552/ This feature is very important for the neutron FWaaS community to move the firewall feature from out of experimental stage. It allows for firewalls to finally be applied to a router and having Horizon support for this will greatly enhance the ability to use FWaaS. The neutron side of the feature got merged just before the K-3 deadline and there isn¹t a neutron client dependency on Horizon for this. A final review version to address comments about UT and also a details page will be made very shortly. The review in its current state is ready to test and for anyone to try out. Please make sure to include the q-fwaas service in your local.conf if testing. Requesting Akihiro and David to please sponsor reviews (as discussed on IRC). Much thanks and kind regards, Abishek __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev