Re: [openstack-dev] [ironic] Baremetal Deploy Ramdisk functional testing

2016-02-16 Thread Maksym Lobur 
Thanks Jim for the feedback, see my comments below
> 
> So, as I understand this, the goal is to test the bareon ramdisk without
> bringing up the rest of the services that talk to it?

Correct.

> Currently in ironic-land, the only runtime testing of our ramdisk(s) is
> the integration tests we do with the rest of openstack (the dsvm tests).
> We've considered functional tests of the ironic-python-agent API, but
> haven't much considered writing scripts to boot it on a VM and do
> things.
> 
> Given the ways IPA interacts with Ironic, we'd basically just end up
> re-writing a bunch of Ironic code if we wanted to do this; however it
> might not be too much code, so maybe it's worth it? I'm not sure; I
> guess it isn't a major priority for us right now.

I know IPA uses a little bit more complex interaction than we are, but still 
this might be simpler than it seems. 
I can understand you about priorities. If you are focusing towards simplicity 
of the IPA there’s no much benefit from this kind of testing. But once you want 
to support more complex deployments, some implicit deployment optimizations 
inside the agent, it might add a value.

> All this is to say, I guess I'd have to look at the functional test
> framework you're building. I'm not opposed to making it more general,
> and as changing repo names is expensive (requires gerrit downtime), it
> might be worth naming it ramdisk-func-test or similar now just in case. :)
> 
Got it. We’ll change naming. If there’s a chance it is going to be reused, we 
don’t want to tie it to bareon.


>>> 
>>> [1] https://wiki.openstack.org/wiki/Bareon 
>>>  
>>> >> >
>>> [2] https://blueprints.launchpad.net/bareon/+spec/bareon-functional-testing 
>>> >>  >
>>> [3] http://pastebin.com/mL39QJS6  
>>> >
>>> [4] https://review.openstack.org/#/c/279120/ 
>>>  
>>> >> >
>>> 
>>> 
>>> Regards,
>>> Max Lobur,
>>> OpenStack Developer, Mirantis, Inc.
>>> 
>> 
> 
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org 
>> ?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev 
>> 
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org 
> ?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev 
> 
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] Baremetal Deploy Ramdisk functional testing

2016-02-15 Thread Jim Rollenhagen 
On Mon, Feb 15, 2016 at 01:48:11PM +0200, Maksym Lobur wrote:
> Re-sending with Ironic stamp… Folks, please see below: 

Hi, I meant to reply to this earlier, but didn't get to it, sorry for
that.

> 
> > 
> > Hi All,
> > 
> > In bareon [1] we have test framework to test deploy ramdsik with bareon 
> > inside (baremetal deployments). This is a functional testing, we do a full 
> > partitioning/image_deployment in a VM, then reboot to see if tenant image 
> > deployed properly. Blueprint is at [2], test example is at [3]. We were 
> > going to put a framework to a separate repo, while keeping functional tests 
> > in bareon tree.
> > 
> > Does someone else have need to test some kind of deployment ramdisks? Maybe 
> > already have existing tools for this? Or would be interested to reuse our 
> > code? Current pull request is to create bareon-func-test repo [4]. But if 
> > that makes sense, we could do something like ramdisk-func-test, e.g. try to 
> > generalize the framework to test other ramdisks/agents.

So, as I understand this, the goal is to test the bareon ramdisk without
bringing up the rest of the services that talk to it?

Currently in ironic-land, the only runtime testing of our ramdisk(s) is
the integration tests we do with the rest of openstack (the dsvm tests).
We've considered functional tests of the ironic-python-agent API, but
haven't much considered writing scripts to boot it on a VM and do
things.

Given the ways IPA interacts with Ironic, we'd basically just end up
re-writing a bunch of Ironic code if we wanted to do this; however it
might not be too much code, so maybe it's worth it? I'm not sure; I
guess it isn't a major priority for us right now.

All this is to say, I guess I'd have to look at the functional test
framework you're building. I'm not opposed to making it more general,
and as changing repo names is expensive (requires gerrit downtime), it
might be worth naming it ramdisk-func-test or similar now just in case. :)

// jim

> > 
> > [1] https://wiki.openstack.org/wiki/Bareon 
> > 
> > [2] https://blueprints.launchpad.net/bareon/+spec/bareon-functional-testing 
> > 
> > [3] http://pastebin.com/mL39QJS6 
> > [4] https://review.openstack.org/#/c/279120/ 
> > 
> > 
> > 
> > Regards,
> > Max Lobur,
> > OpenStack Developer, Mirantis, Inc.
> > 
> 

> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [ironic] Baremetal Deploy Ramdisk functional testing

2016-02-15 Thread Maksym Lobur 
Re-sending with Ironic stamp… Folks, please see below: 

> 
> Hi All,
> 
> In bareon [1] we have test framework to test deploy ramdsik with bareon 
> inside (baremetal deployments). This is a functional testing, we do a full 
> partitioning/image_deployment in a VM, then reboot to see if tenant image 
> deployed properly. Blueprint is at [2], test example is at [3]. We were going 
> to put a framework to a separate repo, while keeping functional tests in 
> bareon tree.
> 
> Does someone else have need to test some kind of deployment ramdisks? Maybe 
> already have existing tools for this? Or would be interested to reuse our 
> code? Current pull request is to create bareon-func-test repo [4]. But if 
> that makes sense, we could do something like ramdisk-func-test, e.g. try to 
> generalize the framework to test other ramdisks/agents.
> 
> [1] https://wiki.openstack.org/wiki/Bareon 
> 
> [2] https://blueprints.launchpad.net/bareon/+spec/bareon-functional-testing 
> 
> [3] http://pastebin.com/mL39QJS6 
> [4] https://review.openstack.org/#/c/279120/ 
> 
> 
> 
> Regards,
> Max Lobur,
> OpenStack Developer, Mirantis, Inc.
> 

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev