Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables
I like the idea and would love to help with mentoring. I’ve learned a lot being a Kolla core. I think every contributor is the same – core or not ☺. At the end of the mentorship, I think we need to make sure that non-cores feel no different than cores, and that every contributor is the same, welcome, helped and mentored in the community ☺. I’ll add my name is the signup sheet! Regards, Vikram Hosakote IRC: vhosakot From: "Steven Dake (stdake)" <std...@cisco.com> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org> Date: Thursday, April 13, 2017 at 9:19 AM To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org> Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables Ok sounds fair. I guess I had misunderstood what nova had done, and thought it was a path to success. I’m happy we can have the conversation about a mentorship program now at least in the Kolla project. I’m not sure how to evaluate the cost of the mentorship program in terms of core reviewer time. Perhaps we should start there. I know core reviewers are swamped for bandwidth, however, I also feel making time for mentorship is essential to the project’s long term health. I am also not sure if we have more individuals interested. If only Rich is interested, that is only one person to mentor. If 100 people are interested, that is beyond our capacity as a team to handle ☺ To help sort out the time commitment for core reviewers, I have started a “sign-up sheet” for folks interested in mentoring here: https://etherpad.openstack.org/p/kolla-mentorship-signup Regards -steve From: "Serguei Bezverkhi (sbezverk)" <sbezv...@cisco.com> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org> Date: Thursday, April 13, 2017 at 8:45 AM To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org> Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables The idea is great, no doubt here, meaning mentoring and everything, but it should not come with price of reducing quality control. 2 x +2 +w should still be required from “regular” cores for PS to merge. Serguei From: Richard Wellum [mailto:richwel...@gmail.com] Sent: Thursday, April 13, 2017 7:02 AM To: OpenStack Development Mailing List (not for usage questions) <openstack-dev@lists.openstack.org> Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables As a relatively new member of the openstack community I think the idea of a mentorship program is a good one; I'd like to throw my hat in the ring if the kolla community needs a guinea-pig to try this on. :) Rich On Wed, Apr 12, 2017 at 7:53 PM Matt Riedemann <mriede...@gmail.com<mailto:mriede...@gmail.com>> wrote: On 4/12/2017 3:40 PM, Steven Dake (stdake) wrote: > Matt, > > Thanks for the response. It is helpful. > > Regards > -steve > > -Original Message- > From: Matt Riedemann <mriede...@gmail.com<mailto:mriede...@gmail.com>> > Reply-To: "OpenStack Development Mailing List (not for usage questions)" > <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> > Date: Wednesday, April 12, 2017 at 4:36 PM > To: > "openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>" > <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> > Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer > mentorship program for Kolla deliverables > > On 4/12/2017 11:59 AM, Steven Dake (stdake) wrote: > > Hey folks, > > > > > > > > In today’s Kolla team meeting, the idea was proposed of adopting nova’s > > “protocore” mentorship program for Kolla. We would like to know what > > nova has learned from this effort. > > > > > > > > In today’s Kolla meeting we had broad consensus on the following: > > > > 1) Kolla has participants that want to be core reviewers > > > > 2) These participants don’t know how to become core reviewers > > > > 3) The core reviewers in Kolla should mentor “protocore” reviewers > > on how to do good reviews > > > > > > > > From that, we concluded some form of mentorship program for potential > > core reviewers was in order. We got into some debate about _/how/_ the > > program should be r
Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables
Thanks sdake! I added this topic to next meeting agenda. Way I see it it might not be any more load on core reviewer as answering questions and reviewing is part of our job already. However having some "trusted" person to ask can mean a lot to new reviewer as it will lower this fear of being ashamed by asking in public (there is nothing to fear, but that's how our brains are wired). Also direct cores attention to comment on mantee review to improve quality. Also mentor can start actual core voting (or ask me to start the voting) when mantee will be ready. Let's give it a try. I'm very hopeful for it! Cheers, Michal On 13 April 2017 at 06:19, Steven Dake (stdake) <std...@cisco.com> wrote: > Ok sounds fair. I guess I had misunderstood what nova had done, and thought > it was a path to success. > > > > I’m happy we can have the conversation about a mentorship program now at > least in the Kolla project. > > > > I’m not sure how to evaluate the cost of the mentorship program in terms of > core reviewer time. Perhaps we should start there. I know core reviewers > are swamped for bandwidth, however, I also feel making time for mentorship > is essential to the project’s long term health. > > > > I am also not sure if we have more individuals interested. If only Rich is > interested, that is only one person to mentor. If 100 people are > interested, that is beyond our capacity as a team to handle J > > > > To help sort out the time commitment for core reviewers, I have started a > “sign-up sheet” for folks interested in mentoring here: > > https://etherpad.openstack.org/p/kolla-mentorship-signup > > > > Regards > > -steve > > > > > > From: "Serguei Bezverkhi (sbezverk)" <sbezv...@cisco.com> > Reply-To: "OpenStack Development Mailing List (not for usage questions)" > <openstack-dev@lists.openstack.org> > Date: Thursday, April 13, 2017 at 8:45 AM > > > To: "OpenStack Development Mailing List (not for usage questions)" > <openstack-dev@lists.openstack.org> > Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer > mentorship program for Kolla deliverables > > > > The idea is great, no doubt here, meaning mentoring and everything, but it > should not come with price of reducing quality control. 2 x +2 +w should > still be required from “regular” cores for PS to merge. > > > > Serguei > > > > From: Richard Wellum [mailto:richwel...@gmail.com] > Sent: Thursday, April 13, 2017 7:02 AM > To: OpenStack Development Mailing List (not for usage questions) > <openstack-dev@lists.openstack.org> > Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer > mentorship program for Kolla deliverables > > > > As a relatively new member of the openstack community I think the idea of a > mentorship program is a good one; I'd like to throw my hat in the ring if > the kolla community needs a guinea-pig to try this on. :) > > > > Rich > > > > On Wed, Apr 12, 2017 at 7:53 PM Matt Riedemann <mriede...@gmail.com> wrote: > > On 4/12/2017 3:40 PM, Steven Dake (stdake) wrote: >> Matt, >> >> Thanks for the response. It is helpful. >> >> Regards >> -steve >> >> -Original Message- >> From: Matt Riedemann <mriede...@gmail.com> >> Reply-To: "OpenStack Development Mailing List (not for usage questions)" >> <openstack-dev@lists.openstack.org> >> Date: Wednesday, April 12, 2017 at 4:36 PM >> To: "openstack-dev@lists.openstack.org" >> <openstack-dev@lists.openstack.org> >> Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer >> mentorship program for Kolla deliverables >> >> On 4/12/2017 11:59 AM, Steven Dake (stdake) wrote: >> > Hey folks, >> > >> > >> > >> > In today’s Kolla team meeting, the idea was proposed of adopting >> nova’s >> > “protocore” mentorship program for Kolla. We would like to know >> what >> > nova has learned from this effort. >> > >> > >> > >> > In today’s Kolla meeting we had broad consensus on the following: >> > >> > 1) Kolla has participants that want to be core reviewers >> > >> > 2) These participants don’t know how to become core reviewers >> > >> > 3) The core reviewers in Kolla should mentor “protocore” >> reviewers >> > on how to do good reviews >> > >> > >> > >> > From th
Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables
Ok sounds fair. I guess I had misunderstood what nova had done, and thought it was a path to success. I’m happy we can have the conversation about a mentorship program now at least in the Kolla project. I’m not sure how to evaluate the cost of the mentorship program in terms of core reviewer time. Perhaps we should start there. I know core reviewers are swamped for bandwidth, however, I also feel making time for mentorship is essential to the project’s long term health. I am also not sure if we have more individuals interested. If only Rich is interested, that is only one person to mentor. If 100 people are interested, that is beyond our capacity as a team to handle ☺ To help sort out the time commitment for core reviewers, I have started a “sign-up sheet” for folks interested in mentoring here: https://etherpad.openstack.org/p/kolla-mentorship-signup Regards -steve From: "Serguei Bezverkhi (sbezverk)" <sbezv...@cisco.com> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org> Date: Thursday, April 13, 2017 at 8:45 AM To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org> Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables The idea is great, no doubt here, meaning mentoring and everything, but it should not come with price of reducing quality control. 2 x +2 +w should still be required from “regular” cores for PS to merge. Serguei From: Richard Wellum [mailto:richwel...@gmail.com] Sent: Thursday, April 13, 2017 7:02 AM To: OpenStack Development Mailing List (not for usage questions) <openstack-dev@lists.openstack.org> Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables As a relatively new member of the openstack community I think the idea of a mentorship program is a good one; I'd like to throw my hat in the ring if the kolla community needs a guinea-pig to try this on. :) Rich On Wed, Apr 12, 2017 at 7:53 PM Matt Riedemann <mriede...@gmail.com<mailto:mriede...@gmail.com>> wrote: On 4/12/2017 3:40 PM, Steven Dake (stdake) wrote: > Matt, > > Thanks for the response. It is helpful. > > Regards > -steve > > -Original Message- > From: Matt Riedemann <mriede...@gmail.com<mailto:mriede...@gmail.com>> > Reply-To: "OpenStack Development Mailing List (not for usage questions)" > <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> > Date: Wednesday, April 12, 2017 at 4:36 PM > To: > "openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>" > <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> > Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer > mentorship program for Kolla deliverables > > On 4/12/2017 11:59 AM, Steven Dake (stdake) wrote: > > Hey folks, > > > > > > > > In today’s Kolla team meeting, the idea was proposed of adopting nova’s > > “protocore” mentorship program for Kolla. We would like to know what > > nova has learned from this effort. > > > > > > > > In today’s Kolla meeting we had broad consensus on the following: > > > > 1) Kolla has participants that want to be core reviewers > > > > 2) These participants don’t know how to become core reviewers > > > > 3) The core reviewers in Kolla should mentor “protocore” reviewers > > on how to do good reviews > > > > > > > > From that, we concluded some form of mentorship program for potential > > core reviewers was in order. We got into some debate about _/how/_ the > > program should be rolled out. Let’s use this thread to discuss how it > > should be rolled out since that seems to be the sticking point of the > > discussion. I saw no dissent in the discussion that the basic concepts > > were a negative change. > > > > > > > > I am aware that nova uses a +1 review from a “protocore” and a +2/+w > > from a core reviewer prior to merge. Nova cores – would you mind > > defining your process (on the ml is fine) more thoroughly and your > > experiences so we can learn from you? > > > > > > > > All kolla contributors, feel free to debate the **how** such a > > mentorship program should be rolled out. I think we have a lot to learn > > from our peers in the OpenStack community and learning from their >
Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables
The idea is great, no doubt here, meaning mentoring and everything, but it should not come with price of reducing quality control. 2 x +2 +w should still be required from “regular” cores for PS to merge. Serguei From: Richard Wellum [mailto:richwel...@gmail.com] Sent: Thursday, April 13, 2017 7:02 AM To: OpenStack Development Mailing List (not for usage questions) <openstack-dev@lists.openstack.org> Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables As a relatively new member of the openstack community I think the idea of a mentorship program is a good one; I'd like to throw my hat in the ring if the kolla community needs a guinea-pig to try this on. :) Rich On Wed, Apr 12, 2017 at 7:53 PM Matt Riedemann <mriede...@gmail.com<mailto:mriede...@gmail.com>> wrote: On 4/12/2017 3:40 PM, Steven Dake (stdake) wrote: > Matt, > > Thanks for the response. It is helpful. > > Regards > -steve > > -Original Message- > From: Matt Riedemann <mriede...@gmail.com<mailto:mriede...@gmail.com>> > Reply-To: "OpenStack Development Mailing List (not for usage questions)" > <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> > Date: Wednesday, April 12, 2017 at 4:36 PM > To: > "openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>" > <openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>> > Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer > mentorship program for Kolla deliverables > > On 4/12/2017 11:59 AM, Steven Dake (stdake) wrote: > > Hey folks, > > > > > > > > In today’s Kolla team meeting, the idea was proposed of adopting nova’s > > “protocore” mentorship program for Kolla. We would like to know what > > nova has learned from this effort. > > > > > > > > In today’s Kolla meeting we had broad consensus on the following: > > > > 1) Kolla has participants that want to be core reviewers > > > > 2) These participants don’t know how to become core reviewers > > > > 3) The core reviewers in Kolla should mentor “protocore” reviewers > > on how to do good reviews > > > > > > > > From that, we concluded some form of mentorship program for potential > > core reviewers was in order. We got into some debate about _/how/_ the > > program should be rolled out. Let’s use this thread to discuss how it > > should be rolled out since that seems to be the sticking point of the > > discussion. I saw no dissent in the discussion that the basic concepts > > were a negative change. > > > > > > > > I am aware that nova uses a +1 review from a “protocore” and a +2/+w > > from a core reviewer prior to merge. Nova cores – would you mind > > defining your process (on the ml is fine) more thoroughly and your > > experiences so we can learn from you? > > > > > > > > All kolla contributors, feel free to debate the **how** such a > > mentorship program should be rolled out. I think we have a lot to learn > > from our peers in the OpenStack community and learning from their > > experiences may be helpful. > > > > > > > > Regards > > > > -steve > > > > > > > > > > > > > __ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe<http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe> > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > Nova has this thing? That's news to me. :) > > I don't think Nova has a formal process for something like this. There > was talk at the BCN summit about giving some people +2 rights on parts > of the tree but not full core on everything. We never implemented that. > > Maybe what you're referring to is how we consider a +1 from a domain > expert like a +2, or at least something that's good to have before cores > are looking into the change in more detail? For example, gibi is the > lead for the versioned notifications effort and we/I generally look for > his +1 on a change before digging into it, or approving it. We have > similar unofficial thi
Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables
As a relatively new member of the openstack community I think the idea of a mentorship program is a good one; I'd like to throw my hat in the ring if the kolla community needs a guinea-pig to try this on. :) Rich On Wed, Apr 12, 2017 at 7:53 PM Matt Riedemann <mriede...@gmail.com> wrote: > On 4/12/2017 3:40 PM, Steven Dake (stdake) wrote: > > Matt, > > > > Thanks for the response. It is helpful. > > > > Regards > > -steve > > > > -Original Message- > > From: Matt Riedemann <mriede...@gmail.com> > > Reply-To: "OpenStack Development Mailing List (not for usage questions)" > <openstack-dev@lists.openstack.org> > > Date: Wednesday, April 12, 2017 at 4:36 PM > > To: "openstack-dev@lists.openstack.org" < > openstack-dev@lists.openstack.org> > > Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer > mentorship program for Kolla deliverables > > > > On 4/12/2017 11:59 AM, Steven Dake (stdake) wrote: > > > Hey folks, > > > > > > > > > > > > In today’s Kolla team meeting, the idea was proposed of adopting > nova’s > > > “protocore” mentorship program for Kolla. We would like to know > what > > > nova has learned from this effort. > > > > > > > > > > > > In today’s Kolla meeting we had broad consensus on the following: > > > > > > 1) Kolla has participants that want to be core reviewers > > > > > > 2) These participants don’t know how to become core reviewers > > > > > > 3) The core reviewers in Kolla should mentor “protocore” > reviewers > > > on how to do good reviews > > > > > > > > > > > > From that, we concluded some form of mentorship program for > potential > > > core reviewers was in order. We got into some debate about > _/how/_ the > > > program should be rolled out. Let’s use this thread to discuss > how it > > > should be rolled out since that seems to be the sticking point of > the > > > discussion. I saw no dissent in the discussion that the basic > concepts > > > were a negative change. > > > > > > > > > > > > I am aware that nova uses a +1 review from a “protocore” and a > +2/+w > > > from a core reviewer prior to merge. Nova cores – would you mind > > > defining your process (on the ml is fine) more thoroughly and your > > > experiences so we can learn from you? > > > > > > > > > > > > All kolla contributors, feel free to debate the **how** such a > > > mentorship program should be rolled out. I think we have a lot to > learn > > > from our peers in the OpenStack community and learning from their > > > experiences may be helpful. > > > > > > > > > > > > Regards > > > > > > -steve > > > > > > > > > > > > > > > > > > > __ > > > OpenStack Development Mailing List (not for usage questions) > > > Unsubscribe: > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > > > Nova has this thing? That's news to me. :) > > > > I don't think Nova has a formal process for something like this. > There > > was talk at the BCN summit about giving some people +2 rights on > parts > > of the tree but not full core on everything. We never implemented > that. > > > > Maybe what you're referring to is how we consider a +1 from a domain > > expert like a +2, or at least something that's good to have before > cores > > are looking into the change in more detail? For example, gibi is the > > lead for the versioned notifications effort and we/I generally look > for > > his +1 on a change before digging into it, or approving it. We have > > similar unofficial things like this in other parts of Nova, or > subteams, > > like Timofey and Pawel with the live migration subteam. > > > > To be sure, someone that is leading a subteam effort and is looked to > > for their opinion on a whole series of changes eventually gets into > the > &
Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables
On 4/12/2017 3:40 PM, Steven Dake (stdake) wrote: Matt, Thanks for the response. It is helpful. Regards -steve -Original Message- From: Matt Riedemann <mriede...@gmail.com> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org> Date: Wednesday, April 12, 2017 at 4:36 PM To: "openstack-dev@lists.openstack.org" <openstack-dev@lists.openstack.org> Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables On 4/12/2017 11:59 AM, Steven Dake (stdake) wrote: > Hey folks, > > > > In today’s Kolla team meeting, the idea was proposed of adopting nova’s > “protocore” mentorship program for Kolla. We would like to know what > nova has learned from this effort. > > > > In today’s Kolla meeting we had broad consensus on the following: > > 1) Kolla has participants that want to be core reviewers > > 2) These participants don’t know how to become core reviewers > > 3) The core reviewers in Kolla should mentor “protocore” reviewers > on how to do good reviews > > > > From that, we concluded some form of mentorship program for potential > core reviewers was in order. We got into some debate about _/how/_ the > program should be rolled out. Let’s use this thread to discuss how it > should be rolled out since that seems to be the sticking point of the > discussion. I saw no dissent in the discussion that the basic concepts > were a negative change. > > > > I am aware that nova uses a +1 review from a “protocore” and a +2/+w > from a core reviewer prior to merge. Nova cores – would you mind > defining your process (on the ml is fine) more thoroughly and your > experiences so we can learn from you? > > > > All kolla contributors, feel free to debate the **how** such a > mentorship program should be rolled out. I think we have a lot to learn > from our peers in the OpenStack community and learning from their > experiences may be helpful. > > > > Regards > > -steve > > > > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > Nova has this thing? That's news to me. :) I don't think Nova has a formal process for something like this. There was talk at the BCN summit about giving some people +2 rights on parts of the tree but not full core on everything. We never implemented that. Maybe what you're referring to is how we consider a +1 from a domain expert like a +2, or at least something that's good to have before cores are looking into the change in more detail? For example, gibi is the lead for the versioned notifications effort and we/I generally look for his +1 on a change before digging into it, or approving it. We have similar unofficial things like this in other parts of Nova, or subteams, like Timofey and Pawel with the live migration subteam. To be sure, someone that is leading a subteam effort and is looked to for their opinion on a whole series of changes eventually gets into the conversation when we're talking about potential core reviewers, in part because, at least I personally, am looking for not only strong code review skills but also leadership/ownership within the project, because those are also the people that tend to stick around awhile so I'm more comfortable investing my time into them (and building a trust relationship with them). So that's all unofficial non-formal stuff and basically grew up organically around the subteam efforts that started several releases ago. I don't know if this helps you or not. -- Thanks, Matt __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev By the way, I should add, while we look for a +1 from a subteam or domain expert, it does not equate to a +2 so
Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables
Matt, Thanks for the response. It is helpful. Regards -steve -Original Message- From: Matt Riedemann <mriede...@gmail.com> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev@lists.openstack.org> Date: Wednesday, April 12, 2017 at 4:36 PM To: "openstack-dev@lists.openstack.org" <openstack-dev@lists.openstack.org> Subject: Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables On 4/12/2017 11:59 AM, Steven Dake (stdake) wrote: > Hey folks, > > > > In today’s Kolla team meeting, the idea was proposed of adopting nova’s > “protocore” mentorship program for Kolla. We would like to know what > nova has learned from this effort. > > > > In today’s Kolla meeting we had broad consensus on the following: > > 1) Kolla has participants that want to be core reviewers > > 2) These participants don’t know how to become core reviewers > > 3) The core reviewers in Kolla should mentor “protocore” reviewers > on how to do good reviews > > > > From that, we concluded some form of mentorship program for potential > core reviewers was in order. We got into some debate about _/how/_ the > program should be rolled out. Let’s use this thread to discuss how it > should be rolled out since that seems to be the sticking point of the > discussion. I saw no dissent in the discussion that the basic concepts > were a negative change. > > > > I am aware that nova uses a +1 review from a “protocore” and a +2/+w > from a core reviewer prior to merge. Nova cores – would you mind > defining your process (on the ml is fine) more thoroughly and your > experiences so we can learn from you? > > > > All kolla contributors, feel free to debate the **how** such a > mentorship program should be rolled out. I think we have a lot to learn > from our peers in the OpenStack community and learning from their > experiences may be helpful. > > > > Regards > > -steve > > > > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > Nova has this thing? That's news to me. :) I don't think Nova has a formal process for something like this. There was talk at the BCN summit about giving some people +2 rights on parts of the tree but not full core on everything. We never implemented that. Maybe what you're referring to is how we consider a +1 from a domain expert like a +2, or at least something that's good to have before cores are looking into the change in more detail? For example, gibi is the lead for the versioned notifications effort and we/I generally look for his +1 on a change before digging into it, or approving it. We have similar unofficial things like this in other parts of Nova, or subteams, like Timofey and Pawel with the live migration subteam. To be sure, someone that is leading a subteam effort and is looked to for their opinion on a whole series of changes eventually gets into the conversation when we're talking about potential core reviewers, in part because, at least I personally, am looking for not only strong code review skills but also leadership/ownership within the project, because those are also the people that tend to stick around awhile so I'm more comfortable investing my time into them (and building a trust relationship with them). So that's all unofficial non-formal stuff and basically grew up organically around the subteam efforts that started several releases ago. I don't know if this helps you or not. -- Thanks, Matt __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables
On 4/12/2017 11:59 AM, Steven Dake (stdake) wrote: Hey folks, In today’s Kolla team meeting, the idea was proposed of adopting nova’s “protocore” mentorship program for Kolla. We would like to know what nova has learned from this effort. In today’s Kolla meeting we had broad consensus on the following: 1) Kolla has participants that want to be core reviewers 2) These participants don’t know how to become core reviewers 3) The core reviewers in Kolla should mentor “protocore” reviewers on how to do good reviews From that, we concluded some form of mentorship program for potential core reviewers was in order. We got into some debate about _/how/_ the program should be rolled out. Let’s use this thread to discuss how it should be rolled out since that seems to be the sticking point of the discussion. I saw no dissent in the discussion that the basic concepts were a negative change. I am aware that nova uses a +1 review from a “protocore” and a +2/+w from a core reviewer prior to merge. Nova cores – would you mind defining your process (on the ml is fine) more thoroughly and your experiences so we can learn from you? All kolla contributors, feel free to debate the **how** such a mentorship program should be rolled out. I think we have a lot to learn from our peers in the OpenStack community and learning from their experiences may be helpful. Regards -steve __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Nova has this thing? That's news to me. :) I don't think Nova has a formal process for something like this. There was talk at the BCN summit about giving some people +2 rights on parts of the tree but not full core on everything. We never implemented that. Maybe what you're referring to is how we consider a +1 from a domain expert like a +2, or at least something that's good to have before cores are looking into the change in more detail? For example, gibi is the lead for the versioned notifications effort and we/I generally look for his +1 on a change before digging into it, or approving it. We have similar unofficial things like this in other parts of Nova, or subteams, like Timofey and Pawel with the live migration subteam. To be sure, someone that is leading a subteam effort and is looked to for their opinion on a whole series of changes eventually gets into the conversation when we're talking about potential core reviewers, in part because, at least I personally, am looking for not only strong code review skills but also leadership/ownership within the project, because those are also the people that tend to stick around awhile so I'm more comfortable investing my time into them (and building a trust relationship with them). So that's all unofficial non-formal stuff and basically grew up organically around the subteam efforts that started several releases ago. I don't know if this helps you or not. -- Thanks, Matt __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [kolla][nova] Starting a core reviewer mentorship program for Kolla deliverables
Hey folks, In today’s Kolla team meeting, the idea was proposed of adopting nova’s “protocore” mentorship program for Kolla. We would like to know what nova has learned from this effort. In today’s Kolla meeting we had broad consensus on the following: 1) Kolla has participants that want to be core reviewers 2) These participants don’t know how to become core reviewers 3) The core reviewers in Kolla should mentor “protocore” reviewers on how to do good reviews From that, we concluded some form of mentorship program for potential core reviewers was in order. We got into some debate about _how_ the program should be rolled out. Let’s use this thread to discuss how it should be rolled out since that seems to be the sticking point of the discussion. I saw no dissent in the discussion that the basic concepts were a negative change. I am aware that nova uses a +1 review from a “protocore” and a +2/+w from a core reviewer prior to merge. Nova cores – would you mind defining your process (on the ml is fine) more thoroughly and your experiences so we can learn from you? All kolla contributors, feel free to debate the *how* such a mentorship program should be rolled out. I think we have a lot to learn from our peers in the OpenStack community and learning from their experiences may be helpful. Regards -steve __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
