Re: [openstack-dev] [mistral] Adding screenshot when making UI changes
A good suggestion, I have a URL for image copy, http://pasteboard.co/ On Mon, Aug 17, 2015 at 8:16 PM, Renat Akhmerov rakhme...@mirantis.com wrote: Yes, I fully support this. Let’s do this. Renat Akhmerov @ Mirantis Inc. On 13 Aug 2015, at 17:44, ELISHA, Moshe (Moshe) moshe.eli...@alcatel-lucent.com wrote: Hey, Following our discussion in the IRC, when pushing UI changes please upload a screenshot of the result and add a link in the commit message. This will allow us to better understand the change and will also allow non-UI developers to comment on the change. Having the screenshot link in the commit message will allow the developer to update the screenshot if there are visible changes as a result of the reviews. If the UI change is very minor or it is only infra and there are no visible changes – use “Screenshot: N/A”. You can see an example at the recent “Task details overview screen” push [1] [1] https://review.openstack.org/#/c/212489/ __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- *Regards!* *---* *Lingxian Kong* __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [mistral] Adding screenshot when making UI changes
Yes, I fully support this. Let’s do this. Renat Akhmerov @ Mirantis Inc. On 13 Aug 2015, at 17:44, ELISHA, Moshe (Moshe) moshe.eli...@alcatel-lucent.com wrote: Hey, Following our discussion in the IRC, when pushing UI changes please upload a screenshot of the result and add a link in the commit message. This will allow us to better understand the change and will also allow non-UI developers to comment on the change. Having the screenshot link in the commit message will allow the developer to update the screenshot if there are visible changes as a result of the reviews. If the UI change is very minor or it is only infra and there are no visible changes – use “Screenshot: N/A”. You can see an example at the recent “Task details overview screen” push [1] [1] https://review.openstack.org/#/c/212489/ https://review.openstack.org/#/c/212489/__ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org mailto:openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [mistral] Adding screenshot when making UI changes
Hey, Following our discussion in the IRC, when pushing UI changes please upload a screenshot of the result and add a link in the commit message. This will allow us to better understand the change and will also allow non-UI developers to comment on the change. Having the screenshot link in the commit message will allow the developer to update the screenshot if there are visible changes as a result of the reviews. If the UI change is very minor or it is only infra and there are no visible changes - use Screenshot: N/A. You can see an example at the recent Task details overview screen push [1] [1] https://review.openstack.org/#/c/212489/ __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
