FYI, numan created a bug [1] about being able to run functional test job in neutron-vpnaas CI I've proposed a patch [2] which simply add neutron-dsvm-functional job in check and gate queue of neutron-vpnaas.
Unfortunately, as discussed with marun on IRC, this won't be enough, since this job depends on hook scripts hosted in the neutron repository [3]. This issue will impact all advanced services which want to run functional test. I will try to investigate this deeper, but any though on this issue would be appreciated [1]https://bugs.launchpad.net/openstack-ci/+bug/1412770 [2]https://review.openstack.org/#/c/148616/ [3] https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/neutron-functional.yaml On Tue, Jan 20, 2015 at 9:02 PM, Kevin Benton <blak...@gmail.com> wrote: > I don't believe we have any unit tests that create namespaces or veth > pairs. This sounds like it belongs with functional tests. > > On Tue, Jan 20, 2015 at 10:20 AM, Numan Siddique < > numan.siddi...@enovance.com> wrote: > >> Hello, >> >> I am working on a bug [1] on neutron vpnaas and submitted the patch here >> [2]. >> >> The test code to test the fix does the following >> - creates a namespace >> - creates a veth pair and add one interface into the namespace >> - configures the interface with an ip address and >> - adds a default gateway >> - and of course tests the code. >> >> This test code only tests a specific function ( OpenSwanProcess. >> _get_nexthop()) >> >> Reviewers of this patch are not clear if this should be part of >> functional tests or unit tests. >> Can unit tests create linux namespaces, interfaces etc or it falls under >> functional tests? >> >> Please let me know your thoughts on this. >> >> [1] - https://bugs.launchpad.net/neutron/+bug/1405413 >> [2] - https://review.openstack.org/#/c/145005/5 >> >> >> Regards >> Numan >> >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> > > > -- > Kevin Benton > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev