Re: [openstack-dev] [nova] [oslo] troubling passing of unit tests on broken code

2015-08-10 Thread Lenny Verkhovsky 
Hi,
Had you tried removing oslo_db package?
I saw a similar issues and usually uninstalling or upgrading packages solved 
the problem

L.

-Original Message-
From: Mike Bayer [mailto:mba...@redhat.com] 
Sent: Saturday, August 08, 2015 1:43 AM
To: OpenStack Development Mailing List (not for usage questions)
Subject: [openstack-dev] [nova] [oslo] troubling passing of unit tests on 
broken code

Just a heads up that this recently merged code is wrong:

https://review.openstack.org/#/c/192760/14/nova/tests/unit/db/test_migrations.py,cm

and here it is failing tests on my local env, as it does on my CI, as would be 
expected, there's a lot more if I keep it running:

http://paste.openstack.org/show/412236/

However, utterly weirdly, all those tests *pass* with the same versions of 
everything in the gate:

http://paste.openstack.org/show/412236/


I have no idea why this is.  This might be on the oslo.db side within 
the test_migrations logic, not really sure.If someone feels like 
digging in, that would be great.

The failure occurs with both Alembic 0.7.7 and Alembic 0.8 as yet unreleased.  
I have a feeling that releasing Alembic 0.8 may or may not bump this failure to 
be more widespread, just because of its apparent heisenbuggy nature, and I'm 
really hoping to release 0.8 next week.  It was supposed to be this week but I 
got sidetracked.



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] [oslo] troubling passing of unit tests on broken code

2015-08-07 Thread Davanum Srinivas 
Mike,

Sounds great! +1 to fix the code.

-- dims

On Fri, Aug 7, 2015 at 9:55 PM, Mike Bayer  wrote:

>
>
> On 8/7/15 8:00 PM, Davanum Srinivas wrote:
>
> Mike,
>
> I edited my nova tox.ini like so:
> http://paste.openstack.org/show/412245/
>
> and it seems to be working for me:
> http://paste.openstack.org/show/412246/
>
> OK I can see why the gate passes, the error is exposed only by Alembic
> 0.8, because the Column() in the remove operation has no Table associated
> with it.
>
> But the code is still wrong and should be fixed.
>
>
>
>
> -- dims
>
> On Fri, Aug 7, 2015 at 6:42 PM, Mike Bayer  wrote:
>
>> Just a heads up that this recently merged code is wrong:
>>
>>
>> https://review.openstack.org/#/c/192760/14/nova/tests/unit/db/test_migrations.py,cm
>>
>> and here it is failing tests on my local env, as it does on my CI, as
>> would be expected, there's a lot more if I keep it running:
>>
>> http://paste.openstack.org/show/412236/
>>
>> However, utterly weirdly, all those tests *pass* with the same versions
>> of everything in the gate:
>>
>> http://paste.openstack.org/show/412236/
>>
>>
>> I have no idea why this is.  This might be on the oslo.db side within the
>> test_migrations logic, not really sure.If someone feels like digging
>> in, that would be great.
>>
>> The failure occurs with both Alembic 0.7.7 and Alembic 0.8 as yet
>> unreleased.  I have a feeling that releasing Alembic 0.8 may or may not
>> bump this failure to be more widespread, just because of its apparent
>> heisenbuggy nature, and I'm really hoping to release 0.8 next week.  It was
>> supposed to be this week but I got sidetracked.
>>
>>
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
>
> --
> Davanum Srinivas :: https://twitter.com/dims
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: 
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribehttp://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>


-- 
Davanum Srinivas :: https://twitter.com/dims
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] [oslo] troubling passing of unit tests on broken code

2015-08-07 Thread Mike Bayer 



On 8/7/15 8:00 PM, Davanum Srinivas wrote:

Mike,

I edited my nova tox.ini like so:
http://paste.openstack.org/show/412245/

and it seems to be working for me:
http://paste.openstack.org/show/412246/
OK I can see why the gate passes, the error is exposed only by Alembic 
0.8, because the Column() in the remove operation has no Table 
associated with it.


But the code is still wrong and should be fixed.





-- dims

On Fri, Aug 7, 2015 at 6:42 PM, Mike Bayer > wrote:


Just a heads up that this recently merged code is wrong:


https://review.openstack.org/#/c/192760/14/nova/tests/unit/db/test_migrations.py,cm

and here it is failing tests on my local env, as it does on my CI,
as would be expected, there's a lot more if I keep it running:

http://paste.openstack.org/show/412236/

However, utterly weirdly, all those tests *pass* with the same
versions of everything in the gate:

http://paste.openstack.org/show/412236/


I have no idea why this is.  This might be on the oslo.db side
within the test_migrations logic, not really sure. If someone
feels like digging in, that would be great.

The failure occurs with both Alembic 0.7.7 and Alembic 0.8 as yet
unreleased.  I have a feeling that releasing Alembic 0.8 may or
may not bump this failure to be more widespread, just because of
its apparent heisenbuggy nature, and I'm really hoping to release
0.8 next week.  It was supposed to be this week but I got sidetracked.



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe

http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




--
Davanum Srinivas :: https://twitter.com/dims


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] [oslo] troubling passing of unit tests on broken code

2015-08-07 Thread Davanum Srinivas 
Mike,

I edited my nova tox.ini like so:
http://paste.openstack.org/show/412245/

and it seems to be working for me:
http://paste.openstack.org/show/412246/

-- dims

On Fri, Aug 7, 2015 at 6:42 PM, Mike Bayer  wrote:

> Just a heads up that this recently merged code is wrong:
>
>
> https://review.openstack.org/#/c/192760/14/nova/tests/unit/db/test_migrations.py,cm
>
> and here it is failing tests on my local env, as it does on my CI, as
> would be expected, there's a lot more if I keep it running:
>
> http://paste.openstack.org/show/412236/
>
> However, utterly weirdly, all those tests *pass* with the same versions of
> everything in the gate:
>
> http://paste.openstack.org/show/412236/
>
>
> I have no idea why this is.  This might be on the oslo.db side within the
> test_migrations logic, not really sure.If someone feels like digging
> in, that would be great.
>
> The failure occurs with both Alembic 0.7.7 and Alembic 0.8 as yet
> unreleased.  I have a feeling that releasing Alembic 0.8 may or may not
> bump this failure to be more widespread, just because of its apparent
> heisenbuggy nature, and I'm really hoping to release 0.8 next week.  It was
> supposed to be this week but I got sidetracked.
>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Davanum Srinivas :: https://twitter.com/dims
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [nova] [oslo] troubling passing of unit tests on broken code

2015-08-07 Thread Mike Bayer 

Just a heads up that this recently merged code is wrong:

https://review.openstack.org/#/c/192760/14/nova/tests/unit/db/test_migrations.py,cm

and here it is failing tests on my local env, as it does on my CI, as 
would be expected, there's a lot more if I keep it running:


http://paste.openstack.org/show/412236/

However, utterly weirdly, all those tests *pass* with the same versions 
of everything in the gate:


http://paste.openstack.org/show/412236/


I have no idea why this is.  This might be on the oslo.db side within 
the test_migrations logic, not really sure.If someone feels like 
digging in, that would be great.


The failure occurs with both Alembic 0.7.7 and Alembic 0.8 as yet 
unreleased.  I have a feeling that releasing Alembic 0.8 may or may not 
bump this failure to be more widespread, just because of its apparent 
heisenbuggy nature, and I'm really hoping to release 0.8 next week.  It 
was supposed to be this week but I got sidetracked.




__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev