Re: [openstack-dev] [nova] Requesting eyes on fix for bug 1686703

[Matthew Booth]

On 31 January 2018 at 16:32, Matt Riedemann  wrote:

> On 1/31/2018 7:30 AM, Matthew Booth wrote:
>
>> Could I please have some eyes on this bugfix:
>> https://review.openstack.org/#/c/462521/ . I addressed an issue raised
>> in August 2017, and it's had no negative feedback since. It would be good
>> to get this one finished.
>>
>
> First, I'd like to avoid setting a precedent of asking for reviews in the
> ML. So please don't do this.
>

I don't generally do this, but I think a polite request after 6 months or
so is reasonable when something has fallen through the cracks.


> Second, this is a latent issue, and we're less than two weeks to RC1, so
> I'd prefer that we hold this off until Rocky opens up in case it introduces
> any regressions so we at least have time to deal with those when we're not
> in stop-ship mode.
>

That's fine. Looks like I have new feedback to address in the meantime
anyway,

Matt
-- 
Matthew Booth
Red Hat OpenStack Engineer, Compute DFG

Phone: +442070094448 (UK)
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] Requesting eyes on fix for bug 1686703

[Matt Riedemann]

On 1/31/2018 7:30 AM, Matthew Booth wrote:
Could I please have some eyes on this bugfix: 
https://review.openstack.org/#/c/462521/ . I addressed an issue raised 
in August 2017, and it's had no negative feedback since. It would be 
good to get this one finished.


First, I'd like to avoid setting a precedent of asking for reviews in 
the ML. So please don't do this.


Second, this is a latent issue, and we're less than two weeks to RC1, so 
I'd prefer that we hold this off until Rocky opens up in case it 
introduces any regressions so we at least have time to deal with those 
when we're not in stop-ship mode.


--

Thanks,

Matt

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [nova] Requesting eyes on fix for bug 1686703

[Matthew Booth]

Could I please have some eyes on this bugfix:
https://review.openstack.org/#/c/462521/ . I addressed an issue raised in
August 2017, and it's had no negative feedback since. It would be good to
get this one finished.

Thanks,

Matt
-- 
Matthew Booth
Red Hat OpenStack Engineer, Compute DFG

Phone: +442070094448 (UK)
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev