Re: [openstack-dev] [nova] gate blockage due to eventlet 0.18

[Victor Stinner]

Hi,

Oops, I feel guilty, I wrote the patch which introduced the regression 
:-/ My patch fixes a bug on Python 3: "sock.makefile('rb').readline() 
doesn't handle blocking errors correctly"

https://github.com/eventlet/eventlet/issues/274

I was relying on the eventlet test suite, but it looks like it lacks an 
unit test on sendto(). FYI I sent a pull request sunday, but just after 
that I noticed that Jakub Stasiak already fixed the regression. My new 
pull request adds an unit test on sendto() and recvfrom() (UDP socket) 
which should help to avoid similar regression:

https://github.com/eventlet/eventlet/pull/292

The best would be to run some OpenStack tests on the development branch 
of eventlet in a CI, or at least run OpenStack tests on new eventlet 
release. It became common to see regression on eventlet releases, it 
looks like eventlet test suite is too small.


Victor

Le 24/01/2016 20:48, Andreas Jaeger a écrit :

On 01/24/2016 08:01 PM, Jeremy Stanley wrote:

On 2016-01-24 13:39:38 -0500 (-0500), Sean Dague wrote:

Something about the eventlet 0.18 release is failing the cloudpipe
functional tests, as well as our docs job (which is really really odd).

An eventlet pin has been posted - https://review.openstack.org/271809 -
once landed it should let the spice flow again. If someone could look
into it deeper it would be appreciated. I know a lot of us are traveling
over the next 24 hours, so not sure who is going to have time to dig in.
But it will be massively appreciated.


Dims reported a related bug upstream:

 https://github.com/eventlet/eventlet/issues/290



0.18.1 was just released and should fix this.

I could reproduce the failure building the docs with 0.18 but with
0.18.1 it works again for me,

Andreas


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] gate blockage due to eventlet 0.18

[Sean Dague]

On 01/25/2016 03:36 AM, Victor Stinner wrote:
> Hi,
> 
> Oops, I feel guilty, I wrote the patch which introduced the regression
> :-/ My patch fixes a bug on Python 3: "sock.makefile('rb').readline()
> doesn't handle blocking errors correctly"
> https://github.com/eventlet/eventlet/issues/274
> 
> I was relying on the eventlet test suite, but it looks like it lacks an
> unit test on sendto(). FYI I sent a pull request sunday, but just after
> that I noticed that Jakub Stasiak already fixed the regression. My new
> pull request adds an unit test on sendto() and recvfrom() (UDP socket)
> which should help to avoid similar regression:
> https://github.com/eventlet/eventlet/pull/292
> 
> The best would be to run some OpenStack tests on the development branch
> of eventlet in a CI, or at least run OpenStack tests on new eventlet
> release. It became common to see regression on eventlet releases, it
> looks like eventlet test suite is too small.

Thanks everyone for getting to the bottom of this. 0.18.1 seems to have
fixed everything, and we're back in business now.

-Sean

-- 
Sean Dague
http://dague.net



signature.asc
Description: OpenPGP digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] gate blockage due to eventlet 0.18

[Andreas Jaeger]

On 2016-01-24 22:35, Diana Clarke wrote:
> And here's the upstream bug for the functional test failures:
> 
> https://github.com/eventlet/eventlet/issues/291
> https://bugs.launchpad.net/nova/+bug/1537450
> 
> It was also fixed in eventlet 0.18.1.

Diana, Thanks for investigating and reporting so that this is fixed now
as well,

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
   HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [nova] gate blockage due to eventlet 0.18

[Sean Dague]

Something about the eventlet 0.18 release is failing the cloudpipe
functional tests, as well as our docs job (which is really really odd).

An eventlet pin has been posted - https://review.openstack.org/271809 -
once landed it should let the spice flow again. If someone could look
into it deeper it would be appreciated. I know a lot of us are traveling
over the next 24 hours, so not sure who is going to have time to dig in.
But it will be massively appreciated.

-Sean

-- 
Sean Dague
http://dague.net

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] gate blockage due to eventlet 0.18

[Jeremy Stanley]

On 2016-01-24 13:39:38 -0500 (-0500), Sean Dague wrote:
> Something about the eventlet 0.18 release is failing the cloudpipe
> functional tests, as well as our docs job (which is really really odd).
> 
> An eventlet pin has been posted - https://review.openstack.org/271809 -
> once landed it should let the spice flow again. If someone could look
> into it deeper it would be appreciated. I know a lot of us are traveling
> over the next 24 hours, so not sure who is going to have time to dig in.
> But it will be massively appreciated.

Dims reported a related bug upstream:

https://github.com/eventlet/eventlet/issues/290

-- 
Jeremy Stanley

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] gate blockage due to eventlet 0.18

[Davanum Srinivas]

yep. we should be all better now :)

-- dims

On Sun, Jan 24, 2016 at 2:48 PM, Andreas Jaeger  wrote:
> On 01/24/2016 08:01 PM, Jeremy Stanley wrote:
>>
>> On 2016-01-24 13:39:38 -0500 (-0500), Sean Dague wrote:
>>>
>>> Something about the eventlet 0.18 release is failing the cloudpipe
>>> functional tests, as well as our docs job (which is really really odd).
>>>
>>> An eventlet pin has been posted - https://review.openstack.org/271809 -
>>> once landed it should let the spice flow again. If someone could look
>>> into it deeper it would be appreciated. I know a lot of us are traveling
>>> over the next 24 hours, so not sure who is going to have time to dig in.
>>> But it will be massively appreciated.
>>
>>
>> Dims reported a related bug upstream:
>>
>>  https://github.com/eventlet/eventlet/issues/290
>>
>
> 0.18.1 was just released and should fix this.
>
> I could reproduce the failure building the docs with 0.18 but with 0.18.1 it
> works again for me,
>
> Andreas
> --
>  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
>   SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>GF: Felix Imendörffer, Jane Smithard, Graham Norton,
>HRB 21284 (AG Nürnberg)
> GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Davanum Srinivas :: https://twitter.com/dims

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] gate blockage due to eventlet 0.18

[Andreas Jaeger]

On 01/24/2016 08:01 PM, Jeremy Stanley wrote:

On 2016-01-24 13:39:38 -0500 (-0500), Sean Dague wrote:

Something about the eventlet 0.18 release is failing the cloudpipe
functional tests, as well as our docs job (which is really really odd).

An eventlet pin has been posted - https://review.openstack.org/271809 -
once landed it should let the spice flow again. If someone could look
into it deeper it would be appreciated. I know a lot of us are traveling
over the next 24 hours, so not sure who is going to have time to dig in.
But it will be massively appreciated.


Dims reported a related bug upstream:

 https://github.com/eventlet/eventlet/issues/290



0.18.1 was just released and should fix this.

I could reproduce the failure building the docs with 0.18 but with 
0.18.1 it works again for me,


Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
   HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] gate blockage due to eventlet 0.18

[Diana Clarke]

And here's the upstream bug for the functional test failures:

https://github.com/eventlet/eventlet/issues/291
https://bugs.launchpad.net/nova/+bug/1537450

It was also fixed in eventlet 0.18.1.

--diana

>> Dims reported a related bug upstream:
>>
>>  https://github.com/eventlet/eventlet/issues/290
>>
>
> 0.18.1 was just released and should fix this.
>
> I could reproduce the failure building the docs with 0.18 but with 0.18.1 it
> works again for me,

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev