Re: [openstack-dev] [os-vif]

[Sriharsha Basavapatna]

On Wed, Jan 10, 2018 at 11:24 AM, Sriharsha Basavapatna <
sriharsha.basavapa...@broadcom.com> wrote:

> On Tue, Jan 9, 2018 at 10:46 PM, Stephen Finucane 
> wrote:
> > On Tue, 2018-01-09 at 16:30 +0530, Sriharsha Basavapatna wrote:
> >> On Tue, Jan 9, 2018 at 2:20 PM, Sriharsha Basavapatna
> >>  wrote:
> >> > Hi Andreas,
> >> >
> >> > On Tue, Jan 9, 2018 at 12:04 PM, Andreas Jaeger 
> >> > wrote:
> >> > > On 2018-01-09 07:00, Sriharsha Basavapatna wrote:
> >> > > > Hi,
> >> > > >
> >> > > > I've uploaded a patch for review:
> >> > > > https://review.openstack.org/#/c/531674/
> >> > > >
> >> > > > This is the first time I'm submitting a patch on openstack. I'd
> >> > > > like
> >> > >
> >> > > Welcome to OpenStack, Harsha.
> >> >
> >> > Thank you.
> >> >
> >> > > Please read
> >> > > https://docs.openstack.org/infra/manual/developers.html if you
> >> > > haven't.
> >> >
> >> > Ok, i'll read it.
> >> > >
> >> > > I see that your change fails the basic tests, you can run these
> >> > > locally
> >> > > as follows to check that your fixes will pass:
> >> > >
> >> > > tox -e pep8
> >> > > tox -e py27
> >> >
> >> > I was wondering if there's a way to catch these errors without
> >> > having
> >> > to submit it for gerrit review.  I fixed the ones that were
> >> > reported
> >> > in patch-set-1; looks like there's some new ones in the second
> >> > patch-set. I'll run the above commands to verify the fix locally.
> >> >
> >> > Thanks,
> >> > -Harsha
> >>
> >> I installed python-pip and tox.  But when I run "tox -e pep8", I'm
> >> seeing some errors:
> >>
> >> building 'netifaces' extension
> >> gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall
> >> -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
> >> --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic
> >> -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall
> >> -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
> >> --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic
> >> -D_GNU_SOURCE -fPIC -fwrapv -fPIC -DNETIFACES_VERSION=0.10.6
> >> -DHAVE_GETIFADDRS=1 -DHAVE_GETNAMEINFO=1 -DHAVE_NETASH_ASH_H=1
> >> -DHAVE_NETATALK_AT_H=1 -DHAVE_NETAX25_AX25_H=1
> >> -DHAVE_NETECONET_EC_H=1
> >> -DHAVE_NETIPX_IPX_H=1 -DHAVE_NETPACKET_PACKET_H=1
> >> -DHAVE_LINUX_IRDA_H=1 -DHAVE_LINUX_ATM_H=1 -DHAVE_LINUX_LLC_H=1
> >> -DHAVE_LINUX_TIPC_H=1 -DHAVE_LINUX_DN_H=1 -DHAVE_SOCKADDR_AT=1
> >> -DHAVE_SOCKADDR_AX25=1 -DHAVE_SOCKADDR_IN=1 -DHAVE_SOCKADDR_IN6=1
> >> -DHAVE_SOCKADDR_IPX=1 -DHAVE_SOCKADDR_UN=1 -DHAVE_SOCKADDR_ASH=1
> >> -DHAVE_SOCKADDR_EC=1 -DHAVE_SOCKADDR_LL=1 -DHAVE_SOCKADDR_ATMPVC=1
> >> -DHAVE_SOCKADDR_ATMSVC=1 -DHAVE_SOCKADDR_DN=1 -DHAVE_SOCKADDR_IRDA=1
> >> -DHAVE_SOCKADDR_LLC=1 -DHAVE_PF_NETLINK=1 -I/usr/include/python2.7 -c
> >> netifaces.c -o build/temp.linux-x86_64-2.7/netifaces.o
> >> netifaces.c:1:20: fatal error: Python.h: No such file or
> >> directory
> >>  #include 
> >> ^
> >> compilation terminated.
> >> error: command 'gcc' failed with exit status 1
> >>
> >> 
> >> Command "/home/harshab/os-vif/.tox/pep8/bin/python2 -u -c "import
> >> setuptools, tokenize;__file__='/tmp/pip-build-
> >> OibnHO/netifaces/setup.py';f=getattr(tokenize,
> >> 'open', open)(__file__);code=f.read().replace('\r\n',
> >> '\n');f.close();exec(compile(code, __file__, 'exec'))" install
> >> --record /tmp/pip-3Hu__1-record/install-record.txt
> >> --single-version-externally-managed --compile --install-headers
> >> /home/harshab/os-vif/.tox/pep8/include/site/python2.7/netifaces"
> >> failed with error code 1 in /tmp/pip-build-OibnHO/netifaces/
> >>
> >> ERROR: could not install deps
> >> [-r/home/harshab/os-vif/requirements.txt,
> >> -r/home/harshab/os-vif/test-requirements.txt]; v =
> >> InvocationError('/home/harshab/os-vif/.tox/pep8/bin/pip install -U
> >> -r/home/harshab/os-vif/requirements.txt
> >> -r/home/harshab/os-vif/test-requirements.txt (see
> >> /home/harshab/os-vif/.tox/pep8/log/pep8-1.log)', 1)
> >> ___ summary
> >> 
> >> ERROR:   pep8: could not install deps
> >> [-r/home/harshab/os-vif/requirements.txt,
> >> -r/home/harshab/os-vif/test-requirements.txt]; v =
> >> InvocationError('/home/harshab/os-vif/.tox/pep8/bin/pip install -U
> >> -r/home/harshab/os-vif/requirements.txt
> >> -r/home/harshab/os-vif/test-requirements.txt (see
> >> /home/harshab/os-vif/.tox/pep8/log/pep8-1.log)', 1)
> >>
> >> Thanks,
> >> -Harsha
> >
> > That's happening because the 'pep8' target is installing all the
> > requirements for the project in a virtualenv, and one of them needs
> > Python development headers. What Linux distro are you using? On Fedora
> > you can fix this like so:
> >
> > sudo dnf install python-devel
>
> Thanks Stephen, I'm using RHEL and 'yum install python-devel' resolved it.
> 

Re: [openstack-dev] [os-vif]

[Sriharsha Basavapatna]

On Tue, Jan 9, 2018 at 10:46 PM, Stephen Finucane  wrote:
> On Tue, 2018-01-09 at 16:30 +0530, Sriharsha Basavapatna wrote:
>> On Tue, Jan 9, 2018 at 2:20 PM, Sriharsha Basavapatna
>>  wrote:
>> > Hi Andreas,
>> >
>> > On Tue, Jan 9, 2018 at 12:04 PM, Andreas Jaeger 
>> > wrote:
>> > > On 2018-01-09 07:00, Sriharsha Basavapatna wrote:
>> > > > Hi,
>> > > >
>> > > > I've uploaded a patch for review:
>> > > > https://review.openstack.org/#/c/531674/
>> > > >
>> > > > This is the first time I'm submitting a patch on openstack. I'd
>> > > > like
>> > >
>> > > Welcome to OpenStack, Harsha.
>> >
>> > Thank you.
>> >
>> > > Please read
>> > > https://docs.openstack.org/infra/manual/developers.html if you
>> > > haven't.
>> >
>> > Ok, i'll read it.
>> > >
>> > > I see that your change fails the basic tests, you can run these
>> > > locally
>> > > as follows to check that your fixes will pass:
>> > >
>> > > tox -e pep8
>> > > tox -e py27
>> >
>> > I was wondering if there's a way to catch these errors without
>> > having
>> > to submit it for gerrit review.  I fixed the ones that were
>> > reported
>> > in patch-set-1; looks like there's some new ones in the second
>> > patch-set. I'll run the above commands to verify the fix locally.
>> >
>> > Thanks,
>> > -Harsha
>>
>> I installed python-pip and tox.  But when I run "tox -e pep8", I'm
>> seeing some errors:
>>
>> building 'netifaces' extension
>> gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall
>> -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
>> --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic
>> -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall
>> -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
>> --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic
>> -D_GNU_SOURCE -fPIC -fwrapv -fPIC -DNETIFACES_VERSION=0.10.6
>> -DHAVE_GETIFADDRS=1 -DHAVE_GETNAMEINFO=1 -DHAVE_NETASH_ASH_H=1
>> -DHAVE_NETATALK_AT_H=1 -DHAVE_NETAX25_AX25_H=1
>> -DHAVE_NETECONET_EC_H=1
>> -DHAVE_NETIPX_IPX_H=1 -DHAVE_NETPACKET_PACKET_H=1
>> -DHAVE_LINUX_IRDA_H=1 -DHAVE_LINUX_ATM_H=1 -DHAVE_LINUX_LLC_H=1
>> -DHAVE_LINUX_TIPC_H=1 -DHAVE_LINUX_DN_H=1 -DHAVE_SOCKADDR_AT=1
>> -DHAVE_SOCKADDR_AX25=1 -DHAVE_SOCKADDR_IN=1 -DHAVE_SOCKADDR_IN6=1
>> -DHAVE_SOCKADDR_IPX=1 -DHAVE_SOCKADDR_UN=1 -DHAVE_SOCKADDR_ASH=1
>> -DHAVE_SOCKADDR_EC=1 -DHAVE_SOCKADDR_LL=1 -DHAVE_SOCKADDR_ATMPVC=1
>> -DHAVE_SOCKADDR_ATMSVC=1 -DHAVE_SOCKADDR_DN=1 -DHAVE_SOCKADDR_IRDA=1
>> -DHAVE_SOCKADDR_LLC=1 -DHAVE_PF_NETLINK=1 -I/usr/include/python2.7 -c
>> netifaces.c -o build/temp.linux-x86_64-2.7/netifaces.o
>> netifaces.c:1:20: fatal error: Python.h: No such file or
>> directory
>>  #include 
>> ^
>> compilation terminated.
>> error: command 'gcc' failed with exit status 1
>>
>> 
>> Command "/home/harshab/os-vif/.tox/pep8/bin/python2 -u -c "import
>> setuptools, tokenize;__file__='/tmp/pip-build-
>> OibnHO/netifaces/setup.py';f=getattr(tokenize,
>> 'open', open)(__file__);code=f.read().replace('\r\n',
>> '\n');f.close();exec(compile(code, __file__, 'exec'))" install
>> --record /tmp/pip-3Hu__1-record/install-record.txt
>> --single-version-externally-managed --compile --install-headers
>> /home/harshab/os-vif/.tox/pep8/include/site/python2.7/netifaces"
>> failed with error code 1 in /tmp/pip-build-OibnHO/netifaces/
>>
>> ERROR: could not install deps
>> [-r/home/harshab/os-vif/requirements.txt,
>> -r/home/harshab/os-vif/test-requirements.txt]; v =
>> InvocationError('/home/harshab/os-vif/.tox/pep8/bin/pip install -U
>> -r/home/harshab/os-vif/requirements.txt
>> -r/home/harshab/os-vif/test-requirements.txt (see
>> /home/harshab/os-vif/.tox/pep8/log/pep8-1.log)', 1)
>> ___ summary
>> 
>> ERROR:   pep8: could not install deps
>> [-r/home/harshab/os-vif/requirements.txt,
>> -r/home/harshab/os-vif/test-requirements.txt]; v =
>> InvocationError('/home/harshab/os-vif/.tox/pep8/bin/pip install -U
>> -r/home/harshab/os-vif/requirements.txt
>> -r/home/harshab/os-vif/test-requirements.txt (see
>> /home/harshab/os-vif/.tox/pep8/log/pep8-1.log)', 1)
>>
>> Thanks,
>> -Harsha
>
> That's happening because the 'pep8' target is installing all the
> requirements for the project in a virtualenv, and one of them needs
> Python development headers. What Linux distro are you using? On Fedora
> you can fix this like so:
>
> sudo dnf install python-devel

Thanks Stephen, I'm using RHEL and 'yum install python-devel' resolved it.
-Harsha

>
> On Ubuntu, I think it's something like this:
>
> sudo apt-get install python-dev
>
> Stephen
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> 

Re: [openstack-dev] [os-vif]

[Stephen Finucane]

On Tue, 2018-01-09 at 16:30 +0530, Sriharsha Basavapatna wrote:
> On Tue, Jan 9, 2018 at 2:20 PM, Sriharsha Basavapatna
>  wrote:
> > Hi Andreas,
> > 
> > On Tue, Jan 9, 2018 at 12:04 PM, Andreas Jaeger 
> > wrote:
> > > On 2018-01-09 07:00, Sriharsha Basavapatna wrote:
> > > > Hi,
> > > > 
> > > > I've uploaded a patch for review:
> > > > https://review.openstack.org/#/c/531674/
> > > > 
> > > > This is the first time I'm submitting a patch on openstack. I'd
> > > > like
> > > 
> > > Welcome to OpenStack, Harsha.
> > 
> > Thank you.
> > 
> > > Please read
> > > https://docs.openstack.org/infra/manual/developers.html if you
> > > haven't.
> > 
> > Ok, i'll read it.
> > > 
> > > I see that your change fails the basic tests, you can run these
> > > locally
> > > as follows to check that your fixes will pass:
> > > 
> > > tox -e pep8
> > > tox -e py27
> > 
> > I was wondering if there's a way to catch these errors without
> > having
> > to submit it for gerrit review.  I fixed the ones that were
> > reported
> > in patch-set-1; looks like there's some new ones in the second
> > patch-set. I'll run the above commands to verify the fix locally.
> > 
> > Thanks,
> > -Harsha
> 
> I installed python-pip and tox.  But when I run "tox -e pep8", I'm
> seeing some errors:
> 
> building 'netifaces' extension
> gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall
> -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
> --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic
> -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall
> -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
> --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic
> -D_GNU_SOURCE -fPIC -fwrapv -fPIC -DNETIFACES_VERSION=0.10.6
> -DHAVE_GETIFADDRS=1 -DHAVE_GETNAMEINFO=1 -DHAVE_NETASH_ASH_H=1
> -DHAVE_NETATALK_AT_H=1 -DHAVE_NETAX25_AX25_H=1
> -DHAVE_NETECONET_EC_H=1
> -DHAVE_NETIPX_IPX_H=1 -DHAVE_NETPACKET_PACKET_H=1
> -DHAVE_LINUX_IRDA_H=1 -DHAVE_LINUX_ATM_H=1 -DHAVE_LINUX_LLC_H=1
> -DHAVE_LINUX_TIPC_H=1 -DHAVE_LINUX_DN_H=1 -DHAVE_SOCKADDR_AT=1
> -DHAVE_SOCKADDR_AX25=1 -DHAVE_SOCKADDR_IN=1 -DHAVE_SOCKADDR_IN6=1
> -DHAVE_SOCKADDR_IPX=1 -DHAVE_SOCKADDR_UN=1 -DHAVE_SOCKADDR_ASH=1
> -DHAVE_SOCKADDR_EC=1 -DHAVE_SOCKADDR_LL=1 -DHAVE_SOCKADDR_ATMPVC=1
> -DHAVE_SOCKADDR_ATMSVC=1 -DHAVE_SOCKADDR_DN=1 -DHAVE_SOCKADDR_IRDA=1
> -DHAVE_SOCKADDR_LLC=1 -DHAVE_PF_NETLINK=1 -I/usr/include/python2.7 -c
> netifaces.c -o build/temp.linux-x86_64-2.7/netifaces.o
> netifaces.c:1:20: fatal error: Python.h: No such file or
> directory
>  #include 
> ^
> compilation terminated.
> error: command 'gcc' failed with exit status 1
> 
> 
> Command "/home/harshab/os-vif/.tox/pep8/bin/python2 -u -c "import
> setuptools, tokenize;__file__='/tmp/pip-build-
> OibnHO/netifaces/setup.py';f=getattr(tokenize,
> 'open', open)(__file__);code=f.read().replace('\r\n',
> '\n');f.close();exec(compile(code, __file__, 'exec'))" install
> --record /tmp/pip-3Hu__1-record/install-record.txt
> --single-version-externally-managed --compile --install-headers
> /home/harshab/os-vif/.tox/pep8/include/site/python2.7/netifaces"
> failed with error code 1 in /tmp/pip-build-OibnHO/netifaces/
> 
> ERROR: could not install deps
> [-r/home/harshab/os-vif/requirements.txt,
> -r/home/harshab/os-vif/test-requirements.txt]; v =
> InvocationError('/home/harshab/os-vif/.tox/pep8/bin/pip install -U
> -r/home/harshab/os-vif/requirements.txt
> -r/home/harshab/os-vif/test-requirements.txt (see
> /home/harshab/os-vif/.tox/pep8/log/pep8-1.log)', 1)
> ___ summary
> 
> ERROR:   pep8: could not install deps
> [-r/home/harshab/os-vif/requirements.txt,
> -r/home/harshab/os-vif/test-requirements.txt]; v =
> InvocationError('/home/harshab/os-vif/.tox/pep8/bin/pip install -U
> -r/home/harshab/os-vif/requirements.txt
> -r/home/harshab/os-vif/test-requirements.txt (see
> /home/harshab/os-vif/.tox/pep8/log/pep8-1.log)', 1)
> 
> Thanks,
> -Harsha

That's happening because the 'pep8' target is installing all the
requirements for the project in a virtualenv, and one of them needs
Python development headers. What Linux distro are you using? On Fedora
you can fix this like so:

sudo dnf install python-devel

On Ubuntu, I think it's something like this:

sudo apt-get install python-dev

Stephen

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif]

[Sriharsha Basavapatna]

On Tue, Jan 9, 2018 at 2:20 PM, Sriharsha Basavapatna
 wrote:
> Hi Andreas,
>
> On Tue, Jan 9, 2018 at 12:04 PM, Andreas Jaeger  wrote:
>> On 2018-01-09 07:00, Sriharsha Basavapatna wrote:
>>> Hi,
>>>
>>> I've uploaded a patch for review:
>>> https://review.openstack.org/#/c/531674/
>>>
>>> This is the first time I'm submitting a patch on openstack. I'd like
>>
>> Welcome to OpenStack, Harsha.
>
> Thank you.
>
>> Please read
>> https://docs.openstack.org/infra/manual/developers.html if you haven't.
>
> Ok, i'll read it.
>>
>> I see that your change fails the basic tests, you can run these locally
>> as follows to check that your fixes will pass:
>>
>> tox -e pep8
>> tox -e py27
>
> I was wondering if there's a way to catch these errors without having
> to submit it for gerrit review.  I fixed the ones that were reported
> in patch-set-1; looks like there's some new ones in the second
> patch-set. I'll run the above commands to verify the fix locally.
>
> Thanks,
> -Harsha

I installed python-pip and tox.  But when I run "tox -e pep8", I'm
seeing some errors:

building 'netifaces' extension
gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic
-D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic
-D_GNU_SOURCE -fPIC -fwrapv -fPIC -DNETIFACES_VERSION=0.10.6
-DHAVE_GETIFADDRS=1 -DHAVE_GETNAMEINFO=1 -DHAVE_NETASH_ASH_H=1
-DHAVE_NETATALK_AT_H=1 -DHAVE_NETAX25_AX25_H=1 -DHAVE_NETECONET_EC_H=1
-DHAVE_NETIPX_IPX_H=1 -DHAVE_NETPACKET_PACKET_H=1
-DHAVE_LINUX_IRDA_H=1 -DHAVE_LINUX_ATM_H=1 -DHAVE_LINUX_LLC_H=1
-DHAVE_LINUX_TIPC_H=1 -DHAVE_LINUX_DN_H=1 -DHAVE_SOCKADDR_AT=1
-DHAVE_SOCKADDR_AX25=1 -DHAVE_SOCKADDR_IN=1 -DHAVE_SOCKADDR_IN6=1
-DHAVE_SOCKADDR_IPX=1 -DHAVE_SOCKADDR_UN=1 -DHAVE_SOCKADDR_ASH=1
-DHAVE_SOCKADDR_EC=1 -DHAVE_SOCKADDR_LL=1 -DHAVE_SOCKADDR_ATMPVC=1
-DHAVE_SOCKADDR_ATMSVC=1 -DHAVE_SOCKADDR_DN=1 -DHAVE_SOCKADDR_IRDA=1
-DHAVE_SOCKADDR_LLC=1 -DHAVE_PF_NETLINK=1 -I/usr/include/python2.7 -c
netifaces.c -o build/temp.linux-x86_64-2.7/netifaces.o
netifaces.c:1:20: fatal error: Python.h: No such file or directory
 #include 
^
compilation terminated.
error: command 'gcc' failed with exit status 1


Command "/home/harshab/os-vif/.tox/pep8/bin/python2 -u -c "import
setuptools, 
tokenize;__file__='/tmp/pip-build-OibnHO/netifaces/setup.py';f=getattr(tokenize,
'open', open)(__file__);code=f.read().replace('\r\n',
'\n');f.close();exec(compile(code, __file__, 'exec'))" install
--record /tmp/pip-3Hu__1-record/install-record.txt
--single-version-externally-managed --compile --install-headers
/home/harshab/os-vif/.tox/pep8/include/site/python2.7/netifaces"
failed with error code 1 in /tmp/pip-build-OibnHO/netifaces/

ERROR: could not install deps
[-r/home/harshab/os-vif/requirements.txt,
-r/home/harshab/os-vif/test-requirements.txt]; v =
InvocationError('/home/harshab/os-vif/.tox/pep8/bin/pip install -U
-r/home/harshab/os-vif/requirements.txt
-r/home/harshab/os-vif/test-requirements.txt (see
/home/harshab/os-vif/.tox/pep8/log/pep8-1.log)', 1)
___ summary 
ERROR:   pep8: could not install deps
[-r/home/harshab/os-vif/requirements.txt,
-r/home/harshab/os-vif/test-requirements.txt]; v =
InvocationError('/home/harshab/os-vif/.tox/pep8/bin/pip install -U
-r/home/harshab/os-vif/requirements.txt
-r/home/harshab/os-vif/test-requirements.txt (see
/home/harshab/os-vif/.tox/pep8/log/pep8-1.log)', 1)

Thanks,
-Harsha

>
>>
>> Andreas
>>
>>> to add code reviewers on this patch. I'd appreciate if you could point
>>> me to any guidelines on how to pick reviewers for a given project
>>> (os-vif library in this case).
>>>
>>> Thanks,
>>> -Harsha
>>>
>>> __
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>>
>> --
>>  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
>>   SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>>GF: Felix Imendörffer, Jane Smithard, Graham Norton,
>>HRB 21284 (AG Nürnberg)
>> GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
>>

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif]

[Sriharsha Basavapatna]

Hi Andreas,

On Tue, Jan 9, 2018 at 12:04 PM, Andreas Jaeger  wrote:
> On 2018-01-09 07:00, Sriharsha Basavapatna wrote:
>> Hi,
>>
>> I've uploaded a patch for review:
>> https://review.openstack.org/#/c/531674/
>>
>> This is the first time I'm submitting a patch on openstack. I'd like
>
> Welcome to OpenStack, Harsha.

Thank you.

> Please read
> https://docs.openstack.org/infra/manual/developers.html if you haven't.

Ok, i'll read it.
>
> I see that your change fails the basic tests, you can run these locally
> as follows to check that your fixes will pass:
>
> tox -e pep8
> tox -e py27

I was wondering if there's a way to catch these errors without having
to submit it for gerrit review.  I fixed the ones that were reported
in patch-set-1; looks like there's some new ones in the second
patch-set. I'll run the above commands to verify the fix locally.

Thanks,
-Harsha

>
> Andreas
>
>> to add code reviewers on this patch. I'd appreciate if you could point
>> me to any guidelines on how to pick reviewers for a given project
>> (os-vif library in this case).
>>
>> Thanks,
>> -Harsha
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
> --
>  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
>   SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>GF: Felix Imendörffer, Jane Smithard, Graham Norton,
>HRB 21284 (AG Nürnberg)
> GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
>

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif]

[Sriharsha Basavapatna]

Hi Yatin,

Thanks for the info; I'll add the reviewers.
-Harsha

On Tue, Jan 9, 2018 at 11:48 AM, Yatin Karel  wrote:
> Hi Sriharsha,
>
> You can check the core reviewers for os-vif here:-
> https://review.openstack.org/#/admin/groups/1175,members
>
> or from system:-  ssh -p 29418  username>@review.openstack.org gerrit ls-members os-vif-core  (This
> can be run from the system for which you have added the puplic keys to
> gerrit)
>
> To add all core-reviewers, you can just type os-vif-core in Add
> Reviewer Text box on gerrit.
>
> For other projects:- Open Gerrit --> Go to People TAB --> Select "List
> Groups" --> search project (look for -core)
>
>
> Hope this helps.
>
> On Tue, Jan 9, 2018 at 11:30 AM, Sriharsha Basavapatna
>  wrote:
>> Hi,
>>
>> I've uploaded a patch for review:
>> https://review.openstack.org/#/c/531674/
>>
>> This is the first time I'm submitting a patch on openstack. I'd like
>> to add code reviewers on this patch. I'd appreciate if you could point
>> me to any guidelines on how to pick reviewers for a given project
>> (os-vif library in this case).
>>
>> Thanks,
>> -Harsha
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif]

[Andreas Jaeger]

On 2018-01-09 07:00, Sriharsha Basavapatna wrote:
> Hi,
> 
> I've uploaded a patch for review:
> https://review.openstack.org/#/c/531674/
> 
> This is the first time I'm submitting a patch on openstack. I'd like

Welcome to OpenStack, Harsha. Please read
https://docs.openstack.org/infra/manual/developers.html if you haven't.

I see that your change fails the basic tests, you can run these locally
as follows to check that your fixes will pass:

tox -e pep8
tox -e py27

Andreas

> to add code reviewers on this patch. I'd appreciate if you could point
> me to any guidelines on how to pick reviewers for a given project
> (os-vif library in this case).
> 
> Thanks,
> -Harsha
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 


-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
   HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif]

[Andreas Jaeger]

On 2018-01-09 07:00, Sriharsha Basavapatna wrote:
> Hi,
> 
> I've uploaded a patch for review:
> https://review.openstack.org/#/c/531674/
> 
> This is the first time I'm submitting a patch on openstack. I'd like
> to add code reviewers on this patch. I'd appreciate if you could point
> me to any guidelines on how to pick reviewers for a given project
> (os-vif library in this case).


In general, there's no need to add core reviewers to a review. Each of
us have their own dashboards or watch projects that we review and review
as time permits.

Since your change is failing the testsuite: Please fix tests first!

os-vif is part of nova, so if you want to discuss about it, best to join
the #openstack-nova freenode IRC channel,

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Felix Imendörffer, Jane Smithard, Graham Norton,
   HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif]

[Yatin Karel]

Hi Sriharsha,

You can check the core reviewers for os-vif here:-
https://review.openstack.org/#/admin/groups/1175,members

or from system:-  ssh -p 29418 @review.openstack.org gerrit ls-members os-vif-core  (This
can be run from the system for which you have added the puplic keys to
gerrit)

To add all core-reviewers, you can just type os-vif-core in Add
Reviewer Text box on gerrit.

For other projects:- Open Gerrit --> Go to People TAB --> Select "List
Groups" --> search project (look for -core)


Hope this helps.

On Tue, Jan 9, 2018 at 11:30 AM, Sriharsha Basavapatna
 wrote:
> Hi,
>
> I've uploaded a patch for review:
> https://review.openstack.org/#/c/531674/
>
> This is the first time I'm submitting a patch on openstack. I'd like
> to add code reviewers on this patch. I'd appreciate if you could point
> me to any guidelines on how to pick reviewers for a given project
> (os-vif library in this case).
>
> Thanks,
> -Harsha
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [os-vif]

[Sriharsha Basavapatna]

Hi,

I've uploaded a patch for review:
https://review.openstack.org/#/c/531674/

This is the first time I'm submitting a patch on openstack. I'd like
to add code reviewers on this patch. I'd appreciate if you could point
me to any guidelines on how to pick reviewers for a given project
(os-vif library in this case).

Thanks,
-Harsha

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] [nova] Changes to os-vif cores

[Stephen Finucane]

On Tue, 2017-10-24 at 15:32 +0100, Stephen Finucane wrote:
> Hey,
> 
> I'm not actually sure what the protocol is for adding/removing cores to a
> library project without a PTL, so I'm just going to put this out there: I'd
> like to propose the following changes to the os-vif core team.
> 
> - Add 'nova-core'
> 
>   os-vif makes extensive use of objects and we've had a few hiccups around
>   versionings and the likes recently [1][2]. I'd the expertise of some of the
>   other nova cores here as we roll this out to projects other than nova, and 
>   I trust those not interested/knowledgeable in this area to stay away :)
> 
> - Remove Russell Bryant, Maxime Leroy
> 
>   These folks haven't been active on os-vif  [3][4] for a long time and I 
>   think they can be safely removed.
> 
> To the existing core team members, please respond with a yay/nay and we'll
> wait a week before doing anything.

Both of these are done now. Thanks for the feedback, folks.

Stephen

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] [nova] Changes to os-vif cores

[Mooney, Sean K]

+1

> -Original Message-
> From: Jay Pipes [mailto:jaypi...@gmail.com]
> Sent: Wednesday, October 25, 2017 3:45 PM
> To: openstack-dev@lists.openstack.org
> Subject: Re: [openstack-dev] [os-vif] [nova] Changes to os-vif cores
> 
> +1
> 
> On 10/24/2017 10:32 AM, Stephen Finucane wrote:
> > Hey,
> >
> > I'm not actually sure what the protocol is for adding/removing cores
> > to a library project without a PTL, so I'm just going to put this out
> > there: I'd like to propose the following changes to the os-vif core
> team.
> >
> > - Add 'nova-core'
> >
> >os-vif makes extensive use of objects and we've had a few hiccups
> around
> >versionings and the likes recently [1][2]. I'd the expertise of
> some of the
> >other nova cores here as we roll this out to projects other than
> nova, and I
> >trust those not interested/knowledgeable in this area to stay away
> > :)
[Mooney, Sean K] in the future as we start integrating with neutron we may want 
to also extend this to neutron-cores with the same understanding that those 
not interested/knowledgeable in this area continue to focus on neutron.

I also think it continues to be the current os-vif teams role to ensure we do 
not break
Our customers and understand the interaction with both nova and neutron of the
Changes we are making and/or reviewing. That is to say I don’t want the fact 
that nova-cores
or neutron-cores is added to imply that only they should make sure os-vif works 
with nova/neutron.
More succinctly this should change should not be a burden on the nova and 
neutron.


> >
> > - Remove Russell Bryant, Maxime Leroy
> >
> >These folks haven't been active on os-vif  [3][4] for a long time
> and I think
> >they can be safely removed.
> >
> > To the existing core team members, please respond with a yay/nay and
> > we'll wait a week before doing anything.
> >
> > Cheers,
> > Stephen
> >
> > [1] https://review.openstack.org/#/c/508498/
> > [2] https://review.openstack.org/#/c/509107/
> > [3]
> >
> https://review.openstack.org/#/q/reviewedby:%22Russell+Bryant+%253Crbr
> > yant% 2540redhat.com%253E%22+project:openstack/os-vif
> > [4]
> >
> https://review.openstack.org/#/q/reviewedby:%22Maxime+Leroy+%253Cmaxim
> > e.ler oy%25406wind.com%253E%22+project:openstack/os-vif
> >
> >
> __
> >  OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> 
> ___
> ___
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-
> requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] [nova] Changes to os-vif cores

[Jay Pipes]

+1

On 10/24/2017 10:32 AM, Stephen Finucane wrote:

Hey,

I'm not actually sure what the protocol is for adding/removing cores to a
library project without a PTL, so I'm just going to put this out there: I'd
like to propose the following changes to the os-vif core team.

- Add 'nova-core'

   os-vif makes extensive use of objects and we've had a few hiccups around
   versionings and the likes recently [1][2]. I'd the expertise of some of the
   other nova cores here as we roll this out to projects other than nova, and I
   trust those not interested/knowledgeable in this area to stay away :)

- Remove Russell Bryant, Maxime Leroy

   These folks haven't been active on os-vif  [3][4] for a long time and I think
   they can be safely removed.

To the existing core team members, please respond with a yay/nay and we'll wait
a week before doing anything.

Cheers,
Stephen

[1] https://review.openstack.org/#/c/508498/
[2] https://review.openstack.org/#/c/509107/
[3] https://review.openstack.org/#/q/reviewedby:%22Russell+Bryant+%253Crbryant%
2540redhat.com%253E%22+project:openstack/os-vif
[4] https://review.openstack.org/#/q/reviewedby:%22Maxime+Leroy+%253Cmaxime.ler
oy%25406wind.com%253E%22+project:openstack/os-vif

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] [nova] Changes to os-vif cores

[Moshe Levi]

> -Original Message-
> From: Sahid Orentino Ferdjaoui [mailto:sferd...@redhat.com]
> Sent: Wednesday, October 25, 2017 11:22 AM
> To: OpenStack Development Mailing List (not for usage questions)
> <openstack-dev@lists.openstack.org>
> Subject: Re: [openstack-dev] [os-vif] [nova] Changes to os-vif cores
> 
> On Tue, Oct 24, 2017 at 03:32:15PM +0100, Stephen Finucane wrote:
> > Hey,
> >
> > I'm not actually sure what the protocol is for adding/removing cores
> > to a library project without a PTL, so I'm just going to put this out
> > there: I'd like to propose the following changes to the os-vif core team.
> >
> > - Add 'nova-core'
> >
> >   os-vif makes extensive use of objects and we've had a few hiccups around
> >   versionings and the likes recently [1][2]. I'd the expertise of some of 
> > the
> >   other nova cores here as we roll this out to projects other than nova, 
> > and I
> >   trust those not interested/knowledgeable in this area to stay away
> > :)
> >
> > - Remove Russell Bryant, Maxime Leroy
> >
> >   These folks haven't been active on os-vif  [3][4] for a long time and I 
> > think
> >   they can be safely removed.
> 
> Indeed, they are not active. Seems to be reasonable.
+1
> 
> > To the existing core team members, please respond with a yay/nay and
> > we'll wait a week before doing anything.
> >
> > Cheers,
> > Stephen
> >
> > [1]
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frev
> >
> iew.openstack.org%2F%23%2Fc%2F508498%2F=02%7C01%7Cmoshele
> %40mella
> >
> nox.com%7Cf9470c2a06914266f7b508d51b819b76%7Ca652971c7d2e4d9ba6a
> 4d1492
> >
> 56f461b%7C0%7C0%7C636445165832350206=PU5gKHSscjFPUaFb5%2B
> g4QyWdv
> > VPWZQE6IuVTERcg1Zg%3D=0 [2]
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frev
> >
> iew.openstack.org%2F%23%2Fc%2F509107%2F=02%7C01%7Cmoshele
> %40mella
> >
> nox.com%7Cf9470c2a06914266f7b508d51b819b76%7Ca652971c7d2e4d9ba6a
> 4d1492
> >
> 56f461b%7C0%7C0%7C636445165832350206=CrXbAUP%2Fut5hov%2F
> YpfVVevu
> > pDzyJpqaoYjXDzSJnbDE%3D=0
> > [3]
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frev
> >
> iew.openstack.org%2F%23%2Fq%2Freviewedby%3A%2522Russell%2BBryant
> %2B%25
> >
> 253Crbryant%25=02%7C01%7Cmoshele%40mellanox.com%7Cf9470c2a
> 0691426
> >
> 6f7b508d51b819b76%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C
> 6364451
> >
> 65832350206=l7iWjHiCxiouHJdWxbvwI9Gi%2Bne8o14TlcfBWHttT8Y%3
> D
> > erved=0 2540redhat.com%253E%22+project:openstack/os-vif
> > [4]
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frev
> >
> iew.openstack.org%2F%23%2Fq%2Freviewedby%3A%2522Maxime%2BLeroy
> %2B%2525
> >
> 3Cmaxime.ler=02%7C01%7Cmoshele%40mellanox.com%7Cf9470c2a06
> 914266f
> >
> 7b508d51b819b76%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C63
> 6445165
> >
> 832350206=8ywHQPppzRO2CAl6e1jzSOLx5G4gvHxRkGzl6qEgbyY%3D
> 
> > d=0 oy%25406wind.com%253E%22+project:openstack/os-vif
> >
> >
> __
> 
> >  OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> >
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flist
> > s.openstack.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fopenstack-
> dev=02
> >
> %7C01%7Cmoshele%40mellanox.com%7Cf9470c2a06914266f7b508d51b819b
> 76%7Ca6
> >
> 52971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636445165832350206
> a=2NIN
> > pJxKv%2BIq0iPCCm7UDPyFNaI9X47d%2B2MmpEQSlPI%3D=0
> 
> __
> 
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-
> requ...@lists.openstack.org?subject:unsubscribe
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.
> openstack.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fopenstack-
> dev=02%7C01%7Cmoshele%40mellanox.com%7Cf9470c2a06914266f7b
> 508d51b819b76%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C6364
> 45165832350206=2NINpJxKv%2BIq0iPCCm7UDPyFNaI9X47d%2B2Mm
> pEQSlPI%3D=0
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] [nova] Changes to os-vif cores

[Sahid Orentino Ferdjaoui]

On Tue, Oct 24, 2017 at 03:32:15PM +0100, Stephen Finucane wrote:
> Hey,
> 
> I'm not actually sure what the protocol is for adding/removing cores to a
> library project without a PTL, so I'm just going to put this out there: I'd
> like to propose the following changes to the os-vif core team.
> 
> - Add 'nova-core'
> 
>   os-vif makes extensive use of objects and we've had a few hiccups around
>   versionings and the likes recently [1][2]. I'd the expertise of some of the
>   other nova cores here as we roll this out to projects other than nova, and I
>   trust those not interested/knowledgeable in this area to stay away :)
> 
> - Remove Russell Bryant, Maxime Leroy
> 
>   These folks haven't been active on os-vif  [3][4] for a long time and I 
> think
>   they can be safely removed.

Indeed, they are not active. Seems to be reasonable.

> To the existing core team members, please respond with a yay/nay and we'll 
> wait
> a week before doing anything.
> 
> Cheers,
> Stephen
> 
> [1] https://review.openstack.org/#/c/508498/
> [2] https://review.openstack.org/#/c/509107/
> [3] 
> https://review.openstack.org/#/q/reviewedby:%22Russell+Bryant+%253Crbryant%
> 2540redhat.com%253E%22+project:openstack/os-vif
> [4] 
> https://review.openstack.org/#/q/reviewedby:%22Maxime+Leroy+%253Cmaxime.ler
> oy%25406wind.com%253E%22+project:openstack/os-vif
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] [nova] Changes to os-vif cores

[Tony Breeds]

On Tue, Oct 24, 2017 at 03:32:15PM +0100, Stephen Finucane wrote:
> Hey,
> 
> I'm not actually sure what the protocol is for adding/removing cores to a
> library project without a PTL, so I'm just going to put this out there: I'd
> like to propose the following changes to the os-vif core team.

FWIW, os-vif is part of nova in terms of governance so Matt is the PTL
for os-vif ;P

https://governance.openstack.org/tc/reference/projects/nova.html#os-vif
 
> - Add 'nova-core'
> 
>   os-vif makes extensive use of objects and we've had a few hiccups around
>   versionings and the likes recently [1][2]. I'd the expertise of some of the
>   other nova cores here as we roll this out to projects other than nova, and I
>   trust those not interested/knowledgeable in this area to stay away :)
> 
> - Remove Russell Bryant, Maxime Leroy
> 
>   These folks haven't been active on os-vif  [3][4] for a long time and I 
> think
>   they can be safely removed.
> 
> To the existing core team members, please respond with a yay/nay and we'll 
> wait
> a week before doing anything.

FWIW that all sounds reasonable to me.

Yours Tony.


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [os-vif] [nova] Changes to os-vif cores

[Stephen Finucane]

Hey,

I'm not actually sure what the protocol is for adding/removing cores to a
library project without a PTL, so I'm just going to put this out there: I'd
like to propose the following changes to the os-vif core team.

- Add 'nova-core'

  os-vif makes extensive use of objects and we've had a few hiccups around
  versionings and the likes recently [1][2]. I'd the expertise of some of the
  other nova cores here as we roll this out to projects other than nova, and I
  trust those not interested/knowledgeable in this area to stay away :)

- Remove Russell Bryant, Maxime Leroy

  These folks haven't been active on os-vif  [3][4] for a long time and I think
  they can be safely removed.

To the existing core team members, please respond with a yay/nay and we'll wait
a week before doing anything.

Cheers,
Stephen

[1] https://review.openstack.org/#/c/508498/
[2] https://review.openstack.org/#/c/509107/
[3] https://review.openstack.org/#/q/reviewedby:%22Russell+Bryant+%253Crbryant%
2540redhat.com%253E%22+project:openstack/os-vif
[4] https://review.openstack.org/#/q/reviewedby:%22Maxime+Leroy+%253Cmaxime.ler
oy%25406wind.com%253E%22+project:openstack/os-vif

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] [passthrough] [VifHostDevice]

[Moshe Levi]

The ODL part is still not ready. We need to do code changes in odl to make it 
work see [1] [2]

[1] https://git.opendaylight.org/gerrit/#/c/62481/ 
[2] https://git.opendaylight.org/gerrit/#/c/60259/ 

We try to make the design as generic as possible so if you have a SR-IOV NIC 
that support switchdev 
And allow to offload rules using linux tc it should work.  

> -Original Message-
> From: pranab boruah [mailto:pranabjyotibor...@gmail.com]
> Sent: Friday, September 22, 2017 4:50 PM
> To: openstack-dev@lists.openstack.org
> Subject: [openstack-dev] [os-vif] [passthrough] [VifHostDevice]
> 
> Thanks Sean for such a descriptive answer. It definitely helped.
> 
> >the hardware offload support for melonox nics is only supported with
> >the openvswitch or odl >ml2 dirvers
> [Pranab] Okay. We have the option of using ODL as the mechanism driver
> too. I am building the cluster with ODL as the mechanism driver right now and
> would experiment with it.
> Do you think there is a design limitation in VIFHostDevice model that limits 
> us
> in using either only Mellanox or Netronome NICs? AFAIK, say I have a SRIOV
> NIC that supports OVS offload and Switchdev and we use openvswitch/odl as
> the mechanism driver, things should work as expected for this NIC too right?
> 
> __
> 
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-
> requ...@lists.openstack.org?subject:unsubscribe
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.
> openstack.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fopenstack-
> dev=02%7C01%7Cmoshele%40mellanox.com%7C5d64f1a6da0142ffb40
> 908d501c0c634%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C63641
> 6849830686294=eU2fTih8PqnDEpmNugmDMmOB2I40znLkEpbEmfYS3
> 3Y%3D=0
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [os-vif] [passthrough] [VifHostDevice]

[pranab boruah]

Thanks Sean for such a descriptive answer. It definitely helped.

>the hardware offload support for melonox nics is only supported with the 
>openvswitch or odl >ml2 dirvers
[Pranab] Okay. We have the option of using ODL as the mechanism driver
too. I am building the cluster with ODL as the mechanism driver right
now and would experiment with it.
Do you think there is a design limitation in VIFHostDevice model that
limits us in using either only Mellanox or Netronome NICs? AFAIK, say
I have a SRIOV NIC that supports OVS offload and Switchdev and we use
openvswitch/odl as the mechanism driver, things should work as
expected for this NIC too right?

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] [passthrough] [VifHostDevice]

[Mooney, Sean K]

> -Original Message-
> From: pranab boruah [mailto:pranabjyotibor...@gmail.com]
> Sent: Thursday, September 21, 2017 5:12 PM
> To: OpenStack Development Mailing List (not for usage questions)
> <openstack-dev@lists.openstack.org>
> Subject: [openstack-dev] [os-vif] [passthrough] [VifHostDevice]
> 
> Hi,
> We have a SRIOV capable NIC that supports OVS offload and Switchdev.
> We are trying to test the VifHostDevice model on a Pike cluster. We are
> running into issues. Here are the config options that we have
> used:
> 
> 1. In Neutron conf file: mechanism driver = ovn 
[Mooney, Sean K] looking at the networking-ovn ml2 dirver vnic type direct is 
not supported
https://github.com/openstack/networking-ovn/blob/f5fe5e3c623a2a65ee78ec28b053d8e72060c13d/networking_ovn/ml2/mech_driver.py#L112
the hardware offload support for melonox nics is only supported with the 
openvswitch or odl ml2 dirvers
netronome smartnics require the use of the agilio ovs ml2 dirver which supports
dirct and virtio forwarder mode
https://github.com/Netronome/agilio-ovs-openstack-plugin/blob/master/networking_netronome/plugins/ml2/drivers/agilio_ovs/mech_driver/mech_agilio_ovs.py#L46-L47

if you wish to use ovn you will need to modify the ovn ml2 dirver to add 
vnic_type direct to the supported vnictypes.

>2. In Nova conf file:
> passthrough_whitelist = {"address":":02:00.*"} 3. Created a port as
> vnic_type=direct and launched instances.
> It gives the following error - Nova error : "No net device was found
> for VF"
> Am I missing some other config options?
[Mooney, Sean K] no but as I mentioned above ovn is not currently supported.
I belive you should have a log message in the neutron server log also as when 
neutron calls
The the networking-ovn ml2 driver here
https://github.com/openstack/neutron/blob/433d5a03534c4f30fdf3b864d11dea527e9b6f91/neutron/plugins/ml2/managers.py#L782
we simply retrun on line 502 here after logging.
https://github.com/openstack/networking-ovn/blob/f5fe5e3c623a2a65ee78ec28b053d8e72060c13d/networking_ovn/ml2/mech_driver.py#L502
if you only have the ovn ml2 driver enabled you should set the prot with 
vif_type_binding_failed howver if you have
the sriovnicagent also enable it may be masking the isses as 
https://github.com/openstack/neutron/blob/433d5a03534c4f30fdf3b864d11dea527e9b6f91/neutron/plugins/ml2/managers.py#L776
will continue to try the other dirvers.

Assuming ovn in the only enabled mech driver i belive this should result in the 
vif_type being set to VIF_TYPE_BINDING_FAILED as
https://github.com/openstack/neutron/blob/433d5a03534c4f30fdf3b864d11dea527e9b6f91/neutron/plugins/ml2/managers.py#L748
will not return anyting so we should execute 
https://github.com/openstack/neutron/blob/433d5a03534c4f30fdf3b864d11dea527e9b6f91/neutron/plugins/ml2/managers.py#L750-L757
you should be able to configm this by doing a port show and/or checking the 
neutron server log.

> 
> Also, how can I check the logs that are related to the os-vif library?
[Mooney, Sean K] the logs are present in the n-cpu log as os-vif executes with 
the nova compute agent.
> 
> Let me know if further details are required.
> 
> TIA,
> Pranab
> 
> ___
> ___
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-
> requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [os-vif] [passthrough] [VifHostDevice]

[pranab boruah]

Hi,
We have a SRIOV capable NIC that supports OVS offload and Switchdev.
We are trying to test the VifHostDevice model on a Pike cluster. We
are running into issues. Here are the config options that we have
used:

1. In Neutron conf file: mechanism driver = ovn
2. In Nova conf file: passthrough_whitelist = {"address":":02:00.*"}
3. Created a port as vnic_type=direct and launched instances.
It gives the following error - Nova error : "No net device was found for VF"
Am I missing some other config options?

Also, how can I check the logs that are related to the os-vif library?

Let me know if further details are required.

TIA,
Pranab

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type VIFHostDevice

[pranab boruah]

Thank you Sean K Mooney and Moshe Levi for your comments.

I have few follow-up questions. Not looking for a detailed answer(I
know you guys must be busy J). Looking for some basic info and will be
obliged if you can point me to a direction(link to code or docs) where
I can continue my research to understand more deeply.


1. What is the difference between neutron port_binding extension
vif_type and vnic_type?

2.How is a vif object in os_vif(eg VifHostDevice) gets related with a
vif_type(direct)?

3.Where does port_profile related data gets populated?

4.How is the decision of picking the correct networking back-end
os_vif plugin is made?

I guess everything comes under port binding negotiation.

-Pranab

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type VIFHostDevice

[Mooney, Sean K]

> -Original Message-
> From: Moshe Levi [mailto:mosh...@mellanox.com]
> Sent: Wednesday, August 9, 2017 4:47 PM
> To: OpenStack Development Mailing List (not for usage questions)
> <openstack-dev@lists.openstack.org>
> Subject: Re: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on
> VIF_Type VIFHostDevice
> 
> 
> 
> -Original Message-
> From: Mooney, Sean K [mailto:sean.k.moo...@intel.com]
> Sent: Wednesday, August 9, 2017 6:36 PM
> To: OpenStack Development Mailing List (not for usage questions)
> <openstack-dev@lists.openstack.org>
> Subject: Re: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on
> VIF_Type VIFHostDevice
> 
> 
> 
> > -Original Message-
> > From: Moshe Levi [mailto:mosh...@mellanox.com]
> > Sent: Wednesday, August 9, 2017 3:25 PM
> > To: OpenStack Development Mailing List (not for usage questions)
> > <openstack-dev@lists.openstack.org>
> > Subject: Re: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on
> > VIF_Type VIFHostDevice
> >
> > Hi,
> >
> > 1) you should use neutron port with vnic_type direct
> > 2) yes,  just use neutron port with vnic_type  direct and confighure
> > the nova compute with pci passthogth whitelist
> > 3) you can configure firewall_driver = openvswitch to work with
> > Conntrack.
> >
> > So in your case if have SR-IOV nic which doesn't support  hardware
> > offload (but has VF representors port)  you will just fallback to the
> > ovs kernel datapath.
> 
> [Mooney, Sean K] that is not what will happen with intel nics and I
> would be doubtful Based on the code I have seen in nova and neutron
> that a fallback will happen with mellanox.
> If the neutron port has vnic_type direct it will Always result in a
> sriov vf being allocated for that port.
> There is no check in nova to ensure ovs support vf configuration and
> there is no check in neutron ml2 driver Either. This is why I wanted
> the feature based scheduling to prevent this from happening as that
> would prevent Nova from allocating the vf which would cause scheduling
> to fail.
> 
> [Moshe Levi] This is not what I meant. I was talking on the
> implementation of the ovs 2.8.0 hardware offload.
> I was referring  for NIC with SR-IOV that support representor ports
> switchdev mode (maybe I miss understood the question).  If it just SR-
> IOV NIC then you are correct.
[Mooney, Sean K] ah yes if the nic and ovs both support representor ports
And tc flower then yes the datapath will auto negociate what can be offloaded
Vs what has to take the exception path via the kernel dataplane. 
> 
> 
> When nova generates the Libvirt xml for that interface it will
> configure that port to use sriov direct pass-through.
> If ovs does not support managing that nic via the representor netdev or
> the nic does not support the tc flower protocol then the port add will
> not fail as we are just adding the representor netdev as a normal port
> But it will not be able to preform any control plane actions on it.
> there is no way for a Libvirt hostdevice to gracefully fall back to the
> kernel dataplane without modifying Xml. After all we are not even
> adding the vf to ovs we are adding a representor port to ovs so the
> dataplane is entirely bypassing ovs for unsupported nics.
> 
> 
> As long as you have the host has vf available and the ovs ml2 driver is
> listed before the sriov nic Agent ml2 driver you will get into this
> broken state.
> 
> > The ovs 2.8.0 code try to offload each datapath rule to NIC hardware
> > if it failed it fails back to the ovs kernel datapath.
> > So if have NIC that can offload classification  on vlan  and action
> > output. Only datapath flows that constructed for this classification
> > and action  will be offload to hardware.
> >
> > -Original Meyssage-
> > From: pranab boruah [mailto:pranabjyotibor...@gmail.com]
> > Sent: Wednesday, August 9, 2017 4:36 PM
> > To: OpenStack Development Mailing List (not for usage questions)
> > <openstack-dev@lists.openstack.org>
> > Subject: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type
> > VIFHostDevice
> >
> > Hi,
> > I am experimenting with the os-vif library and stumbled upon this new
> > VIF type called VIFHostDevice. I have few general queries. TIA.
> >
> > 1. How do I create ports with VIF_type as VIFHostDevice? Looking for
> > the CLI command options.
> >
> >
> > 2. Say, I have OVS running completely on x86 host(no datapath or flow
> > offload to
> >  NIC) as the networking mechanism and a SRIOV capable NIC(for
> > existence of VF representors that wi

Re: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type VIFHostDevice

[Moshe Levi]

-Original Message-
From: Mooney, Sean K [mailto:sean.k.moo...@intel.com] 
Sent: Wednesday, August 9, 2017 6:36 PM
To: OpenStack Development Mailing List (not for usage questions) 
<openstack-dev@lists.openstack.org>
Subject: Re: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type 
VIFHostDevice



> -Original Message-
> From: Moshe Levi [mailto:mosh...@mellanox.com]
> Sent: Wednesday, August 9, 2017 3:25 PM
> To: OpenStack Development Mailing List (not for usage questions) 
> <openstack-dev@lists.openstack.org>
> Subject: Re: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on 
> VIF_Type VIFHostDevice
> 
> Hi,
> 
> 1) you should use neutron port with vnic_type direct
> 2) yes,  just use neutron port with vnic_type  direct and confighure 
> the nova compute with pci passthogth whitelist
> 3) you can configure firewall_driver = openvswitch to work with 
> Conntrack.
> 
> So in your case if have SR-IOV nic which doesn't support  hardware 
> offload (but has VF representors port)  you will just fallback to the 
> ovs kernel datapath.

[Mooney, Sean K] that is not what will happen with intel nics and I would be 
doubtful Based on the code I have seen in nova and neutron that a fallback will 
happen with mellanox.
If the neutron port has vnic_type direct it will Always result in a sriov vf 
being allocated for that port. 
There is no check in nova to ensure ovs support vf configuration and there is 
no check in neutron ml2 driver Either. This is why I wanted the feature based 
scheduling to prevent this from happening as that would prevent Nova from 
allocating the vf which would cause scheduling to fail.

[Moshe Levi] This is not what I meant. I was talking on the implementation of 
the ovs 2.8.0 hardware offload. 
I was referring  for NIC with SR-IOV that support representor ports switchdev 
mode (maybe I miss understood the question).  If it just SR-IOV NIC then you 
are correct.  
 

When nova generates the Libvirt xml for that interface it will configure that 
port to use sriov direct pass-through.
If ovs does not support managing that nic via the representor netdev or the nic 
does not support the tc flower protocol then the port add will not fail as we 
are just adding the representor netdev as a normal port But it will not be able 
to preform any control plane actions on it. there is no way for a Libvirt 
hostdevice to gracefully fall back to the kernel dataplane without modifying 
Xml. After all we are not even adding the vf to ovs we are adding a representor 
port to ovs so the dataplane is entirely bypassing ovs for unsupported nics.


As long as you have the host has vf available and the ovs ml2 driver is listed 
before the sriov nic Agent ml2 driver you will get into this broken state.

> The ovs 2.8.0 code try to offload each datapath rule to NIC hardware 
> if it failed it fails back to the ovs kernel datapath.
> So if have NIC that can offload classification  on vlan  and action 
> output. Only datapath flows that constructed for this classification 
> and action  will be offload to hardware.
> 
> -Original Meyssage-
> From: pranab boruah [mailto:pranabjyotibor...@gmail.com]
> Sent: Wednesday, August 9, 2017 4:36 PM
> To: OpenStack Development Mailing List (not for usage questions) 
> <openstack-dev@lists.openstack.org>
> Subject: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type 
> VIFHostDevice
> 
> Hi,
> I am experimenting with the os-vif library and stumbled upon this new 
> VIF type called VIFHostDevice. I have few general queries. TIA.
> 
> 1. How do I create ports with VIF_type as VIFHostDevice? Looking for 
> the CLI command options.
> 
> 
> 2. Say, I have OVS running completely on x86 host(no datapath or flow 
> offload to
>  NIC) as the networking mechanism and a SRIOV capable NIC(for 
> existence of VF representors that will be added to the OVS bridge). 
> Can I still launch instances with VIF_type as VIFHostDevice?
> 
> 
> 3. I want to use Security Groups using OVS+Conntrack as the mechanism.
> Can I apply SG rules on the ports of type VIFHostDevice using the 
> above mechanism?
> 
> PS: I am still trying to understand this. Hence, I might get my 
> premises wrong in the above questions. Will appreciate a detailed 
> explanation.
> 
> Regards,
> Pranab
> 
> __
> _
> ___
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-
> requ...@lists.openstack.org?subject:unsubscribe
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flist
> s
> .openstack.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fopenstack-
> dev=02%7C01%7Cmoshele%40mellanox.com%7C0af8192c256c42f1252308d4df
> 2 
> b96b4%7Ca652971c7d2e4d9

Re: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type VIFHostDevice

[Mooney, Sean K]

> -Original Message-
> From: Moshe Levi [mailto:mosh...@mellanox.com]
> Sent: Wednesday, August 9, 2017 3:25 PM
> To: OpenStack Development Mailing List (not for usage questions)
> <openstack-dev@lists.openstack.org>
> Subject: Re: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on
> VIF_Type VIFHostDevice
> 
> Hi,
> 
> 1) you should use neutron port with vnic_type direct
> 2) yes,  just use neutron port with vnic_type  direct and confighure
> the nova compute with pci passthogth whitelist
> 3) you can configure firewall_driver = openvswitch to work with
> Conntrack.
> 
> So in your case if have SR-IOV nic which doesn't support  hardware
> offload (but has VF representors port)  you will just fallback to the
> ovs kernel datapath.

[Mooney, Sean K] that is not what will happen with intel nics and I would be 
doubtful
Based on the code I have seen in nova and neutron that a fallback will happen 
with mellanox.
If the neutron port has vnic_type direct it will Always result in a sriov vf 
being allocated for that port. 
There is no check in nova to ensure ovs support vf configuration and there is 
no check in neutron ml2 driver
Either. This is why I wanted the feature based scheduling to prevent this from 
happening as that would prevent
Nova from allocating the vf which would cause scheduling to fail. 

When nova generates the Libvirt xml for that interface it will configure that 
port to use sriov direct pass-through.
If ovs does not support managing that nic via the representor netdev or the nic 
does not support the
tc flower protocol then the port add will not fail as we are just adding the 
representor netdev as a normal port
But it will not be able to preform any control plane actions on it. there is no 
way for a Libvirt hostdevice
to gracefully fall back to the kernel dataplane without modifying Xml. After 
all we are not even adding the vf
to ovs we are adding a representor port to ovs so the dataplane is entirely 
bypassing ovs for unsupported nics.

As long as you have the host has vf available and the ovs ml2 driver is listed 
before the sriov nic
Agent ml2 driver you will get into this broken state.

> The ovs 2.8.0 code try to offload each datapath rule to NIC hardware if
> it failed it fails back to the ovs kernel datapath.
> So if have NIC that can offload classification  on vlan  and action
> output. Only datapath flows that constructed for this classification
> and action  will be offload to hardware.
> 
> -Original Meyssage-
> From: pranab boruah [mailto:pranabjyotibor...@gmail.com]
> Sent: Wednesday, August 9, 2017 4:36 PM
> To: OpenStack Development Mailing List (not for usage questions)
> <openstack-dev@lists.openstack.org>
> Subject: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type
> VIFHostDevice
> 
> Hi,
> I am experimenting with the os-vif library and stumbled upon this new
> VIF type called VIFHostDevice. I have few general queries. TIA.
> 
> 1. How do I create ports with VIF_type as VIFHostDevice? Looking for
> the CLI command options.
> 
> 
> 2. Say, I have OVS running completely on x86 host(no datapath or flow
> offload to
>  NIC) as the networking mechanism and a SRIOV capable NIC(for existence
> of VF representors that will be added to the OVS bridge). Can I still
> launch instances with VIF_type as VIFHostDevice?
> 
> 
> 3. I want to use Security Groups using OVS+Conntrack as the mechanism.
> Can I apply SG rules on the ports of type VIFHostDevice using the above
> mechanism?
> 
> PS: I am still trying to understand this. Hence, I might get my
> premises wrong in the above questions. Will appreciate a detailed
> explanation.
> 
> Regards,
> Pranab
> 
> ___
> ___
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-
> requ...@lists.openstack.org?subject:unsubscribe
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists
> .openstack.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fopenstack-
> dev=02%7C01%7Cmoshele%40mellanox.com%7C0af8192c256c42f1252308d4df2
> b96b4%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636378825693889082
> data=iNi%2FLHV5LkTKs8sSpS4BgHU6lwaoywo6O%2BNcF3hqtms%3D=0
> ___
> ___
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-
> requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type VIFHostDevice

[Mooney, Sean K]

> -Original Message-
> From: pranab boruah [mailto:pranabjyotibor...@gmail.com]
> Sent: Wednesday, August 9, 2017 2:36 PM
> To: OpenStack Development Mailing List (not for usage questions)
> <openstack-dev@lists.openstack.org>
> Subject: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type
> VIFHostDevice
> 
> Hi,
> I am experimenting with the os-vif library and stumbled upon this new
> VIF type called VIFHostDevice. I have few general queries. TIA.
> 
> 1. How do I create ports with VIF_type as VIFHostDevice? Looking for
> the CLI command options.
[Mooney, Sean K] hi os-vif vif objects such as VIFHostDevice have no direct 
correlation
With the neutron port binding extention vif_type or vnic_type. That is to say 
you
Cannot direcly request VIFHostDevice via the cli by seting a vif_type or 
vnic_type.
The vif object in os vif are datastuctures that encapluate the common datamodel 
that
Descibse a specific network interface type. In the case of VIFHostDevice this 
corresponds
To a sriov VF. This is then paird with a os-vif plugin which encapsulates the 
port binding logic
For plugging these abstract vif into that specific network backend. This is 
combined with an
Os vif port profile object which transports any backend specific info that 
cannot be generically included
Int the os vif vif object. For example vf representor netdev address or a 
vSwitches bridge name. 

> 
> 
> 2. Say, I have OVS running completely on x86 host(no datapath or flow
> offload to
>  NIC) as the networking mechanism and a SRIOV capable NIC(for existence
> of VF representors that will be added to the OVS bridge). Can I still
> launch instances with VIF_type as VIFHostDevice?
[Mooney, Sean K] you can launch an instance with that configuration yes however
You will not have any way to manage that vf via ovs. Libvirt would still
Connect the dataplane to the vm via standard host passthrouhg/sriov howver
Applying action to the representor port attached to the ovs bridge such as
Tagging the interface with a vlan or installing openflow rules to fileter the 
traffic
With the ovs conntrack security group driver would have no effect on dataplane.

> 
> 
> 3. I want to use Security Groups using OVS+Conntrack as the mechanism.
> Can I apply SG rules on the ports of type VIFHostDevice using the above
> mechanism?

[Mooney, Sean K] that should work with a melonox or netroneome smart nic with
A ovs that support the tc flower offload if they have implemented conntrack 
support
But it would not work with a generic nic. That is something that in the future 
we do intend
To support but at present it requires nic support to enable with conntrack. It 
may be possible
To use the learn action openflow security group driver if your nic does not 
support conntrack
For stateless firewalling which is still better then what you have today with 
sriov but the
Bottome line is you need nic support in hardware/firmware and ovs support for 
that nic offload to make this work.

> 
> PS: I am still trying to understand this. Hence, I might get my
> premises wrong in the above questions. Will appreciate a detailed
> explanation.
> 
> Regards,
> Pranab
> 
> ___
> ___
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-
> requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type VIFHostDevice

[Moshe Levi]

Hi, 

1) you should use neutron port with vnic_type direct
2) yes,  just use neutron port with vnic_type  direct and confighure the nova 
compute with pci passthogth whitelist 
3) you can configure firewall_driver = openvswitch to work with Conntrack.

So in your case if have SR-IOV nic which doesn't support  hardware offload (but 
has VF representors port)  you will just fallback to the ovs kernel datapath.  
The ovs 2.8.0 code try to offload each datapath rule to NIC hardware if it 
failed it fails back to the ovs kernel datapath.
So if have NIC that can offload classification  on vlan  and action output. 
Only datapath flows that constructed for this classification and action  will 
be offload to hardware.

-Original Meyssage-
From: pranab boruah [mailto:pranabjyotibor...@gmail.com] 
Sent: Wednesday, August 9, 2017 4:36 PM
To: OpenStack Development Mailing List (not for usage questions) 
<openstack-dev@lists.openstack.org>
Subject: [openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type 
VIFHostDevice

Hi,
I am experimenting with the os-vif library and stumbled upon this new VIF type 
called VIFHostDevice. I have few general queries. TIA.

1. How do I create ports with VIF_type as VIFHostDevice? Looking for the CLI 
command options.


2. Say, I have OVS running completely on x86 host(no datapath or flow offload to
 NIC) as the networking mechanism and a SRIOV capable NIC(for existence of VF 
representors that will be added to the OVS bridge). Can I still launch 
instances with VIF_type as VIFHostDevice?


3. I want to use Security Groups using OVS+Conntrack as the mechanism.
Can I apply SG rules on the ports of type VIFHostDevice using the above 
mechanism?

PS: I am still trying to understand this. Hence, I might get my premises wrong 
in the above questions. Will appreciate a detailed explanation.

Regards,
Pranab

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openstack.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fopenstack-dev=02%7C01%7Cmoshele%40mellanox.com%7C0af8192c256c42f1252308d4df2b96b4%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636378825693889082=iNi%2FLHV5LkTKs8sSpS4BgHU6lwaoywo6O%2BNcF3hqtms%3D=0
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [os-vif] [vif_plug_ovs] Queries on VIF_Type VIFHostDevice

[pranab boruah]

Hi,
I am experimenting with the os-vif library and stumbled upon this new
VIF type called VIFHostDevice. I have few general queries. TIA.

1. How do I create ports with VIF_type as VIFHostDevice? Looking for
the CLI command options.


2. Say, I have OVS running completely on x86 host(no datapath or flow offload to
 NIC) as the networking mechanism and a SRIOV capable NIC(for existence of
VF representors that will be added to the OVS bridge). Can I still
launch instances with VIF_type as VIFHostDevice?


3. I want to use Security Groups using OVS+Conntrack as the mechanism.
Can I apply SG rules on the ports of type VIFHostDevice using the
above mechanism?

PS: I am still trying to understand this. Hence, I might get my
premises wrong in the above questions. Will appreciate a detailed
explanation.

Regards,
Pranab

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] 1.6.1 release for pike.

[Mooney, Sean K]

You are right but adding [os-vif] lands it in my os-vif folder os
I guess [openstack-dev][os-vif][nova][neutron] 1.6.1 release for pike 
Would have made it work for everyone :)

> -Original Message-
> From: Matt Riedemann [mailto:mriede...@gmail.com]
> Sent: Tuesday, July 18, 2017 10:35 PM
> To: openstack-dev@lists.openstack.org
> Subject: Re: [openstack-dev] [os-vif] 1.6.1 release for pike.
> 
> On 7/18/2017 12:07 PM, Mooney, Sean K wrote:
> > Resending with correct subject line
> 
> The real correct subject line tag would be [nova] or [nova][neutron].
> :P
> 
> --
> 
> Thanks,
> 
> Matt
> 
> ___
> ___
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-
> requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] os-vif 1.6.1 release for pike.

[Jan Gutter]

On Tue, Jul 18, 2017 at 5:54 PM, Mooney, Sean K  wrote:
> Should have:
>
> Improve OVS Representor Lookup  https://review.openstack.org/#/c/484051/

I've split out the review into two portions, here is the second one:

Improve OVS Representor VF Lookup  https://review.openstack.org/#/c/485125/

-- 
Jan Gutter
Embedded Networking Software Engineer

Netronome | First Floor Suite 1, Block A, Southdowns Ridge Office Park,
Cnr Nellmapius and John Vorster St, Irene, Pretoria, 0157
Phone: +27 (12) 665-4427 | Skype: jangutter |  www.netronome.com

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [os-vif] 1.6.1 release for pike.

[Matt Riedemann]

On 7/18/2017 12:07 PM, Mooney, Sean K wrote:

Resending with correct subject line


The real correct subject line tag would be [nova] or [nova][neutron]. :P

--

Thanks,

Matt

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [os-vif] 1.6.1 release for pike.

[Mooney, Sean K]

Resending with correct subject line

From: Mooney, Sean K
Sent: Tuesday, July 18, 2017 4:54 PM
To: openstack-dev@lists.openstack.org
Cc: Jay Pipes ; 'Stephen Finucane' ; 
Moshe Levi ; 'rbry...@redhat.com' ; 
'maxime.le...@6wind.com' ; sahid 
; 'jan.gut...@netronome.com' 

Subject: os-vif 1.6.1 release for pike.


Hi

We are approaching the non-client library freeze on Thursday.
Below are a list of pending patches that I think will be good to review for 
inclusion in pike.

Should have:
Improve OVS Representor Lookup  https://review.openstack.org/#/c/484051/
Add support for VIFPortProfileOVSRepresentor 
https://review.openstack.org/#/c/483921/
unplug_vf_passthrough: don't try to delete representor netdev 
https://review.openstack.org/#/c/478820/


Nice to have:
Add memoize function using oslo.cache https://review.openstack.org/#/c/472773/
Read datapath_type from VIF object https://review.openstack.org/#/c/474914/
doc: Remove cruft from releasenotes conf.py 
https://review.openstack.org/#/c/480092/2

Queens:
add host port profile info class https://review.openstack.org/#/c/441590/
Add abstract OVSDB API https://review.openstack.org/#/c/476612/
Add native implementation OVSDB API https://review.openstack.org/#/c/482226/
*Migration from 'ip' commands to pyroute2 
https://review.openstack.org/#/c/484386/
*Convert all 'ip-link set' commands to pyroute2 
https://review.openstack.org/#/c/451433/
Add Virtual Ethernet device pair  https://review.openstack.org/#/c/484726/
objects: Add 'dns_domain' attribute to 'Network' 
https://review.openstack.org/#/c/480630/
Add Constraints support https://review.openstack.org/#/c/413325/


*These do the same thing.
The items in the should have list are required to complete the netronome and 
mellanox hardware
Accelerated ovs integration.

The nice to have items are small cleanup that are not vitial but would be nice 
to merge sooner
Rather than later. The remaining items while I would like to see merged, I 
think need
More work so I would suggest moving to queens.

If people have time it would be good to review these items today and I will 
submit at patch to
https://github.com/openstack/releases/blob/master/deliverables/pike/os-vif.yaml 
to introduce
version 1.6.1 tomorrow.

Regards
Sean.


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] os-vif 1.6.1 release for pike.

[Mooney, Sean K]

Hi

We are approaching the non-client library freeze on Thursday.
Below are a list of pending patches that I think will be good to review for 
inclusion in pike.

Should have:
Improve OVS Representor Lookup  https://review.openstack.org/#/c/484051/
Add support for VIFPortProfileOVSRepresentor 
https://review.openstack.org/#/c/483921/
unplug_vf_passthrough: don't try to delete representor netdev 
https://review.openstack.org/#/c/478820/


Nice to have:
Add memoize function using oslo.cache https://review.openstack.org/#/c/472773/
Read datapath_type from VIF object https://review.openstack.org/#/c/474914/
doc: Remove cruft from releasenotes conf.py 
https://review.openstack.org/#/c/480092/2

Queens:
add host port profile info class https://review.openstack.org/#/c/441590/
Add abstract OVSDB API https://review.openstack.org/#/c/476612/
Add native implementation OVSDB API https://review.openstack.org/#/c/482226/
*Migration from 'ip' commands to pyroute2 
https://review.openstack.org/#/c/484386/
*Convert all 'ip-link set' commands to pyroute2 
https://review.openstack.org/#/c/451433/
Add Virtual Ethernet device pair  https://review.openstack.org/#/c/484726/
objects: Add 'dns_domain' attribute to 'Network' 
https://review.openstack.org/#/c/480630/
Add Constraints support https://review.openstack.org/#/c/413325/


*These do the same thing.

The items in the should have list are required to complete the netronome and 
mellanox hardware
Accelerated ovs integration.

The nice to have items are small cleanup that are not vitial but would be nice 
to merge sooner
Rather than later. The remaining items while I would like to see merged, I 
think need
More work so I would suggest moving to queens.

If people have time it would be good to review these items today and I will 
submit at patch to
https://github.com/openstack/releases/blob/master/deliverables/pike/os-vif.yaml 
to introduce
version 1.6.1 tomorrow.

Regards
Sean.


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev