Re: [openstack-dev] [oslo_messaging] Limiting the number of retries for kafka driver
Yes, there is a config option for *oslo_messaging_rabbit* default_notification_retry_attempts http://docs.openstack.org/mitaka/config-reference/compute/rpc.html The problem with Nova and Neutron provide the retry mechanism, there is no configuration on nova or neutron, which can be passed onto the also_messaging. I will add a patch so that it would pick up from the configuration in oslo_messaging itself. Thanks & Regards, Cheran On 2/14/17, 9:32 PM, "Ken Giusti" wrote: >On Tue, Feb 14, 2017 at 2:52 PM, Elancheran Subramanian > wrote: >> Hello All, >> This is reg limiting the number of retries for Kafka driver support on >>Nova >> and Neutron. >> >> While trying out the oslo messaging notifications support for Kafka on >>Nova >> and Neutron, the Kafka driver doesn’t support limiting the number of >>retries >> for failed messages. When I checked the code, currently there is no >> configuration which support that, though the send_notification has retry >> >>https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_d >>rivers/impl_kafka.py#L336 >> but it’s not set or passed from component’s (nova or neutron’s) >> configuration. Is there any configuration which I’m missing? Please let >>me >> know. >> > >You haven't missed anything - the kafka driver doesn't provide a means >to set a default retry via its configuration. >The expectation is that the caller (nova/neutron) would provide a >retry value when constructing a Notifier instance. > >There was such a config option for the rabbitmq driver >(rabbit_max_retries) but that was removed because it broke >*something* - can't remember exactly the reason tho, sorry. > >> >> Thanks in advance, >> Cheran >> >> >>_ >>_ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >>openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > > >-- >Ken Giusti (kgiu...@gmail.com) > >__ >OpenStack Development Mailing List (not for usage questions) >Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo_messaging] Limiting the number of retries for kafka driver
On 14/02/17 02:52 PM, Elancheran Subramanian wrote: > Hello All, > This is reg limiting the number of retries for Kafka driver support on > Nova and Neutron. > > While trying out the oslo messaging notifications support for Kafka on > Nova and Neutron, the Kafka driver doesn’t support limiting the number > of retries for failed messages. When I checked the code, currently there > is no configuration which support that, though the send_notification has > retry > https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_kafka.py#L336 > but > it’s not set or passed from component’s (nova or neutron’s) > configuration. Is there any configuration which I’m missing? Please let > me know. > disclaimer: i didn't try the following... you should be able to pass a retry value from when you create Notifier obj. like ceilometer[1]... i don't think nova uses it[2]. [1] https://github.com/openstack/ceilometer/blob/master/ceilometer/publisher/messaging.py#L205 [2] https://github.com/openstack/nova/blob/8557aaeb2f3818de352ce7d0b7bf62d74ddffc4e/nova/rpc.py#L82-L98 cheers, -- gord __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo_messaging] Limiting the number of retries for kafka driver
On Tue, Feb 14, 2017 at 2:52 PM, Elancheran Subramanian wrote: > Hello All, > This is reg limiting the number of retries for Kafka driver support on Nova > and Neutron. > > While trying out the oslo messaging notifications support for Kafka on Nova > and Neutron, the Kafka driver doesn’t support limiting the number of retries > for failed messages. When I checked the code, currently there is no > configuration which support that, though the send_notification has retry > https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_kafka.py#L336 > but it’s not set or passed from component’s (nova or neutron’s) > configuration. Is there any configuration which I’m missing? Please let me > know. > You haven't missed anything - the kafka driver doesn't provide a means to set a default retry via its configuration. The expectation is that the caller (nova/neutron) would provide a retry value when constructing a Notifier instance. There was such a config option for the rabbitmq driver (rabbit_max_retries) but that was removed because it broke *something* - can't remember exactly the reason tho, sorry. > > Thanks in advance, > Cheran > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Ken Giusti (kgiu...@gmail.com) __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [oslo_messaging] Limiting the number of retries for kafka driver
Hello All, This is reg limiting the number of retries for Kafka driver support on Nova and Neutron. While trying out the oslo messaging notifications support for Kafka on Nova and Neutron, the Kafka driver doesn’t support limiting the number of retries for failed messages. When I checked the code, currently there is no configuration which support that, though the send_notification has retry https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_kafka.py#L336 but it’s not set or passed from component’s (nova or neutron’s) configuration. Is there any configuration which I’m missing? Please let me know. Thanks in advance, Cheran __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
