Re: [openstack-dev] [puppet] deprecation warning everywhere issue
On 12/23/2015 04:30 AM, Matt Fischer wrote:
> I've pinged you on IRC to this effect but this has broken the stable
> branches which now have unresolvable dependencies on the service whose
> name has changed.
>
>
> Error: Could not find resource 'Keystone_endpoint[RegionOne/glance]' for
> relationship on 'Service[glance-api]' on node
> openstack-puppet-test.openstacklocal
> Error: Could not find resource 'Keystone_endpoint[RegionOne/glance]' for
> relationship on 'Service[glance-api]' on node
> openstack-puppet-test.openstacklocal
>
> This break is specifically in glance, here:
>
> manifests/keystone/auth.pp
>
> if $configure_endpoint {
> Keystone_endpoint["${region}/${real_service_name}"] ~> Service <|
> name == 'glance-api' |>
> Keystone_endpoint["${region}/${real_service_name}"] -> Glance_image<||>
> }
>
> I have not checked the other modules. I will be around for reviews on
> this if you ping me via email.
Yes I know, it's because the backport in stable/liberty for the
puppet-glance patch did not merge yet...
Please review https://review.openstack.org/#/c/260695/
And all should be back again.
FYI, master is fixed (except trove, having packaging issue in RDO,
working on it at this time) and stable/liberty almost fixed when the
puppet-glance patch is merged (and I'll backport the pupper-trove patch
too).
>
>
> On Tue, Dec 22, 2015 at 1:42 PM, Matt Fischer > wrote:
>
> Thanks Emilien,
>
> This is what I was mentioning to you on IRC last week as a must fix
> for Mitaka. I'd like to also backport this to Liberty once it lands.
>
> On Mon, Dec 21, 2015 at 10:48 AM, Emilien Macchi > wrote:
>
> Hello,
>
> I just reported [1] which affects puppet-keystone but also *all*
> modules.
> Since [2], you now have a lot of warnings about the new way to
> declare
> keystone_endpoint resource.
>
> This is not really acceptable and provides a poor end-user
> experience to
> have (by default) a lot of warnings.
>
> The patch that will fix it in puppet-keystone is [3] (please
> review it).
> To fix all other modules, we need to update unit tests and sometimes
> keystone/auth.pp in the module. It will requires a Depends-On the
> puppet-keystone patch, which means puppet-keystone patch will fail
> integration tests (circular dependency). Ex with [4] (puppet-glance)
>
> So here is the plan:
> * let's review [3] but do not merge it.
> * let's review [4] and other that will follow (on same Gerrit
> topic).
> * Once all patches have been submitted, I'll send a patch to
> puppet-openstack-integration with Depends-On of all other
> patches and
> see Integration testing, so we don't break our CI.
>
> You can follow all this work on the "endpoint/warnings" Gerrit
> topic [5].
>
> Any other suggestion is welcome,
> Please review,
>
> [1] https://bugs.launchpad.net/puppet-keystone/+bug/1528308
> [2]
>
> http://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=0a4e06abb0f5b3f324464ff5219d2885816311ce
> [3] https://review.openstack.org/#/c/259996/
> [4] https://review.openstack.org/#/c/260044/
> [5] https://review.openstack.org/#/q/topic:endpoint/warnings
> --
> Emilien Macchi
>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
--
Emilien Macchi
signature.asc
Description: OpenPGP digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [puppet] deprecation warning everywhere issue
I've pinged you on IRC to this effect but this has broken the stable
branches which now have unresolvable dependencies on the service whose name
has changed.
Error: Could not find resource 'Keystone_endpoint[RegionOne/glance]' for
relationship on 'Service[glance-api]' on node
openstack-puppet-test.openstacklocal
Error: Could not find resource 'Keystone_endpoint[RegionOne/glance]' for
relationship on 'Service[glance-api]' on node
openstack-puppet-test.openstacklocal
This break is specifically in glance, here:
manifests/keystone/auth.pp
if $configure_endpoint {
Keystone_endpoint["${region}/${real_service_name}"] ~> Service <| name
== 'glance-api' |>
Keystone_endpoint["${region}/${real_service_name}"] -> Glance_image<||>
}
I have not checked the other modules. I will be around for reviews on this
if you ping me via email.
On Tue, Dec 22, 2015 at 1:42 PM, Matt Fischer wrote:
> Thanks Emilien,
>
> This is what I was mentioning to you on IRC last week as a must fix for
> Mitaka. I'd like to also backport this to Liberty once it lands.
>
> On Mon, Dec 21, 2015 at 10:48 AM, Emilien Macchi
> wrote:
>
>> Hello,
>>
>> I just reported [1] which affects puppet-keystone but also *all* modules.
>> Since [2], you now have a lot of warnings about the new way to declare
>> keystone_endpoint resource.
>>
>> This is not really acceptable and provides a poor end-user experience to
>> have (by default) a lot of warnings.
>>
>> The patch that will fix it in puppet-keystone is [3] (please review it).
>> To fix all other modules, we need to update unit tests and sometimes
>> keystone/auth.pp in the module. It will requires a Depends-On the
>> puppet-keystone patch, which means puppet-keystone patch will fail
>> integration tests (circular dependency). Ex with [4] (puppet-glance)
>>
>> So here is the plan:
>> * let's review [3] but do not merge it.
>> * let's review [4] and other that will follow (on same Gerrit topic).
>> * Once all patches have been submitted, I'll send a patch to
>> puppet-openstack-integration with Depends-On of all other patches and
>> see Integration testing, so we don't break our CI.
>>
>> You can follow all this work on the "endpoint/warnings" Gerrit topic [5].
>>
>> Any other suggestion is welcome,
>> Please review,
>>
>> [1] https://bugs.launchpad.net/puppet-keystone/+bug/1528308
>> [2]
>>
>> http://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=0a4e06abb0f5b3f324464ff5219d2885816311ce
>> [3] https://review.openstack.org/#/c/259996/
>> [4] https://review.openstack.org/#/c/260044/
>> [5] https://review.openstack.org/#/q/topic:endpoint/warnings
>> --
>> Emilien Macchi
>>
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [puppet] deprecation warning everywhere issue
Thanks Emilien, This is what I was mentioning to you on IRC last week as a must fix for Mitaka. I'd like to also backport this to Liberty once it lands. On Mon, Dec 21, 2015 at 10:48 AM, Emilien Macchi wrote: > Hello, > > I just reported [1] which affects puppet-keystone but also *all* modules. > Since [2], you now have a lot of warnings about the new way to declare > keystone_endpoint resource. > > This is not really acceptable and provides a poor end-user experience to > have (by default) a lot of warnings. > > The patch that will fix it in puppet-keystone is [3] (please review it). > To fix all other modules, we need to update unit tests and sometimes > keystone/auth.pp in the module. It will requires a Depends-On the > puppet-keystone patch, which means puppet-keystone patch will fail > integration tests (circular dependency). Ex with [4] (puppet-glance) > > So here is the plan: > * let's review [3] but do not merge it. > * let's review [4] and other that will follow (on same Gerrit topic). > * Once all patches have been submitted, I'll send a patch to > puppet-openstack-integration with Depends-On of all other patches and > see Integration testing, so we don't break our CI. > > You can follow all this work on the "endpoint/warnings" Gerrit topic [5]. > > Any other suggestion is welcome, > Please review, > > [1] https://bugs.launchpad.net/puppet-keystone/+bug/1528308 > [2] > > http://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=0a4e06abb0f5b3f324464ff5219d2885816311ce > [3] https://review.openstack.org/#/c/259996/ > [4] https://review.openstack.org/#/c/260044/ > [5] https://review.openstack.org/#/q/topic:endpoint/warnings > -- > Emilien Macchi > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [puppet] deprecation warning everywhere issue
On 12/21/2015 06:48 PM, Emilien Macchi wrote: > Hello, > > I just reported [1] which affects puppet-keystone but also *all* modules. > Since [2], you now have a lot of warnings about the new way to declare > keystone_endpoint resource. > > This is not really acceptable and provides a poor end-user experience to > have (by default) a lot of warnings. > > The patch that will fix it in puppet-keystone is [3] (please review it). > To fix all other modules, we need to update unit tests and sometimes > keystone/auth.pp in the module. It will requires a Depends-On the > puppet-keystone patch, which means puppet-keystone patch will fail > integration tests (circular dependency). Ex with [4] (puppet-glance) > > So here is the plan: > * let's review [3] but do not merge it. > * let's review [4] and other that will follow (on same Gerrit topic). > * Once all patches have been submitted, I'll send a patch to > puppet-openstack-integration with Depends-On of all other patches and > see Integration testing, so we don't break our CI. > > You can follow all this work on the "endpoint/warnings" Gerrit topic [5]. Err: https://review.openstack.org/#/q/topic:bug/1528308 > Any other suggestion is welcome, > Please review, > > [1] https://bugs.launchpad.net/puppet-keystone/+bug/1528308 > [2] > http://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=0a4e06abb0f5b3f324464ff5219d2885816311ce > [3] https://review.openstack.org/#/c/259996/ > [4] https://review.openstack.org/#/c/260044/ > [5] https://review.openstack.org/#/q/topic:endpoint/warnings > > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Emilien Macchi signature.asc Description: OpenPGP digital signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [puppet] deprecation warning everywhere issue
Hello, I just reported [1] which affects puppet-keystone but also *all* modules. Since [2], you now have a lot of warnings about the new way to declare keystone_endpoint resource. This is not really acceptable and provides a poor end-user experience to have (by default) a lot of warnings. The patch that will fix it in puppet-keystone is [3] (please review it). To fix all other modules, we need to update unit tests and sometimes keystone/auth.pp in the module. It will requires a Depends-On the puppet-keystone patch, which means puppet-keystone patch will fail integration tests (circular dependency). Ex with [4] (puppet-glance) So here is the plan: * let's review [3] but do not merge it. * let's review [4] and other that will follow (on same Gerrit topic). * Once all patches have been submitted, I'll send a patch to puppet-openstack-integration with Depends-On of all other patches and see Integration testing, so we don't break our CI. You can follow all this work on the "endpoint/warnings" Gerrit topic [5]. Any other suggestion is welcome, Please review, [1] https://bugs.launchpad.net/puppet-keystone/+bug/1528308 [2] http://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=0a4e06abb0f5b3f324464ff5219d2885816311ce [3] https://review.openstack.org/#/c/259996/ [4] https://review.openstack.org/#/c/260044/ [5] https://review.openstack.org/#/q/topic:endpoint/warnings -- Emilien Macchi signature.asc Description: OpenPGP digital signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
