Re: [openstack-dev] [tripleo] Roles count and flavors inside Heat environment file

2016-10-03 Thread Steven Hardy
On Mon, Oct 03, 2016 at 02:23:08PM +0200, Marius Cornea wrote:
> Hello everyone,
> 
> In Newton we've deprecated the *-scale and *-flavor deploy command
> arguments in favor of using Heat environment files. In the context of
> testing the composable roles where the custom roles' node count and
> flavor need to be passed inside an environment file I would like to
> build the test plan by using an environment containing all nodes count
> and flavors, including the preexisting roles.
> 
> A deploy command example would look like:
> 
> openstack overcloud deploy --stack cloudy --templates -e nodes.yaml
> 
> where the nodes environment file contains something like:
> 
> parameter_defaults:
>   ControllerCount: 3
>   ComputeCount: 2
>   CephStorageCount: 3
>   ServiceApiCount: 3
> 
>   OvercloudControlFlavor: controller
>   OvercloudComputeFlavor: compute
>   OvercloudCephStorageFlavor: ceph
>   OvercloudServiceApiFlavor: serviceapi
> 
> 
> I would like to get some feedback about this approach. I think it's
> better to keep all the roles count/flavors in the same place for
> consistency reasons.

+1 - I think this is well aligned with the interfaces we want to encourage
(vs the hard-coded CLI options which we want to move away from).

The only disadvantage of this approach is there's a few special-cases where
the parameter name isn't intuitive (OvercloudControlFlavor is an example).

It'd be better if we move to a consistent e.g $roleFlavor interface in due
course), but I still think encouraging this pattern is good, as it'll help
us identify the parameter interfaces which are inconsistent, then we can
fix them (deprecate the old parameter, add new consistent ones).

Thanks,

Steve

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [tripleo] Roles count and flavors inside Heat environment file

2016-10-03 Thread Michele Baldessari
On Mon, Oct 03, 2016 at 02:23:08PM +0200, Marius Cornea wrote:
> Hello everyone,
> 
> In Newton we've deprecated the *-scale and *-flavor deploy command
> arguments in favor of using Heat environment files. In the context of
> testing the composable roles where the custom roles' node count and
> flavor need to be passed inside an environment file I would like to
> build the test plan by using an environment containing all nodes count
> and flavors, including the preexisting roles.
> 
> A deploy command example would look like:
> 
> openstack overcloud deploy --stack cloudy --templates -e nodes.yaml
> 
> where the nodes environment file contains something like:
> 
> parameter_defaults:
>   ControllerCount: 3
>   ComputeCount: 2
>   CephStorageCount: 3
>   ServiceApiCount: 3
> 
>   OvercloudControlFlavor: controller
>   OvercloudComputeFlavor: compute
>   OvercloudCephStorageFlavor: ceph
>   OvercloudServiceApiFlavor: serviceapi
> 
> 
> I would like to get some feedback about this approach. I think it's
> better to keep all the roles count/flavors in the same place for
> consistency reasons.

I fully agree with this approach. I think it is also preferrable to have
a single point where we define this.

cheers,
Michele
-- 
Michele Baldessari
C2A5 9DA3 9961 4FFB E01B  D0BC DDD4 DCCB 7515 5C6D

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [tripleo] Roles count and flavors inside Heat environment file

2016-10-03 Thread Marius Cornea
Hello everyone,

In Newton we've deprecated the *-scale and *-flavor deploy command
arguments in favor of using Heat environment files. In the context of
testing the composable roles where the custom roles' node count and
flavor need to be passed inside an environment file I would like to
build the test plan by using an environment containing all nodes count
and flavors, including the preexisting roles.

A deploy command example would look like:

openstack overcloud deploy --stack cloudy --templates -e nodes.yaml

where the nodes environment file contains something like:

parameter_defaults:
  ControllerCount: 3
  ComputeCount: 2
  CephStorageCount: 3
  ServiceApiCount: 3

  OvercloudControlFlavor: controller
  OvercloudComputeFlavor: compute
  OvercloudCephStorageFlavor: ceph
  OvercloudServiceApiFlavor: serviceapi


I would like to get some feedback about this approach. I think it's
better to keep all the roles count/flavors in the same place for
consistency reasons.

Thank you,
Marius

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev