Re: [openstack-dev] [Horizon] request to review bug 1301359

2014-07-07 Thread Radomir Dopieralski 
On 08/07/14 08:29, Harshada Kakad wrote:>

> HI All,
> Could someone please, review the bug 
[...]

Hello Harshada,

please don't send such e-mails or ask in the IRC, submitting the patch
is enough to get reviewers to read it, eventually. If we sent such an
e-mail for every patch, this mailing list would become useless quickly.

Please note, however, that the patch queue for Horizon is quite long and
we only have so many people doing reviews, so it can take a long time.
If you would like to speed up the whole process, please help us by
reviewing some patches yourself. That will help us review faster and get
to your patch sooner.

Thank you,
-- 
Radomir Dopieralski

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [Horizon] request to review bug 1301359

2014-07-07 Thread Harshada Kakad 
HI All,
Could someone please, review the bug
https://bugs.launchpad.net/horizon/+bug/1301359


Made Size parameter optional while creating DB Instance.

While creating Database Instance size parameter depends on
whether trove_volume_support is set. So size paramater is
set to mandatory if trove_volume_support is set else its kept optional.

Here is the link for review :  https://review.openstack.org/#/c/86295/

-- 
*Regards,*
*Harshada Kakad*
**
*Sr. Software Engineer*
*C3/101, Saudamini Complex, Right Bhusari Colony, Paud Road, Pune – 411013,
India*
*Mobile-9689187388*
*Email-Id : harshada.ka...@izeltech.com *
*website : www.izeltech.com *

-- 
*Disclaimer*
The information contained in this e-mail and any attachment(s) to this 
message are intended for the exclusive use of the addressee(s) and may 
contain proprietary, confidential or privileged information of Izel 
Technologies Pvt. Ltd. If you are not the intended recipient, you are 
notified that any review, use, any form of reproduction, dissemination, 
copying, disclosure, modification, distribution and/or publication of this 
e-mail message, contents or its attachment(s) is strictly prohibited and 
you are requested to notify us the same immediately by e-mail and delete 
this mail immediately. Izel Technologies Pvt. Ltd accepts no liability for 
virus infected e-mail or errors or omissions or consequences which may 
arise as a result of this e-mail transmission.
*End of Disclaimer*
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Horizon] request to review bug 1301359

2014-06-04 Thread Harshada Kakad 
My patch actually does not relies on any not approved feature of a client.
And I have not used any such features in my patch.
Could you let me know which feature you are talking about which you think I
have used, due to which patch would fail in integration testing?


On Wed, Jun 4, 2014 at 6:14 PM, Matthias Runge  wrote:

> On Wed, Jun 04, 2014 at 04:13:33PM +0530, Harshada Kakad wrote:
> > HI Matthias Runge,
> >
> > Which feature in trove are you talking about?
> > And even which capabilities are missing which will make the patch fail?
> > I believe the patch has nothing to do with
> > https://review.openstack.org/#/c/83503/
>
> If your patch relies on a not approved feature of a client, and we'd do
> a full integration testing with Horizon, your patch would fail, because
> the underlying client does not have the required feature.
>
> Does that make sense?
> --
> Matthias Runge 
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
*Regards,*
*Harshada Kakad*
**
*Sr. Software Engineer*
*C3/101, Saudamini Complex, Right Bhusari Colony, Paud Road, Pune – 411013,
India*
*Mobile-9689187388*
*Email-Id : harshada.ka...@izeltech.com *
*website : www.izeltech.com *

-- 
*Disclaimer*
The information contained in this e-mail and any attachment(s) to this 
message are intended for the exclusive use of the addressee(s) and may 
contain proprietary, confidential or privileged information of Izel 
Technologies Pvt. Ltd. If you are not the intended recipient, you are 
notified that any review, use, any form of reproduction, dissemination, 
copying, disclosure, modification, distribution and/or publication of this 
e-mail message, contents or its attachment(s) is strictly prohibited and 
you are requested to notify us the same immediately by e-mail and delete 
this mail immediately. Izel Technologies Pvt. Ltd accepts no liability for 
virus infected e-mail or errors or omissions or consequences which may 
arise as a result of this e-mail transmission.
*End of Disclaimer*
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Horizon] request to review bug 1301359

2014-06-04 Thread Matthias Runge 
On Wed, Jun 04, 2014 at 04:13:33PM +0530, Harshada Kakad wrote:
> HI Matthias Runge,
> 
> Which feature in trove are you talking about?
> And even which capabilities are missing which will make the patch fail?
> I believe the patch has nothing to do with
> https://review.openstack.org/#/c/83503/

If your patch relies on a not approved feature of a client, and we'd do
a full integration testing with Horizon, your patch would fail, because
the underlying client does not have the required feature.

Does that make sense?
-- 
Matthias Runge 

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Horizon] request to review bug 1301359

2014-06-04 Thread Harshada Kakad 
HI Matthias Runge,

Which feature in trove are you talking about?
And even which capabilities are missing which will make the patch fail?
I believe the patch has nothing to do with
https://review.openstack.org/#/c/83503/



On Wed, Jun 4, 2014 at 3:45 PM, Matthias Runge  wrote:

> On Wed, Jun 04, 2014 at 02:18:19PM +0530, Harshada Kakad wrote:
> > HI All,
> > Could someone please, review the bug
> > https://bugs.launchpad.net/horizon/+bug/1301359
> >
> >
> > Made Size parameter optional while creating DB Instance.
> >
> > While creating Database Instance size parameter depends on
> > whether trove_volume_support is set. So size paramater is
> > set to mandatory if trove_volume_support is set else its kept optional.
> >
> > Here is the link for review :  https://review.openstack.org/#/c/86295/
> >
> Thank you for your patch. It relies on a (currently not merged) feature in
> trove.
>
> In an ideal world (or OpenStack test deployment), your patch would fail,
> because capabilities to execute your patch are missing (yet), thus
> making it more clear, a cooperation with trove is required.
> --
> Matthias Runge 
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
*Regards,*
*Harshada Kakad*
**
*Sr. Software Engineer*
*C3/101, Saudamini Complex, Right Bhusari Colony, Paud Road, Pune – 411013,
India*
*Mobile-9689187388*
*Email-Id : harshada.ka...@izeltech.com *
*website : www.izeltech.com *

-- 
*Disclaimer*
The information contained in this e-mail and any attachment(s) to this 
message are intended for the exclusive use of the addressee(s) and may 
contain proprietary, confidential or privileged information of Izel 
Technologies Pvt. Ltd. If you are not the intended recipient, you are 
notified that any review, use, any form of reproduction, dissemination, 
copying, disclosure, modification, distribution and/or publication of this 
e-mail message, contents or its attachment(s) is strictly prohibited and 
you are requested to notify us the same immediately by e-mail and delete 
this mail immediately. Izel Technologies Pvt. Ltd accepts no liability for 
virus infected e-mail or errors or omissions or consequences which may 
arise as a result of this e-mail transmission.
*End of Disclaimer*
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Horizon] request to review bug 1301359

2014-06-04 Thread Matthias Runge 
On Wed, Jun 04, 2014 at 02:18:19PM +0530, Harshada Kakad wrote:
> HI All,
> Could someone please, review the bug
> https://bugs.launchpad.net/horizon/+bug/1301359
> 
> 
> Made Size parameter optional while creating DB Instance.
> 
> While creating Database Instance size parameter depends on
> whether trove_volume_support is set. So size paramater is
> set to mandatory if trove_volume_support is set else its kept optional.
> 
> Here is the link for review :  https://review.openstack.org/#/c/86295/
> 
Thank you for your patch. It relies on a (currently not merged) feature in 
trove.

In an ideal world (or OpenStack test deployment), your patch would fail,
because capabilities to execute your patch are missing (yet), thus
making it more clear, a cooperation with trove is required.
-- 
Matthias Runge 

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [Horizon] request to review bug 1301359

2014-06-04 Thread Harshada Kakad 
HI All,
Could someone please, review the bug
https://bugs.launchpad.net/horizon/+bug/1301359


Made Size parameter optional while creating DB Instance.

While creating Database Instance size parameter depends on
whether trove_volume_support is set. So size paramater is
set to mandatory if trove_volume_support is set else its kept optional.

Here is the link for review :  https://review.openstack.org/#/c/86295/

--
*Regards,*
*Harshada Kakad*
**
*Sr. Software Engineer*
*C3/101, Saudamini Complex, Right Bhusari Colony, Paud Road, Pune – 411013,
India*
*Mobile-9689187388*
*Email-Id : harshada.ka...@izeltech.com *
*website : www.izeltech.com *

-- 
*Disclaimer*
The information contained in this e-mail and any attachment(s) to this 
message are intended for the exclusive use of the addressee(s) and may 
contain proprietary, confidential or privileged information of Izel 
Technologies Pvt. Ltd. If you are not the intended recipient, you are 
notified that any review, use, any form of reproduction, dissemination, 
copying, disclosure, modification, distribution and/or publication of this 
e-mail message, contents or its attachment(s) is strictly prohibited and 
you are requested to notify us the same immediately by e-mail and delete 
this mail immediately. Izel Technologies Pvt. Ltd accepts no liability for 
virus infected e-mail or errors or omissions or consequences which may 
arise as a result of this e-mail transmission.
*End of Disclaimer*
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev