Re: [openstack-dev] Could we highlight +0 reviews in review.openstack.org

[David Pursehouse]

On Thu, Nov 12, 2015 at 1:14 PM Amrith Kumar  wrote:

> Thanks Jermey!
>
> I'll go look and see where one logs this request on upstream Gerrit
>
>
https://code.google.com/p/gerrit/issues/list
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] Could we highlight +0 reviews in review.openstack.org

[Amrith Kumar]

Thanks Jermey!

I'll go look and see where one logs this request on upstream Gerrit

-amrith

> -Original Message-
> From: Jeremy Stanley [mailto:fu...@yuggoth.org]
> Sent: Thursday, November 12, 2015 11:44 AM
> To: OpenStack Development Mailing List (not for usage questions)
> 
> Subject: Re: [openstack-dev] Could we highlight +0 reviews in
> review.openstack.org
> 
> On 2015-11-12 16:33:52 + (+), Amrith Kumar wrote:
> > When you look at a review on https://review.openstack.org, you see a
> > section of the screen that shows +2's, +1's, -1's and -2's above
> > Verified and Workflow. But we don't show +0's there.
> [...]
> 
> This is because Gerrit tries to treat a 0 vote as "unset" or "absent" so your
> suggestion needs to be filed upstream with Google's Gerrit developer team
> as a feature request (and may already be). The reviewer list is always carried
> over from one patchset to the next even if their associated votes are not, so
> there is no way in the reviewers box of the Web UI right now to distinguish
> someone who commented without voting (a.k.a. a 0 vote) on the current
> patchset from someone who only voted on previous patchsets.
> --
> Jeremy Stanley
> 
> __
> 
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-
> requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] Could we highlight +0 reviews in review.openstack.org

[Jeremy Stanley]

On 2015-11-12 16:33:52 + (+), Amrith Kumar wrote:
> When you look at a review on https://review.openstack.org, you see
> a section of the screen that shows +2's, +1's, -1's and -2's above
> Verified and Workflow. But we don't show +0's there.
[...]

This is because Gerrit tries to treat a 0 vote as "unset" or
"absent" so your suggestion needs to be filed upstream with Google's
Gerrit developer team as a feature request (and may already be). The
reviewer list is always carried over from one patchset to the next
even if their associated votes are not, so there is no way in the
reviewers box of the Web UI right now to distinguish someone who
commented without voting (a.k.a. a 0 vote) on the current patchset
from someone who only voted on previous patchsets.
-- 
Jeremy Stanley

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] Could we highlight +0 reviews in review.openstack.org

[Amrith Kumar]

When you look at a review on https://review.openstack.org, you see a section of 
the screen that shows +2's, +1's, -1's and -2's above Verified and Workflow. 
But we don't show +0's there.

It would be useful when looking at a review to be also able to see if there are 
any 0's there. Maybe in a different color. Otherwise, it is easy to miss a 
perfectly legitimate review with a 0 score.

I think the UI would be more user friendly with that, maybe we could make it a 
user preference whether this is shown or not.

Thanks,

-amrith

--
Amrith Kumar
Tesora, Inc
amr...@tesora.com
amrith on Freenode




__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev