Re: [openstack-dev] Do you hate the new gerrit thing where the cursor jumps all over?

2017-10-20 Thread Tim Burke 
OMG yes! I can actually search when looking at a diff now!

Thanks Matt.

Tim

> On Oct 20, 2017, at 9:02 AM, Matt Riedemann  wrote:
> 
> When you're lower in a change trying to expand comments and it always jumps 
> you back up to the top?
> 
> Since not everyone might know about the solution, it's:
> 
> 1. Go into settings
> 2. Diff Preference
> 3. Change "Render" from Fast to Slow.
> 4. Save
> 
> Get back to reviewing stuff without losing your mind.
> 
> -- 
> 
> Thanks,
> 
> Matt
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] Do you hate the new gerrit thing where the cursor jumps all over?

2017-10-20 Thread Jeremy Freudberg 
Indeed it helps. Thanks!

On Fri, Oct 20, 2017 at 1:27 PM, Clark Boylan  wrote:

> On Fri, Oct 20, 2017, at 10:16 AM, Jeremy Freudberg wrote:
> > I don't wanna turn this into a complaint session about new Gerrit. But
> > three little notes since the upgrade:
> >
> > - I can't push the "e" key to go into editing mode anymore
> > - Cherry-picks change the gerrit topic (that's probably a feature)
> > - The patch I'm already looking at shows up under "Same Topic" (that's
> > probably a feature)
> >
> >
> > The only one that really kills me is the first one. Anyone know if the
> > keyboard shortcut changed, or if it's disabled but configurable, etc...?
>
> The help overlay on the diff screen (brought up by hitting '?') says it
> is now " +  + e : Open Inline Editor".
>
> This seems to work for me in firefox on linux.
>
> Hope this helps,
> Clark
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] Do you hate the new gerrit thing where the cursor jumps all over?

2017-10-20 Thread Clark Boylan 
On Fri, Oct 20, 2017, at 10:16 AM, Jeremy Freudberg wrote:
> I don't wanna turn this into a complaint session about new Gerrit. But
> three little notes since the upgrade:
> 
> - I can't push the "e" key to go into editing mode anymore
> - Cherry-picks change the gerrit topic (that's probably a feature)
> - The patch I'm already looking at shows up under "Same Topic" (that's
> probably a feature)
> 
> 
> The only one that really kills me is the first one. Anyone know if the
> keyboard shortcut changed, or if it's disabled but configurable, etc...?

The help overlay on the diff screen (brought up by hitting '?') says it
is now " +  + e : Open Inline Editor".

This seems to work for me in firefox on linux.

Hope this helps,
Clark

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] Do you hate the new gerrit thing where the cursor jumps all over?

2017-10-20 Thread Jeremy Freudberg 
I don't wanna turn this into a complaint session about new Gerrit. But
three little notes since the upgrade:

- I can't push the "e" key to go into editing mode anymore
- Cherry-picks change the gerrit topic (that's probably a feature)
- The patch I'm already looking at shows up under "Same Topic" (that's
probably a feature)


The only one that really kills me is the first one. Anyone know if the
keyboard shortcut changed, or if it's disabled but configurable, etc...?

On Fri, Oct 20, 2017 at 12:02 PM, Matt Riedemann 
wrote:

> When you're lower in a change trying to expand comments and it always
> jumps you back up to the top?
>
> Since not everyone might know about the solution, it's:
>
> 1. Go into settings
> 2. Diff Preference
> 3. Change "Render" from Fast to Slow.
> 4. Save
>
> Get back to reviewing stuff without losing your mind.
>
> --
>
> Thanks,
>
> Matt
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] Do you hate the new gerrit thing where the cursor jumps all over?

2017-10-20 Thread Matt Riedemann 
When you're lower in a change trying to expand comments and it always 
jumps you back up to the top?


Since not everyone might know about the solution, it's:

1. Go into settings
2. Diff Preference
3. Change "Render" from Fast to Slow.
4. Save

Get back to reviewing stuff without losing your mind.

--

Thanks,

Matt

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev