Re: [openstack-dev] Doc to with pointers on how to review?
On 2014-03-31 13:28:24 +0900 (+0900), Emmet Hikory wrote: There are any number of projects that may have specific requirements that aren't documented on that page (please add them), but I found that having read that gave me great confidence to submit more reviews. I also just updated it to remove outdated advice about manually adding all new files to the list in MANIFEST.in, genericized the references to hacking guidelines, and added a mention of the UpgradeImpact tag along with the others which were already represented there. This article definitely should stay on the watch list for anyone who spends time mentoring new contributors, so that we can be sure to keep it up to date and relevant. -- Jeremy Stanley ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] Doc to with pointers on how to review?
Hi, Just wondering, do we have a document somewhere that educates people on how to do a code review? eg giving a few pointers that reviewers for a particular project normally look for So far everything I've seen (aside from https://wiki.openstack.org/wiki/GerritJenkinsGit#Reviewing_a_Change) is written from the perspective of how the review process works when you're submitting a patch and others are reviewing your code. However, it's early in the morning and it's likely my google-fu is at low levels ... perhaps such a doc exists? Maybe on a blog somewhere? Regards, Tom ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Doc to with pointers on how to review?
On Mon, Mar 31, 2014 at 5:57 AM, Tom Fifield t...@openstack.org wrote: Hi, Just wondering, do we have a document somewhere that educates people on how to do a code review? eg giving a few pointers that reviewers for a particular project normally look for Hi Tom, The closest to your description document is: https://wiki.openstack.org/wiki/ReviewChecklist ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Doc to with pointers on how to review?
On 31/03/14 12:24, Ruslan Kamaldinov wrote: On Mon, Mar 31, 2014 at 5:57 AM, Tom Fifield t...@openstack.org wrote: Hi, Just wondering, do we have a document somewhere that educates people on how to do a code review? eg giving a few pointers that reviewers for a particular project normally look for Hi Tom, The closest to your description document is: https://wiki.openstack.org/wiki/ReviewChecklist Thanks! That's just what I was looking for :) Now to link to it from everywhere... Regards, Tom ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Doc to with pointers on how to review?
Tom Fifield wrote: Just wondering, do we have a document somewhere that educates people on how to do a code review? eg giving a few pointers that reviewers for a particular project normally look for I asked this very question on IRC a few days ago, and was pointed at https://wiki.openstack.org/wiki/ReviewChecklist There are any number of projects that may have specific requirements that aren't documented on that page (please add them), but I found that having read that gave me great confidence to submit more reviews. -- Emmet HIKORY ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
