Re: [openstack-dev] Openstack + OpenContrail
On Mon, Nov 18, 2013 at 12:50 AM, Pedro Roque Marques
pedro.r.marq...@gmail.com wrote:
Does it address the catch-22 problem that a Neutron reviewer asks for the
plugin to be accepted upstream into devstack as pre-condition for
acceptance whether a devstack reviewer as for the plugin to be upstreamed
into Neutron first ?
Yes, that is the intention. However, you have to do the work of
integrating it, it isn't going to go into the existing gate right off, if
ever. Mark's message this morning[1] lays it out from their point of view.
He mentions using the CI third party testing integration [2] in the
'Testing Requirements' section. Ideally, you get that running with a trunk
DevStack plus your plugin against the Nova and Neutron branches with your
contrail plugin/mods.
Also, DevStack does not install support services that are not packaged in
the underlying distro. Look at Docker's split between the support
service(s) that start before stack.sh runs and the parts that specifically
configure Nova.
Can you please elaborate as to what are support services in this context
?
Things required of the running environment that are not shipped with the
OS need to be in place before stack.sh runs. i.e., you are compiling a
kernel module. DevStack's workflow is not an appropriate place to do that.
As another example, we have an install script for Docker that takes care
of their service installation and startup that is up to the end-user ot
have run before running stack.sh. This keeps us (DevStack) out of the
business of trying to maintain something we {can not/do not} test.
The patches that are being applied by the script have been submitted for
review. Using a patch approach is helpful in attempting to demonstrate that
the resulting code works against the master branch of Nova/Neutron.
The OpenStack methodology for this is to fork the repo and create a branch
of the source tree with your patch and test against that.
For the gate testing, DevStack actually does NONE of the source branch
setup work. A CI component names Zuul does all of that, pulling branches
and repos as it requires to set up the correct environment. Patching the
source trees after that destroys the integrity of what
Gerrit/Jenkins/devstack-gate thinks it is testing.
Can you please suggest a sequence of steps... ?
I understand that it makes sense to follow the plugin documentation
specified above. That would be the first step. But it is not clear to me
how to break it down further while having something that is still
functional.
If you get it running as a plugin and there are no changes required to the
existing DevStack files then you are done. Any changes to DevStack
indicate a shortcoming in the plugin interface and may need to be
generalized anyway.
dt
[1]
http://www.mail-archive.com/openstack-dev@lists.openstack.org/msg08700.html
[2] http://ci.openstack.org/third_party.html
--
Dean Troyer
dtro...@gmail.com
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Openstack + OpenContrail
On Nov 16, 2013, at 9:43 AM, Dean Troyer dtro...@gmail.com wrote: On Sat, Nov 16, 2013 at 11:15 AM, Harshad Nakil hna...@contrailsystems.com wrote: Sean, We have diff in three repositories. Nova, Neutron and devstack. Each review is requiring other to happen first. Do you have recommendation how do we deal with these dependencies? First off, if you rebase on to a current DevStack you will find a new plugin mechanism specifically designed to address this sort of problem. Dean, Does it address the catch-22 problem that a Neutron reviewer asks for the plugin to be accepted upstream into devstack as pre-condition for acceptance whether a devstack reviewer as for the plugin to be upstreamed into Neutron first ? You've already worked out the plugin bits for Neutron, the parts for stack.sh are similar, located in extras.d. http://devstack.org/plugins.html describes how it works. Also, DevStack does not install support services that are not packaged in the underlying distro. Look at Docker's split between the support service(s) that start before stack.sh runs and the parts that specifically configure Nova. Can you please elaborate as to what are support services in this context ? The patches to Neutron and Nova should be handled by setting the *_BRANCH and *_REPO variables to point to your repo and branch. DevStack will check them out for you when it installs the project source. That would mean forking Neutron and Nova; the code in question is a plugin. It actually show not need to be a diff other than for the fact that the Nova network plugins have so far been done via if ... else statements in nova/virt/libvirt/vif.py. The patches that are being applied by the script have been submitted for review. Using a patch approach is helpful in attempting to demonstrate that the resulting code works against the master branch of Nova/Neutron. You should be able to re-arrange things to support this architecture. Also, expect to break the remaining DevStack changes into digestible bits. As it stands, your branch is unmergable, even if it was based on a semi-current commit. Can you please suggest a sequence of steps... ? I understand that it makes sense to follow the plugin documentation specified above. That would be the first step. But it is not clear to me how to break it down further while having something that is still functional. FWIW, the opencontrail.org website appears to be off the air making it harder to understand what it is you are trying to integrate here. It must have been a transient error. The web site is working at the moment. OpenContrail is a network virtualization solution that provides a service model comparable to AWS VPC without the need for L2 support for the underlying switching infrastructure. It implements distributed router functionality so that traffic that crosses different Neutron networks doesn't have to traverse a router appliance (virtual or otherwise). Thank you, Pedro. dt -- Dean Troyer dtro...@gmail.com ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Openstack + OpenContrail
For something to go in devstack, it has to be included in the base server project. So first step is to work on getting your code upstream into the relevant upstream. We don't preintegrate into devstack, because it's job is not to be a general installer, it's to be an opinionated development setup tool for the existing integrated projects, making it easier for people to develop and work with the whole stack. -Sean On 11/15/2013 07:35 PM, Deepinder Singh Setia wrote: I would like to add that the work in forked devstack is ongoing and not complete. I am trying to understand what would it take to push these changes upstream such as coding requirements, testing, code organization, documentation etc. Thanks Deepinder From: Deepinder Setia dse...@juniper.net mailto:dse...@juniper.net Reply-To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org mailto:openstack-dev@lists.openstack.org Date: Friday, November 15, 2013 4:25 PM To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org mailto:openstack-dev@lists.openstack.org Subject: [openstack-dev] Openstack + OpenContrail I forked devstack a few weeks ago to integrate with OpenContrail at https://github.com/dsetia/devstack. This installs and launches OpenContrail in addition to openstack components. OpenContrail provides network virtualization components - SDN controller, Virtual Router and analytics - via neutron and nova plugins along with other modules built and launched when stack.sh is run. Please see * https://github.com/dsetia/devstack/blob/master/contrail/README - * http://pedrormarques.wordpress.com/2013/11/14/using-devstack-plus-opencontrail/ * http://opencontrail.org/ Bulk of the work is done by new file lib/neutron_thirdparty/contrail such as cloning open contrail repo, building and launching contrail modules. I also have directory called contrail under devstack which includes: 1. sample localrc files for setting up single or multi node openstack + open contrail system 2. Support files and scripts needed by lib/neutron_thirdparty/contrail functions 3. Neutron and Nova patches needed by OpenStack. These plugins have been submitted for review. Once approved, I will get rid of code to patch them I would like to understand the procedure, requirements and logistics to push these changes upstream to devstack repository. Thanks Deepinder ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Openstack + OpenContrail
Sean, We have diff in three repositories. Nova, Neutron and devstack. Each review is requiring other to happen first. Do you have recommendation how do we deal with these dependencies? Regards -Harshad On Nov 16, 2013, at 9:11 AM, Sean Dague s...@dague.net wrote: For something to go in devstack, it has to be included in the base server project. So first step is to work on getting your code upstream into the relevant upstream. We don't preintegrate into devstack, because it's job is not to be a general installer, it's to be an opinionated development setup tool for the existing integrated projects, making it easier for people to develop and work with the whole stack. -Sean On 11/15/2013 07:35 PM, Deepinder Singh Setia wrote: I would like to add that the work in forked devstack is ongoing and not complete. I am trying to understand what would it take to push these changes upstream such as coding requirements, testing, code organization, documentation etc. Thanks Deepinder From: Deepinder Setia dse...@juniper.net mailto:dse...@juniper.net Reply-To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org mailto:openstack-dev@lists.openstack.org Date: Friday, November 15, 2013 4:25 PM To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org mailto:openstack-dev@lists.openstack.org Subject: [openstack-dev] Openstack + OpenContrail I forked devstack a few weeks ago to integrate with OpenContrail at https://github.com/dsetia/devstack. This installs and launches OpenContrail in addition to openstack components. OpenContrail provides network virtualization components - SDN controller, Virtual Router and analytics - via neutron and nova plugins along with other modules built and launched when stack.sh is run. Please see * https://github.com/dsetia/devstack/blob/master/contrail/README - * http://pedrormarques.wordpress.com/2013/11/14/using-devstack-plus-opencontrail/ * http://opencontrail.org/ Bulk of the work is done by new file lib/neutron_thirdparty/contrail such as cloning open contrail repo, building and launching contrail modules. I also have directory called contrail under devstack which includes: 1. sample localrc files for setting up single or multi node openstack + open contrail system 2. Support files and scripts needed by lib/neutron_thirdparty/contrail functions 3. Neutron and Nova patches needed by OpenStack. These plugins have been submitted for review. Once approved, I will get rid of code to patch them I would like to understand the procedure, requirements and logistics to push these changes upstream to devstack repository. Thanks Deepinder ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Openstack + OpenContrail
On Sat, Nov 16, 2013 at 11:15 AM, Harshad Nakil hna...@contrailsystems.comwrote: Sean, We have diff in three repositories. Nova, Neutron and devstack. Each review is requiring other to happen first. Do you have recommendation how do we deal with these dependencies? First off, if you rebase on to a current DevStack you will find a new plugin mechanism specifically designed to address this sort of problem. You've already worked out the plugin bits for Neutron, the parts for stack.sh are similar, located in extras.d. http://devstack.org/plugins.htmldescribes how it works. Also, DevStack does not install support services that are not packaged in the underlying distro. Look at Docker's split between the support service(s) that start before stack.sh runs and the parts that specifically configure Nova. The patches to Neutron and Nova should be handled by setting the *_BRANCH and *_REPO variables to point to your repo and branch. DevStack will check them out for you when it installs the project source. You should be able to re-arrange things to support this architecture. Also, expect to break the remaining DevStack changes into digestible bits. As it stands, your branch is unmergable, even if it was based on a semi-current commit. FWIW, the opencontrail.org website appears to be off the air making it harder to understand what it is you are trying to integrate here. dt -- Dean Troyer dtro...@gmail.com ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] Openstack + OpenContrail
I forked devstack a few weeks ago to integrate with OpenContrail at https://github.com/dsetia/devstack. This installs and launches OpenContrail in addition to openstack components. OpenContrail provides network virtualization components - SDN controller, Virtual Router and analytics - via neutron and nova plugins along with other modules built and launched when stack.sh is run. Please see * https://github.com/dsetia/devstack/blob/master/contrail/README - * http://pedrormarques.wordpress.com/2013/11/14/using-devstack-plus-opencontrail/ * http://opencontrail.org/ Bulk of the work is done by new file lib/neutron_thirdparty/contrail such as cloning open contrail repo, building and launching contrail modules. I also have directory called contrail under devstack which includes: 1. sample localrc files for setting up single or multi node openstack + open contrail system 2. Support files and scripts needed by lib/neutron_thirdparty/contrail functions 3. Neutron and Nova patches needed by OpenStack. These plugins have been submitted for review. Once approved, I will get rid of code to patch them I would like to understand the procedure, requirements and logistics to push these changes upstream to devstack repository. Thanks Deepinder ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Openstack + OpenContrail
I would like to add that the work in forked devstack is ongoing and not complete. I am trying to understand what would it take to push these changes upstream such as coding requirements, testing, code organization, documentation etc. Thanks Deepinder From: Deepinder Setia dse...@juniper.netmailto:dse...@juniper.net Reply-To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.orgmailto:openstack-dev@lists.openstack.org Date: Friday, November 15, 2013 4:25 PM To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.orgmailto:openstack-dev@lists.openstack.org Subject: [openstack-dev] Openstack + OpenContrail I forked devstack a few weeks ago to integrate with OpenContrail at https://github.com/dsetia/devstack. This installs and launches OpenContrail in addition to openstack components. OpenContrail provides network virtualization components - SDN controller, Virtual Router and analytics - via neutron and nova plugins along with other modules built and launched when stack.sh is run. Please see * https://github.com/dsetia/devstack/blob/master/contrail/README - * http://pedrormarques.wordpress.com/2013/11/14/using-devstack-plus-opencontrail/ * http://opencontrail.org/ Bulk of the work is done by new file lib/neutron_thirdparty/contrail such as cloning open contrail repo, building and launching contrail modules. I also have directory called contrail under devstack which includes: 1. sample localrc files for setting up single or multi node openstack + open contrail system 2. Support files and scripts needed by lib/neutron_thirdparty/contrail functions 3. Neutron and Nova patches needed by OpenStack. These plugins have been submitted for review. Once approved, I will get rid of code to patch them I would like to understand the procedure, requirements and logistics to push these changes upstream to devstack repository. Thanks Deepinder ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
