Re: [openstack-dev] [Neutron] Stale patches
On Tue, Nov 18, 2014 at 7:39 AM, Jeremy Stanley wrote: > This has come up before... if you don't want to see stale patches > you can use Gerrit queries or custom dashboards to only show you > patches with recent activity. If all patches older than some > specific date get abandoned, then that impacts the view of these > patches for every reviewer. Selectively abandoning patches because > they're no longer relevant makes sense, but just automatically > abandoning them because _some_ reviewers don't want to see old > changes is a disservice to other reviewers who don't have the same > personal preference. I'd rather our infrastructure empowered > reviewers to look at the changes they *want* to see, not tell them > which changes they're *supposed* to review. I see your point here. We're all going to have our own customizations, of course but the fact that Salvatore took his time -- which is precious to the project -- to go through and abandon stale patches and his effort was met with applause and congratulations says something to me. It says that, as a project, we want this. If I'm speaking out of turn, please speak up and let me know. I personally don't enjoy customizing my own view more than I have to. I see it as kind of an annoyance. I'd rather not have to and be free to focus on other project issues. Carl ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron] Stale patches
> -Original Message- > From: Jeremy Stanley [mailto:fu...@yuggoth.org] > Sent: 18 November 2014 14:40 > To: OpenStack Development Mailing List (not for usage questions) > Subject: Re: [openstack-dev] [Neutron] Stale patches > > On 2014-11-18 05:55:55 + (+), Kenichi Oomichi wrote: > > I am not concentrating on Neutron devs, but I also have the same > > feeling on the other area devs. I also cannot abandon the other > > developers' patches even if non-activities against some negative > > feedback. > > This has come up before... if you don't want to see stale patches you > can use Gerrit queries or custom dashboards to only show you patches > with recent activity. If all patches older than some specific date get > abandoned, then that impacts the view of these patches for every > reviewer. Selectively abandoning patches because they're no longer > relevant makes sense, but just automatically abandoning them because > _some_ reviewers don't want to see old changes is a disservice to other > reviewers who don't have the same personal preference. I'd rather our > infrastructure empowered reviewers to look at the changes they *want* to > see, not tell them which changes they're *supposed* to review. I saw mail targeted towards nova earlier that Sean Dague was going to write an auto-abandon script to abandon patches with negative feedback for nova. Perhaps that script could be reused by other projects that see value in it. This was also brought up for the tripleo projects before, where I think the idea was mainly positively thought of (I am definitely an advocate for it). > -- > Jeremy Stanley > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Thanks, Jon-Paul Sullivan ☺ Cloud Services - @hpcloud Postal Address: Hewlett-Packard Galway Limited, Ballybrit Business Park, Galway. Registered Office: Hewlett-Packard Galway Limited, 63-74 Sir John Rogerson's Quay, Dublin 2. Registered Number: 361933 The contents of this message and any attachments to it are confidential and may be legally privileged. If you have received this message in error you should delete it from your system immediately and advise the sender. To any recipient of this message within HP, unless otherwise stated, you should consider this message and attachments as "HP CONFIDENTIAL". ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron] Stale patches
On 2014-11-18 05:55:55 + (+), Kenichi Oomichi wrote: > I am not concentrating on Neutron devs, but I also have the same > feeling on the other area devs. I also cannot abandon the other > developers' patches even if non-activities against some negative > feedback. This has come up before... if you don't want to see stale patches you can use Gerrit queries or custom dashboards to only show you patches with recent activity. If all patches older than some specific date get abandoned, then that impacts the view of these patches for every reviewer. Selectively abandoning patches because they're no longer relevant makes sense, but just automatically abandoning them because _some_ reviewers don't want to see old changes is a disservice to other reviewers who don't have the same personal preference. I'd rather our infrastructure empowered reviewers to look at the changes they *want* to see, not tell them which changes they're *supposed* to review. -- Jeremy Stanley ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron] Stale patches
> -Original Message- > From: Carl Baldwin [mailto:c...@ecbaldwin.net] > Sent: Tuesday, November 18, 2014 9:35 AM > To: OpenStack Development Mailing List (not for usage questions) > Subject: Re: [openstack-dev] [Neutron] Stale patches > > +1. I always hesitate to abandon someone's patch because it is so > personal. The auto-expire is impersonal and procedural. I agree that > 1 week is too soon. Give it at least a month. +1 I am not concentrating on Neutron devs, but I also have the same feeling on the other area devs. I also cannot abandon the other developers' patches even if non-activities against some negative feedback. Thanks Ken'ichi Ohmichi --- > Abandoned patches that have some importance shouldn't ever really be > lost. They should be linked to bug reports or blueprints to which > they're related. So, why do we need to keep them around while there > is no activity on them? > > Carl > > On Mon, Nov 17, 2014 at 11:45 AM, Collins, Sean > wrote: > > Perhaps we should re-introduce the auto-expiration of patches, albeit on > > a very leisurely timeframe. Before, it was like 1 week to expire a > > patch, which was a bit aggressive. Perhaps we could auto-expire patches > > that haven't been touched in 4 or 6 weeks, to expire patches that have > > truly been abandoned by authors? > > > > -- > > Sean M. Collins > > ___ > > OpenStack-dev mailing list > > OpenStack-dev@lists.openstack.org > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron] Stale patches
+1. I always hesitate to abandon someone's patch because it is so personal. The auto-expire is impersonal and procedural. I agree that 1 week is too soon. Give it at least a month. Abandoned patches that have some importance shouldn't ever really be lost. They should be linked to bug reports or blueprints to which they're related. So, why do we need to keep them around while there is no activity on them? Carl On Mon, Nov 17, 2014 at 11:45 AM, Collins, Sean wrote: > Perhaps we should re-introduce the auto-expiration of patches, albeit on > a very leisurely timeframe. Before, it was like 1 week to expire a > patch, which was a bit aggressive. Perhaps we could auto-expire patches > that haven't been touched in 4 or 6 weeks, to expire patches that have > truly been abandoned by authors? > > -- > Sean M. Collins > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron] Stale patches
Perhaps we should re-introduce the auto-expiration of patches, albeit on a very leisurely timeframe. Before, it was like 1 week to expire a patch, which was a bit aggressive. Perhaps we could auto-expire patches that haven't been touched in 4 or 6 weeks, to expire patches that have truly been abandoned by authors? -- Sean M. Collins ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron] Stale patches
good job :-) 2014-11-14 18:34 GMT+08:00 Miguel Ángel Ajo : > Thanks for cleaning up the house!, > > Best regards, > > Miguel Ángel Ajo > > On Friday, 14 de November de 2014 at 00:46, Salvatore Orlando wrote: > > There are a lot of neutron patches which, for different reasons, have not > been updated in a while. > In order to ensure reviewers focus on active patch, I have set a few > patches (about 75) as 'abandoned'. > > No patch with an update in the past month, either patchset or review, has > been abandoned. Moreover, only a part of the patches not updated for over a > month have been abandoned. I took extra care in identifying which ones > could safely be abandoned, and which ones were instead still valuable; > nevertheless, if you find out I abandoned a change you're actively working > on, please restore it. > > If you are the owner of one of these patches, you can use the 'restore > change' button in gerrit to resurrect the change. If you're not the other > and wish to resume work on these patches either contact any member of the > neutron-core team in IRC or push a new patch. > > Salvatore > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Neutron] Stale patches
Thanks for cleaning up the house!, Best regards, Miguel Ángel Ajo On Friday, 14 de November de 2014 at 00:46, Salvatore Orlando wrote: > There are a lot of neutron patches which, for different reasons, have not > been updated in a while. > In order to ensure reviewers focus on active patch, I have set a few patches > (about 75) as 'abandoned'. > > No patch with an update in the past month, either patchset or review, has > been abandoned. Moreover, only a part of the patches not updated for over a > month have been abandoned. I took extra care in identifying which ones could > safely be abandoned, and which ones were instead still valuable; > nevertheless, if you find out I abandoned a change you're actively working > on, please restore it. > > If you are the owner of one of these patches, you can use the 'restore > change' button in gerrit to resurrect the change. If you're not the other and > wish to resume work on these patches either contact any member of the > neutron-core team in IRC or push a new patch. > > Salvatore > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org (mailto:OpenStack-dev@lists.openstack.org) > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
