Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Tristan Cacqueray]

On February 20, 2018 1:35 am, Emilien Macchi wrote:

On Mon, Feb 19, 2018 at 7:03 AM, Jeremy Stanley  wrote:
[...]


This is hopefully only a temporary measure? I think I've heard it
mentioned that planning is underway to switch that CI system to Zuul
v3 (perhaps after 3.0.0 officially releases soon).



Adding Tristan and Fabien in copy, they know better about the roadmap.
--


Hi,

We are indeed waiting for the official Zuul 3.0.0 release to ship the
next version of Software Factory and deploy it for rdoproject.org.

-Tristan


pgpxjfzJyJ7Rv.pgp
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Emilien Macchi]

On Mon, Feb 19, 2018 at 7:03 AM, Jeremy Stanley  wrote:
[...]

> This is hopefully only a temporary measure? I think I've heard it
> mentioned that planning is underway to switch that CI system to Zuul
> v3 (perhaps after 3.0.0 officially releases soon).
>

Adding Tristan and Fabien in copy, they know better about the roadmap.
-- 
Emilien Macchi
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Joshua Hesketh]

Perhaps we need to consider a backport of the syntax to the 2.5 series?

It could help with the transition for those who need to upgrade. However,
on the other hand it might make deployers more complacent to do so.

On Tue, Feb 20, 2018 at 2:03 AM, Jeremy Stanley  wrote:

> On 2018-02-18 19:25:07 -0800 (-0800), Emilien Macchi wrote:
> [...]
> > My recommendation for TripleO devs: use the old syntax if you want your
> > code to be tested by RDO Third party CI
> [...]
>
> This is hopefully only a temporary measure? I think I've heard it
> mentioned that planning is underway to switch that CI system to Zuul
> v3 (perhaps after 3.0.0 officially releases soon).
> --
> Jeremy Stanley
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Jeremy Stanley]

On 2018-02-18 19:25:07 -0800 (-0800), Emilien Macchi wrote:
[...]
> My recommendation for TripleO devs: use the old syntax if you want your
> code to be tested by RDO Third party CI
[...]

This is hopefully only a temporary measure? I think I've heard it
mentioned that planning is underway to switch that CI system to Zuul
v3 (perhaps after 3.0.0 officially releases soon).
-- 
Jeremy Stanley


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Emilien Macchi]

I just realized that the new syntax doesn't work when third party jobs use
an old version of Zuul (e.g. RDO RCI).

Which means:
Depends-On: https://review.openstack.org/#/c/542556/
doesn't work

and
Depends-On: Ia30965b362d1c05d216f59b4cc1b3cb7e1284046
works for third party jobs.

We have to be very careful how we use the feature in TripleO CI. I've lost
a bit of time trying to figuring out why my code wasn't passing our
functional tests when I realized my code wasn't properly checkout.

My recommendation for TripleO devs: use the old syntax if you want your
code to be tested by RDO Third party CI (now voting btw).

Thanks,

On Mon, Feb 5, 2018 at 1:11 PM, Alex Schultz  wrote:

> On Thu, Feb 1, 2018 at 11:55 AM, James E. Blair 
> wrote:
> > Zane Bitter  writes:
> >
> >> Yeah, it's definitely nice to have that flexibility. e.g. here is a
> >> patch that wouldn't merge for 3 months because the thing it was
> >> dependent on also got proposed as a backport:
> >>
> >> https://review.openstack.org/#/c/514761/1
> >>
> >> From an OpenStack perspective, it would be nice if a Gerrit ID implied
> >> a change from the same Gerrit instance as the current repo and the
> >> same branch as the current patch if it exists (otherwise any branch),
> >> and we could optionally use a URL instead to select a particular
> >> change.
> >
> > Yeah, that's reasonable, and it is similar to things Zuul does in other
> > areas, but I think one of the thing we want to do with Depends-On is
> > consider that Zuul isn't the only audience.  It's there just as much for
> > the reviewers, and other folks.  So when it comes to Gerrit change ids,
> > I feel we had to constrain it to Gerrit's own behavior.  When you click
> > on one of those in Gerrit, it shows you all of the changes across all of
> > the repos and branches with that change-id.  So that result list is what
> > Zuul should work with.  Otherwise there's a discontinuity between what a
> > user sees when they click the hyperlink under the change-id and what
> > Zuul does.
> >
> > Similarly, in the new system, you click the URL and you see what Zuul is
> > going to use.
> >
> > And that leads into the reason we want to drop the old syntax: to make
> > it seamless for a GitHub user to know how to Depends-On a Gerrit change,
> > and vice versa, with neither requiring domain-specific knowledge about
> > the system.
> >
>
> While I can appreciate that, having to manage urls for backports in
> commit messages will lead to missing patches and other PEBAC related
> problems. Perhaps rather than throwing out this functionality we can
> push for improvements in the gerrit interaction itself?  I'm really -1
> on removing the change-id syntax just for this reasoning. The UX of
> having to manage complex depends-on urls for things like backports
> makes switching to URLs a non-starter unless I have a bunch of
> external system deps (and I generally don't).
>
> Thanks,
> -Alex
>
> > -Jim
> >
> > 
> __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Emilien Macchi
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Alex Schultz]

On Thu, Feb 1, 2018 at 11:55 AM, James E. Blair  wrote:
> Zane Bitter  writes:
>
>> Yeah, it's definitely nice to have that flexibility. e.g. here is a
>> patch that wouldn't merge for 3 months because the thing it was
>> dependent on also got proposed as a backport:
>>
>> https://review.openstack.org/#/c/514761/1
>>
>> From an OpenStack perspective, it would be nice if a Gerrit ID implied
>> a change from the same Gerrit instance as the current repo and the
>> same branch as the current patch if it exists (otherwise any branch),
>> and we could optionally use a URL instead to select a particular
>> change.
>
> Yeah, that's reasonable, and it is similar to things Zuul does in other
> areas, but I think one of the thing we want to do with Depends-On is
> consider that Zuul isn't the only audience.  It's there just as much for
> the reviewers, and other folks.  So when it comes to Gerrit change ids,
> I feel we had to constrain it to Gerrit's own behavior.  When you click
> on one of those in Gerrit, it shows you all of the changes across all of
> the repos and branches with that change-id.  So that result list is what
> Zuul should work with.  Otherwise there's a discontinuity between what a
> user sees when they click the hyperlink under the change-id and what
> Zuul does.
>
> Similarly, in the new system, you click the URL and you see what Zuul is
> going to use.
>
> And that leads into the reason we want to drop the old syntax: to make
> it seamless for a GitHub user to know how to Depends-On a Gerrit change,
> and vice versa, with neither requiring domain-specific knowledge about
> the system.
>

While I can appreciate that, having to manage urls for backports in
commit messages will lead to missing patches and other PEBAC related
problems. Perhaps rather than throwing out this functionality we can
push for improvements in the gerrit interaction itself?  I'm really -1
on removing the change-id syntax just for this reasoning. The UX of
having to manage complex depends-on urls for things like backports
makes switching to URLs a non-starter unless I have a bunch of
external system deps (and I generally don't).

Thanks,
-Alex

> -Jim
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[James E. Blair]

cor...@inaugust.com (James E. Blair) writes:

> The reason is that, contrary to earlier replies in this thread, the
> /#/c/ version of the change URL does not work.

The /#/c/ form of Gerrit URLs should work now; if it doesn't, please let
me know.

I would still recommend (and personally plan to use) the other form --
it's very easy to end up with a URL in Gerrit which includes the
patchset, or even a set of patchset diffs.  Zuul will ignore this
information and select the latest patchset of the change as its
dependency.  If a user clicks on a URL with an embedded patchset though,
they may end up looking at an old version, and not the version that Zuul
will use.

At any rate, the /#/c/ form should work.  I'd recommend trying to trim
off anything past the change number, if you do use it, to avoid
ambiguity.

-Jim

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[James E. Blair]

Zane Bitter  writes:

> Yeah, it's definitely nice to have that flexibility. e.g. here is a
> patch that wouldn't merge for 3 months because the thing it was
> dependent on also got proposed as a backport:
>
> https://review.openstack.org/#/c/514761/1
>
> From an OpenStack perspective, it would be nice if a Gerrit ID implied
> a change from the same Gerrit instance as the current repo and the
> same branch as the current patch if it exists (otherwise any branch),
> and we could optionally use a URL instead to select a particular
> change.

Yeah, that's reasonable, and it is similar to things Zuul does in other
areas, but I think one of the thing we want to do with Depends-On is
consider that Zuul isn't the only audience.  It's there just as much for
the reviewers, and other folks.  So when it comes to Gerrit change ids,
I feel we had to constrain it to Gerrit's own behavior.  When you click
on one of those in Gerrit, it shows you all of the changes across all of
the repos and branches with that change-id.  So that result list is what
Zuul should work with.  Otherwise there's a discontinuity between what a
user sees when they click the hyperlink under the change-id and what
Zuul does.

Similarly, in the new system, you click the URL and you see what Zuul is
going to use.

And that leads into the reason we want to drop the old syntax: to make
it seamless for a GitHub user to know how to Depends-On a Gerrit change,
and vice versa, with neither requiring domain-specific knowledge about
the system.

-Jim

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Zane Bitter]

On 25/01/18 19:08, James E. Blair wrote:

Mathieu Gagné  writes:


On Thu, Jan 25, 2018 at 3:55 PM, Ben Nemec  wrote:



I'm curious what this means as far as best practices for inter-patch
references.  In the past my understanding was the the change id was
preferred, both because if gerrit changed its URL format the change id links
would be updated appropriately, and also because change ids can be looked up
offline in git commit messages.  Would that still be the case for everything
except depends-on now?


Yes, that's a down-side of URLs.  I personally think it's fine to keep
using change-ids for anything other than Depends-On, though in many of
those cases the commit sha may work as well.


That's my concern too. Also AFAIK, Change-Id is branch agnostic. This
means you can more easily cherry-pick between branches without having
to change the URL to match the new branch for your dependencies.


Yes, there is a positive and negative aspect to this issue.

On the one hand, for those times where it was convenient to say "depend
on this change in all its forms across all branches of all projects",
one must now add a URL for each.

On the other hand, with URLs, it is now possible to indicate that a
change specifically depends on another change targeted to one branch, or
targeted to several branches.  Simply list each URL (or don't) as
appropriate.  That wasn't possible before -- it wall all or none.


Yeah, it's definitely nice to have that flexibility. e.g. here is a 
patch that wouldn't merge for 3 months because the thing it was 
dependent on also got proposed as a backport:


https://review.openstack.org/#/c/514761/1

From an OpenStack perspective, it would be nice if a Gerrit ID implied 
a change from the same Gerrit instance as the current repo and the same 
branch as the current patch if it exists (otherwise any branch), and we 
could optionally use a URL instead to select a particular change.


It's not obvious to me that that'd be the wrong thing for a tool that 
works across multiple Gerrit instances and/or other backends either, but 
I'm sure y'all have thought about it in more depth than I have.


cheers,
Zane.

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[James E. Blair]

Eric Fried  writes:

> For my part, I tried it [1] and it doesn't seem to have worked.  (The
> functional test failure is what the dep is supposed to have fixed.)  Did
> I do something wrong?
>
> [1] https://review.openstack.org/#/c/533821/12

If you examine the "items:" section in this file:

  
http://logs.openstack.org/21/533821/12/check/openstack-tox-functional/9066bb2/zuul-info/inventory.yaml

You will see that Zuul collected the following changes to test together:

526541,19
533808,6
521098,29
521187,29
535463,3
536624,3
536625,4
537648,5
533821,12

All on the master branch of nova.  The change you specified,
"https://review.openstack.org/#/c/536545/"; is not present.

The reason is that, contrary to earlier replies in this thread, the
/#/c/ version of the change URL does not work.

I'm sure we can fix that, but for the moment, we'll need to use the
permalink form.

-Jim

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Jeremy Stanley]

On 2018-01-26 08:57:02 -0800 (-0800), James E. Blair wrote:
[...]
> Perhaps a method of automatically noting the dependencies in git
> notes could help with that case?  Or maybe use a different way of
> communicating that information -- even with change-ids, there's
> still a lot of missing information in that scenario (for instance,
> which changes still haven't merged).

For what it's worth, Git notes for change commits already include
their corresponding Gerrit change URLs so can be found offline that
way regardless (as long as you configure your git client to retrieve
them whenever you retrieve other Git objects, e.g. during a remote
update). Even with a Change-Id you don't have any means of
identifying the containing repository except through brute force
means or online searching, so aside from being tracked in notes
rather than commit messages there's not much else different in the
new model.
-- 
Jeremy Stanley


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[James E. Blair]

Mathieu Gagné  writes:

> On Thu, Jan 25, 2018 at 7:08 PM, James E. Blair  wrote:
>> Mathieu Gagné  writes:
>>
>>> On Thu, Jan 25, 2018 at 3:55 PM, Ben Nemec  wrote:


 I'm curious what this means as far as best practices for inter-patch
 references.  In the past my understanding was the the change id was
 preferred, both because if gerrit changed its URL format the change id 
 links
 would be updated appropriately, and also because change ids can be looked 
 up
 offline in git commit messages.  Would that still be the case for 
 everything
 except depends-on now?
>>
>> Yes, that's a down-side of URLs.  I personally think it's fine to keep
>> using change-ids for anything other than Depends-On, though in many of
>> those cases the commit sha may work as well.
>>
>>> That's my concern too. Also AFAIK, Change-Id is branch agnostic. This
>>> means you can more easily cherry-pick between branches without having
>>> to change the URL to match the new branch for your dependencies.
>>
>> Yes, there is a positive and negative aspect to this issue.
>>
>> On the one hand, for those times where it was convenient to say "depend
>> on this change in all its forms across all branches of all projects",
>> one must now add a URL for each.
>>
>> On the other hand, with URLs, it is now possible to indicate that a
>> change specifically depends on another change targeted to one branch, or
>> targeted to several branches.  Simply list each URL (or don't) as
>> appropriate.  That wasn't possible before -- it wall all or none.
>>
>> -Jim
>>
>
>> The old syntax will continue to work for a while
>
> I still believe Change-Id should be supported and not removed as
> suggested. The use of URL assumes you have access to Gerrit to fetch
> more information about the change.
> This might not always be true or possible, especially when Gerrit is
> kept private and only the git repository is replicated publicly and
> you which to cherry-pick something (and its dependencies) from it.

Perhaps a method of automatically noting the dependencies in git notes
could help with that case?  Or maybe use a different way of
communicating that information -- even with change-ids, there's still a
lot of missing information in that scenario (for instance, which changes
still haven't merged).

-Jim

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Eric Fried]

For my part, I tried it [1] and it doesn't seem to have worked.  (The
functional test failure is what the dep is supposed to have fixed.)  Did
I do something wrong?

[1] https://review.openstack.org/#/c/533821/12

On 01/25/2018 09:33 PM, Mathieu Gagné wrote:
> On Thu, Jan 25, 2018 at 7:08 PM, James E. Blair  wrote:
>> Mathieu Gagné  writes:
>>
>>> On Thu, Jan 25, 2018 at 3:55 PM, Ben Nemec  wrote:


 I'm curious what this means as far as best practices for inter-patch
 references.  In the past my understanding was the the change id was
 preferred, both because if gerrit changed its URL format the change id 
 links
 would be updated appropriately, and also because change ids can be looked 
 up
 offline in git commit messages.  Would that still be the case for 
 everything
 except depends-on now?
>>
>> Yes, that's a down-side of URLs.  I personally think it's fine to keep
>> using change-ids for anything other than Depends-On, though in many of
>> those cases the commit sha may work as well.
>>
>>> That's my concern too. Also AFAIK, Change-Id is branch agnostic. This
>>> means you can more easily cherry-pick between branches without having
>>> to change the URL to match the new branch for your dependencies.
>>
>> Yes, there is a positive and negative aspect to this issue.
>>
>> On the one hand, for those times where it was convenient to say "depend
>> on this change in all its forms across all branches of all projects",
>> one must now add a URL for each.
>>
>> On the other hand, with URLs, it is now possible to indicate that a
>> change specifically depends on another change targeted to one branch, or
>> targeted to several branches.  Simply list each URL (or don't) as
>> appropriate.  That wasn't possible before -- it wall all or none.
>>
>> -Jim
>>
> 
>> The old syntax will continue to work for a while
> 
> I still believe Change-Id should be supported and not removed as
> suggested. The use of URL assumes you have access to Gerrit to fetch
> more information about the change.
> This might not always be true or possible, especially when Gerrit is
> kept private and only the git repository is replicated publicly and
> you which to cherry-pick something (and its dependencies) from it.
> 
> --
> Mathieu
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Mathieu Gagné]

On Thu, Jan 25, 2018 at 7:08 PM, James E. Blair  wrote:
> Mathieu Gagné  writes:
>
>> On Thu, Jan 25, 2018 at 3:55 PM, Ben Nemec  wrote:
>>>
>>>
>>> I'm curious what this means as far as best practices for inter-patch
>>> references.  In the past my understanding was the the change id was
>>> preferred, both because if gerrit changed its URL format the change id links
>>> would be updated appropriately, and also because change ids can be looked up
>>> offline in git commit messages.  Would that still be the case for everything
>>> except depends-on now?
>
> Yes, that's a down-side of URLs.  I personally think it's fine to keep
> using change-ids for anything other than Depends-On, though in many of
> those cases the commit sha may work as well.
>
>> That's my concern too. Also AFAIK, Change-Id is branch agnostic. This
>> means you can more easily cherry-pick between branches without having
>> to change the URL to match the new branch for your dependencies.
>
> Yes, there is a positive and negative aspect to this issue.
>
> On the one hand, for those times where it was convenient to say "depend
> on this change in all its forms across all branches of all projects",
> one must now add a URL for each.
>
> On the other hand, with URLs, it is now possible to indicate that a
> change specifically depends on another change targeted to one branch, or
> targeted to several branches.  Simply list each URL (or don't) as
> appropriate.  That wasn't possible before -- it wall all or none.
>
> -Jim
>

> The old syntax will continue to work for a while

I still believe Change-Id should be supported and not removed as
suggested. The use of URL assumes you have access to Gerrit to fetch
more information about the change.
This might not always be true or possible, especially when Gerrit is
kept private and only the git repository is replicated publicly and
you which to cherry-pick something (and its dependencies) from it.

--
Mathieu

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[James E. Blair]

Mathieu Gagné  writes:

> On Thu, Jan 25, 2018 at 3:55 PM, Ben Nemec  wrote:
>>
>>
>> I'm curious what this means as far as best practices for inter-patch
>> references.  In the past my understanding was the the change id was
>> preferred, both because if gerrit changed its URL format the change id links
>> would be updated appropriately, and also because change ids can be looked up
>> offline in git commit messages.  Would that still be the case for everything
>> except depends-on now?

Yes, that's a down-side of URLs.  I personally think it's fine to keep
using change-ids for anything other than Depends-On, though in many of
those cases the commit sha may work as well.

> That's my concern too. Also AFAIK, Change-Id is branch agnostic. This
> means you can more easily cherry-pick between branches without having
> to change the URL to match the new branch for your dependencies.

Yes, there is a positive and negative aspect to this issue.

On the one hand, for those times where it was convenient to say "depend
on this change in all its forms across all branches of all projects",
one must now add a URL for each.

On the other hand, with URLs, it is now possible to indicate that a
change specifically depends on another change targeted to one branch, or
targeted to several branches.  Simply list each URL (or don't) as
appropriate.  That wasn't possible before -- it wall all or none.

-Jim

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Mathieu Gagné]

On Thu, Jan 25, 2018 at 3:55 PM, Ben Nemec  wrote:
>
>
> I'm curious what this means as far as best practices for inter-patch
> references.  In the past my understanding was the the change id was
> preferred, both because if gerrit changed its URL format the change id links
> would be updated appropriately, and also because change ids can be looked up
> offline in git commit messages.  Would that still be the case for everything
> except depends-on now?
>

That's my concern too. Also AFAIK, Change-Id is branch agnostic. This
means you can more easily cherry-pick between branches without having
to change the URL to match the new branch for your dependencies.

--
Mathieu

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Ben Nemec]

On 01/24/2018 02:31 PM, Monty Taylor wrote:

On 01/24/2018 02:25 PM, David Shrewsbury wrote:

This is a (the?) killer feature.


On Wed, Jan 24, 2018 at 11:33 AM, James E. Blair > wrote:


    Hi,

    We recently introduced a new URL-based syntax for Depends-On: footers
    in commit messages:

   Depends-On: https://review.openstack.org/535851
    

    The old syntax will continue to work for a while, but please begin 
using

    the new syntax on new changes.

    Why are we changing this?  Zuul has grown the ability to interact 
with
    multiple backend systems (Gerrit, GitHub, and plain Git so far), 
and we

    have extended the cross-repo-dependency feature to support multiple
    systems.  But Gerrit is the only one that uses the change-id syntax.
    URLs, on the other hand, are universal.

    That means you can write, as in https://review.openstack.org/535541
    , a
    commit message such as:

   Depends-On:
    https://github.com/ikalnytskyi/sphinxcontrib-openapi/pull/17
    

    Or in a Github pull request like
    https://github.com/ansible/ansible/pull/20974
    , you can write:

   Depends-On: https://review.openstack.org/536159
    

    But we're getting a bit ahead of ourselves here -- we're just getting
    started with Gerrit <-> GitHub dependencies and we haven't worked
    everything out yet.  While you can Depends-On any GitHub URL, you 
can't

    add any project to required-projects yet, and we need to establish a
    process to actually report on GitHub projects.  But cool things are
    coming.

    We will continue to support the Gerrit-specific syntax for a while,
    probably for several months at least, so you don't need to update the
    commit messages of changes that have accumulated precious +2s.  
But do
    please start using the new syntax now, so that we can age the old 
syntax

    out.

    There are a few differences in using the new syntax:

    * Rather than copying the change-id from a commit message, you'll 
need
   to get the URL from Gerrit.  That means the dependent change 
already
   needs to be uploaded.  In some complex situations, this may 
mean that
   you need to amend an existing commit message to add in the URL 
later.


   If you're uploading both changes, Gerrit will output the URL 
when you

   run git-review, and you can copy it from there.  If you are
    looking at
   an existing change in Gerrit, you can copy the URL from the 
permalink

   at the top left of the page.  Where it says "Change 535855 - Needs
   ..." the change number itself is the permalink of the change.



Is the permalink the only valid format here for gerrit? Or does the fully
expanded link also work. E.g.,

    Depends-On: https://review.openstack.org/536540

versus

    Depends-On: https://review.openstack.org/#/c/536540/


The fully expanded one works too. See:

   https://review.openstack.org/#/c/520812/

for an example of a patch with expanded links.


I'm curious what this means as far as best practices for inter-patch 
references.  In the past my understanding was the the change id was 
preferred, both because if gerrit changed its URL format the change id 
links would be updated appropriately, and also because change ids can be 
looked up offline in git commit messages.  Would that still be the case 
for everything except depends-on now?


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[Monty Taylor]

On 01/24/2018 02:25 PM, David Shrewsbury wrote:

This is a (the?) killer feature.


On Wed, Jan 24, 2018 at 11:33 AM, James E. Blair > wrote:


Hi,

We recently introduced a new URL-based syntax for Depends-On: footers
in commit messages:

   Depends-On: https://review.openstack.org/535851


The old syntax will continue to work for a while, but please begin using
the new syntax on new changes.

Why are we changing this?  Zuul has grown the ability to interact with
multiple backend systems (Gerrit, GitHub, and plain Git so far), and we
have extended the cross-repo-dependency feature to support multiple
systems.  But Gerrit is the only one that uses the change-id syntax.
URLs, on the other hand, are universal.

That means you can write, as in https://review.openstack.org/535541
, a
commit message such as:

   Depends-On:
https://github.com/ikalnytskyi/sphinxcontrib-openapi/pull/17


Or in a Github pull request like
https://github.com/ansible/ansible/pull/20974
, you can write:

   Depends-On: https://review.openstack.org/536159


But we're getting a bit ahead of ourselves here -- we're just getting
started with Gerrit <-> GitHub dependencies and we haven't worked
everything out yet.  While you can Depends-On any GitHub URL, you can't
add any project to required-projects yet, and we need to establish a
process to actually report on GitHub projects.  But cool things are
coming.

We will continue to support the Gerrit-specific syntax for a while,
probably for several months at least, so you don't need to update the
commit messages of changes that have accumulated precious +2s.  But do
please start using the new syntax now, so that we can age the old syntax
out.

There are a few differences in using the new syntax:

* Rather than copying the change-id from a commit message, you'll need
   to get the URL from Gerrit.  That means the dependent change already
   needs to be uploaded.  In some complex situations, this may mean that
   you need to amend an existing commit message to add in the URL later.

   If you're uploading both changes, Gerrit will output the URL when you
   run git-review, and you can copy it from there.  If you are
looking at
   an existing change in Gerrit, you can copy the URL from the permalink
   at the top left of the page.  Where it says "Change 535855 - Needs
   ..." the change number itself is the permalink of the change.



Is the permalink the only valid format here for gerrit? Or does the fully
expanded link also work. E.g.,

    Depends-On: https://review.openstack.org/536540

versus

    Depends-On: https://review.openstack.org/#/c/536540/


The fully expanded one works too. See:

  https://review.openstack.org/#/c/520812/

for an example of a patch with expanded links.


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra][all] New Zuul Depends-On syntax

[David Shrewsbury]

This is a (the?) killer feature.


On Wed, Jan 24, 2018 at 11:33 AM, James E. Blair 
wrote:

> Hi,
>
> We recently introduced a new URL-based syntax for Depends-On: footers
> in commit messages:
>
>   Depends-On: https://review.openstack.org/535851
>
> The old syntax will continue to work for a while, but please begin using
> the new syntax on new changes.
>
> Why are we changing this?  Zuul has grown the ability to interact with
> multiple backend systems (Gerrit, GitHub, and plain Git so far), and we
> have extended the cross-repo-dependency feature to support multiple
> systems.  But Gerrit is the only one that uses the change-id syntax.
> URLs, on the other hand, are universal.
>
> That means you can write, as in https://review.openstack.org/535541, a
> commit message such as:
>
>   Depends-On: https://github.com/ikalnytskyi/sphinxcontrib-openapi/pull/17
>
> Or in a Github pull request like
> https://github.com/ansible/ansible/pull/20974, you can write:
>
>   Depends-On: https://review.openstack.org/536159
>
> But we're getting a bit ahead of ourselves here -- we're just getting
> started with Gerrit <-> GitHub dependencies and we haven't worked
> everything out yet.  While you can Depends-On any GitHub URL, you can't
> add any project to required-projects yet, and we need to establish a
> process to actually report on GitHub projects.  But cool things are
> coming.
>
> We will continue to support the Gerrit-specific syntax for a while,
> probably for several months at least, so you don't need to update the
> commit messages of changes that have accumulated precious +2s.  But do
> please start using the new syntax now, so that we can age the old syntax
> out.
>
> There are a few differences in using the new syntax:
>
> * Rather than copying the change-id from a commit message, you'll need
>   to get the URL from Gerrit.  That means the dependent change already
>   needs to be uploaded.  In some complex situations, this may mean that
>   you need to amend an existing commit message to add in the URL later.
>
>   If you're uploading both changes, Gerrit will output the URL when you
>   run git-review, and you can copy it from there.  If you are looking at
>   an existing change in Gerrit, you can copy the URL from the permalink
>   at the top left of the page.  Where it says "Change 535855 - Needs
>   ..." the change number itself is the permalink of the change.
>


Is the permalink the only valid format here for gerrit? Or does the fully
expanded link also work. E.g.,

   Depends-On: https://review.openstack.org/536540

versus

   Depends-On: https://review.openstack.org/#/c/536540/

[snip]


-Dave
-- 
David Shrewsbury (Shrews)
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev