Re: [openstack-dev] [nova] [neutron] What the behavior of AddFixedIp API should be?

[Alex Xu]

oops, sorry, the correct link is https://review.openstack.org/#/c/384261/,
I must remove last number accidently

2017-03-30 14:34 GMT+08:00 Kevin Benton :

> Not sure what you meant to link to, but that's not a spec. :)
>
> On Wed, Mar 29, 2017 at 11:21 PM, Alex Xu  wrote:
>
>> I just move the spec into Pike release https://review.opensta
>> ck.org/#/c/38426.
>>
>> The problem description section describes the strange API behaviour, and
>> proposal to deprecate the API since there isn't a clear use-case for this
>> API.
>>
>> 2017-03-29 8:59 GMT+08:00 Kevin Benton :
>>
>>> +1. If there is a use case missing from the neutron API that this
>>> allows, we can also expand the API to address it.
>>>
>>> On Mar 28, 2017 07:16, "Matt Riedemann"  wrote:
>>>
 On 3/27/2017 11:42 PM, Rui Chen wrote:

> Thank you Matt, the background information is important. Seems all the
> peoples don't know how the add-fixed-ip API works,
> and there is no exact use case about it. Now neutron port-update API
> also support to set multiple fixed ip for a port, and
> the fixed-ip updating will sync to nova side automatically (I had
> verified it in my latest devstack). Updating fixed-ip for
> specified port is easier to understand for me in multiple nics case
> than
> nova add-fixed-ip API.
>
> So if others known the orignal API design or had used nova add/remove
> fixed-ip API and would like to show your use cases,
> it's nice for us to understand how the API works and when we should use
> it, we can update the api-ref and add exact usage,
> avoid users' confusion about it. Feel free to reply something, thank
> you.
>
>
 If the functionality is available via Neutron APIs, we should just
 deprecate the multinic API like we did for the other network API proxies in
 microversion 2.36. This reminds me that Alex Xu had a blueprint for
 deprecating the multinic API [1] but it needs to be updated for Pike.

 [1] https://review.openstack.org/#/c/384261/

 --

 Thanks,

 Matt

 
 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe: openstack-dev-requ...@lists.op
 enstack.org?subject:unsubscribe
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

>>>
>>> 
>>> __
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: openstack-dev-requ...@lists.op
>>> enstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>>
>>
>> 
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscrib
>> e
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] [neutron] What the behavior of AddFixedIp API should be?

[Kevin Benton]

Not sure what you meant to link to, but that's not a spec. :)

On Wed, Mar 29, 2017 at 11:21 PM, Alex Xu  wrote:

> I just move the spec into Pike release https://review.
> openstack.org/#/c/38426.
>
> The problem description section describes the strange API behaviour, and
> proposal to deprecate the API since there isn't a clear use-case for this
> API.
>
> 2017-03-29 8:59 GMT+08:00 Kevin Benton :
>
>> +1. If there is a use case missing from the neutron API that this allows,
>> we can also expand the API to address it.
>>
>> On Mar 28, 2017 07:16, "Matt Riedemann"  wrote:
>>
>>> On 3/27/2017 11:42 PM, Rui Chen wrote:
>>>
 Thank you Matt, the background information is important. Seems all the
 peoples don't know how the add-fixed-ip API works,
 and there is no exact use case about it. Now neutron port-update API
 also support to set multiple fixed ip for a port, and
 the fixed-ip updating will sync to nova side automatically (I had
 verified it in my latest devstack). Updating fixed-ip for
 specified port is easier to understand for me in multiple nics case than
 nova add-fixed-ip API.

 So if others known the orignal API design or had used nova add/remove
 fixed-ip API and would like to show your use cases,
 it's nice for us to understand how the API works and when we should use
 it, we can update the api-ref and add exact usage,
 avoid users' confusion about it. Feel free to reply something, thank
 you.


>>> If the functionality is available via Neutron APIs, we should just
>>> deprecate the multinic API like we did for the other network API proxies in
>>> microversion 2.36. This reminds me that Alex Xu had a blueprint for
>>> deprecating the multinic API [1] but it needs to be updated for Pike.
>>>
>>> [1] https://review.openstack.org/#/c/384261/
>>>
>>> --
>>>
>>> Thanks,
>>>
>>> Matt
>>>
>>> 
>>> __
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: openstack-dev-requ...@lists.op
>>> enstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>> 
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscrib
>> e
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] [neutron] What the behavior of AddFixedIp API should be?

[Alex Xu]

I just move the spec into Pike release
https://review.openstack.org/#/c/38426.

The problem description section describes the strange API behaviour, and
proposal to deprecate the API since there isn't a clear use-case for this
API.

2017-03-29 8:59 GMT+08:00 Kevin Benton :

> +1. If there is a use case missing from the neutron API that this allows,
> we can also expand the API to address it.
>
> On Mar 28, 2017 07:16, "Matt Riedemann"  wrote:
>
>> On 3/27/2017 11:42 PM, Rui Chen wrote:
>>
>>> Thank you Matt, the background information is important. Seems all the
>>> peoples don't know how the add-fixed-ip API works,
>>> and there is no exact use case about it. Now neutron port-update API
>>> also support to set multiple fixed ip for a port, and
>>> the fixed-ip updating will sync to nova side automatically (I had
>>> verified it in my latest devstack). Updating fixed-ip for
>>> specified port is easier to understand for me in multiple nics case than
>>> nova add-fixed-ip API.
>>>
>>> So if others known the orignal API design or had used nova add/remove
>>> fixed-ip API and would like to show your use cases,
>>> it's nice for us to understand how the API works and when we should use
>>> it, we can update the api-ref and add exact usage,
>>> avoid users' confusion about it. Feel free to reply something, thank you.
>>>
>>>
>> If the functionality is available via Neutron APIs, we should just
>> deprecate the multinic API like we did for the other network API proxies in
>> microversion 2.36. This reminds me that Alex Xu had a blueprint for
>> deprecating the multinic API [1] but it needs to be updated for Pike.
>>
>> [1] https://review.openstack.org/#/c/384261/
>>
>> --
>>
>> Thanks,
>>
>> Matt
>>
>> 
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscrib
>> e
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] [neutron] What the behavior of AddFixedIp API should be?

[Kevin Benton]

+1. If there is a use case missing from the neutron API that this allows,
we can also expand the API to address it.

On Mar 28, 2017 07:16, "Matt Riedemann"  wrote:

> On 3/27/2017 11:42 PM, Rui Chen wrote:
>
>> Thank you Matt, the background information is important. Seems all the
>> peoples don't know how the add-fixed-ip API works,
>> and there is no exact use case about it. Now neutron port-update API
>> also support to set multiple fixed ip for a port, and
>> the fixed-ip updating will sync to nova side automatically (I had
>> verified it in my latest devstack). Updating fixed-ip for
>> specified port is easier to understand for me in multiple nics case than
>> nova add-fixed-ip API.
>>
>> So if others known the orignal API design or had used nova add/remove
>> fixed-ip API and would like to show your use cases,
>> it's nice for us to understand how the API works and when we should use
>> it, we can update the api-ref and add exact usage,
>> avoid users' confusion about it. Feel free to reply something, thank you.
>>
>>
> If the functionality is available via Neutron APIs, we should just
> deprecate the multinic API like we did for the other network API proxies in
> microversion 2.36. This reminds me that Alex Xu had a blueprint for
> deprecating the multinic API [1] but it needs to be updated for Pike.
>
> [1] https://review.openstack.org/#/c/384261/
>
> --
>
> Thanks,
>
> Matt
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] [neutron] What the behavior of AddFixedIp API should be?

[Matt Riedemann]

On 3/27/2017 11:42 PM, Rui Chen wrote:

Thank you Matt, the background information is important. Seems all the
peoples don't know how the add-fixed-ip API works,
and there is no exact use case about it. Now neutron port-update API
also support to set multiple fixed ip for a port, and
the fixed-ip updating will sync to nova side automatically (I had
verified it in my latest devstack). Updating fixed-ip for
specified port is easier to understand for me in multiple nics case than
nova add-fixed-ip API.

So if others known the orignal API design or had used nova add/remove
fixed-ip API and would like to show your use cases,
it's nice for us to understand how the API works and when we should use
it, we can update the api-ref and add exact usage,
avoid users' confusion about it. Feel free to reply something, thank you.



If the functionality is available via Neutron APIs, we should just 
deprecate the multinic API like we did for the other network API proxies 
in microversion 2.36. This reminds me that Alex Xu had a blueprint for 
deprecating the multinic API [1] but it needs to be updated for Pike.


[1] https://review.openstack.org/#/c/384261/

--

Thanks,

Matt

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] [neutron] What the behavior of AddFixedIp API should be?

[Rui Chen]

Thank you Matt, the background information is important. Seems all the
peoples don't know how the add-fixed-ip API works,
and there is no exact use case about it. Now neutron port-update API also
support to set multiple fixed ip for a port, and
the fixed-ip updating will sync to nova side automatically (I had verified
it in my latest devstack). Updating fixed-ip for
specified port is easier to understand for me in multiple nics case than
nova add-fixed-ip API.

So if others known the orignal API design or had used nova add/remove
fixed-ip API and would like to show your use cases,
it's nice for us to understand how the API works and when we should use it,
we can update the api-ref and add exact usage,
avoid users' confusion about it. Feel free to reply something, thank you.

2017-03-27 23:36 GMT+08:00 Matt Riedemann :

> On 3/27/2017 7:23 AM, Rui Chen wrote:
>
>> Hi:
>>
>> A question about nova AddFixedIp API, nova api-ref[1] describe the
>> API as "Adds a fixed IP address to a server instance, which associates
>> that address with the server.", the argument of API is network id, so if
>> there are two or more subnets in a network, which one is lucky to
>> associate ip address to the instance? and the API behavior is always
>> consistent? I'm not sure.
>> The latest code[2] get all of the instance's ports and subnets of
>> the specified network, then loop them, but it return when the first
>> update_port success, so the API behavior depends on the order of subnet
>> and port list that return by neutron API. I have no idea about what
>> scenario we should use the API in, and the original design, anyone know
>> that?
>>
>> [1]: https://developer.openstack.org/api-ref/compute/#add-associa
>> te-fixed-ip-addfixedip-action
>> [2]: https://github.com/openstack/nova/blob/master/nova/network/n
>> eutronv2/api.py#L1366
>>
>>
>> 
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscrib
>> e
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
> I wondered about this API implementation myself awhile ago, see this bug
> report for details:
>
> https://bugs.launchpad.net/nova/+bug/1430512
>
> There was a related change for this from garyk:
>
> https://review.openstack.org/#/c/163864/
>
> But that was abandoned.
>
> I'm honestly not really sure what the direction is here. From what I
> remember when I reported that bug, this was basically a feature-parity
> implementation in the compute API for the multinic API with nova-network.
> However, I'm not sure it's very usable. There is a Tempest test for this
> API, but I think all it does is attach an interface and make sure that does
> not blow up, it does not try to use the interface to ssh into the guest,
> for example.
>
> --
>
> Thanks,
>
> Matt
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] [neutron] What the behavior of AddFixedIp API should be?

[Matt Riedemann]

On 3/27/2017 7:23 AM, Rui Chen wrote:

Hi:

A question about nova AddFixedIp API, nova api-ref[1] describe the
API as "Adds a fixed IP address to a server instance, which associates
that address with the server.", the argument of API is network id, so if
there are two or more subnets in a network, which one is lucky to
associate ip address to the instance? and the API behavior is always
consistent? I'm not sure.
The latest code[2] get all of the instance's ports and subnets of
the specified network, then loop them, but it return when the first
update_port success, so the API behavior depends on the order of subnet
and port list that return by neutron API. I have no idea about what
scenario we should use the API in, and the original design, anyone know
that?

[1]: 
https://developer.openstack.org/api-ref/compute/#add-associate-fixed-ip-addfixedip-action
[2]: 
https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1366


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



I wondered about this API implementation myself awhile ago, see this bug 
report for details:


https://bugs.launchpad.net/nova/+bug/1430512

There was a related change for this from garyk:

https://review.openstack.org/#/c/163864/

But that was abandoned.

I'm honestly not really sure what the direction is here. From what I 
remember when I reported that bug, this was basically a feature-parity 
implementation in the compute API for the multinic API with 
nova-network. However, I'm not sure it's very usable. There is a Tempest 
test for this API, but I think all it does is attach an interface and 
make sure that does not blow up, it does not try to use the interface to 
ssh into the guest, for example.


--

Thanks,

Matt

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev