Hey Darragh and Kien, What I proposed is to create a etherpad/spec/blueprint to cover these changes of using the convert to xml function in JJB, and include it in the commit message as reference to keep tracking the process, so if someone else would like to contribute, it will be easy to find it.
Yes, include the document link into the commit message is not a good commit message, I agree to keep the commits describing the functional reason. Thanks, Vincent 2016-07-01 22:25 GMT+08:00 Darragh Bailey <daragh.bai...@gmail.com>: > Hi Kien, > > > I missed this email, but spotted this appearing in recent commits. > > > On 13 June 2016 at 03:28, Kien Ha <kienha9...@gmail.com> wrote: > >> >> On Sat, Jun 11, 2016 at 11:12 PM, Dong Ma <winterma.d...@gmail.com> >> wrote: >> >>> Hello Kien Ha, >>> >>> Thanks for the contribution to the Jenkins job builder projects, have >>> one comment here, how about add your proposal document link or create a new >>> etherpad into the commit message of each patches as reference to keep >>> tracking the process. >>> >>> Vincent >>> >> > This kind goes outside of what is generally described as > https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages > > > The update to the mailing list is more than enough, let's keep the commits > describing the functional reason for the change, or if there is a separate > proposal spec/blueprint that covers changing to use the convert to xml > function in JJB, changes relevant can include a reference, otherwise lets > keep the commit messages focused on the change itself. > > > -- > Darragh Bailey > "Nothing is foolproof to a sufficiently talented fool" >
_______________________________________________ OpenStack-Infra mailing list OpenStack-Infra@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra
