commit libnetfilter_cthelper for openSUSE:Factory

2014-09-26 Thread h_root
Hello community,

here is the log from the commit of package libnetfilter_cthelper for 
openSUSE:Factory checked in at 2014-09-26 10:52:23

Comparing /work/SRC/openSUSE:Factory/libnetfilter_cthelper (Old)
 and  /work/SRC/openSUSE:Factory/.libnetfilter_cthelper.new (New)


Package is "libnetfilter_cthelper"

Changes:

--- 
/work/SRC/openSUSE:Factory/libnetfilter_cthelper/libnetfilter_cthelper.changes  
2012-12-14 09:37:44.0 +0100
+++ 
/work/SRC/openSUSE:Factory/.libnetfilter_cthelper.new/libnetfilter_cthelper.changes
 2014-09-26 11:21:42.0 +0200
@@ -1,0 +2,6 @@
+Tue Sep 23 15:43:40 UTC 2014 - jeng...@inai.de
+
+- Drop gpg-offline build-time requirement; this is now handled by
+  the local source validator
+
+---



Other differences:
--
++ libnetfilter_cthelper.spec ++
--- /var/tmp/diff_new_pack.drTaXc/_old  2014-09-26 11:21:43.0 +0200
+++ /var/tmp/diff_new_pack.drTaXc/_new  2014-09-26 11:21:43.0 +0200
@@ -1,7 +1,7 @@
 #
 # spec file for package libnetfilter_cthelper
 #
-# Copyright (c) 2012 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -36,14 +36,7 @@
 #BuildRequires:  automake >= 1.6
 #BuildRequires:  libtool >= 2
 BuildRequires:  pkgconfig >= 0.21
-%if 0%{?suse_version} >= 1140 || 0%{?fedora_version}
 BuildRequires:  pkgconfig(libmnl) >= 1.0.0
-%else
-BuildRequires:  libmnl-devel >= 1.0.0
-%endif
-%if 0%{?suse_version} >= 1230
-BuildRequires:  gpg-offline
-%endif
 
 %description
 This library provides the programming interface (API) to the
@@ -58,18 +51,15 @@
 Netfilter userspace helper infrastructure.
 
 %package devel
-Requires:   %lname = %version
 Summary:Userspace library for the Netfilter Conntrack Helper extension
 Group:  Development/Libraries/C and C++
+Requires:   %lname = %version
 
 %description devel
 This library provides the programming interface (API) to the
 Netfilter userspace helper infrastructure.
 
 %prep
-%if 0%{?gpg_verify:1}
-%gpg_verify %{S:2}
-%endif
 %setup -q
 
 %build


-- 
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org



commit libnetfilter_cthelper for openSUSE:Factory

2012-09-14 Thread h_root
Hello community,

here is the log from the commit of package libnetfilter_cthelper for 
openSUSE:Factory checked in at 2012-09-14 12:28:52

Comparing /work/SRC/openSUSE:Factory/libnetfilter_cthelper (Old)
 and  /work/SRC/openSUSE:Factory/.libnetfilter_cthelper.new (New)


Package is "libnetfilter_cthelper", Maintainer is ""

Changes:

--- 
/work/SRC/openSUSE:Factory/libnetfilter_cthelper/libnetfilter_cthelper.changes  
2012-06-12 07:09:13.0 +0200
+++ 
/work/SRC/openSUSE:Factory/.libnetfilter_cthelper.new/libnetfilter_cthelper.changes
 2012-09-14 12:28:54.0 +0200
@@ -1,0 +2,5 @@
+Fri Aug 31 18:06:01 UTC 2012 - jeng...@inai.de
+
+- Rectify baselibs.conf to include the right package name
+
+---



Other differences:
--
++ libnetfilter_cthelper.spec ++
--- /var/tmp/diff_new_pack.ssFhSJ/_old  2012-09-14 12:28:55.0 +0200
+++ /var/tmp/diff_new_pack.ssFhSJ/_new  2012-09-14 12:28:55.0 +0200
@@ -30,10 +30,15 @@
 Source3:baselibs.conf
 Patch1:libname.diff
 BuildRoot:  %{_tmppath}/%{name}-%{version}-build
-BuildRequires:  autoconf, automake >= 1.6
-BuildRequires:  libtool
+BuildRequires:  autoconf
+BuildRequires:  automake >= 1.6
+BuildRequires:  libtool >= 2
 BuildRequires:  pkgconfig >= 0.21
+%if 0%{?suse_version} >= 1140 || 0%{?fedora_version}
 BuildRequires:  pkgconfig(libmnl) >= 1.0.0
+%else
+BuildRequires:  libmnl-devel >= 1.0.0
+%endif
 BuildRequires: xz
 
 %description
@@ -58,7 +63,12 @@
 Netfilter userspace helper infrastructure.
 
 %prep
+%if 0%{?__xz:1}
 %setup -qn %name
+%else
+tar -xf "%{S:0}" --use=xz;
+%setup -DTqn %name
+%endif
 %patch -P 1 -p1
 
 %build
@@ -69,7 +79,7 @@
 make %{?_smp_mflags}
 
 %install
-%makeinstall
+make install DESTDIR="%buildroot";
 rm -f "%buildroot/%_libdir"/*.la;
 
 %post -n %lname -p /sbin/ldconfig
@@ -82,7 +92,7 @@
 
 %files devel
 %defattr(-,root,root)
-%_includedir/libnetfilter_cthelper*
+%_includedir/%name-%version
 %_libdir/libnetfilter_cthelper.so
 %_libdir/pkgconfig/libnetfilter_cthelper.pc
 

++ baselibs.conf ++
--- /var/tmp/diff_new_pack.ssFhSJ/_old  2012-09-14 12:28:55.0 +0200
+++ /var/tmp/diff_new_pack.ssFhSJ/_new  2012-09-14 12:28:55.0 +0200
@@ -1 +1 @@
-libnetfilter_cttimeout1
+libnetfilter_cthelper-0-0


-- 
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org



commit libnetfilter_cthelper for openSUSE:Factory

2012-12-14 Thread h_root
Hello community,

here is the log from the commit of package libnetfilter_cthelper for 
openSUSE:Factory checked in at 2012-12-14 09:37:44

Comparing /work/SRC/openSUSE:Factory/libnetfilter_cthelper (Old)
 and  /work/SRC/openSUSE:Factory/.libnetfilter_cthelper.new (New)


Package is "libnetfilter_cthelper", Maintainer is ""

Changes:

--- 
/work/SRC/openSUSE:Factory/libnetfilter_cthelper/libnetfilter_cthelper.changes  
2012-10-16 07:08:28.0 +0200
+++ 
/work/SRC/openSUSE:Factory/.libnetfilter_cthelper.new/libnetfilter_cthelper.changes
 2012-12-14 09:37:44.0 +0100
@@ -1,0 +2,5 @@
+Wed Nov 28 20:23:02 CET 2012 - sbra...@suse.cz
+
+- Verify GPG signature
+
+---

New:

  libnetfilter_cthelper.keyring



Other differences:
--
++ libnetfilter_cthelper.spec ++
--- /var/tmp/diff_new_pack.8p68ra/_old  2012-12-14 09:37:46.0 +0100
+++ /var/tmp/diff_new_pack.8p68ra/_new  2012-12-14 09:37:46.0 +0100
@@ -30,6 +30,7 @@
 Source: 
http://netfilter.org/projects/libnetfilter_cthelper/files/%name-%version.tar.bz2
 Source2:
http://netfilter.org/projects/libnetfilter_cthelper/files/%name-%version.tar.bz2.sig
 Source3:baselibs.conf
+Source4:%name.keyring
 BuildRoot:  %{_tmppath}/%{name}-%{version}-build
 #BuildRequires:  autoconf
 #BuildRequires:  automake >= 1.6
@@ -40,6 +41,9 @@
 %else
 BuildRequires:  libmnl-devel >= 1.0.0
 %endif
+%if 0%{?suse_version} >= 1230
+BuildRequires:  gpg-offline
+%endif
 
 %description
 This library provides the programming interface (API) to the
@@ -63,6 +67,9 @@
 Netfilter userspace helper infrastructure.
 
 %prep
+%if 0%{?gpg_verify:1}
+%gpg_verify %{S:2}
+%endif
 %setup -q
 
 %build


++ libnetfilter_cthelper.keyring ++
pub   4096R/BB5F58CC 2010-10-21 [expires: 2015-10-20]
uid  Netfilter Core Team 
sub   4096R/04B92F5C 2010-10-21 [expires: 2015-10-20]

-BEGIN PGP PUBLIC KEY BLOCK-
Version: GnuPG v2.0.19 (GNU/Linux)

mQINBEzAS5EBEADVlGm+KwODJcVmP33HTCbn/eP8obZbgu+3Z1CYRklF8V43vC6D
8Jfk7fjD4/gWbAKZxriOESXVAN7mp0Fho4+Ga+pxWeLIET9tVM5xbNFK1p9R3XCK
p5SrugG+tGhizTR9b/1YCMVRz/yX3aDtC7lwObas4hkr5BqhphjvlkjFE7us32by
43LPpFj2yUpp1VdOf6gxl03kAgJg08h9J7a+n9KHQeAhIpXSRFq3tXiTdXQlovsv
ckwBjO0m8P2d1Z8/UYwXQgXzuO8W8EqaUSR95nDwl7UnilnKJm2fGvNg3A6PfCSk
3KdeEBZ45SRfMTPsuC5C4T0Az75h3HFR6YSae46ymg7d4ZA/Bd5K4hvp4PdYrfCi
GXen7iK9q5XDpopWb0yCrEVJzKjBjDurvpLtAD0IFWcpB6zwM38AnxVH05J8QOx/
VCZ4vZJxTKWbpHbdcISSMmVt00VfKorF9DsjiAcBRMBcIvDpJTP4yjvr32W09wLc
d5CIYGrLKhLNysUIJ44AQoTL9yV5aQvCb2EFnoPqCEKQm8onTAGX19PpTDjDPJFt
WyMMUDtiMp2yODuFo1qHjxvqzSVX+Ti2sGpiT1hEz97GAIlbAvmXs/bTb+U+rBnd
6027ooes3cWmBSV5kpz/sMp+nFynrLZ5NDnehPScz3W31oGgSdrGsnnhaQARAQAB
tCxOZXRmaWx0ZXIgQ29yZSBUZWFtIDxjb3JldGVhbUBuZXRmaWx0ZXIub3JnPokC
PgQTAQIAKAUCTMBLkQIbAwUJCWYBgAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AA
CgkQpBEfibtfWMzULxAAtGgYeuEqk0F9y4sz6hFJf+fXKSPPrwWTIUXs/sCxlBtS
lgf9oTvk3aT48zsMIfsDsS8yfIUjaK+eedIZW3oJ0lBtwRncZKjks8Od5J7DvEhR
Kpo3cajT1KXJh584IvXN0/BbCdPUI6EQE8n0fEUrSWANfzhuD3qYtX9UUGBq/7i8
Cf3pGFDeYRjcwWeNZ1T+xbaCKPS5BGlOVhMtauaTBZvTJniB828bOZXd3KrXUeul
AicbzZzqU7XcNX2YKw19MTQzuGNZQ3npJUPQiHgyELTh3+YUmRkPaZaZiDNZeQvu
/j8cgSoa26Q48apjghREo0Ues4MwQwEGBbdVkEQQMuC9ASti3OyZBTOqyApc2rpE
VsW2CkqvoQ8jaP51Ua4mjerYkqEqXaVtbPelNFMJXGNXrKdf0xg5Nl/onWnT9S/s
jtR3LtjOQ0apbBiGPROtYKWSQtA55TgYNLLS1+947TvU134Px1FA8Dqi72SBl7Xc
ET4nwISO222wMJBxbY4MYB2TppMysIKXUazIyekbRkpK1woH4AR6NsuJOiVdhjEi
46MkN7tmHI9S9blA98Ih6C9hMz2YgmQEwOQ0qYgVruPdYZSP+M5o+pra9ch+STBk
FbB03L9kqcAAE8wpGSBRYU+KuyVRipnPeqoeR8niO71AiKbsfbL1skTGRafC2Q+5
Ag0ETMBLkQEQANNv2Ymm/BVxwqb1vrLq1scoWK5kmeaRD3ndMBv9F3xwqGnE/JTn
HnVoZIzGb8MD+MCe9jfm8Y+NLU0D71NpDDqRzFZCCjcTmRMYV6QXlsg/ndnSaU1b
hG0gSq4N+qZFZ+35yiY5pYv1qZkIqWr4/vg9mk53CU620bNgNJ1+F19s/eTw1231
pJ6K6BsDi7pj4LXGD5wHZPKAmLabFweCkGbGQo6VwWw1ieNJ0igvzkZtVXuvoeHU
mAitCaZT9AIYDl4PHryckIzjgTdhK0PP92fyHV64Yr3B7G6hWlEwq4wKk9irdgqD
20Fuqw8Cvv6k1YucWfdpNbZkUI3siQE+1HUUuRTcT8yrPcEA5ZM1/U+e8jBT3EAr
hk69G6LCfwyX2Xd/JGlBmc0Qv0t2YKqj9Io1G5lBN1q57+vK7ttiIUomwvfD2ltY
0bdcEr5LjXOk3Sb+OPIVm7+vr6hDMKdUpdm5ABZRSUb0RJ37hBT+DKYbnp0t/e3a
MXxV9m3jUq8hNdwc8vU1khr9kf+MWPonE0Vw2kqHIIb4I5W9HkMJf4Vzj9/hVPMI
ucV+2de/7zqxwa0Jh5VSD7SeKj7LznsAy9gi/AioYq4AKVTsigfyJlWpjOLeOvv7
z4uUfLRQ5OWWfX8BBw8SoPwnWQD4cXHkrHXVwYR2yy7pEc1CstUN+uqXABEBAAGJ
AiUEGAECAA8FAkzAS5ECGwwFCQlmAYAACgkQpBEfibtfWMyLqw/6A12S4bnLYaik
ToKc13ywTUsHplbmlLOy2E/5ZMksdfuWjh9XTMR0nbXWnFULxGKTP00kA0yVpv/j
beDY/qLzY2Yb0rROCQJjuWSLYuNW40+Hmh9TGsDWt7iK3XsONVpV0sRsMOBCwV3k
2EsFXu73Fj+1JvQ+WSGluj+N7HFAqPi5OFk3IFFnIGhScUz22V6meSaOEqiXLySg
qh3lv7+XuGzoBjdy7dDm+SnbmK9lO1IqPsIm4iDwmTNJBiu1Wrz319kLYA0/Vx+o
fmxyViOX1GZShb1mGH0Aeo4jeYmDNLXapkoymC3HCIMctYDmuIw6QlgG8i1LRcFh
VKMngLjZ17dl/w8gYOdkCsGIUBzvbFBhxuJnXMnFVyDxft/lorM

commit libnetfilter_cthelper for openSUSE:Factory

2012-10-15 Thread h_root
Hello community,

here is the log from the commit of package libnetfilter_cthelper for 
openSUSE:Factory checked in at 2012-10-16 07:08:24

Comparing /work/SRC/openSUSE:Factory/libnetfilter_cthelper (Old)
 and  /work/SRC/openSUSE:Factory/.libnetfilter_cthelper.new (New)


Package is "libnetfilter_cthelper", Maintainer is ""

Changes:

--- 
/work/SRC/openSUSE:Factory/libnetfilter_cthelper/libnetfilter_cthelper.changes  
2012-09-14 12:28:54.0 +0200
+++ 
/work/SRC/openSUSE:Factory/.libnetfilter_cthelper.new/libnetfilter_cthelper.changes
 2012-10-16 07:08:28.0 +0200
@@ -1,0 +2,7 @@
+Mon Oct  8 15:35:52 UTC 2012 - jeng...@inai.de
+
+- Update to initial official release 1.0.0
+* This library provides the infrastructure for the user-space
+  helper infrastructure available since the Linux kernel 3.6.
+
+---

Old:

  libname.diff
  libnetfilter_cthelper-0.tar.xz

New:

  libnetfilter_cthelper-1.0.0.tar.bz2
  libnetfilter_cthelper-1.0.0.tar.bz2.sig



Other differences:
--
++ libnetfilter_cthelper.spec ++
--- /var/tmp/diff_new_pack.X6P6np/_old  2012-10-16 07:08:29.0 +0200
+++ /var/tmp/diff_new_pack.X6P6np/_new  2012-10-16 07:08:29.0 +0200
@@ -17,8 +17,8 @@
 
 
 Name:   libnetfilter_cthelper
-%define lname  %{name}-0-0
-Version:0
+%define lname  %{name}0
+Version:1.0.0
 Release:0
 Url:http://netfilter.org/projects/libnetfilter_cthelper/
 Summary:Userspace library for the Netfilter Conntrack Helper extension
@@ -26,20 +26,20 @@
 Group:  Productivity/Networking/Security
 
 #Git-Clone:git://git.netfilter.org/libnetfilter_cthelper
-Source: %name-%version.tar.xz
+#DL-URL:   http://netfilter.org/projects/libnetfilter_cthelper/files/
+Source: 
http://netfilter.org/projects/libnetfilter_cthelper/files/%name-%version.tar.bz2
+Source2:
http://netfilter.org/projects/libnetfilter_cthelper/files/%name-%version.tar.bz2.sig
 Source3:baselibs.conf
-Patch1: libname.diff
 BuildRoot:  %{_tmppath}/%{name}-%{version}-build
-BuildRequires:  autoconf
-BuildRequires:  automake >= 1.6
-BuildRequires:  libtool >= 2
+#BuildRequires:  autoconf
+#BuildRequires:  automake >= 1.6
+#BuildRequires:  libtool >= 2
 BuildRequires:  pkgconfig >= 0.21
 %if 0%{?suse_version} >= 1140 || 0%{?fedora_version}
 BuildRequires:  pkgconfig(libmnl) >= 1.0.0
 %else
 BuildRequires:  libmnl-devel >= 1.0.0
 %endif
-BuildRequires:  xz
 
 %description
 This library provides the programming interface (API) to the
@@ -63,13 +63,7 @@
 Netfilter userspace helper infrastructure.
 
 %prep
-%if 0%{?__xz:1}
-%setup -qn %name
-%else
-tar -xf "%{S:0}" --use=xz;
-%setup -DTqn %name
-%endif
-%patch -P 1 -p1
+%setup -q
 
 %build
 if [ ! -e configure ]; then
@@ -88,7 +82,7 @@
 
 %files -n %lname
 %defattr(-,root,root)
-%_libdir/libnetfilter_cthelper-0.so.0*
+%_libdir/libnetfilter_cthelper.so.0*
 
 %files devel
 %defattr(-,root,root)

++ baselibs.conf ++
--- /var/tmp/diff_new_pack.X6P6np/_old  2012-10-16 07:08:29.0 +0200
+++ /var/tmp/diff_new_pack.X6P6np/_new  2012-10-16 07:08:29.0 +0200
@@ -1 +1 @@
-libnetfilter_cthelper-0-0
+libnetfilter_cthelper0

-- 
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org



commit libnetfilter_cthelper for openSUSE:Factory

2014-12-09 Thread h_root
Hello community,

here is the log from the commit of package libnetfilter_cthelper for 
openSUSE:Factory checked in at 2014-12-09 09:14:21

Comparing /work/SRC/openSUSE:Factory/libnetfilter_cthelper (Old)
 and  /work/SRC/openSUSE:Factory/.libnetfilter_cthelper.new (New)


Package is "libnetfilter_cthelper"

Changes:

--- 
/work/SRC/openSUSE:Factory/libnetfilter_cthelper/libnetfilter_cthelper.changes  
2014-09-26 11:21:42.0 +0200
+++ 
/work/SRC/openSUSE:Factory/.libnetfilter_cthelper.new/libnetfilter_cthelper.changes
 2014-12-09 09:13:58.0 +0100
@@ -1,0 +2,12 @@
+Mon Dec  8 17:27:32 UTC 2014 - jeng...@inai.de
+
+- Remove version from subinclude directory; it tends to break
+  recompiles of third software after a library update.
+
+---
+Sun Dec  7 19:58:44 UTC 2014 - cshor...@googlemail.com
+
+- Add fix_h_expect_policy_free.patch to fix crash due to following
+  a just-freed pointer [bnc#908875]
+
+---

New:

  fix_h_expect_policy_free.patch



Other differences:
--
++ libnetfilter_cthelper.spec ++
--- /var/tmp/diff_new_pack.VtuwDb/_old  2014-12-09 09:13:59.0 +0100
+++ /var/tmp/diff_new_pack.VtuwDb/_new  2014-12-09 09:13:59.0 +0100
@@ -31,6 +31,7 @@
 Source2:
http://netfilter.org/projects/libnetfilter_cthelper/files/%name-%version.tar.bz2.sig
 Source3:baselibs.conf
 Source4:%name.keyring
+Patch1: fix_h_expect_policy_free.patch
 BuildRoot:  %{_tmppath}/%{name}-%{version}-build
 #BuildRequires:  autoconf
 #BuildRequires:  automake >= 1.6
@@ -61,12 +62,13 @@
 
 %prep
 %setup -q
+%patch -P 1 -p1
 
 %build
 if [ ! -e configure ]; then
autoreconf -fi;
 fi;
-%configure --disable-static --includedir=%_includedir/%name-%version
+%configure --disable-static --includedir="%_includedir/%name"
 make %{?_smp_mflags}
 
 %install
@@ -83,7 +85,7 @@
 
 %files devel
 %defattr(-,root,root)
-%_includedir/%name-%version
+%_includedir/%name/
 %_libdir/libnetfilter_cthelper.so
 %_libdir/pkgconfig/libnetfilter_cthelper.pc
 

++ fix_h_expect_policy_free.patch ++
From: Chris Horler 
Date: 2014-12-08 11:54:20 CET
References: https://bugzilla.netfilter.org/show_bug.cgi?id=990

Dereferencing h after freeing leads to undefined behavior.

--- libnetfilter_cthelper-1.0.0.orig/src/libnetfilter_cthelper.c
2012-06-05 17:59:28.810356258 +0100
+++ libnetfilter_cthelper-1.0.0/src/libnetfilter_cthelper.c 2014-12-07 
19:52:55.769975500 +
@@ -113,11 +113,11 @@
 {
int i;
 
-   free(h);
for (i=0; iexpect_policy[i])
free(h->expect_policy[i]);
}
+   free(h);
 }
 EXPORT_SYMBOL(nfct_helper_free);
 

-- 
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org



commit libnetfilter_cthelper for openSUSE:Factory

2020-10-24 Thread root
Hello community,

here is the log from the commit of package libnetfilter_cthelper for 
openSUSE:Factory checked in at 2020-10-24 15:14:36

Comparing /work/SRC/openSUSE:Factory/libnetfilter_cthelper (Old)
 and  /work/SRC/openSUSE:Factory/.libnetfilter_cthelper.new.3463 (New)


Package is "libnetfilter_cthelper"

Sat Oct 24 15:14:36 2020 rev:11 rq:843036 version:1.0.0

Changes:

--- 
/work/SRC/openSUSE:Factory/libnetfilter_cthelper/libnetfilter_cthelper.changes  
2014-12-09 09:13:58.0 +0100
+++ 
/work/SRC/openSUSE:Factory/.libnetfilter_cthelper.new.3463/libnetfilter_cthelper.changes
2020-10-24 15:14:39.588042192 +0200
@@ -1,0 +2,5 @@
+Wed Oct 14 00:09:08 UTC 2020 - Jan Engelhardt 
+
+- Modernize specfile constructs.
+
+---



Other differences:
--
++ libnetfilter_cthelper.spec ++
--- /var/tmp/diff_new_pack.EQsn0V/_old  2020-10-24 15:14:40.180042931 +0200
+++ /var/tmp/diff_new_pack.EQsn0V/_new  2020-10-24 15:14:40.180042931 +0200
@@ -1,7 +1,7 @@
 #
 # spec file for package libnetfilter_cthelper
 #
-# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2020 SUSE LLC
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -12,7 +12,7 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
 
 
@@ -20,10 +20,10 @@
 %define lname  %{name}0
 Version:1.0.0
 Release:0
-Url:http://netfilter.org/projects/libnetfilter_cthelper/
 Summary:Userspace library for the Netfilter Conntrack Helper extension
-License:GPL-2.0+
+License:GPL-2.0-or-later
 Group:  Productivity/Networking/Security
+URL:https://netfilter.org/projects/libnetfilter_cthelper/
 
 #Git-Clone:git://git.netfilter.org/libnetfilter_cthelper
 #DL-URL:   http://netfilter.org/projects/libnetfilter_cthelper/files/
@@ -32,11 +32,9 @@
 Source3:baselibs.conf
 Source4:%name.keyring
 Patch1: fix_h_expect_policy_free.patch
-BuildRoot:  %{_tmppath}/%{name}-%{version}-build
 #BuildRequires:  autoconf
 #BuildRequires:  automake >= 1.6
 #BuildRequires:  libtool >= 2
-BuildRequires:  pkgconfig >= 0.21
 BuildRequires:  pkgconfig(libmnl) >= 1.0.0
 
 %description
@@ -61,30 +59,27 @@
 Netfilter userspace helper infrastructure.
 
 %prep
-%setup -q
-%patch -P 1 -p1
+%autosetup -p1
 
 %build
 if [ ! -e configure ]; then
-   autoreconf -fi;
-fi;
+   autoreconf -fi
+fi
+# includedir intentional, cf. bugzilla.opensuse.org/795968
 %configure --disable-static --includedir="%_includedir/%name"
-make %{?_smp_mflags}
+%make_build
 
 %install
-make install DESTDIR="%buildroot";
-rm -f "%buildroot/%_libdir"/*.la;
+%make_install
+rm -f "%buildroot/%_libdir"/*.la
 
 %post -n %lname -p /sbin/ldconfig
-
 %postun -n %lname -p /sbin/ldconfig
 
 %files -n %lname
-%defattr(-,root,root)
 %_libdir/libnetfilter_cthelper.so.0*
 
 %files devel
-%defattr(-,root,root)
 %_includedir/%name/
 %_libdir/libnetfilter_cthelper.so
 %_libdir/pkgconfig/libnetfilter_cthelper.pc