commit rpmlint for openSUSE:Factory
Hello community,
here is the log from the commit of package rpmlint for openSUSE:Factory
checked in at Wed Jun 8 09:11:30 CEST 2011.
--- rpmlint/rpmlint.changes 2011-05-31 13:31:04.0 +0200
+++ /mounts/work_src_done/STABLE/rpmlint/rpmlint.changes2011-06-07
17:14:42.0 +0200
@@ -1,0 +2,12 @@
+Tue Jun 7 15:14:20 UTC 2011 - lnus...@suse.de
+
+- add colord to dbus whitelist (bnc#698250)
+
+---
+Tue Jun 7 15:03:54 UTC 2011 - lnus...@suse.de
+
+- CheckPolkitPrivs.py: use different tag for non-fatal issues
+- CheckBuildDate.py: print either file-contains-current-date or
+ file-contains-current-date but not both
+
+---
calling whatdependson for head-i586
Other differences:
--
++ rpmlint.spec ++
--- /var/tmp/diff_new_pack.z0BpNY/_old 2011-06-08 09:09:00.0 +0200
+++ /var/tmp/diff_new_pack.z0BpNY/_new 2011-06-08 09:09:00.0 +0200
@@ -23,7 +23,7 @@
BuildRequires: rpm-python xz
Summary:Rpm correctness checker
Version:1.2
-Release:7
+Release:9
Source0:http://rpmlint.zarb.org/download/rpmlint-%{version}.tar.xz
Source1:config
Source1001: config.in
++ CheckBuildDate.py ++
--- /var/tmp/diff_new_pack.z0BpNY/_old 2011-06-08 09:09:00.0 +0200
+++ /var/tmp/diff_new_pack.z0BpNY/_new 2011-06-08 09:09:00.0 +0200
@@ -30,13 +30,13 @@
grep_date = pkg.grep(self.istoday, filename)
-if len(grep_date):
-printWarning(pkg, file-contains-current-date, filename)
-
grep_time = pkg.grep(self.looksliketime, filename)
-if len(grep_date) and len(grep_time):
-printError(pkg, file-contains-date-and-time, filename)
+if len(grep_date):
+if len(grep_time):
+printError(pkg, file-contains-date-and-time, filename)
+else:
+printWarning(pkg, file-contains-current-date, filename)
check=BuildDateCheck()
++ CheckPolkitPrivs.py ++
--- /var/tmp/diff_new_pack.z0BpNY/_old 2011-06-08 09:09:00.0 +0200
+++ /var/tmp/diff_new_pack.z0BpNY/_new 2011-06-08 09:09:00.0 +0200
@@ -77,37 +77,50 @@
try:
if f.startswith(/usr/share/PolicyKit/policy/)\
or f.startswith(/usr/share/polkit-1/actions/):
-f = pkg.dirName() + f
-xml = parse(f)
+xml = parse(pkg.dirName() + f)
for a in xml.getElementsByTagName(action):
action = a.getAttribute('id')
if not action in self.privs:
iserr = 0
foundno = 0
-anyseen = 0
+foundundef = 0
+settings = {}
try:
defaults =
a.getElementsByTagName(defaults)[0]
for i in defaults.childNodes:
if not i.nodeType == i.ELEMENT_NODE:
continue
-if i.nodeName == 'allow_any':
-anyseen = 1
-if i.firstChild.data.find(auth_admin) !=
0:
-if i.firstChild.data == 'no':
-foundno = 1
-else:
-iserr = 1
+
+if i.nodeName in ('allow_any',
'allow_inactive', 'allow_active'):
+settings[i.nodeName] =
i.firstChild.data
+
except:
iserr = 1
+for i in ('allow_any', 'allow_inactive',
'allow_active'):
+if not i in settings:
+foundundef = 1
+settings[i] = '??'
+elif settings[i].find(auth_admin) != 0:
+if settings[i] == 'no':
+foundno = 1
+else:
+iserr = 1
+
if iserr:
-printError(pkg,
'polkit-unauthorized-privilege', action)
+printError(pkg,
'polkit-unauthorized-privilege', '%s (%s:%s:%s)' % (action, \
+settings['allow_any'],
settings['allow_inactive'], settings['allow_active']))
commit rpmlint for openSUSE:Factory
Hello community,
here is the log from the commit of package rpmlint for openSUSE:Factory
checked in at Wed Jun 1 09:49:36 CEST 2011.
--- rpmlint/rpmlint.changes 2011-05-24 16:21:21.0 +0200
+++ /mounts/work_src_done/STABLE/rpmlint/rpmlint.changes2011-05-31
13:31:04.0 +0200
@@ -1,0 +2,5 @@
+Tue May 31 11:29:52 UTC 2011 - lnus...@suse.de
+
+- add check for /var/lock/subsys usage
+
+---
calling whatdependson for head-i586
New:
rpmlint-subsys.diff
Other differences:
--
++ rpmlint.spec ++
--- /var/tmp/diff_new_pack.Be91bV/_old 2011-06-01 09:49:02.0 +0200
+++ /var/tmp/diff_new_pack.Be91bV/_new 2011-06-01 09:49:02.0 +0200
@@ -23,7 +23,7 @@
BuildRequires: rpm-python xz
Summary:Rpm correctness checker
Version:1.2
-Release:5
+Release:7
Source0:http://rpmlint.zarb.org/download/rpmlint-%{version}.tar.xz
Source1:config
Source1001: config.in
@@ -130,6 +130,7 @@
Patch89:rpmlint-pie.diff
# accepted upstream
Patch90:rpmlint-typo.diff
+Patch91:rpmlint-subsys.diff
%py_requires
%description
@@ -145,6 +146,7 @@
%prep
%setup -q -n rpmlint-%{version}
+%patch91 -p1
%patch0
%patch1
%patch2
++ config ++
--- /var/tmp/diff_new_pack.Be91bV/_old 2011-06-01 09:49:03.0 +0200
+++ /var/tmp/diff_new_pack.Be91bV/_new 2011-06-01 09:49:03.0 +0200
@@ -64,6 +64,7 @@
#setOption(ValidGroups, (Group1, Group2))
#setOption(KernelModuleRPMsOK, 0)
setOption(CompressExtension, None)
+setOption('UseVarLockSubsys', False)
setOption('StandardGroups', (
'aegis',
++ rpmlint-subsys.diff ++
From 665a612a589e161509de4aeab1486f430cc99e03 Mon Sep 17 00:00:00 2001
From: Ludwig Nussel ludwig.nus...@suse.de
Date: Tue, 31 May 2011 13:21:27 +0200
Subject: [PATCH] add option to disable /var/lock/subsys check
openSUSE for example doesn't use /var/lock/subsys
---
InitScriptCheck.py | 11 +--
config |4
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/InitScriptCheck.py b/InitScriptCheck.py
index ba7952e..167385b 100644
--- a/InitScriptCheck.py
+++ b/InitScriptCheck.py
@@ -29,6 +29,7 @@ dot_in_name_regex = re.compile('.*\..*')
use_deflevels = Config.getOption('UseDefaultRunlevels', True)
lsb_tags_regex = re.compile('^# ([\w-]+):\s*(.*?)\s*$')
lsb_cont_regex = re.compile('^#(?:\t| )(.*?)\s*$')
+use_subsys = Config.getOption('UseVarLockSubsys', True)
LSB_KEYWORDS = ('Provides', 'Required-Start', 'Required-Stop', 'Should-Start',
'Should-Stop', 'Default-Start', 'Default-Stop',
@@ -152,7 +153,7 @@ class InitScriptCheck(AbstractCheck.AbstractCheck):
if res:
subsys_regex_found = True
name = res.group(1)
-if name != basename:
+if use_subsys and name != basename:
error = True
if name[0] == '$':
value = Pkg.substitute_shell_vars(name,
content_str)
@@ -181,8 +182,10 @@ class InitScriptCheck(AbstractCheck.AbstractCheck):
printWarning(pkg, 'no-reload-entry', fname)
if not chkconfig_content_found:
printError(pkg, 'no-chkconfig-line', fname)
-if not subsys_regex_found:
+if not subsys_regex_found and use_subsys:
printError(pkg, 'subsys-not-used', fname)
+elif subsys_regex_found and not use_subsys:
+printError(pkg, 'subsys-unsupported', fname)
goodnames = (pkg.name.lower(), pkg.name.lower() + 'd')
if len(initscript_list) == 1 and initscript_list[0] not in goodnames:
@@ -238,6 +241,10 @@ reasons, most services should not be. Use - as the
default runlevel in the
init script's chkconfig: line and/or remove the Default-Start: LSB keyword
to fix this if appropriate for this service.''',
+'subsys-unsupported',
+'''The init script uses /var/lock/subsys which is not supported by
+this distribution.''',
+
'subsys-not-used',
'''While your daemon is running, you have to put a lock file in
/var/lock/subsys/. To see an example, look at this directory on your
diff --git a/config b/config
index 8ed05d4..5631260 100644
--- a/config
+++ b/config
@@ -162,6 +162,10 @@ from Config import *
# Type: boolean, default: True
#setOption(UseVersionInChangelog, True)
+# Whether init scripts must use /var/lock/subsys
+# Type: boolean, default: True
+#setOption(UseVarLockSubsys, True)
+
# Architecture dependent paths in which packages are allowed to install files
# even if they are all non-binary.
# Type: regexp, default: see BinariesCheck
--
1.7.3.4
++ suse-rclink-check.diff ++
--- /var/tmp/diff_new_pack.Be91bV/_old 2011-06-01
commit rpmlint for openSUSE:Factory
Hello community,
here is the log from the commit of package rpmlint for openSUSE:Factory
checked in at Wed May 25 09:45:38 CEST 2011.
--- rpmlint/rpmlint.changes 2011-05-20 16:48:08.0 +0200
+++ /mounts/work_src_done/STABLE/rpmlint/rpmlint.changes2011-05-24
16:21:21.0 +0200
@@ -1,0 +2,5 @@
+Tue May 24 14:20:48 UTC 2011 - lnus...@suse.de
+
+- disable source-or-patch-not-compressed. Not useful anymore.
+
+---
calling whatdependson for head-i586
Old:
suse-bzip-bigger-than-100k.diff
Other differences:
--
++ rpmlint.spec ++
--- /var/tmp/diff_new_pack.MgCkGh/_old 2011-05-25 09:44:48.0 +0200
+++ /var/tmp/diff_new_pack.MgCkGh/_new 2011-05-25 09:44:48.0 +0200
@@ -23,7 +23,7 @@
BuildRequires: rpm-python xz
Summary:Rpm correctness checker
Version:1.2
-Release:3
+Release:5
Source0:http://rpmlint.zarb.org/download/rpmlint-%{version}.tar.xz
Source1:config
Source1001: config.in
@@ -65,7 +65,8 @@
Patch2: suse-version.diff
Patch3: suse-url-check.diff
Patch4: invalid-filerequires.diff
-Patch5: suse-bzip-bigger-than-100k.diff
+# disable
+#Patch5: suse-bzip-bigger-than-100k.diff
Patch6: suse-filesystem.diff
Patch7: suse-pkg-config-check.diff
Patch8: suse-binarieschecks.diff
@@ -149,7 +150,7 @@
%patch2
%patch3
%patch4
-%patch5
+#patch5
%patch6
%patch7
%patch8
++ config ++
--- /var/tmp/diff_new_pack.MgCkGh/_old 2011-05-25 09:44:48.0 +0200
+++ /var/tmp/diff_new_pack.MgCkGh/_new 2011-05-25 09:44:48.0 +0200
@@ -63,6 +63,7 @@
#setOption(ReleaseExtension, None)
#setOption(ValidGroups, (Group1, Group2))
#setOption(KernelModuleRPMsOK, 0)
+setOption(CompressExtension, None)
setOption('StandardGroups', (
'aegis',
Remember to have fun...
--
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org
commit rpmlint for openSUSE:Factory
Hello community,
here is the log from the commit of package rpmlint for openSUSE:Factory
checked in at Mon May 23 14:16:04 CEST 2011.
--- rpmlint/rpmlint.changes 2011-05-20 10:04:51.0 +0200
+++ /mounts/work_src_done/STABLE/rpmlint/rpmlint.changes2011-05-20
16:48:08.0 +0200
@@ -1,0 +2,6 @@
+Fri May 20 14:47:40 UTC 2011 - lnus...@suse.de
+
+- add synche-connector (bnc#683956) to dbus whitelist
+- update system-config-printer (bnc#694640) in dbus whiteliste
+
+---
calling whatdependson for head-i586
Other differences:
--
++ rpmlint.spec ++
--- /var/tmp/diff_new_pack.tbEeeI/_old 2011-05-23 12:49:58.0 +0200
+++ /var/tmp/diff_new_pack.tbEeeI/_new 2011-05-23 12:49:58.0 +0200
@@ -23,7 +23,7 @@
BuildRequires: rpm-python xz
Summary:Rpm correctness checker
Version:1.2
-Release:1
+Release:3
Source0:http://rpmlint.zarb.org/download/rpmlint-%{version}.tar.xz
Source1:config
Source1001: config.in
++ config ++
--- /var/tmp/diff_new_pack.tbEeeI/_old 2011-05-23 12:49:58.0 +0200
+++ /var/tmp/diff_new_pack.tbEeeI/_new 2011-05-23 12:49:58.0 +0200
@@ -314,9 +314,9 @@
# gconf2
org.gnome.GConf.Defaults.service,
org.gnome.GConf.Defaults.conf,
-# system-config-printer
-newprinternotification.conf,
-printerdriversinstaller.conf,
+# system-config-printer (bnc#694640)
+com.redhat.NewPrinterNotification.conf,
+com.redhat.PrinterDriversInstaller.conf,
# rtkit
org.freedesktop.RealtimeKit1.conf,
org.freedesktop.RealtimeKit1.service,
@@ -420,6 +420,9 @@
# account services (bnc#676638)
org.freedesktop.Accounts.service,
org.freedesktop.Accounts.conf,
+# synche-connector (bnc#683956)
+org.synce.dccm.service,
+org.synce.dccm.conf,
))
# Output filters
Remember to have fun...
--
To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org
For additional commands, e-mail: opensuse-commit+h...@opensuse.org
commit rpmlint for openSUSE:Factory
Hello community,
here is the log from the commit of package rpmlint for openSUSE:Factory
checked in at Wed May 18 11:23:38 CEST 2011.
--- rpmlint/rpmlint.changes 2011-05-11 14:31:54.0 +0200
+++ /mounts/work_src_done/STABLE/rpmlint/rpmlint.changes2011-05-17
12:42:52.0 +0200
@@ -1,0 +2,6 @@
+Tue May 17 09:41:43 UTC 2011 - lnus...@suse.de
+
+- update rpmlint-pie.diff and suse-file-var-run.diff with upstream
+ accepted variant
+
+---
calling whatdependson for head-i586
New:
rpmlint-typo.diff
Other differences:
--
++ rpmlint.spec ++
--- /var/tmp/diff_new_pack.qlXPww/_old 2011-05-18 11:23:05.0 +0200
+++ /var/tmp/diff_new_pack.qlXPww/_new 2011-05-18 11:23:05.0 +0200
@@ -23,7 +23,7 @@
BuildRequires: rpm-python
Summary:Rpm correctness checker
Version:1.1
-Release:35
+Release:37
Source0:%{name}-%{version}.tar.bz2
Source1:config
Source1001: config.in
@@ -71,6 +71,7 @@
Patch8: suse-binarieschecks.diff
Patch9: no-doc-for-lib.diff
Patch10:add-scoring-support.diff
+# accepted upstream
Patch11:suse-file-var-run.diff
Patch12:usr-arch.diff
Patch13:script-interpreter-only-for-exec-scripts.diff
@@ -122,10 +123,13 @@
Patch84:extend-suse-conffiles-check.diff
Patch85:suse-changelog.patch
Patch86:suse-rclink-check.diff
-# already upstream
+# accepted upstream
Patch87:rpmlint-add-details.diff
Patch88:suse-speccheck-utf8.diff
+# accepted upstream
Patch89:rpmlint-pie.diff
+# accepted upstream
+Patch90:rpmlint-typo.diff
%py_requires
%description
@@ -206,6 +210,7 @@
%patch87 -p1
%patch88
%patch89 -p1
+%patch90 -p1
cp -p %{SOURCE1} .
cp -p %{SOURCE2} .
cp -p %{SOURCE3} .
++ pie.config ++
--- /var/tmp/diff_new_pack.qlXPww/_old 2011-05-18 11:23:05.0 +0200
+++ /var/tmp/diff_new_pack.qlXPww/_new 2011-05-18 11:23:05.0 +0200
@@ -3,8 +3,7 @@
# This file should list daemons and programs that are likely to be set setuid
# by users. Files listed in permissions.eays are automatically checked.
-setOption(PieExecutables,
-(
+pie_execs = (
/bin/ping,
/bin/ping6,
/bin/su,
@@ -231,4 +230,5 @@
/usr/sbin/ypserv,
/usr/bin/zone2ldap,
)
-)
+
+setOption('PieExecutables', '^(?:%s)$' % '|'.join(pie_execs))
++ rpmlint-pie.diff ++
--- /var/tmp/diff_new_pack.qlXPww/_old 2011-05-18 11:23:05.0 +0200
+++ /var/tmp/diff_new_pack.qlXPww/_new 2011-05-18 11:23:05.0 +0200
@@ -1,56 +1,61 @@
-From cdf3d7e6338e8133d9b2b8f19de8e5a3308327bc Mon Sep 17 00:00:00 2001
-From: Ludwig Nussel ludwig.nus...@suse.de
-Date: Mon, 9 May 2011 11:54:48 +0200
-Subject: [PATCH] check for position independent executables
+From 6eedb2e510533cb196f37803b78ca64c0d0a77d4 Mon Sep 17 00:00:00 2001
+From: scop scop@9bc8b190-ac0f-0410-8968-dc7d1f502856
+Date: Sun, 15 May 2011 09:05:04 +
+Subject: [PATCH] Check for position independent executables (based on patch by
Ludwig Nussel).
+git-svn-id: http://rpmlint.zarb.org/svn/trunk@1865
9bc8b190-ac0f-0410-8968-dc7d1f502856
---
- BinariesCheck.py | 11 +++
+ BinariesCheck.py | 10 ++
config |4
- 2 files changed, 15 insertions(+), 0 deletions(-)
+ 2 files changed, 14 insertions(+), 0 deletions(-)
Index: rpmlint-1.1/BinariesCheck.py
===
--- rpmlint-1.1.orig/BinariesCheck.py
+++ rpmlint-1.1/BinariesCheck.py
-@@ -25,6 +25,9 @@ DEFAULT_SYSTEM_LIB_PATHS = (
- '/lib', '/usr/lib', '/usr/X11R6/lib',
- '/lib64', '/usr/lib64', '/usr/X11R6/lib64')
-
-+DEFAULT_PIE_EXECUTABLES = (
-+)
-+
- class BinaryInfo:
-
- needed_regex = re.compile('\s+\(NEEDED\).*\[(\S+)\]')
-@@ -189,6 +192,7 @@ so_regex = re.compile('/lib(64)?/[^/]+\.
+@@ -189,6 +189,8 @@ so_regex = re.compile('/lib(64)?/[^/]+\.
validso_regex = re.compile('(\.so\.\d+(\.\d+)*|\d\.so)$')
sparc_regex = re.compile('SPARC32PLUS|SPARC V9|UltraSPARC')
system_lib_paths = Config.getOption('SystemLibPaths',
DEFAULT_SYSTEM_LIB_PATHS)
-+pie_executables = Config.getOption('PieExecutables', DEFAULT_PIE_EXECUTABLES)
++pie_exec_re = Config.getOption('PieExecutables')
++if pie_exec_re: pie_exec_re = re.compile(pie_exec_re)
usr_lib_regex = re.compile('^/usr/lib(64)?/')
bin_regex = re.compile('^(/usr(/X11R6)?)?/s?bin/')
soversion_regex =
re.compile('.*?([0-9][.0-9]*)\\.so|.*\\.so\\.([0-9][.0-9]*).*')
-@@ -377,6 +381,9 @@ class BinariesCheck(AbstractCheck.Abstra
+@@ -377,6 +379,11 @@ class BinariesCheck(AbstractCheck.Abstra
if not is_exec and not is_shobj:
continue
-+if fname in pie_executables and not is_shobj:
-+printError(pkg,
commit rpmlint for openSUSE:Factory
Hello community,
here is the log from the commit of package rpmlint for openSUSE:Factory
checked in at Mon May 16 11:33:47 CEST 2011.
--- rpmlint/rpmlint.changes 2011-05-05 09:16:21.0 +0200
+++ /mounts/work_src_done/STABLE/rpmlint/rpmlint.changes2011-05-11
14:31:54.0 +0200
@@ -1,0 +2,12 @@
+Wed May 11 11:25:33 UTC 2011 - lnus...@suse.de
+
+- don't filter non-standard-gid anymore
+- add dir-or-file-in-var-lock check
+- remove 'nobody' from standard users
+
+---
+Tue May 10 11:38:05 UTC 2011 - lnus...@suse.de
+
+- add not-a-position-independent-executable check
+
+---
calling whatdependson for head-i586
New:
pie.config
rpmlint-pie.diff
Other differences:
--
++ rpmlint.spec ++
--- /var/tmp/diff_new_pack.Xnh5Rj/_old 2011-05-16 11:31:42.0 +0200
+++ /var/tmp/diff_new_pack.Xnh5Rj/_new 2011-05-16 11:31:42.0 +0200
@@ -23,7 +23,7 @@
BuildRequires: rpm-python
Summary:Rpm correctness checker
Version:1.1
-Release:33
+Release:35
Source0:%{name}-%{version}.tar.bz2
Source1:config
Source1001: config.in
@@ -49,6 +49,7 @@
Source21: BashismsCheck.py
Source22: CheckGNOMEMacros.py
Source23: CheckBuildDate.py
+Source24: pie.config
Source100: syntax-validator.py
Url:http://rpmlint.zarb.org/
License:GPLv2+
@@ -124,6 +125,7 @@
# already upstream
Patch87:rpmlint-add-details.diff
Patch88:suse-speccheck-utf8.diff
+Patch89:rpmlint-pie.diff
%py_requires
%description
@@ -150,7 +152,7 @@
%patch8
%patch9
#%patch10
-%patch11
+%patch11 -p1
%patch12
%patch13
%patch14
@@ -203,6 +205,7 @@
%patch86
%patch87 -p1
%patch88
+%patch89 -p1
cp -p %{SOURCE1} .
cp -p %{SOURCE2} .
cp -p %{SOURCE3} .
@@ -238,6 +241,7 @@
# make sure that the package is sane
python -tt %{SOURCE100} $RPM_BUILD_ROOT/usr/share/rpmlint/*.py
$RPM_BUILD_ROOT/usr/share/rpmlint/config
%__install -m 644 %{SOURCE20} %{buildroot}/%{_sysconfdir}/rpmlint/
+%__install -m 644 %{SOURCE24} %{buildroot}/%{_sysconfdir}/rpmlint/
%clean
rm -rf $RPM_BUILD_ROOT
@@ -249,6 +253,7 @@
%{_prefix}/share/rpmlint
%config(noreplace) /etc/rpmlint/config
%config %{_sysconfdir}/rpmlint/rpmgroups.config
+%config %{_sysconfdir}/rpmlint/pie.config
%dir /etc/rpmlint
/usr/share/man/man1/rpmlint.1.gz
++ BashismsCheck.py ++
--- /var/tmp/diff_new_pack.Xnh5Rj/_old 2011-05-16 11:31:42.0 +0200
+++ /var/tmp/diff_new_pack.Xnh5Rj/_new 2011-05-16 11:31:42.0 +0200
@@ -28,9 +28,12 @@
status, output = Pkg.getstatusoutput([dash, -n, filename])
if status == 2:
printWarning(pkg, bin-sh-syntax-error, filename)
-status, output = Pkg.getstatusoutput([checkbashisms,
filename])
-if status == 1:
-printInfo(pkg, potential-bashisms, filename)
+try:
+status, output = Pkg.getstatusoutput([checkbashisms,
filename])
+if status == 1:
+printInfo(pkg, potential-bashisms, filename)
+except Exception, x:
+printError(pkg, 'rpmlint-exception', %(file)s raised an
exception: %(x)s % {'file':filename, 'x':x})
finally:
f.close()
++ CheckSUIDPermissions.py ++
--- /var/tmp/diff_new_pack.Xnh5Rj/_old 2011-05-16 11:31:42.0 +0200
+++ /var/tmp/diff_new_pack.Xnh5Rj/_new 2011-05-16 11:31:42.0 +0200
@@ -135,6 +135,10 @@
else:
f += '/'
+if type == 010:
+if not 'shared object' in pkgfile.magic:
+printError(pkg,
'not-a-position-independent-executable', f)
+
m = self.perms[f]['mode']
o = self.perms[f]['owner']
@@ -159,6 +163,10 @@
else:
printWarning(pkg, 'permissions-directory-setuid-bit',
msg)
+if type == 010:
+if not 'shared object' in pkgfile.magic:
+printError(pkg,
'not-a-position-independent-executable', f)
+
if mode02:
need_verifyscript = True
printError(pkg, 'permissions-world-writable', \
++ config ++
--- /var/tmp/diff_new_pack.Xnh5Rj/_old 2011-05-16 11:31:42.0 +0200
+++ /var/tmp/diff_new_pack.Xnh5Rj/_new 2011-05-16 11:31:42.0 +0200
@@ -139,6 +139,7 @@
'pulse-rt',
'quagga',
'radiusd',
+'root',
'sabayon-admin',
'sapdb',
'shadow',
@@ -217,7 +218,6 @@
'nagios',
'named',
'news',
-'nobody',
commit rpmlint for openSUSE:Factory
Hello community,
here is the log from the commit of package rpmlint for openSUSE:Factory
checked in at Mon May 2 17:31:26 CEST 2011.
--- rpmlint/rpmlint.changes 2011-04-23 11:26:24.0 +0200
+++ rpmlint/rpmlint.changes 2011-05-02 16:17:12.0 +0200
@@ -1,0 +2,21 @@
+Mon May 2 14:17:04 UTC 2011 - lnus...@suse.de
+
+- add account services (bnc#676638)
+
+---
+Mon May 2 11:56:25 UTC 2011 - lnus...@suse.de
+
+- another try to fix InitScriptCheck.py (bnc#690961)
+
+---
+Wed Apr 27 15:09:54 CEST 2011 - dmuel...@suse.de
+
+- implement setFilterException()
+- rediff noarch-lib64.diff and enable it again (bnc#663885)
+
+---
+Tue Apr 26 15:19:36 CEST 2011 - dmuel...@suse.de
+
+- make error description more clearn (bnc#686328)
+
+---
calling whatdependson for head-i586
New:
suse-filter-exception.diff
suse-speccheck-utf8.diff
Other differences:
--
++ rpmlint.spec ++
--- /var/tmp/diff_new_pack.dQQ8aG/_old 2011-05-02 17:29:24.0 +0200
+++ /var/tmp/diff_new_pack.dQQ8aG/_new 2011-05-02 17:29:24.0 +0200
@@ -23,7 +23,7 @@
BuildRequires: rpm-python
Summary:Rpm correctness checker
Version:1.1
-Release:29
+Release:31
Source0:%{name}-%{version}.tar.bz2
Source1:config
Source1001: config.in
@@ -74,6 +74,7 @@
Patch12:usr-arch.diff
Patch13:script-interpreter-only-for-exec-scripts.diff
Patch14:sourced-dirs.diff
+Patch15:suse-filter-exception.diff
Patch17:docdata-examples.diff
Patch19:yast-provides.diff
Patch20:xdg-paths-update.diff
@@ -122,6 +123,7 @@
Patch86:suse-rclink-check.diff
# already upstream
Patch87:rpmlint-add-details.diff
+Patch88:suse-speccheck-utf8.diff
%py_requires
%description
@@ -152,6 +154,7 @@
%patch12
%patch13
%patch14
+%patch15
%patch17
%patch19
%patch20
@@ -171,7 +174,7 @@
#%patch41
%patch42
#%patch46
-#%patch47
+%patch47
#%patch49
%patch50
%patch51
@@ -199,6 +202,7 @@
%patch85
%patch86
%patch87 -p1
+%patch88
cp -p %{SOURCE1} .
cp -p %{SOURCE2} .
cp -p %{SOURCE3} .
++ config ++
--- /var/tmp/diff_new_pack.dQQ8aG/_old 2011-05-02 17:29:25.0 +0200
+++ /var/tmp/diff_new_pack.dQQ8aG/_new 2011-05-02 17:29:25.0 +0200
@@ -414,6 +414,9 @@
# urfkill (bnc#688328)
org.freedesktop.URfkill.service,
org.freedesktop.URfkill.conf,
+# account services (bnc#676638)
+org.freedesktop.Accounts.service,
+org.freedesktop.Accounts.conf,
))
# Output filters
++ noarch-lib64.diff ++
--- /var/tmp/diff_new_pack.dQQ8aG/_old 2011-05-02 17:29:25.0 +0200
+++ /var/tmp/diff_new_pack.dQQ8aG/_new 2011-05-02 17:29:25.0 +0200
@@ -1,43 +1,39 @@
--- BinariesCheck.py
+++ BinariesCheck.py
-@@ -153,6 +153,7 @@ class BinariesCheck(AbstractCheck.AbstractCheck):
- binary=0
- binary_in_usr_lib=0
- has_usr_lib_file=0
-+file_in_lib64=0
+@@ -223,6 +223,7 @@
+ binary = False
+ binary_in_usr_lib = False
+ has_usr_lib_file = False
++file_in_lib64 = False
+ multi_pkg = False
res = srcname_regex.search(pkg[rpm.RPMTAG_SOURCERPM] or '')
- if res:
-@@ -161,10 +162,13 @@ class BinariesCheck(AbstractCheck.AbstractCheck):
- multi_pkg=0
-
- for f in files:
--if usr_lib_regex.search(f) and not
usr_lib_exception_regex.search(f) and not stat.S_ISDIR(files[f][0]):
-+if stat.S_ISREG(files[f][0]) and usr_lib_regex.search(f) and not
usr_lib_exception_regex.search(f):
- has_usr_lib_file=f
- break
-
-+if stat.S_ISREG(files[f][0]) and (f.startswith(/usr/lib64) or
f.startswith(/lib64)):
-+file_in_lib64=1
+@@ -239,6 +240,10 @@
+ # only-non-binary-in-usr-lib false positives
+ binary_in_usr_lib = True
+
++if stat.S_ISREG(pkgfile.mode) and \
++(fname.startswith(/usr/lib64) or
fname.startswith(/lib64)):
++file_in_lib64 = True
+
- for i in info:
- is_elf = string.find(i[1], 'ELF') != -1
- is_ar = string.find(i[1], 'current ar archive') != -1
-@@ -316,9 +320,12 @@ class BinariesCheck(AbstractCheck.AbstractCheck):
+ is_elf = 'ELF' in pkgfile.magic
+ is_ar = 'current ar archive' in pkgfile.magic
+ is_ocaml_native = 'Objective caml native' in pkgfile.magic
+@@ -433,9 +438,12 @@
+ if version and version != -1 and version not in pkg.name:
commit rpmlint for openSUSE:Factory
Hello community,
here is the log from the commit of package rpmlint for openSUSE:Factory
checked in at Tue Apr 26 16:54:21 CEST 2011.
--- rpmlint/rpmlint.changes 2011-04-21 15:01:05.0 +0200
+++ /mounts/work_src_done/STABLE/rpmlint/rpmlint.changes2011-04-23
11:26:24.0 +0200
@@ -1,0 +2,6 @@
+Sat Apr 23 11:11:37 CEST 2011 - dmuel...@suse.de
+
+- fix abort in BinariesCheck
+- fix sysv5-init-check.diff for real
+
+---
calling whatdependson for head-i586
Other differences:
--
++ rpmlint.spec ++
--- /var/tmp/diff_new_pack.yvc8kJ/_old 2011-04-26 16:53:39.0 +0200
+++ /var/tmp/diff_new_pack.yvc8kJ/_new 2011-04-26 16:53:39.0 +0200
@@ -23,7 +23,7 @@
BuildRequires: rpm-python
Summary:Rpm correctness checker
Version:1.1
-Release:27
+Release:29
Source0:%{name}-%{version}.tar.bz2
Source1:config
Source1001: config.in
++ suse-binarieschecks.diff ++
--- /var/tmp/diff_new_pack.yvc8kJ/_old 2011-04-26 16:53:39.0 +0200
+++ /var/tmp/diff_new_pack.yvc8kJ/_new 2011-04-26 16:53:39.0 +0200
@@ -1,8 +1,6 @@
-Index: BinariesCheck.py
-===
BinariesCheck.py.orig
+--- BinariesCheck.py
+++ BinariesCheck.py
-@@ -10,6 +10,7 @@
+@@ -10,13 +10,15 @@
import re
import stat
@@ -10,7 +8,8 @@
import rpm
-@@ -17,6 +18,7 @@ from Filter import addDetails, printErro
+-from Filter import addDetails, printError, printWarning
++from Filter import addDetails, printError, printWarning, printInfo
import AbstractCheck
import Config
import Pkg
@@ -18,7 +17,7 @@
DEFAULT_SYSTEM_LIB_PATHS = (
-@@ -37,6 +39,9 @@ class BinaryInfo:
+@@ -37,6 +39,9 @@
unused_regex = re.compile('^\s+(\S+)')
exit_call_regex = re.compile('\s+FUNC\s+.*?\s+(_?exit(?:@\S+)?)(?:\s|$)')
fork_call_regex = re.compile('\s+FUNC\s+.*?\s+(fork(?:@\S+)?)(?:\s|$)')
@@ -28,7 +27,7 @@
def __init__(self, pkg, path, file, is_ar, is_shlib):
self.readelf_error = False
-@@ -50,7 +55,10 @@ class BinaryInfo:
+@@ -50,7 +55,10 @@
self.stack = False
self.exec_stack = False
self.exit_calls = []
@@ -39,7 +38,7 @@
self.tail = ''
is_debug = path.endswith('.debug')
-@@ -93,6 +101,11 @@ class BinaryInfo:
+@@ -93,6 +101,11 @@
self.exec_stack = True
continue
@@ -51,7 +50,7 @@
if is_shlib:
r = BinaryInfo.exit_call_regex.search(l)
if r:
-@@ -103,6 +116,14 @@ class BinaryInfo:
+@@ -103,6 +116,14 @@
fork_called = True
continue
@@ -66,7 +65,7 @@
if self.non_pic:
self.non_pic = 'TEXTREL' in res[1]
-@@ -263,13 +284,26 @@ class BinariesCheck(AbstractCheck.Abstra
+@@ -263,13 +284,26 @@
continue
# stripped ?
@@ -94,7 +93,7 @@
if is_shlib:
has_lib = True
-@@ -319,6 +353,10 @@ class BinariesCheck(AbstractCheck.Abstra
+@@ -319,6 +353,10 @@
for ec in bin_info.exit_calls:
printWarning(pkg, 'shared-lib-calls-exit', fname, ec)
@@ -105,7 +104,7 @@
# rpath ?
if bin_info.rpath:
for p in bin_info.rpath:
-@@ -504,6 +542,14 @@ with the intended shared libraries only.
+@@ -504,6 +542,14 @@
'ldd-failed',
'''Executing ldd on this file failed, all checks could not be run.''',
@@ -120,7 +119,7 @@
'executable-stack',
'''The binary declares the stack as executable. Executable stack is usually
an
error as it is only needed if the code contains GCC trampolines or similar
-@@ -516,6 +562,10 @@ don\'t define a proper .note.GNU-stack s
+@@ -516,6 +562,10 @@
make the stack executable. Usual suspects include use of a non-GNU linker or
an old GNU linker version.''',
@@ -131,7 +130,7 @@
'shared-lib-calls-exit',
'''This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
-@@ -533,6 +583,12 @@ form, make sure that rpmbuild does not s
+@@ -533,6 +583,12 @@
that use prelink, make sure that prelink does not strip it either, usually by
placing a blacklist file in /etc/prelink.conf.d. For more information, see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=256900#49''',
++ sysv5-init-checks.diff ++
--- /var/tmp/diff_new_pack.yvc8kJ/_old 2011-04-26 16:53:39.0 +0200
+++ /var/tmp/diff_new_pack.yvc8kJ/_new 2011-04-26 16:53:39.0 +0200
@@ -1,8 +1,6 @@
-Index: InitScriptCheck.py
-===
InitScriptCheck.py.orig
