Re: [Openvpn-devel] [PATCH 06/10] PolarSSL x509_get_sha1_hash now returns correct SHA1 fingerprint.

2016-04-28 Thread Arne Schwabe
Am 04.04.16 um 23:01 schrieb Steffan Karger:
> Hi list,
> 
> I just noticed I sent my previous reply only to James, instead of to
> the list.  See below.
> 

ACK. Also code identical to James and only docu added.

Arne




Re: [Openvpn-devel] [PATCH 07/10] Implemented x509-track for PolarSSL.

2016-04-28 Thread Arne Schwabe
Am 09.03.16 um 00:10 schrieb Steffan Karger:
> Hi,
> 
> This addition is welcome and the code does the job it promises to do,
> but after reviewing the code I would like to propose a different
> implementation.  The reasons for this are gives as inline replies
> below.  The alternative patch proposal is attached.

Code looks good to me, ACK.

Arne




[Openvpn-devel] [PATCH applied] Re: PolarSSL x509_get_sha1_hash now returns correct SHA1 fingerprint.

2016-04-28 Thread Gert Doering
Your patch has been applied to the master branch.  

(Changes.rst had to be manually applied as it conflicted with an 
intermediate change)

commit dd2fbc26eb7b32325793ae3f7d215f46e881e68c (master)
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Mon Apr 4 21:59:38 2016 +0200

 PolarSSL x509_get_sha1_hash now returns correct SHA1 fingerprint.

 Signed-off-by: James Yonan 
 Signed-off-by: Steffan Karger 
 Acked-by: Arne Schwabe 
 Message-Id: 

 URL: http://article.gmane.org/gmane.network.openvpn.devel/11396
 Signed-off-by: Gert Doering 


--
kind regards,

Gert Doering




[Openvpn-devel] [PATCH applied] Re: Implemented x509-track for PolarSSL.

2016-04-28 Thread Gert Doering
Your patch has been applied to the master branch.

commit fab49d17d36053189cf504d57e53a8b0cb907f6f
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Sat Mar 5 17:08:22 2016 +0100

 Implemented x509-track for PolarSSL.

 Signed-off-by: Steffan Karger 
 Acked-by: Arne Schwabe 
 Message-Id: 

 URL: http://article.gmane.org/gmane.network.openvpn.devel/11350
 Signed-off-by: Gert Doering 


--
kind regards,

Gert Doering




[Openvpn-devel] [PATCH applied] Re: Migrate to mbed TLS 2.x

2016-04-28 Thread Gert Doering
Your patch has been applied to the master branch.

(One minor whitespace fix to configure.ac)

Just to point it out here again, in case someone is frustrated and googles
for it: mbedTLS 2.x refuses RSA keys < 2048 bits by default - so if your
setup is nicely working with shorter RSA keys and PolarSSL 1.3 today, 
this commit *will break it* - and it won't tell you why ("VERIFY FAILED"
is all you get).  A patch with a more helpful error message is forthcoming.


commit 86d8cd6860dfc74cb1a040ff8fe03140ebe7f930
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Sun Apr 17 20:35:42 2016 +0200

 Migrate to mbed TLS 2.x

 Signed-off-by: Steffan Karger 
 Acked-by: Arne Schwabe 
 Message-Id: <1460918143-408-1-git-send-email-stef...@karger.me>
 URL: http://article.gmane.org/gmane.network.openvpn.devel/11458
 Signed-off-by: Gert Doering 


--
kind regards,

Gert Doering




[Openvpn-devel] [PATCH applied] Re: Rename files with 'polarssl' in the name to 'mbedtls'

2016-04-28 Thread Gert Doering
Your patch has been applied to the master branch.

commit 74586c6508e5dd283eaef9d098644a7800beec01
Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Sun Apr 17 20:35:43 2016 +0200

 Rename files with 'polarssl' in the name to 'mbedtls'

 Signed-off-by: Steffan Karger 
 Acked-by: Arne Schwabe 
 Message-Id: <1460918143-408-2-git-send-email-stef...@karger.me>
 URL: http://article.gmane.org/gmane.network.openvpn.devel/11459
 Signed-off-by: Gert Doering 


--
kind regards,

Gert Doering




Re: [Openvpn-devel] [PATCH] Added client-ip option to NAT

2016-04-28 Thread Arne Schwabe
Am 28.04.16 um 04:01 schrieb Rafael Gava:
> Hi Arne, 
> 
> what a surprise I thought that the NAT patch had been dropped. :-)

More or less forgotten. IIrc the active FTP part was controversal. This
part is okay.

> So, please, should I change the code based on your comments and resend
> the patch?

Yes, please.

Arne