Re: [Openvpn-devel] [PATCH applied] Re: Add a unit test for functions in cryptoapi.c
Hi,
On Sat, Feb 25, 2023 at 12:23:42PM -0500, Selva Nair wrote:
> > OTOH, there might be a bit of polishing needed - the other tests
> > print out what they are doing ("Running 7 test(s)"), while the
> > cryptoapi unit test "just succeeds". Is there something missing
> > wrt cmocka initalization?
[..]
> That one is for OpenSSL 1.1.1 while this test is built only for OpenSSL3,
> so nothing to run. Do we need to continue testing Windows builds of 2.6 for
> OpenSSL 1.1?
Ah. Indeed, I saw the #ifdef in the code, but then looked in the wrong
test result.
Thanks for enlightening me (again).
Arne, indeed, this sounds as if we shouldn't run these test units on
mingw + 1.1.1 builds. Just confusing people, like, me.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH applied] Re: Add a unit test for functions in cryptoapi.c
Hi
On Sat, Feb 25, 2023 at 11:29 AM Gert Doering wrote:
> Acked-by: Gert Doering
>
> Thanks for the v4. This enabled me to just push to GH to have
> to build and run the tests, without having to bother myself with
> copying binaries around :-)
>
> OTOH, there might be a bit of polishing needed - the other tests
> print out what they are doing ("Running 7 test(s)"), while the
> cryptoapi unit test "just succeeds". Is there something missing
> wrt cmocka initalization?
> https://github.com/cron2/openvpn/actions/runs/4270790193/jobs/7434873211
That one is for OpenSSL 1.1.1 while this test is built only for OpenSSL3,
so nothing to run. Do we need to continue testing Windows builds of 2.6 for
OpenSSL 1.1?
Logs for OpenSSL 3 build look okay:
>
https://github.com/OpenVPN/openvpn/actions/runs/4270860888/jobs/7434989645#logs
>
Run ./unittests/cryptoapi_testdriver.exe
> 4[==] Running 1 test(s).
> 5[ RUN ] test_parse_hexstring
> 6[ OK ] test_parse_hexstring
> 7[ PASSED ] 1 test(s).
> 8[==] 1 test(s) run.
Selva
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH applied] Re: configure: fix formatting of --disable-lz4 and --enable-comp-stub
Acked-by: Gert Doering
"Makes sense".
Before:
--disable-lzo disable LZO compression support [default=yes]
--disable-lz4 Disable LZ4 compression support
--enable-comp-stub Don't compile compression support but still allow
limited interoperability with compression-enabled peers
After:
--disable-lzo disable LZO compression support [default=yes]
--disable-lz4 disable LZ4 compression support [default=yes]
--enable-comp-stub disable compression support but still allow limited
interoperability with compression-enabled peers
("default=yes" is still confusing - does that mean "enabled by default" or
"disabled=yes by default"?, but that seems to be "the autoconf way")
Your patch has been applied to the master and release/2.6 branch.
commit 24e1d8ff87b189247d56261a9497b1f509b286df (master)
commit 91da6b9463745635b75df171678ab54b5dcdb0de (release/2.6)
Author: Frank Lichtenheld
Date: Mon Feb 6 14:08:46 2023 +0100
configure: fix formatting of --disable-lz4 and --enable-comp-stub
Signed-off-by: Frank Lichtenheld
Acked-by: Gert Doering
Message-Id: <20230206130846.63415-1-fr...@lichtenheld.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26156.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH applied] Re: Windows: fix signedness errors with recv/send
Acked-by: Gert Doering I'm not a big fan of adding (cast) to silence compiler warnings, but this signed/unsigned char * nonsense is really hard to avoid - casting to (void *) is the right fix here. I have only test compiled on MinGW - and my MinGW did not warn about these anyway (maybe not enough -Wthing switches). But it did not break anything, and does not introduce new warnings. Your patch has been applied to the master and release/2.6 branch. commit 7acd93a6bef2dd9b660571c29b5f41c8ca351161 (master) commit e9ae7cee2ca9b9ab78de01f1d3c562610e5624d2 (release/2.6) Author: Frank Lichtenheld Date: Fri Feb 3 20:14:40 2023 +0100 Windows: fix signedness errors with recv/send Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20230203191440.136050-6-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26144.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH applied] Re: Add a unit test for functions in cryptoapi.c
Acked-by: Gert Doering
Thanks for the v4. This enabled me to just push to GH to have
to build and run the tests, without having to bother myself with
copying binaries around :-)
OTOH, there might be a bit of polishing needed - the other tests
print out what they are doing ("Running 7 test(s)"), while the
cryptoapi unit test "just succeeds". Is there something missing
wrt cmocka initalization?
https://github.com/cron2/openvpn/actions/runs/4270790193/jobs/7434873211
I also did do a MinGW "make check" and it built the new test binary
just fine, and succeeded otherwise.
298368704 -rwxrwxr-x 1 gert gert 718042 Feb 25 16:10
./tests/unit_tests/openvpn/.libs/cryptoapi_testdriver.exe
The unit test itself looks reasonably complete in testing expected
and error-handling behaviour (v3->v4). Not much coverage beyond
"parse_hexstring()", but it's a good start to build upon :-)
Your patch has been applied to the master and release/2.6 branch.
commit 8aff5655a51d9f9f67ca31b363d4ebaf5342d410 (master)
commit 094aea56ce20d0bb6fe79e6e14a3dfe68ea11786 (release/2.6)
Author: Selva Nair
Date: Tue Feb 14 15:08:04 2023 -0500
Add a unit test for functions in cryptoapi.c
Signed-off-by: Selva Nair
Acked-by: Gert Doering
Message-Id: <20230214200804.600405-1-selva.n...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26268.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH applied] Re: Add logging for windows driver selection process
Acked-by: Gert Doering While I do have no idea about windows drivers and such, having some helpful debug output for "adapter not found" issues is good. I have stared at the code for a bit, and it's all fairly trivial msg()'ing of strings and integers (plus an M_ERRNO added in one of the error paths). MinGW compile says "it's the correct data types for each msg() call", so, good enough for me :-) Your patch has been applied to the master and release/2.6 branch. commit 5b748ad099ed69b893124e2805b5ddeb6b0ec8fc (master) commit dff1e78957fa97b3258d5e1b0ef05ad3f853ada2 (release/2.6) Author: Lev Stipakov Date: Thu Feb 16 18:01:29 2023 +0200 Add logging for windows driver selection process Signed-off-by: Lev Stipakov Acked-by: Gert Doering Message-Id: <20230216160129.994-1-lstipa...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26281.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH applied] Re: configure: enable DCO by default on FreeBSD/Linux
This patch is identical to v3, except that it modifies the github actions to avoid GHA explosions on the linux workers. So recording Selva's and Antonio's ACKs of v3 here on v6. Pushed to GHA and buildbots, all of them are happy now. (We need to remember to add this to Changes.rst, as it might come as a surprise to people upgrading 2.6.0 -> 2.6.1 and building from source) Your patch has been applied to the master and release/2.6 branch. commit 2a1a21e3da3ec66d901864edd7b3b0e2498b3b0a (master) commit f63c9b1edbda41491ba2e05ff706bf0233903cb6 (release/2.6) Author: Frank Lichtenheld Date: Wed Feb 15 17:26:54 2023 +0100 configure: enable DCO by default on FreeBSD/Linux Signed-off-by: Frank Lichtenheld Acked-by: Selva Nair Acked-by: Antonio Quartulli Message-Id: <20230215162654.52137-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26272.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
