[Openvpn-devel] [PATCH] man: extend description for "dhcp-option DNS" on Windows
From: Antonio Quartulli Add an important detail about the DNS configured via this option to be an "interface-specific" DNS. This detail is important when troubleshooting DNS issues since this logic will bypass the routing table. Signed-off-by: Antonio Quartulli --- doc/man-sections/vpn-network-options.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/man-sections/vpn-network-options.rst b/doc/man-sections/vpn-network-options.rst index b7f33acd..17c7d4a2 100644 --- a/doc/man-sections/vpn-network-options.rst +++ b/doc/man-sections/vpn-network-options.rst @@ -158,6 +158,12 @@ routing. Set primary domain name server IPv4 or IPv6 address. Repeat this option to set secondary DNS server addresses. +On Windows this option sets an "interface-specific" DNS, meaning +that the system will try to reach it via the VPN interface, no +matter what the routing table says. If the wanted DNS is not +expected to be reached via VPN, please don't use this option, but +rather set the DNS manually (or via DHCP). + Note: DNS IPv6 servers are currently set using netsh (the existing DHCP code can only do IPv4 DHCP, and that protocol only permits IPv4 addresses anywhere). The option will be put into the -- 2.41.0 ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [S] Change in openvpn[master]: GHA: do not trigger builds in openvpn-build anymore
On Tue, Sep 05, 2023 at 07:22:46PM +0200, Gert Doering wrote: > Hi, > > On Tue, Sep 05, 2023 at 01:12:10PM +, flichtenheld (Code Review) wrote: > > GHA: do not trigger builds in openvpn-build anymore > > > > We do this via explicit PRs now, generated by renovate. > > This allows much better control over what state of the > > code gets built. > > Can you elaborate on this a bit more? I see lots of things flying by, > but do not understand any of it... Sure. We have the renovate GHA at https://github.com/OpenVPN/openvpn-build/actions/workflows/renovate.yaml That runs regularly and checks whether all of the dependencies of openvpn-build can be updated. There are three primary inputs for renovate (its "state"): 1) The openvpn-build git repository 2) The PRs in the openvpn-build github repository 3) The "Dependency Dashboard" issue in openvpn-build github repository (https://github.com/OpenVPN/openvpn-build/issues/386) In 3) you can see a list of dependencies renovate has detected. >From 1) renovate will determine which dependencies are out-of-date. It will then check 2) whether it has already created a branch and PR to update this dependency. It respects closed PRs. So if it created a PR previously and the PR was closed without merging it, it will not be recreated. So for example if you push something into OpenVPN/openvpn, then renovate will determine on the next run that the src/openvpn submodule in openvpn-build is out of date and open a PR to fix that. renovate tracks both master and release/2.6 and through the information in the .gitmodules knows which branch of OpenVPN/openvpn to look at. So if you push into both master and release/2.6, it will create two PRs, against master and release/2.6 in openvpn-build, respectively. So as a result, we get PRs (and through that PR builds) for every push into any of the dependent repositories. That gives us a much more detailed picture than we had before, when we just inside the GHA updated all of the repositories to their latest state and hoped that they work together. Hope this helps, -- Frank Lichtenheld ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [S] Change in openvpn[master]: GHA: do not trigger builds in openvpn-build anymore
Hi, On Tue, Sep 05, 2023 at 01:12:10PM +, flichtenheld (Code Review) wrote: > GHA: do not trigger builds in openvpn-build anymore > > We do this via explicit PRs now, generated by renovate. > This allows much better control over what state of the > code gets built. Can you elaborate on this a bit more? I see lots of things flying by, but do not understand any of it... gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Support for long INFO/INFO_PRE messages
Attention is currently required from: flichtenheld, stipa. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/327?usp=email ) Change subject: Support for long INFO/INFO_PRE messages .. Patch Set 2: (1 comment) Patchset: PS2: This is something that only affects the properitary Cloud implementation. OpenVPN 2.x will also never send longer URLs since we are currently limited by the MAX_PARAM_SIZE (=256) define on sending URLs to the client. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/327?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I2139b62117ba69d643b585d2610e8aef15f71d3e Gerrit-Change-Number: 327 Gerrit-PatchSet: 2 Gerrit-Owner: stipa Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-CC: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: stipa Gerrit-Comment-Date: Tue, 05 Sep 2023 13:46:58 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [S] Change in openvpn[master]: GHA: do not trigger builds in openvpn-build anymore
flichtenheld has uploaded this change for review. (
http://gerrit.openvpn.net/c/openvpn/+/328?usp=email )
Change subject: GHA: do not trigger builds in openvpn-build anymore
..
GHA: do not trigger builds in openvpn-build anymore
We do this via explicit PRs now, generated by renovate.
This allows much better control over what state of the
code gets built.
Change-Id: I8b00d7d79a26ad4aaae529cb496e125398169b50
Signed-off-by: Frank Lichtenheld
---
M .github/workflows/build.yaml
1 file changed, 0 insertions(+), 13 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/28/328/1
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 1b75a1a..58fbc29 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -290,19 +290,6 @@
!${{ github.workspace }}/out/**/CMakeFiles/**
!${{ github.workspace }}/out/**/vcpkg_installed/**
- trigger_openvpn_build:
-runs-on: windows-latest
-needs: [checkuncrustify, mingw, ubuntu, ubuntu-clang-asan, macos, msvc]
-if: ${{ github.event_name != 'pull_request' && github.repository ==
'openvpn/openvpn' && github.ref == 'refs/heads/master' }}
-
-steps:
-- name: Repository Dispatch
- uses: peter-evans/repository-dispatch@v2
- with:
-token: ${{ secrets.OPENVPN_BUILD_REPO_DISPATCH }}
-repository: openvpn/openvpn-build
-event-type: openvpn-commit
-
libressl:
strategy:
fail-fast: false
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/328?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8b00d7d79a26ad4aaae529cb496e125398169b50
Gerrit-Change-Number: 328
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-MessageType: newchange
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH] Fix StatusChangeCallback so it works without a LogCallback
On 05/09/2023 07:03, Jeremy Fleischman wrote: I have a feeling we're missing a check here. Got it! You're right, I've added that in the v2 version of this patch (see below). Could you send this via git-send-email, I think this is getting ready to be pulled in now. $ git send-email -v2 \ --in-reply-to 20230709231929.195048-1-jeremyfleisch...@gmail.com Thx! -- kind regards, David Sommerseth OpenVPN Inc ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
