Re: [Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic
On 26/06/12 16:03, Alon Bar-Lev wrote: > pam cannot be compiled on OpenBSD and Windows. > down-root cannot be compiled on Windows. > > Signed-off-by: Alon Bar-Lev > --- > configure.ac | 21 - > 1 files changed, 16 insertions(+), 5 deletions(-) > Applied to master. commit 5a57e201223f7265af0a56859b00aOn 26/06/12 16:03, Alon Bar-Lev wrote: 594b0d98f5b Author: Alon Bar-Lev List-Post: openvpn-devel@lists.sourceforge.net Date: Tue Jun 26 17:03:26 2012 +0300 build: plugins: set defaults based on platform pam cannot be compiled on OpenBSD and Windows. down-root cannot be compiled on Windows. Signed-off-by: Alon Bar-Lev Acked-by: Gert Doering Acked-by: Samuli Seppänen Message-Id: 1340719406-12157-1-git-send-email-alon.bar...@gmail.com URL: http://article.gmane.org/gmane.network.openvpn.devel/6795 Signed-off-by: David Sommerseth kind regards, David Sommerseth signature.asc Description: OpenPGP digital signature
Re: [Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic
Without this patch cross-compiling for Windows on Linux failed because --enable-plugin-pam/-down-root was on by default. With this patch building succeeded. ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > pam cannot be compiled on OpenBSD and Windows. > down-root cannot be compiled on Windows. > > Signed-off-by: Alon Bar-Lev > --- > configure.ac | 21 - > 1 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/configure.ac b/configure.ac > index db19d4a..d3d974d 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -195,16 +195,27 @@ AC_ARG_ENABLE( > > AC_ARG_ENABLE( > [plugin-auth-pam], > - [AS_HELP_STRING([--disable-plugin-auth-pam], [disable auth-pam plugin > @<:@default=yes@:>@])], > + [AS_HELP_STRING([--disable-plugin-auth-pam], [disable auth-pam plugin > @<:@default=platform specific@:>@])], > , > - [enable_plugin_auth_pam="yes"] > + [ > + case "$host" in > + *-*-openbsd*) enable_plugin_auth_pam="no";; > + *-mingw*) enable_plugin_auth_pam="no";; > + *) enable_plugin_auth_pam="yes";; > + esac > + ] > ) > > AC_ARG_ENABLE( > [plugin-down-root], > - [AS_HELP_STRING([--disable-plugin-down-root], [disable down-root plugin > @<:@default=yes@:>@])], > + [AS_HELP_STRING([--disable-plugin-down-root], [disable down-root plugin > @<:@default=platform specific@:>@])], > , > - [enable_plugin_down_root="yes"] > + [ > + case "$host" in > + *-mingw*) enable_plugin_down_root="no";; > + *) enable_plugin_down_root="yes";; > + esac > + ] > ) > > AC_ARG_ENABLE(
Re: [Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic
Hi, On Tue, Jun 26, 2012 at 05:03:26PM +0300, Alon Bar-Lev wrote: > pam cannot be compiled on OpenBSD and Windows. > down-root cannot be compiled on Windows. > > Signed-off-by: Alon Bar-Lev > --- > configure.ac | 21 - > 1 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/configure.ac b/configure.ac > index db19d4a..d3d974d 100644 Thanks, this looks good to me. (Yes, it's complex, but since my much simpler proposal of "if you can't find libpam, don't build the plugin" is unacceptable to you, this is how it will have to be) ACK for OpenBSD, but Samuli, please test for Windows. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de pgpmcwKsw7nkc.pgp Description: PGP signature
Re: [Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic
This removes the Linux from the help string. On Tue, Jun 26, 2012 at 5:03 PM, Alon Bar-Lev wrote: > pam cannot be compiled on OpenBSD and Windows. > down-root cannot be compiled on Windows. > > Signed-off-by: Alon Bar-Lev > --- > configure.ac | 21 - > 1 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/configure.ac b/configure.ac > index db19d4a..d3d974d 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -195,16 +195,27 @@ AC_ARG_ENABLE( > > AC_ARG_ENABLE( > [plugin-auth-pam], > - [AS_HELP_STRING([--disable-plugin-auth-pam], [disable auth-pam plugin > @<:@default=yes@:>@])], > + [AS_HELP_STRING([--disable-plugin-auth-pam], [disable auth-pam plugin > @<:@default=platform specific@:>@])], > , > - [enable_plugin_auth_pam="yes"] > + [ > + case "$host" in > + *-*-openbsd*) enable_plugin_auth_pam="no";; > + *-mingw*) enable_plugin_auth_pam="no";; > + *) enable_plugin_auth_pam="yes";; > + esac > + ] > ) > > AC_ARG_ENABLE( > [plugin-down-root], > - [AS_HELP_STRING([--disable-plugin-down-root], [disable down-root > plugin @<:@default=yes@:>@])], > + [AS_HELP_STRING([--disable-plugin-down-root], [disable down-root > plugin @<:@default=platform specific@:>@])], > , > - [enable_plugin_down_root="yes"] > + [ > + case "$host" in > + *-mingw*) enable_plugin_down_root="no";; > + *) enable_plugin_down_root="yes";; > + esac > + ] > ) > > AC_ARG_ENABLE( > -- > 1.7.3.4 >
[Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic
pam cannot be compiled on OpenBSD and Windows. down-root cannot be compiled on Windows. Signed-off-by: Alon Bar-Lev --- configure.ac | 21 - 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index db19d4a..d3d974d 100644 --- a/configure.ac +++ b/configure.ac @@ -195,16 +195,27 @@ AC_ARG_ENABLE( AC_ARG_ENABLE( [plugin-auth-pam], - [AS_HELP_STRING([--disable-plugin-auth-pam], [disable auth-pam plugin @<:@default=yes@:>@])], + [AS_HELP_STRING([--disable-plugin-auth-pam], [disable auth-pam plugin @<:@default=platform specific@:>@])], , - [enable_plugin_auth_pam="yes"] + [ + case "$host" in + *-*-openbsd*) enable_plugin_auth_pam="no";; + *-mingw*) enable_plugin_auth_pam="no";; + *) enable_plugin_auth_pam="yes";; + esac + ] ) AC_ARG_ENABLE( [plugin-down-root], - [AS_HELP_STRING([--disable-plugin-down-root], [disable down-root plugin @<:@default=yes@:>@])], + [AS_HELP_STRING([--disable-plugin-down-root], [disable down-root plugin @<:@default=platform specific@:>@])], , - [enable_plugin_down_root="yes"] + [ + case "$host" in + *-mingw*) enable_plugin_down_root="no";; + *) enable_plugin_down_root="yes";; + esac + ] ) AC_ARG_ENABLE( -- 1.7.3.4
Re: [Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic
If anyone here is opened minded - still. This shows that default should be "no" for all plugins. Distro maintainer should decide what to switch on. Anyway, this is my recommendation. On Tue, Jun 26, 2012 at 4:55 PM, Alon Bar-Lev wrote: > pam cannot be compiled on OpenBSD and Windows. > down-root cannot be compiled on Windows. > > Signed-off-by: Alon Bar-Lev > --- > configure.ac | 21 - > 1 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/configure.ac b/configure.ac > index db19d4a..b1140f8 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -195,16 +195,27 @@ AC_ARG_ENABLE( > > AC_ARG_ENABLE( > [plugin-auth-pam], > - [AS_HELP_STRING([--disable-plugin-auth-pam], [disable auth-pam plugin > @<:@default=yes@:>@])], > + [AS_HELP_STRING([--disable-plugin-auth-pam], [disable auth-pam plugin > @<:@default=yes for Linux@:>@])], > , > - [enable_plugin_auth_pam="yes"] > + [ > + case "$host" in > + *-*-openbsd*) enable_plugin_auth_pam="no";; > + *-mingw*) enable_plugin_auth_pam="no";; > + *) enable_plugin_auth_pam="yes";; > + esac > + ] > ) > > AC_ARG_ENABLE( > [plugin-down-root], > - [AS_HELP_STRING([--disable-plugin-down-root], [disable down-root > plugin @<:@default=yes@:>@])], > + [AS_HELP_STRING([--disable-plugin-down-root], [disable down-root > plugin @<:@default=yes for POSIX@:>@])], > , > - [enable_plugin_down_root="yes"] > + [ > + case "$host" in > + *-mingw*) enable_plugin_down_root="no";; > + *) enable_plugin_down_root="yes";; > + esac > + ] > ) > > AC_ARG_ENABLE( > -- > 1.7.3.4 >
[Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic
pam cannot be compiled on OpenBSD and Windows. down-root cannot be compiled on Windows. Signed-off-by: Alon Bar-Lev --- configure.ac | 21 - 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index db19d4a..b1140f8 100644 --- a/configure.ac +++ b/configure.ac @@ -195,16 +195,27 @@ AC_ARG_ENABLE( AC_ARG_ENABLE( [plugin-auth-pam], - [AS_HELP_STRING([--disable-plugin-auth-pam], [disable auth-pam plugin @<:@default=yes@:>@])], + [AS_HELP_STRING([--disable-plugin-auth-pam], [disable auth-pam plugin @<:@default=yes for Linux@:>@])], , - [enable_plugin_auth_pam="yes"] + [ + case "$host" in + *-*-openbsd*) enable_plugin_auth_pam="no";; + *-mingw*) enable_plugin_auth_pam="no";; + *) enable_plugin_auth_pam="yes";; + esac + ] ) AC_ARG_ENABLE( [plugin-down-root], - [AS_HELP_STRING([--disable-plugin-down-root], [disable down-root plugin @<:@default=yes@:>@])], + [AS_HELP_STRING([--disable-plugin-down-root], [disable down-root plugin @<:@default=yes for POSIX@:>@])], , - [enable_plugin_down_root="yes"] + [ + case "$host" in + *-mingw*) enable_plugin_down_root="no";; + *) enable_plugin_down_root="yes";; + esac + ] ) AC_ARG_ENABLE( -- 1.7.3.4
Re: [Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic
Hi, On Tue, Jun 26, 2012 at 04:45:55PM +0300, Alon Bar-Lev wrote: > pam cannot be compiled on *BSD and Windows. *Open*BSD. Not *BSD. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025g...@net.informatik.tu-muenchen.de pgpr020jxpy48.pgp Description: PGP signature
[Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic
pam cannot be compiled on *BSD and Windows. down-root cannot be compiled on Windows. Signed-off-by: Alon Bar-Lev --- configure.ac | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index db19d4a..9fb24ad 100644 --- a/configure.ac +++ b/configure.ac @@ -195,16 +195,26 @@ AC_ARG_ENABLE( AC_ARG_ENABLE( [plugin-auth-pam], - [AS_HELP_STRING([--disable-plugin-auth-pam], [disable auth-pam plugin @<:@default=yes@:>@])], + [AS_HELP_STRING([--disable-plugin-auth-pam], [disable auth-pam plugin @<:@default=yes for Linux@:>@])], , - [enable_plugin_auth_pam="yes"] + [ + case "$host" in + *-*-linux*) enable_plugin_auth_pam="yes";; + *) enable_plugin_auth_pam="no";; + esac + ] ) AC_ARG_ENABLE( [plugin-down-root], - [AS_HELP_STRING([--disable-plugin-down-root], [disable down-root plugin @<:@default=yes@:>@])], + [AS_HELP_STRING([--disable-plugin-down-root], [disable down-root plugin @<:@default=yes for POSIX@:>@])], , - [enable_plugin_down_root="yes"] + [ + case "$host" in + *-mingw*) enable_plugin_down_root="no";; + *) enable_plugin_down_root="yes";; + esac + ] ) AC_ARG_ENABLE( -- 1.7.3.4
