Re: [Openvpn-devel] [PATCH 00/52] build revolution

[David Sommerseth]

On 29/02/12 21:11, Alon Bar-Lev wrote:
> 1. Many cleanups.
> 2. New directory layout.
> 3. Remove easy-rsa, install-win32, windows build, tap-win32.
> 4. Standard autotools build system.
> 5. msbuild build system.
> 6. Split out most of platform specific code.

All patches in this patch set has been ACKed, and I've pushed out a new
master branch with these changes.  Below is a completely git history
with all commits references and ACK credits.

Thanks a lot to Alon for his hard work on this patch set.  But we must
beware that more changes and improvements will come in the near future
too.  Many improvements are to come on top of this.


kind regards,

David Sommerseth



commit 0e4b6c455e0236a4eb45eb1df869b5ce0b97518a
Author: Alon Bar-Lev 
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Wed Feb 29 22:12:22 2012 +0200

build: use tap-windows.h as external dependency

tap-windows.h is provided by the tap project

Signed-off-by: Alon Bar-Lev 
Acked-by: Samuli Seppänen 
Signed-off-by: David Sommerseth 

commit 880a2ae97c44d75a3529adda8a11e266fb61092e
Author: Alon Bar-Lev 
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Wed Feb 29 22:12:21 2012 +0200

build: distribute samples in windows

Signed-off-by: Alon Bar-Lev 
Acked-by: Samuli Seppänen 
Signed-off-by: David Sommerseth 

commit 6187644b660ce284d0a706811eae2dce7cb411b2
Author: Alon Bar-Lev 
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Wed Feb 29 22:12:20 2012 +0200

build: windows: install version.sh to allow installer read version

Signed-off-by: Alon Bar-Lev 
Acked-by: Samuli Seppänen 
Signed-off-by: David Sommerseth 

commit 14a131ac1cfc95e5ba2518ff887d04c034aecc53
Author: Alon Bar-Lev 
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Wed Feb 29 22:12:19 2012 +0200

build: move wrappers into platform module

+ Some fixups within the platform.c functions.
- need to check environment set on Windows.

Signed-off-by: Alon Bar-Lev 
Acked-by: Gert Doering 
Signed-off-by: David Sommerseth 

commit 72c7b12cb65cee69ea129cc520b26dcc64977a17
Author: Alon Bar-Lev 
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Wed Feb 29 22:12:18 2012 +0200

cleanup: move console related function into its own module

Signed-off-by: Alon Bar-Lev 
Acked-by: Gert Doering 
Signed-off-by: David Sommerseth 

commit f106f64b1cc228b3b937ed15a1a45bc28edefed9
Author: Alon Bar-Lev 
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Wed Feb 29 22:12:17 2012 +0200

build: move inet_ntop(), inet_pton() emulation into compat

Signed-off-by: Alon Bar-Lev 
Acked-by: Samuli Seppänen 
Acked-by: David Sommerseth 
Signed-off-by: David Sommerseth 

commit 7b49c16761b4a11f1f0846cd46bd7194392efbfa
Author: Alon Bar-Lev 
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Wed Feb 29 22:12:16 2012 +0200

build: move daemon() emulation into compat

Signed-off-by: Alon Bar-Lev 
Acked-by: Samuli Seppänen 
Acked-by: David Sommerseth 
Signed-off-by: David Sommerseth 

commit 3d163bc544ab9dfc62d9a2c865f8abb865bf6eb3
Author: Alon Bar-Lev 
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Wed Feb 29 22:12:15 2012 +0200

build: move gettimeofday() emulation to compat

Remove all references to gettimeofday() from main project.

SIDE EFFECT: mingw will use its own internal gettimeofday().

Signed-off-by: Alon Bar-Lev 
Acked-by: David Sommerseth 
Signed-off-by: David Sommerseth 

commit dc81e743989640cc681a40e69455cc9fc736ab9c
Author: Alon Bar-Lev 
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Wed Feb 29 22:12:14 2012 +0200

build: split out compat

compat should not use any of the main project headers or conventions,
it should be a standalone library that provides missing library
functions.

Signed-off-by: Alon Bar-Lev 
Acked-by: David Sommerseth 
Signed-off-by: David Sommerseth 

commit c110b289eced4a792fd7c7c29e651b22f602fd24
Author: Alon Bar-Lev 
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Wed Feb 29 22:12:13 2012 +0200

build: move out config.h 

[Openvpn-devel] [PATCH 00/52] build revolution

[Alon Bar-Lev]

1. Many cleanups.
2. New directory layout.
3. Remove easy-rsa, install-win32, windows build, tap-win32.
4. Standard autotools build system.
5. msbuild build system.
6. Split out most of platform specific code.

After review I suggest you pull my repository[1], much safer than
doing the MIME magic.

Alon Bar-Lev (52):
  build: version should not contain '-'
  package: rpm: strip should be handled by package management
  cleanup: options.c: remove redundant include
  cleanup: remove C++ warnings
  cleanup: win32.c: wrong printf format
  cleanup: remove redundant ';'
  cleanup: crypto_openssl.c: remove support for pre-openssl-0.9.6
  cleanup: tun.c: fix incorrect option in message (ip-win32)
  cleanup: memcmp.c: remove unused source
  fixup: init.c: add missing conditional for ENABLE_CLIENT_CR
  build: correct place to alter WINVER is at build system
  Update .gitignore
  build: handle printf style format in mingw
  build: rename plugin directory to plugins
  build: plugins: properly use CC, CFLAGS and LDFLAGS
  build: we need the sample.ovpn in future
  Remove install-win32
  Remove easy-rsa
  Remove tap-win32
  cleanup: rename tap-windows function from win32 to win
  build: remove windows specific build system
  build: split acinclude.m4 into m4/*
  build: m4/ax_varargs.m4: cleanup
  build: m4/ax_emptyarray.m4: cleanup
  build: m4/ax_socklen_t.m4: cleanup
  build: autotools: first pass of trivial autotools changes
  build: autoconf: remove OPENVPN_ADD_LIBS useless macro
  build: remove awk and non-standard autoconf output processing
  build: standard directory layout
  build: add libtool + windows resources for executables
  build: autoconf: commands as environment
  build: libdl usage
  build: properly detect and use socket libs
  build: autoconf: minor cleanups
  build: proper selinux detection and usage
  build: distribute pkg.m4
  build: proper pkcs11-helper detection and usage
  build: properly process lzo-stub
  build: proper lzo detection and usage
  build: proper crypto detection and usage
  build: autoconf: update defaults for options
  build: win-msvc: msbuild format
  build: move out config.h include from syshead
  build: split out compat
  build: move gettimeofday() emulation to compat
  build: move daemon() emulation into compat
  build: move inet_ntop(), inet_pton() emulation into compat
  cleanup: move console related function into its own module
  build: move wrappers into platform module
  build: windows: install version.sh to allow installer read version
  build: distribute samples in windows
  build: use tap-windows.h as external dependency

 .gitignore  |   43 +-
 .svnignore  |   20 -
 Makefile.am |  156 +-
 acinclude.m4|  131 -
 base64.c|  163 -
 base64.h|   44 -
 basic.h |   49 -
 buffer.c| 1095 
 buffer.h|  906 ---
 build/Makefile.am   |   17 +
 build/ltrc.inc  |   23 +
 build/msvc/Makefile.am  |   15 +
 build/msvc/msvc-generate/Makefile.am|   18 +
 build/msvc/msvc-generate/Makefile.mak   |   13 +
 build/msvc/msvc-generate/msvc-generate.js   |  118 +
 build/msvc/msvc-generate/msvc-generate.vcproj   |   74 +
 circ_list.h |   78 -
 clinat.c|  263 -
 clinat.h|   65 -
 common.h|  107 -
 compat.c|  129 -
 compat.h|   42 -
 compat.m4   |   70 +
 config-msvc-version.h.in|   10 +
 config-msvc.h   |  121 +
 configure.ac| 1620 +++---
 configure_h.awk |   39 -
 configure_log.awk   |   33 -
 crypto.c| 1455 -
 crypto.h|  398 --
 crypto_backend.h|  490 --
 crypto_openssl.c|  793 ---
 crypto_openssl.h|   73 -
 crypto_polarssl.c   |  560 --
 crypto_polarssl.h   |   74 -
 cryptoapi.c |  459 --
 cryptoapi.h |7 -
 debug/doval |4 +
 debug/dovalns   |2 +
 dhcp.c  |  206 -
 dhcp.h  |