Hi Lev,
I'm struggling with family duties now that schools are closed. This makes it
hard to find any time for computers.
Nevertheless, should find_adapters() fail for some reason, it is not critical
to bail out of FindSystemInfo() custom action.
The find_adapters() itself already displays a resumable error message (MSI also
writes it to the log) on all of the error return paths:
- tap_list_adapters() calls msg(M_NONFATAL...) on error returns
- other returns have msg(M_NONFATAL...)
Mind that msg() is using MSI error messaging
[https://github.com/rozmansi/openvpn/blob/feature/msi/src/openvpnmsica/dllmain.c#L108].
MsiProcessMessage(s->hInstall, INSTALLMESSAGE_ERROR, hRecordProg); will popup
an error dialog in interactive MSI sessions, and write error message to the log
in interactive and non-interactive sessions.
To summarize: the return value of find_adapters() call is ignored on purpose.
Regards,
Simon
-Original Message-
From: Lev Stipakov
Date: Tuesday, 24 March 2020 at 13:07
To: Simon Rozman
Cc: "openvpn-devel@lists.sourceforge.net"
Subject: Re: [Openvpn-devel] [PATCH 11/12] openvpnmsica: Merge
FindTUNTAPAdapters into FindSystemInfo
Hi,
Compiled with msvc, smoke-tested with rundll32.
One thing:
> +set_openvpnserv_state(hInstall);
> +find_adapters(
> +hInstall,
> +TEXT("root\\") TEXT(TAP_WIN_COMPONENT_ID),
> +TEXT("TAPWINDOWS6ADAPTERS"),
> +TEXT("ACTIVETAPWINDOWS6ADAPTERS"));
Both methods return error codes which we ignore.
smime.p7s
Description: S/MIME cryptographic signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
