Re: [Openvpn-devel] [PATCH applied] Re: Add a unit test for functions in cryptoapi.c
Hi,
On Sat, Feb 25, 2023 at 12:23:42PM -0500, Selva Nair wrote:
> > OTOH, there might be a bit of polishing needed - the other tests
> > print out what they are doing ("Running 7 test(s)"), while the
> > cryptoapi unit test "just succeeds". Is there something missing
> > wrt cmocka initalization?
[..]
> That one is for OpenSSL 1.1.1 while this test is built only for OpenSSL3,
> so nothing to run. Do we need to continue testing Windows builds of 2.6 for
> OpenSSL 1.1?
Ah. Indeed, I saw the #ifdef in the code, but then looked in the wrong
test result.
Thanks for enlightening me (again).
Arne, indeed, this sounds as if we shouldn't run these test units on
mingw + 1.1.1 builds. Just confusing people, like, me.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH applied] Re: Add a unit test for functions in cryptoapi.c
Hi
On Sat, Feb 25, 2023 at 11:29 AM Gert Doering wrote:
> Acked-by: Gert Doering
>
> Thanks for the v4. This enabled me to just push to GH to have
> to build and run the tests, without having to bother myself with
> copying binaries around :-)
>
> OTOH, there might be a bit of polishing needed - the other tests
> print out what they are doing ("Running 7 test(s)"), while the
> cryptoapi unit test "just succeeds". Is there something missing
> wrt cmocka initalization?
> https://github.com/cron2/openvpn/actions/runs/4270790193/jobs/7434873211
That one is for OpenSSL 1.1.1 while this test is built only for OpenSSL3,
so nothing to run. Do we need to continue testing Windows builds of 2.6 for
OpenSSL 1.1?
Logs for OpenSSL 3 build look okay:
>
https://github.com/OpenVPN/openvpn/actions/runs/4270860888/jobs/7434989645#logs
>
Run ./unittests/cryptoapi_testdriver.exe
> 4[==] Running 1 test(s).
> 5[ RUN ] test_parse_hexstring
> 6[ OK ] test_parse_hexstring
> 7[ PASSED ] 1 test(s).
> 8[==] 1 test(s) run.
Selva
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
