Re: [Openvpn-devel] [PATCH v2 5/5] Deprecate the --verify-hash option
Hi, On 21/03/2021 18:38, Arne Schwabe wrote: > This patch conflicts since the grammar in the previous patch was fixed. > If there is nothing else wrong with it I can resend a rebased v3. That was it. Feel free to send v3. Cheers, -- Antonio Quartulli ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH v2 5/5] Deprecate the --verify-hash option
Am 21.03.21 um 18:22 schrieb Antonio Quartulli: > Hi, > > On 19/03/2021 15:20, Arne Schwabe wrote: >> Despite trying to figure out with multiple people what the use case for >> this option is, we could not come up with a good one. Checking that only >> a specific CA is used can be also done by only using that CA in the --ca >> directive. >> >> Although it feels a bit strange to deprecate the option after improving >> it with peer-fingerprint patches, all the improvements are needed for >> --peer-fingerprint and making them specify to --peer-fingerprint would >> have added more (unecessary) changes. >> >> Signed-off-by: Arne Schwabe > > This patch looks good to me, but it does not apply on top of the > previous 4. Maybe it was committed without considering the old 4/4? > This patch conflicts since the grammar in the previous patch was fixed. If there is nothing else wrong with it I can resend a rebased v3. Arne ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH v2 5/5] Deprecate the --verify-hash option
Hi, On 19/03/2021 15:20, Arne Schwabe wrote: > Despite trying to figure out with multiple people what the use case for > this option is, we could not come up with a good one. Checking that only > a specific CA is used can be also done by only using that CA in the --ca > directive. > > Although it feels a bit strange to deprecate the option after improving > it with peer-fingerprint patches, all the improvements are needed for > --peer-fingerprint and making them specify to --peer-fingerprint would > have added more (unecessary) changes. > > Signed-off-by: Arne Schwabe This patch looks good to me, but it does not apply on top of the previous 4. Maybe it was committed without considering the old 4/4? Regards, -- Antonio Quartulli ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
