Re: maven archetypes ?

2009-12-22 Thread Mark Struberg
nope, I don't think we made some archetypes yet :(
The main problem with archtetypes for OWB is that we'd need 6 of them ;)

We discussed about creating some pure pom modules which 'bundle' OWB parts 
together for providing the right dependencies out of the box + preconfigured 
openwebbeans.properties
e.g. for a standalone servlet engine + JSF2 use case: cdi-api + atinject-api + 
webbeans-impl + webbeans-resource + webbeans-jsf

LieGrue,
strub

--- Matthias Wessendorf mat...@apache.org schrieb am Di, 22.12.2009:

 Von: Matthias Wessendorf mat...@apache.org
 Betreff: Re: maven archetypes ?
 An: openwebbeans-dev@incubator.apache.org
 Datum: Dienstag, 22. Dezember 2009, 17:48
 On Tue, Dec 22, 2009 at 5:46 PM,
 Matthias Wessendorf mat...@apache.org
 wrote:
  Hello guys,
 
  are there some maven archetype around? I can't see a
 folder that could
  contain them:
 
  http://svn.apache.org/repos/asf/incubator/openwebbeans/trunk/
 
  also, I wonder where the API has been moved to :-)
  (e.g. the javax.enterprise.context.* package)
 
 found them:
 http://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-cdi_1.0_spec/
 http://svn.apache.org/repos/asf/geronimo/specs/trunk/geronimo-atinject_1.0_spec/
 (after I remembered the discussion)
 
 So maybe I also just forgot about the archetypes ? :-)
 
 -Matthias
 
 
  -Matthias
 
  --
  Matthias Wessendorf
 
  blog: http://matthiaswessendorf.wordpress.com/
  sessions: http://www.slideshare.net/mwessendorf
  twitter: http://twitter.com/mwessendorf
 
 
 
 
 -- 
 Matthias Wessendorf
 
 blog: http://matthiaswessendorf.wordpress.com/
 sessions: http://www.slideshare.net/mwessendorf
 twitter: http://twitter.com/mwessendorf
 

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


Proxy only gets resolved for the first instance injection

2009-12-21 Thread Mark Struberg
Hi!

I've created OWB-206 and checked in a unit test which demonstrates the blocker!

I know that the build is currently broken therefore, but it's really important 
that we fix this issue asap!

LieGrue,
strub

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


Re: Proxy only gets resolved for the first instance injection

2009-12-21 Thread Mark Struberg
yes, that is exactly the same problem.

LieGrue,
strub

--- Sven Linstaedt sven.linsta...@googlemail.com schrieb am Mo, 21.12.2009:

 Von: Sven Linstaedt sven.linsta...@googlemail.com
 Betreff: Re: Proxy only gets resolved for the first instance injection
 An: openwebbeans-dev@incubator.apache.org
 Datum: Montag, 21. Dezember 2009, 17:59
 May this also be the reason for my
 observation when retrieving the current
 Conversation that sometimes I am gettting a proxy,
 sometimes not? I was not
 able to investigate into this strange behavior yet.
 
 br, Sven
 
 
 
 2009/12/21 Gurkan Erdogdu gurkanerdo...@yahoo.com
 
  Hi;
 
  Bean instance is injected by the container using
  getReference#BeanManagerImpl that uses proxy every
 time! (creates new one or
  use existing one with normal scoped beans)
 
  If you use Context interface directly, you must not
 use Context interface
  directly to get instance that is specified in the
 specification explicitly.
 
  This is just a quick try, but I will look at your test
 class after you
  check in.
 
  Thanks ;
 
  --Gurkan
 
 
 
 
  
  From: Mark Struberg strub...@yahoo.de
  To: openwebbeans-dev@incubator.apache.org
  Sent: Mon, December 21, 2009 6:14:51 PM
  Subject: Proxy only gets resolved for the first
 instance injection
 
  Hi!
 
  I've created OWB-206 and checked in a unit test which
 demonstrates the
  blocker!
 
  I know that the build is currently broken therefore,
 but it's really
  important that we fix this issue asap!
 
  LieGrue,
  strub
 
  __
  Do You Yahoo!?
  Sie sind Spam leid? Yahoo! Mail verfügt über einen
 herausragenden Schutz
  gegen Massenmails.
  http://mail.yahoo.com
 
 
 
    
    ___
  Yahoo! Türkiye açıldı!  http://yahoo.com.tr
  İnternet üzerindeki en iyi içeriği Yahoo! Türkiye
 sizlere sunuyor!
 
 

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


[jira] Updated: (OWB-206) proxies only get injected for the 1st instance of a bean

2009-12-21 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg updated OWB-206:
--

Attachment: OWB-206-rfc.patch

 proxies only get injected for the 1st instance of a bean
 

 Key: OWB-206
 URL: https://issues.apache.org/jira/browse/OWB-206
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
Priority: Blocker
 Fix For: M4

 Attachments: OWB-206-rfc.patch


 I think I've hit a big problem!
 If I inject a bean twice, I get no interceptor for the 2nd instance!
 The problem seems caused in AbstractContext#getInstance() which puts the 
 unproxied! instance into the map!
 I'll checkin a unit test i've written to demonstrate the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [jira] Updated: (OWB-206) proxies only get injected for the 1st instance of a bean

2009-12-21 Thread Mark Struberg
Hi!

yes, np, happens to everyone some days. Maybe the cause of the change got 
rendered useless due some spec change in the past anyway.

It seems to work ok with my change so far, so I'll go and close the issue. But 
we should take care if we notice some weird side effects. I hope this will also 
easy Joe and Svens tasks in catching decorator and JSF related issues more 
easily ;)

LieGrue,
strub

--- Gurkan Erdogdu gurkanerdo...@yahoo.com schrieb am Mo, 21.12.2009:

 Von: Gurkan Erdogdu gurkanerdo...@yahoo.com
 Betreff: Re: [jira] Updated: (OWB-206) proxies only get injected for the 1st 
 instance of a bean
 An: openwebbeans-dev@incubator.apache.org
 Datum: Montag, 21. Dezember 2009, 20:16
 I added this section for some reasons
 that I do not remember now!
 
 I will look at it
 
 
 
 
 
 From: Mark Struberg (JIRA) j...@apache.org
 To: openwebbeans-dev@incubator.apache.org
 Sent: Mon, December 21, 2009 7:36:18 PM
 Subject: [jira] Updated: (OWB-206) proxies only get
 injected for the 1st instance of a bean
 
 
      [ 
 https://issues.apache.org/jira/browse/OWB-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]
 
 Mark Struberg updated OWB-206:
 --
 
     Attachment: OWB-206-rfc.patch
 
  proxies only get injected for the 1st instance of a
 bean
 
 
 
              
    Key: OWB-206
              
    URL: https://issues.apache.org/jira/browse/OWB-206
          
    Project: OpenWebBeans
           Issue Type: Bug
     Affects Versions: M3
             Reporter:
 Mark Struberg
             Assignee:
 Mark Struberg
             Priority:
 Blocker
          
    Fix For: M4
 
          Attachments:
 OWB-206-rfc.patch
 
 
  I think I've hit a big problem!
  If I inject a bean twice, I get no interceptor for the
 2nd instance!
  The problem seems caused in
 AbstractContext#getInstance() which puts the unproxied!
 instance into the map!
  I'll checkin a unit test i've written to demonstrate
 the problem.
 
 -- 
 This message is automatically generated by JIRA.
 -
 You can reply to this email to add a comment to the issue
 online.
 
 
      
 ___
 Yahoo! Türkiye açıldı!  http://yahoo.com.tr
 İnternet üzerindeki en iyi içeriği Yahoo! Türkiye
 sizlere sunuyor!

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


[jira] Resolved: (OWB-206) proxies only get injected for the 1st instance of a bean

2009-12-21 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-206.
---

Resolution: Fixed

 proxies only get injected for the 1st instance of a bean
 

 Key: OWB-206
 URL: https://issues.apache.org/jira/browse/OWB-206
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
Priority: Blocker
 Fix For: M4

 Attachments: OWB-206-rfc.patch


 I think I've hit a big problem!
 If I inject a bean twice, I get no interceptor for the 2nd instance!
 The problem seems caused in AbstractContext#getInstance() which puts the 
 unproxied! instance into the map!
 I'll checkin a unit test i've written to demonstrate the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



OWB proxy characteristics

2009-12-21 Thread Mark Struberg
Hi!

Just a short mail to ensure that we take care of a few things:

.) Are our proxies 100% thread safe? Because we currently only create one proxy 
instance for all instances of a specific bean. Which means that parallel 
requests coming through a web server may result in concurrent proxy invocations 
to the same proxy instance, even if the proxied bean instances behind the 
facade differ.

LieGrue,
strub

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


AW: OpenJPA Maven Plugin

2009-12-20 Thread Mark Struberg
sorry, that slipped in. 

I will release 1.1 in the next few weeks, but actually it should work with 1.0 
too.
Will downgrade now.

txs and LieGrue,
strub

--- Gurkan Erdogdu gurkanerdo...@yahoo.com schrieb am So, 20.12.2009:

 Von: Gurkan Erdogdu gurkanerdo...@yahoo.com
 Betreff: OpenJPA Maven Plugin
 An: openwebbeans-dev@incubator.apache.org
 Datum: Sonntag, 20. Dezember 2009, 13:35
 Hi Mark
 
 Seems that samples/reservation depends on
 openjpa-maven-plugin. But I do not find how to get this
 plugin from which repository?
 
 Could you update pom.xml with repository info that provides
 1.1-SNAPSHOT for this plugin;
 
 Thanks;
 
 --Gurkan
 
 
 
      
 ___
 Yahoo! Türkiye açıldı!  http://yahoo.com.tr
 İnternet üzerindeki en iyi içeriği Yahoo! Türkiye
 sizlere sunuyor!

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


Re: Integration of JSF2 specific API calls

2009-12-19 Thread Mark Struberg
+1

I'm still on the daily snapshots, but only because the alpha announcement 
slipped under my radar :( 
As far as I can tell, MyFaces2 looks pretty promising and stable.

LieGrue,
strub

--- Gurkan Erdogdu cgurkanerdo...@gmail.com schrieb am Sa, 19.12.2009:

 Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Betreff: Re: Integration of JSF2 specific API calls
 An: openwebbeans-dev@incubator.apache.org
 Datum: Samstag, 19. Dezember 2009, 1:55
 MyFaces 2 Alpha Release Maven
 
 http://repo1.maven.org/maven2/org/apache/myfaces/core/myfaces-api/2.0.0-alpha/
 
 2009/12/19 Gurkan Erdogdu cgurkanerdo...@gmail.com
 
  Also we have to update our poms for JSf2
 
  2009/12/19 Gurkan Erdogdu cgurkanerdo...@gmail.com
 
  Just adding classes to webbeans-jsf project.
 
  For example you can add JSf2WebBeansListener etc.
 
  2009/12/19 Sven Linstaedt sven.linsta...@googlemail.com
 
  Was there any agreement on the JSF2 topic? As far
 as I remember two
  solutions were mentioned:
 
  1. Move completely to JSF2, JSF1 is not
 supported any more
  2. Create an additional project for JSF2
 integration
 
  br, Sven
 
 
 
  2009/12/18 Mark Struberg strub...@yahoo.de
 
   +1  big one :)
  
   webbeans-impl should finally need no
 other dependencies than SE (maybe
  +
   the servlet_spec because that would be
 much work to sort it out)
  
   LieGrue,
   strub
  
   --- Sven Linstaedt sven.linsta...@googlemail.com
 schrieb am Fr,
   18.12.2009:
  
Von: Sven Linstaedt sven.linsta...@googlemail.com
Betreff: Re: Integration of JSF2
 specific API calls
An: openwebbeans-dev@incubator.apache.org
Datum: Freitag, 18. Dezember 2009,
 13:38
I also thought about migrating all
JSF compile time depend classes
 from
webbeans-impl to webbeans-jsf for a
 clearer seperation.
wdyt?
   
br, Sven
   
2009/12/17 Mark Struberg strub...@yahoo.de
   
 Yes we can start that way.

 But having 2 modules would have
 the benefit that we
can define the
 corresponding dependencies and
 thus make sure that we
do not use 'newer'
 features at compile time.

 LieGrue,
 strub

 --- Gurkan Erdogdu cgurkanerdo...@gmail.com
schrieb am Do, 17.12.2009:

  Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
  Betreff: Re: Integration
 of JSF2 specific API
calls
  An: openwebbeans-dev@incubator.apache.org
  Datum: Donnerstag, 17.
 Dezember 2009, 10:49
  I think we
 will start
  hacking on the feature and
 if we hit the point
of
  no return we should create
 an own module.
  We could definitely create
 a new package for
unique JSF2
  features if we will
  have under webbeans-jsf
 project. So management
and
  configuration are much
  more easy with having one
 JSF module.
 
 
  2009/12/17 Gurkan Erdogdu
 cgurkanerdo...@gmail.com
 
   What I mean is that,
  
   Our code base has
 nothing regarding to JSF
1.2 like
  other JSF
   Frameworks/Tools etc.
 do.
  
   We have just
 implemented 2 class for
conversation
  service
  
   1* WebBeansPhase
 Listener -- For
restore
  conversations
   2* Custom View
 Handler
     -- For
 adding cid to view
handler
  
   Both of them work on
 any JSF1.2 or JSF2
  implementation.
  
   Therefore it is not
 rational to define new
jsf2
  project from my point of
   view. If we were
 implementing lots of code
unique to
  JSF 1.2 then it will be
   reasonable to define
 new JSF2 project but we
did not.
  Actually it is
   meaningless for me to
 separate JSF 1.2 and
JSF 2.
  
   We must not think of
 such a backward
compatibility
  with JSF 1.2 etc because
   we have been
 implementing Java EE 6 defined
JSR-299
  specification.
  
  
   --Gurkan
  
   2009/12/17 Mark
 Struberg strub...@yahoo.de
  
   Gurkan,
  
   I was not talking
 about special
products, I also
  meant the API and I
   mentioned
 RichFaces-3.3.2 only as an
example. You
  can google for the
   incompatibility
 problems.
  
   Matter of fact:
   .) EE6 WebProfile
 defines JSF-2, so from
this
  point I'm with you
  
   But:
   .) there is no
 full stack for JSF-2 on
the market
  currently (the component
   libraries are
 missing, since they are
mostly
  incompatible)
   Plus, there will
 be lot old projects
which still
  use JSF-1.2 but may like
   to use OWB for
 new extensions.
  
   and as such:
   .) providing an
 easy migration path to
EE6 by
  allowing to use JSF-1.2 +
   OWB would imho be
 a pretty nice goodie.
  
   I don't think it
 will confuse users if
they have a
  choice between a
   JSF-1.2 and a
 JSF-2 plugin if we explain
the
  differences in the
   documentation

[jira] Resolved: (OWB-191) Convert logging to use keyed, formatted strings from a ResourceBundle to allow for translation.

2009-12-19 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-191.
---

Resolution: Fixed

i18n bundle moved from
* META-INF/Messages_en.properties 
to
* openwebbeans/Messages.properties

to ensure 2 things
1.) the Messages also get picked up if  the langage is not 'en' e.g for a 
Locale='de_AT'
2.) the resource doesn't interfere with other Messages.properties files this way

 Convert logging to use keyed, formatted strings from a ResourceBundle to 
 allow for translation.
 ---

 Key: OWB-191
 URL: https://issues.apache.org/jira/browse/OWB-191
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Core
 Environment: All.
Reporter: Paul J. Reder
Assignee: Gurkan Erdogdu
 Fix For: M4

 Attachments: ResourceBundlePort.patch


 Currently all logs and exceptions use hard coded strings that are embedded 
 throughout the source. The attached patch converts the code to use key-based 
 strings from a ResourceBundle so that all strings are collected in one place 
 to enable translation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OWB-202) move all JSF specific code from webbeans-impl to webbeans-jsf and upgrade to JSF-2

2009-12-19 Thread Mark Struberg (JIRA)
move all JSF specific code from webbeans-impl to webbeans-jsf and upgrade to 
JSF-2
--

 Key: OWB-202
 URL: https://issues.apache.org/jira/browse/OWB-202
 Project: OpenWebBeans
  Issue Type: Improvement
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OWB-202) upgrade webbeans-jsf to JSF-2

2009-12-19 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg updated OWB-202:
--

Component/s: Context and Scopes
Description: 
*edit* saw that webbeans-impl already has been cleaned up!

Summary: upgrade webbeans-jsf to JSF-2  (was: move all JSF specific 
code from webbeans-impl to webbeans-jsf and upgrade to JSF-2)

 upgrade webbeans-jsf to JSF-2
 -

 Key: OWB-202
 URL: https://issues.apache.org/jira/browse/OWB-202
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Context and Scopes
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 *edit* saw that webbeans-impl already has been cleaned up!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-190) Make the TestLifeCycles available in webbeans-impl

2009-12-19 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-190.
---

Resolution: Fixed

Moved the TestLifeCycle to a visible package.

A unittest in a project using OpenWebBeans could be using

META-INF/openwebbeans/openwebbeans.properties:
{noformat}
# the service section:
# The key is the Interface, the value the implementation of the service

# use the static HashMap instead of storing objects in JNDI as default  
org.apache.webbeans.spi.JNDIService=org.apache.webbeans.spi.se.JNDIServiceStaticImpl

# lookup the javax.transaction.TransactionManager via JNDI as default 
org.apache.webbeans.spi.TransactionService=org.apache.webbeans.spi.se.TransactionServiceNonJTA

#use the web metadata as default
org.apache.webbeans.spi.deployer.MetaDataDiscoveryService=org.apache.webbeans.spi.se.deployer.MetaDataDiscoveryStandard

#Lifecycle to start container
org.apache.webbeans.spi.Lifecycle=org.apache.webbeans.lifecycle.test.EnterpriseTestLifeCycle
{noformat}


And utilise it from the unit tests by using the following class to bootstrap 
OWB in a @BeforeClass or similar:
{noformat}
import java.util.Set;

import javax.enterprise.inject.spi.Bean;
import javax.enterprise.inject.spi.BeanManager;

import org.apache.webbeans.lifecycle.LifecycleFactory;
import org.apache.webbeans.spi.Lifecycle;
import org.testng.Assert;

public class ContainerStarter {

private Lifecycle lifecycle = null;

public  void boot(Object startupObject) throws Exception {
lifecycle = LifecycleFactory.getInstance().getLifecycle();
lifecycle.applicationStarted(startupObject);
}

public void shutdown(Object endObject) throws Exception {
lifecycle = LifecycleFactory.getInstance().getLifecycle();
if (lifecycle != null) {
lifecycle.applicationEnded(endObject);
}
}

public  BeanManager getBeanManager() {
return lifecycle.getBeanManager();
}

public T T getInstance(ClassT clazz) {
SetBean? beans = getBeanManager().getBeans(clazz);
Assert.assertNotNull(beans, cannot find beans for class  + 
clazz.getCanonicalName());
Assert.assertTrue(!beans.isEmpty(), cannot find beans for class  + 
clazz.getCanonicalName());

@SuppressWarnings(unchecked)
BeanT bean = (BeanT)beans.iterator().next();

@SuppressWarnings(unchecked)
T instance = (T) getBeanManager().getReference(bean, clazz, 
getBeanManager().createCreationalContext(bean));
return instance;
}

}
{noformat}

 Make the TestLifeCycles available in webbeans-impl
 --

 Key: OWB-190
 URL: https://issues.apache.org/jira/browse/OWB-190
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Lifecycle
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 Currently the OpenWebBeansTestLifecycle is only available internally for the 
 tests and via the tests.jar.
 This is not usable for running automated function tests in projects which use 
 OWB.
 I'd like to move over the OpenWebBeansTestLifeCycle (where one has to 
 manually select all classes which should get scanned) to a new lifecycle.test 
 package and also add a new EnterpriseTestLifeCycle which scanns all classes 
 on the classpaths according to the spec.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-203) Improve logging of webbeans-resource if a PersistenceUnit cannot be found

2009-12-19 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-203.
---

Resolution: Fixed

 Improve logging of webbeans-resource if a PersistenceUnit cannot be found
 -

 Key: OWB-203
 URL: https://issues.apache.org/jira/browse/OWB-203
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Java EE Integration
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 currently if someone tries to inject a @PersistenceUnit(myUnitName) we 
 inject null without logging something.
 We shall log at least a INFO in this case!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OWB-171) CID during GET requests must be set on UIViewRoot earlier than before render response

2009-12-19 Thread Mark Struberg (JIRA)

[ 
https://issues.apache.org/jira/browse/OWB-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792929#action_12792929
 ] 

Mark Struberg commented on OWB-171:
---

sven, can you please merge again and attach the patch?
I have problems with applying the WebBeansPhaseListener :(
you can also join us in IRC tomorrow and then we can do it together.

 CID during GET requests must be set on UIViewRoot earlier than before render 
 response
 -

 Key: OWB-171
 URL: https://issues.apache.org/jira/browse/OWB-171
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Context and Scopes
Affects Versions: M3
Reporter: Sven Linstaedt
Assignee: Gurkan Erdogdu
 Fix For: M4

 Attachments: owb-171.diff, owb-171.diff, owb-171.diff


 The problem:
 GET requests in JSF2 can be handled by the full lifecycle, if the view 
 contains a f:metadata/ with appropriate  f:viewParam/ components. Because 
 no UIViewRoot is restored, but instead a new one is created, no cid can be 
 restored from the view root until WebBeansPhaseListener handles before render 
 rensponse.
 If one  requests the Conversation for injection during the lifecycle 
 ConversationBean.createInstance() is called, which should lookup the 
 conversation on the ConversationManager using the current sessionid and cid. 
 Both string based parameters are again looked up from the 
 ConversationService. Unfortunately ConversationService.getConversationId() 
 uses the ViewRoot's attributes map of current FacesContext to retrieve the 
 cid, which will be first set in the render phase. This results in a new 
 conversation being created. 
 A possible solution would consists of setting the cid as early as the view 
 root is created in restore view.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-176) InterceptionType.AROUND_TIMEOUT is missing

2009-12-18 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-176.
---

Resolution: Fixed

 InterceptionType.AROUND_TIMEOUT is missing
 --

 Key: OWB-176
 URL: https://issues.apache.org/jira/browse/OWB-176
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 AROUND_TIMEOUT must be added

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-144) upgrade OWB TCK from webbeans to weld

2009-12-18 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-144.
---

Resolution: Fixed

 upgrade OWB TCK from webbeans to weld
 -

 Key: OWB-144
 URL: https://issues.apache.org/jira/browse/OWB-144
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 JBoss has renamed the name of JSR-299 from WebBeans to weld. Thus we have to 
 reflect the changes we need for the TCK in our webbeans-tck module.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Integration of JSF2 specific API calls

2009-12-17 Thread Mark Struberg
 JSF2 is backward compatible

Not when it comes to the details!
E.g. try running RichFaces-3.3.2 on a JSF-2 container ;)

There have been a few changes which allows us to create better support for 
JSF2, mostly in the AJAX area. In JSF-1.2 there was no standardised ajax 
handling, so we would have no chance to use those features in a portable 
fashion.

LieGrue,
strub

--- Gurkan Erdogdu cgurkanerdo...@gmail.com schrieb am Do, 17.12.2009:

 Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Betreff: Re: Integration of JSF2 specific API calls
 An: openwebbeans-dev@incubator.apache.org
 Datum: Donnerstag, 17. Dezember 2009, 9:50
 Id favour a
 webbeans-jsf2, I think that's more future proof.
 I think that there is no need to define extra jsf
 module/project. There is
 no such a thing that You could use it in JSF 1.2  but
 not JSF2 or vice
 versa. We support JSF2 and JSF2 is backward compatible.
 But, if we really
 emphasize that the code is related with JSF2, we can
 create a package with
 named jsf2 in webbeans-jsf project.
 
 Thanks;
 
 --Gurkan
 
 2009/12/17 Mark Struberg strub...@yahoo.de
 
  cool!
 
  Id favour a webbeans-jsf2, I think that's more future
 proof.
 
  And as Gurkan already said: please attach the patch as
 owb-171-patch.rfc in
  Jira.
 
  txs and LieGrue,
  strub
 
  --- Sven Linstaedt sven.linsta...@googlemail.com
 schrieb am Do,
  17.12.2009:
 
   Von: Sven Linstaedt sven.linsta...@googlemail.com
   Betreff: Integration of JSF2 specific API calls
   An: openwebbeans-dev@incubator.apache.org
   Datum: Donnerstag, 17. Dezember 2009, 2:24
   Back in business.
  
   I am currently working on a patch for OWB-171.
 Besides some
   cleanups I have refactored the code:
  
   Conversation is request scoped and solely created
 or
   restored by ConversationBean which delegates the
 later one
   to the ConversationManager. WebBeansPhaseListener
 is only
   responsible for retrieving and handling the
   ConversationContext. Conversation is only
 restored using the
   cid request parameter and not the
   UIViewRoot's attributes, because the view is
 only
   accessible after restore view phase. The
 restored
   conversation (and it's context of course) must
 actually
   exist for restoring the view. This chicken or egg
 problem
   was the reason not to store the the cid in the
 view's
   attributes, because restoring these attributes
 actually
   needs restoring the conversation beforehand.
  
  
   There is still an issue with the jsf2-example: In
 case of
   ajax requests which start a long running
 conversation, all
   form's action attributes needs to be updated to
 reflect
   the current active conversation for following
 request. This
   could be done using JSF2 specific API features.
 At the
   moment webbeans-impl is purely compiled against
 the JSF 1.2
   API. Without the necessary abstraction there is
 no chance to
   get the JSF2 specific ajax functionality working
 again.
  
  
   I have attached the patch to this mail and not to
 the
   issue, because the patch is not meant for
 inclusion yet, but
   for testing purposes. Integration it and
 rerunning the
   jsf2-example points out my problem. If you
 disable ajax by
   disabling javascript in your browser e.g. the
 conversation
   example is working, because in this case the full
 page with
   updated form's action urls is rendered during
 each
   action invocation.
  
  
   Last but not least: Do you guys have a glue how
 JSF2
   specific extension for conversation handling
 should be
   integrated? I supose either adding another
 project
   (webbeans-jsf2 e.g.) or updating the JSF API (not
 impl)
   version to 2.x and making sure, we are loading
 JSF2 specific
   classes only for this ajax purpose.
  
  
   good night, Sven
  
  
 
  __
  Do You Yahoo!?
  Sie sind Spam leid? Yahoo! Mail verfügt über einen
 herausragenden Schutz
  gegen Massenmails.
  http://mail.yahoo.com
 
 
 
 
 -- 
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com
 

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


Re: Integration of JSF2 specific API calls

2009-12-17 Thread Mark Struberg
Yes we can start that way.

But having 2 modules would have the benefit that we can define the 
corresponding dependencies and thus make sure that we do not use 'newer' 
features at compile time.

LieGrue,
strub

--- Gurkan Erdogdu cgurkanerdo...@gmail.com schrieb am Do, 17.12.2009:

 Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Betreff: Re: Integration of JSF2 specific API calls
 An: openwebbeans-dev@incubator.apache.org
 Datum: Donnerstag, 17. Dezember 2009, 10:49
 I think we will start
 hacking on the feature and if we hit the point of
 no return we should create an own module.
 We could definitely create a new package for unique JSF2
 features if we will
 have under webbeans-jsf project. So management and
 configuration are much
 more easy with having one JSF module.
 
 
 2009/12/17 Gurkan Erdogdu cgurkanerdo...@gmail.com
 
  What I mean is that,
 
  Our code base has nothing regarding to JSF 1.2 like
 other JSF
  Frameworks/Tools etc. do.
 
  We have just implemented 2 class for conversation
 service
 
  1* WebBeansPhase Listener -- For restore
 conversations
  2* Custom View Handler   
    -- For adding cid to view handler
 
  Both of them work on any JSF1.2 or JSF2
 implementation.
 
  Therefore it is not rational to define new jsf2
 project from my point of
  view. If we were implementing lots of code unique to
 JSF 1.2 then it will be
  reasonable to define new JSF2 project but we did not.
 Actually it is
  meaningless for me to separate JSF 1.2 and JSF 2.
 
  We must not think of such a backward compatibility
 with JSF 1.2 etc because
  we have been implementing Java EE 6 defined JSR-299
 specification.
 
 
  --Gurkan
 
  2009/12/17 Mark Struberg strub...@yahoo.de
 
  Gurkan,
 
  I was not talking about special products, I also
 meant the API and I
  mentioned RichFaces-3.3.2 only as an example. You
 can google for the
  incompatibility problems.
 
  Matter of fact:
  .) EE6 WebProfile defines JSF-2, so from this
 point I'm with you
 
  But:
  .) there is no full stack for JSF-2 on the market
 currently (the component
  libraries are missing, since they are mostly
 incompatible)
  Plus, there will be lot old projects which still
 use JSF-1.2 but may like
  to use OWB for new extensions.
 
  and as such:
  .) providing an easy migration path to EE6 by
 allowing to use JSF-1.2 +
  OWB would imho be a pretty nice goodie.
 
  I don't think it will confuse users if they have a
 choice between a
  JSF-1.2 and a JSF-2 plugin if we explain the
 differences in the
  documentation.
  I think we will start hacking on the feature and
 if we hit the point of no
  return we should create an own module.
 
 
  wdyt?
 
  LieGrue,
  strub
 
  --- Gurkan Erdogdu cgurkanerdo...@gmail.com
 schrieb am Do, 17.12.2009:
 
   Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
   Betreff: Re: Integration of JSF2 specific API
 calls
   An: openwebbeans-dev@incubator.apache.org
   Datum: Donnerstag, 17. Dezember 2009, 10:03
   Hey Mark,
  
   E.g. try running RichFaces-3.3.2 on a
 JSF-2
   container ;)
   Java EE standards do not depend on any
 special product!
   Standards talk about
   API.
  
   In JSF-1.2 there was no standardised
 ajax handling,
   so we would have no
   chance to use those features in a portable
 fashion.
   JSR-299 is contained in Java EE 6. Java EE 6
 defines JSF2
   and when we talk
   about JSF functionality, it means JSF2 not
 JSF1.2 or
   earlier.
   We wrote a little JSF code for conversations
 and at that
   time there was no
   offical MyFaces JSF2 API to use. Now there is
 one and we
   will update our pom
   to use MyFaces JSF2 and we will go ahead with
 it. In fact,
   our codes in
   webbeans-jsf must work within JSF2. Moreover,
 JSF2 is
   compatible with JSF1.2
   as written in Java EE 6 specification.
  
   So all functionality must go into package
 webbeans-jsf.
   There is no need to
   create extra project modules that confuses
 developers
   minds.
  
   Thnks;
  
   --Gurkan
  
   2009/12/17 Mark Struberg strub...@yahoo.de
  
 JSF2 is backward compatible
   
Not when it comes to the details!
E.g. try running RichFaces-3.3.2 on a
 JSF-2 container
   ;)
   
There have been a few changes which
 allows us to
   create better support for
JSF2, mostly in the AJAX area. In
 JSF-1.2 there was no
   standardised ajax
handling, so we would have no chance to
 use those
   features in a portable
fashion.
   
LieGrue,
strub
   
--- Gurkan Erdogdu cgurkanerdo...@gmail.com
   schrieb am Do, 17.12.2009:
   
 Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Betreff: Re: Integration of JSF2
 specific API
   calls
 An: openwebbeans-dev@incubator.apache.org
 Datum: Donnerstag, 17. Dezember
 2009, 9:50
 Id favour a
 webbeans-jsf2, I think that's more
 future proof.
 I think that there is no need to
 define extra
   jsf
 module/project. There is
 no such a thing that You could use
 it in JSF
   1.2  but
 not JSF2 or vice
 versa

Congratulations! OpenWebBeans is now a TLP

2009-12-17 Thread Mark Struberg
Hi!

From the ASF board meeting report:

 The following resolutions were passed unaminously:
 ...
   B. Establish the Apache OpenWebBeans Project (Gurkan Erdogdu, VP)

Congratulations all for the hard and successful work!

I'd like to specially thank our Mentors Kevan and Matthias for their support 
and of course Gurkan for doing most of the actual hacking :)

LieGrue,
strub

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


[jira] Created: (OWB-190) Make the TestLifeCycles available in webbeans-impl

2009-12-15 Thread Mark Struberg (JIRA)
Make the TestLifeCycles available in webbeans-impl
--

 Key: OWB-190
 URL: https://issues.apache.org/jira/browse/OWB-190
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Lifecycle
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


Currently the OpenWebBeansTestLifecycle is only available internally for the 
tests and via the tests.jar.

This is not usable for running automated function tests in projects which use 
OWB.
I'd like to move over the OpenWebBeansTestLifeCycle (where one has to manually 
select all classes which should get scanned) to a new lifecycle.test package 
and also add a new EnterpriseTestLifeCycle which scanns all classes on the 
classpaths according to the spec.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



AW: Removing webbeans-api and atinject-api

2009-12-14 Thread Mark Struberg
cool!
+1

How does the Release process and patching work?
Do we have commit rights for e.g. improving the JavaDoc in geronimo-specs?

How is the release process working? Are we obliged to release those 2 modules 
or do we have to send a request to geronimo-dev?

txs and LieGrue,
strub

--- Gurkan Erdogdu cgurkanerdo...@gmail.com schrieb am Di, 15.12.2009:

 Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Betreff: Removing webbeans-api and atinject-api
 An: openwebbeans-dev@incubator.apache.org
 Datum: Dienstag, 15. Dezember 2009, 7:59
 Hi folks;
 
 We have pushed those projects into 
 https://svn.apache.org/repos/asf/geronimo/specs/trunk/;
 with
 
 JSR-299 API -- geronimo-cdi_1.0_spec/
 JSR-330 API -- geronimo-atinject_1.0_spec/
 
 And snapshots are located at
 http://repository.apache.org/snapshots/org/apache/geronimo/specs/.http://repository.apache.org/snapshots/org/apache/geronimo/specs/
 
 I will remove those projects from our svn if there is no
 objection? After
 that we patch geronimo-spec project for updating
 
 Thanks;
 
 --Gurkan
 

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


Re: [jira] Resolved: (OWB-188) remove webbeans-jpa and cleanup webbeans-resource

2009-12-11 Thread Mark Struberg
 We sure that all examples still work :)
Heh, I hope so, I at least tried out samples/guess and samples/reservation 
before checking in ;)

I hope I can sum up the magic behind this (maybe even in the new xdoc) this 
weekend.

In general it seems like we have a 3-staged mechanism (even if this is not so 
visible from the first glance)

1st layer: 
webbeans-core

2nd layer: 
the general plugin on a specific specification area (e.g. JMS, JPA, EJB)

3rd layer: 
the 2) bound to a specific product or technique: e.g. the JPA Implementation 
for SE (provided originally with webbeans-jpa, now moved over to 
webbeans-resource) will give you a @PersistenceContext EntityManager with 
PersitenceType.EXTENDED whereas if you switch over to the SPI Implementation 
from webbeans-geronimo you will get a TRANSACTIONAL PersistenceContext (which 
we get from OpenEJB + it's JTA layer).
It's really important to know these differences and to understand the 
fundamentally different way those 2 EntityManagers work internally. But I think 
David or the other geronimo and OpenEJB folks here can explain this much better 
than I can, so I'll focus on the OWB part.

LieGrue,
strub


--- Gurkan Erdogdu cgurkanerdo...@gmail.com schrieb am Fr, 11.12.2009:

 Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Betreff: Re: [jira] Resolved: (OWB-188) remove webbeans-jpa and cleanup  
 webbeans-resource
 An: openwebbeans-dev@incubator.apache.org
 Datum: Freitag, 11. Dezember 2009, 10:51
 Awesome thanks! Good idea to throw
 out trashed code.
 
 We sure that all examples still work :)
 
 --Gurkan
 
 2009/12/11 Mark Struberg (JIRA) j...@apache.org
 
 
      [
  https://issues.apache.org/jira/browse/OWB-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
 
  Mark Struberg resolved OWB-188.
  ---
 
     Resolution: Fixed
 
   remove webbeans-jpa and cleanup
 webbeans-resource
  
 -
  
               
    Key: OWB-188
               
    URL: https://issues.apache.org/jira/browse/OWB-188
           
    Project: OpenWebBeans
            Issue Type:
 Improvement
      Affects Versions: M3
             
 Reporter: Mark Struberg
             
 Assignee: Mark Struberg
           
    Fix For: M4
  
  
   Most of the code from webbeans-jpa has been
 dupped over to
  webbeans-resource. The whole plugin is now essentially
 obsolete and shall be
  removed.
   We also have to cleanup webbeans-resource and
 webbeans-geronimo and
  remove unused code.
 
  --
  This message is automatically generated by JIRA.
  -
  You can reply to this email to add a comment to the
 issue online.
 
 
 
 
 -- 
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com
 

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


Re: [jira] Resolved: (OWB-188) remove webbeans-jpa and cleanup webbeans-resource

2009-12-11 Thread Mark Struberg
true, I think we should really go and rename webbeans-geronimo to 
webbeans-openejb.

In fact there is a 4th layer: the integration via bundles of 3) for the default 
packages of various containers (all with preconfigured openwebbeans.properties):

just a few ideas
bundles/geronimo (MyFaces + OpenEJB + OpenJPA ...)
bundles/web_se (MyFaces + OpenJPA)
bundles/web_wicket(wicket + OpenJPA)
bundles/standalone 

LieGrue,
strub

--- Gurkan Erdogdu cgurkanerdo...@gmail.com schrieb am Fr, 11.12.2009:

 Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Betreff: Re: [jira] Resolved: (OWB-188) remove webbeans-jpa and cleanup  
 webbeans-resource
 An: openwebbeans-dev@incubator.apache.org
 Datum: Freitag, 11. Dezember 2009, 12:30
 Good seperation Mark!
 
 Actually webbeans-geronimo will be leading to some
 confusion. The main
 motivation behind this project was that it will include
 integration code for
 geronimo .But currently it includes OpenEJB code. I think
 that we have to
 separate those things and some refactoring.
 
 My advice is that
 
 1* Change project name of webbeans-ejb --
 webbeans-openejb as Mark stated
 earlier
 2* Move OpenEJB related code from webbeans-geronimo to
 webbeans-ejb
 3* Remove webbeans-geronimo
     In reality Geronimo integration code will be
 implemented in the Geronimo
 code base using its plugin architecture. This will use the
 same technique
 for what happened to MyFaces and OpenJPA, OpenEJB etc.
 integration.
 
 
 --Gurkan
 
 
 2009/12/11 Mark Struberg strub...@yahoo.de
 
   We sure that all examples still work :)
  Heh, I hope so, I at least tried out samples/guess and
 samples/reservation
  before checking in ;)
 
  I hope I can sum up the magic behind this (maybe even
 in the new xdoc) this
  weekend.
 
  In general it seems like we have a 3-staged mechanism
 (even if this is not
  so visible from the first glance)
 
  1st layer:
  webbeans-core
 
  2nd layer:
  the general plugin on a specific specification area
 (e.g. JMS, JPA, EJB)
 
  3rd layer:
  the 2) bound to a specific product or technique: e.g.
 the JPA
  Implementation for SE (provided originally with
 webbeans-jpa, now moved over
  to webbeans-resource) will give you a
 @PersistenceContext EntityManager with
  PersitenceType.EXTENDED whereas if you switch over to
 the SPI Implementation
  from webbeans-geronimo you will get a TRANSACTIONAL
 PersistenceContext
  (which we get from OpenEJB + it's JTA layer).
  It's really important to know these differences and to
 understand the
  fundamentally different way those 2 EntityManagers
 work internally. But I
  think David or the other geronimo and OpenEJB folks
 here can explain this
  much better than I can, so I'll focus on the OWB
 part.
 
  LieGrue,
  strub
 
 
  --- Gurkan Erdogdu cgurkanerdo...@gmail.com
 schrieb am Fr, 11.12.2009:
 
   Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
   Betreff: Re: [jira] Resolved: (OWB-188) remove
 webbeans-jpa and cleanup
   webbeans-resource
   An: openwebbeans-dev@incubator.apache.org
   Datum: Freitag, 11. Dezember 2009, 10:51
   Awesome thanks! Good idea to throw
   out trashed code.
  
   We sure that all examples still work :)
  
   --Gurkan
  
   2009/12/11 Mark Struberg (JIRA) j...@apache.org
  
   
        [
   
  https://issues.apache.org/jira/browse/OWB-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
  ]
   
Mark Struberg resolved OWB-188.
---
   
       Resolution: Fixed
   
 remove webbeans-jpa and cleanup
   webbeans-resource

  
 -


      Key: OWB-188

      URL: https://issues.apache.org/jira/browse/OWB-188

      Project: OpenWebBeans
          Issue
 Type:
   Improvement
    Affects Versions: M3

   Reporter: Mark Struberg

   Assignee: Mark Struberg

      Fix For: M4


 Most of the code from webbeans-jpa has
 been
   dupped over to
webbeans-resource. The whole plugin is now
 essentially
   obsolete and shall be
removed.
 We also have to cleanup
 webbeans-resource and
   webbeans-geronimo and
remove unused code.
   
--
This message is automatically generated by
 JIRA.
-
You can reply to this email to add a comment
 to the
   issue online.
   
   
  
  
   --
   Gurkan Erdogdu
   http://gurkanerdogdu.blogspot.com
  
 
  __
  Do You Yahoo!?
  Sie sind Spam leid? Yahoo! Mail verfügt über einen
 herausragenden Schutz
  gegen Massenmails.
  http://mail.yahoo.com
 
 
 
 
 -- 
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com
 

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


Upgrade to JPA2?

2009-12-10 Thread Mark Struberg
Hi!

I'm currently preparing the upgrade to JPA-2 since this is the version which is 
defined in the EE6 Web profile.

I write this mail because there is a bit of confusion about the spec versions. 
JPA1 was part of EJB3 and thus the artifact was called geronimo-jpa_3.0_spec. 
So the '3.0' meant EJB-3.0!

Now, JPA became an own JSR and geronimo folks decided to name it 
geronimo-jpa_2.0_spec. Here the '2.0' means JPA-2.0! 
The current version is 1.0-PFD2.

So geronimo-jpa_2.0_spec is NEWER than geronimo-jpa_3.0_spec :)
I was also a bit confused, but Michael Dick told me that my assumptions were 
right.

I will also upgrade all out tests to OpenJPA-2.0.0-M3 which got released a 
short time ago.


LieGrue,
strub

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


[jira] Created: (OWB-186) Upgrade OWB to the JPA-2 spec

2009-12-10 Thread Mark Struberg (JIRA)
Upgrade OWB to the JPA-2 spec
-

 Key: OWB-186
 URL: https://issues.apache.org/jira/browse/OWB-186
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Enterprise Web Beans
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


The EE6 Web profile defines JPA2 as persistence provider technologie. Thus we 
shall upgrade to the jpa2-api and OpenJPA-2.0.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-186) Upgrade OWB to the JPA-2 spec

2009-12-10 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-186.
---

Resolution: Fixed

implemented in Revision 889274

 Upgrade OWB to the JPA-2 spec
 -

 Key: OWB-186
 URL: https://issues.apache.org/jira/browse/OWB-186
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Enterprise Web Beans
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 The EE6 Web profile defines JPA2 as persistence provider technologie. Thus we 
 shall upgrade to the jpa2-api and OpenJPA-2.0.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



webbeans-jpa vs webbeans-resource

2009-12-10 Thread Mark Struberg
Gurkan!

It seems you duplicated the jpa part to the resource plugin.
It seems there are a bunch of cleanup tasks left open.

I think we can drop the webbeans-jpa, and I will cleanup webbeans-resource and 
webbeans-geronimo accordingly, ok?

LieGrue,
strub



__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


[jira] Created: (OWB-188) remove webbeans-jpa and cleanup webbeans-resource

2009-12-10 Thread Mark Struberg (JIRA)
remove webbeans-jpa and cleanup webbeans-resource
-

 Key: OWB-188
 URL: https://issues.apache.org/jira/browse/OWB-188
 Project: OpenWebBeans
  Issue Type: Improvement
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


Most of the code from webbeans-jpa has been dupped over to webbeans-resource. 
The whole plugin is now essentially obsolete and shall be removed.
We also have to cleanup webbeans-resource and webbeans-geronimo and remove 
unused code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: December Report

2009-12-09 Thread Mark Struberg
+1, looks fine :)

btw, I hope that the bugs in the TCK get fixed soon ;)

LieGrue,
strub

--- Matthias Wessendorf mat...@apache.org schrieb am Mi, 9.12.2009:

 Von: Matthias Wessendorf mat...@apache.org
 Betreff: Re: December Report
 An: openwebbeans-dev@incubator.apache.org
 Datum: Mittwoch, 9. Dezember 2009, 11:10
 looks good so far...
 
 On Wed, Dec 9, 2009 at 10:35 AM, Gurkan Erdogdu
 cgurkanerdo...@gmail.com
 wrote:
  Hi folks;
 
  I have written our December Report
  http://wiki.apache.org/incubator/December2009.
 
  Today is the last day for sending reports.
 
  Thanks;
 
  --Gurkan
 
 
 
 
 -- 
 Matthias Wessendorf
 
 blog: http://matthiaswessendorf.wordpress.com/
 sessions: http://www.slideshare.net/mwessendorf
 twitter: http://twitter.com/mwessendorf
 

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


Re: About JSR-299 and JSR-330 API

2009-12-09 Thread Mark Struberg
Just 2 make sure we all speak about the same:

We'd like to move over the atinject-api which only contains the annotations of 
JSR-330. (This is similar to commons-annotations)

OpenWebBeans implements processing functionality for those annotations as part 
of the JSR-299 implementation and passes the JSR-330 TCK. There is no separate 
JSR-330-container or something.

So assumed we speak about only the api, then I'm d'accord we should release it 
as 1.0.0

LieGrue,
strub


--- Matthias Wessendorf mat...@apache.org schrieb am Mi, 9.12.2009:

 Von: Matthias Wessendorf mat...@apache.org
 Betreff: Re: About JSR-299 and JSR-330 API
 An: d...@geronimo.apache.org
 CC: openwebbeans-dev@incubator.apache.org
 Datum: Mittwoch, 9. Dezember 2009, 14:16
 IMO would be cool if there is a
 standalone release of that soon.
 As this passed the TCK, we even do not need to say alpha
 or so, on that...
 
 -Matthias
 
 On Wed, Dec 9, 2009 at 12:28 PM, Gurkan Erdogdu
 cgurkanerdo...@gmail.com
 wrote:
  Hi folks;
 
  We would like to port our JSR-299 and JSR-330 related
 API projects into
  Geronimo spec. project. How could we start ?
 
  Thanks;
 
  --Gurkan
 
 
 
 
 -- 
 Matthias Wessendorf
 
 blog: http://matthiaswessendorf.wordpress.com/
 sessions: http://www.slideshare.net/mwessendorf
 twitter: http://twitter.com/mwessendorf
 

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


[jira] Commented: (OWB-182) Even if @PreDestroy is used in an Interceptor, it doesn't need an InvoicationContext parameter

2009-12-02 Thread Mark Struberg (JIRA)

[ 
https://issues.apache.org/jira/browse/OWB-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784742#action_12784742
 ] 

Mark Struberg commented on OWB-182:
---

oki, command return ;)

After a long discussion on the JSR-299 list it turns out that CDI will not 
support this 'new oldschool' type of @PreDestroy on Interceptors.
Instead each JSR-299 container must act in an EJB specification compatible way:
@PreDestroy, @PostConstruct et al on an Interceptor must have an 
InvoicationContext parameter as our original implementation did force.

The weld team will fix the corresponding TCK test.

 Even if @PreDestroy is used in an Interceptor, it doesn't need an 
 InvoicationContext parameter
 --

 Key: OWB-182
 URL: https://issues.apache.org/jira/browse/OWB-182
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 thus we must disable the check in WebBeansUtils#configureInterceptorMethods

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OWB-182) Even if @PreDestroy is used in an Interceptor, it doesn't need an InvoicationContext parameter

2009-12-02 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg closed OWB-182.
-


 Even if @PreDestroy is used in an Interceptor, it doesn't need an 
 InvoicationContext parameter
 --

 Key: OWB-182
 URL: https://issues.apache.org/jira/browse/OWB-182
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 thus we must disable the check in WebBeansUtils#configureInterceptorMethods

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Reopened: (OWB-127) @Stateful EJBs have to be handled as being passivation capable

2009-12-02 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg reopened OWB-127:
---


WebBeansUtil#checkPassivationScope still fails with a 
WebBeansPassivationException while handling @Stateful session beans.

 @Stateful EJBs have to be handled as being passivation capable
 --

 Key: OWB-127
 URL: https://issues.apache.org/jira/browse/OWB-127
 Project: OpenWebBeans
  Issue Type: Bug
Reporter: Mark Struberg
Assignee: Gurkan Erdogdu
 Fix For: M4


 Currently the container complains about @Stateful session beans do not have 
 the Interface Serializable.
 This check must not be performed for stateful session beans, since they are 
 per se passivation capable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Apache Web Profile Edition of the Java EE 6 standard ?

2009-12-02 Thread Mark Struberg
Txs Matthias!

I just wonder about the @ManagedBean, because I still couldn't find anything in 
the official JSF-2 spec (and also nothing about the JSF scopes! 
Gerhard Petracek pointed me to the Mojarra where this is also implemented, but 
it this 'official' now?

I'd like to implement a JSR-299 extension which basically provides an alias 
between javax.faces.scopes.SessionScoped and 
javax.enterprise.context.SessionScoped and others. As well as a JSR-299 
implementation of the FlashScoped and support for @ManagedBean of course. The 
goal is to be able to disable the whole DI part of MyFaces/Mojarra somehow 
(haven't looked at it) and use OWB instead if it is available.

txs and LieGrue,
strub

--- Gurkan Erdogdu cgurkanerdo...@gmail.com schrieb am Mi, 2.12.2009:

 Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Betreff: Re: Apache Web Profile Edition of the Java EE 6 standard ?
 An: openwebbeans-dev@incubator.apache.org
 Datum: Mittwoch, 2. Dezember 2009, 12:29
 Yeah, that will be awesome.
 
 --Gurkan
 
 2009/12/2 Matthias Wessendorf mat...@apache.org
 
  FYI
 
  http://markmail.org/message/kbnb2imqdohkra7f
 
  -Matthias
 
  --
  Matthias Wessendorf
 
  blog: http://matthiaswessendorf.wordpress.com/
  sessions: http://www.slideshare.net/mwessendorf
  twitter: http://twitter.com/mwessendorf
 
 
 
 
 -- 
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com
 

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


TCK bugfixes

2009-12-02 Thread Mark Struberg
Hi folks!

I have tweaked the JSR-299 TCK and now a bit more tests pass.

I also found (and reported) a few bugs in the TCK, so for now, you should 
checkout the TCK from

http://anonsvn.jboss.org/repos/weld/cdi-tck/trunk

and update the dependencyin openwebbeans-tck to 1.1.0-SNAPSHOT again.

Pete will fix the TCK on the weekend, but for now you need to apply the patch I 
added.

LieGrue,
strub

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com Index: impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/KokkolaInterceptor.java
===
--- impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/KokkolaInterceptor.java	(Revision 5190)
+++ impl/src/main/java/org/jboss/jsr299/tck/tests/context/passivating/KokkolaInterceptor.java	(Arbeitskopie)
@@ -9,7 +9,7 @@
 public class KokkolaInterceptor implements Serializable
 {
@AroundInvoke
-   public Object intercept(InvocationContext context)
+   public Object intercept(InvocationContext context) throws Exception
{
   // do nothing
   return null;
Index: impl/src/main/java/org/jboss/jsr299/tck/tests/context/dependent/TransactionalInterceptor.java
===
--- impl/src/main/java/org/jboss/jsr299/tck/tests/context/dependent/TransactionalInterceptor.java	(Revision 5190)
+++ impl/src/main/java/org/jboss/jsr299/tck/tests/context/dependent/TransactionalInterceptor.java	(Arbeitskopie)
@@ -18,7 +18,7 @@
   return ctx.proceed();
}
 
-   @PreDestroy public void destroy()
+   @PreDestroy public void destroy(InvocationContext ctx)
{
   destroyed = true;
}


[jira] Created: (OWB-184) BeanManager itself needs to be added as managed bean

2009-12-02 Thread Mark Struberg (JIRA)
BeanManager itself needs to be added as managed bean


 Key: OWB-184
 URL: https://issues.apache.org/jira/browse/OWB-184
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


The BeanManager itself needs to be added as manages bean at the time we 
bootstrap the lifecycle.
This needs to be done to be able to @Inject BeanManager bm; which a lot TCK 
tests rely on.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OWB-184) BeanManager itself needs to be added as managed bean

2009-12-02 Thread Mark Struberg (JIRA)

[ 
https://issues.apache.org/jira/browse/OWB-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784817#action_12784817
 ] 

Mark Struberg commented on OWB-184:
---

after further debugging it turned out that we already deploy the 
BeanManagerBean in
BeansDeployer#configureDefaultBeans()

My problem seems to be a undeploy issue:

{noformat}
ObserverMethodImplT.getMethodArguments(Object) line: 271  
ObserverMethodImplT.notify(T) line: 188   
NotificationManager.fireEvent(Object, Annotation...) line: 239  
BeanManagerImpl.fireEvent(Object, Annotation...) line: 302  
EnterpriseLifeCycle.applicationEnded(Object) line: 218  
StandaloneContainersImpl.undeploy() line: 144   
{noformat}

just a gut feeling:
Bean? bean = InjectionResolver.getInstance().implResolveByType(type, 
bindingTypes).iterator().next(); 
doesn't find the BeanManagerBean anymore, because it seems to be be terminated 
already...



 BeanManager itself needs to be added as managed bean
 

 Key: OWB-184
 URL: https://issues.apache.org/jira/browse/OWB-184
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 The BeanManager itself needs to be added as manages bean at the time we 
 bootstrap the lifecycle.
 This needs to be done to be able to @Inject BeanManager bm; which a lot TCK 
 tests rely on.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



RE: Documentation: first draft

2009-12-01 Thread Mark Struberg
it seems that our list drops the attachment.

LieGrue,
strub

--- Monteiro Jean-Louis jean-louis.monte...@atosorigin.com schrieb am Di, 
1.12.2009:

 Von: Monteiro Jean-Louis jean-louis.monte...@atosorigin.com
 Betreff: RE: Documentation: first draft
 An: openwebbeans-dev@incubator.apache.org 
 openwebbeans-dev@incubator.apache.org
 Datum: Dienstag, 1. Dezember 2009, 10:31
 No, but here is again the document.
 
 Jean-Louis
 
 -Message d'origine-
 De : Gurkan Erdogdu [mailto:cgurkanerdo...@gmail.com]
 Envoyé : mardi 1 décembre 2009 10:31
 À : openwebbeans-dev@incubator.apache.org
 Objet : Re: Documentation: first draft
 
 Hi Jean-Louis;
 
 Do you forget to attach first draft ?
 
 Thanks;
 
 --Gurkan
 
 2009/12/1 Monteiro Jean-Louis jean-louis.monte...@atosorigin.com
 
   Hi all,
 
 
 
  I've been working on the documentation.
 
  I refactored a lot of things to make all more sexy and
 professional.
 
 
 
  Before submitting a patch, I'd like to have your
 opinion.
 
  I'm ready to change whatever you want.
 
 
 
  Any feedback is welcome.
 
 
 
  * *
 
  *Jean-Louis*
 
  --
 
  Ce message et les pièces jointes sont confidentiels
 et réservés à l'usage
  exclusif de ses destinataires. Il peut également
 être protégé par le secret
  professionnel. Si vous recevez ce message par erreur,
 merci d'en avertir
  immédiatement l'expéditeur et de le détruire.
 L'intégrité du message ne
  pouvant être assurée sur Internet, la
 responsabilité du groupe Atos Origin
  ne pourra être recherchée quant au contenu de ce
 message. Bien que les
  meilleurs efforts soient faits pour maintenir cette
 transmission exempte de
  tout virus, l'expéditeur ne donne aucune garantie à
 cet égard et sa
  responsabilité ne saurait être recherchée pour tout
 dommage résultant d'un
  virus transmis.
 
  This e-mail and the documents attached are
 confidential and intended solely
  for the addressee; it may also be privileged. If you
 receive this e-mail in
  error, please notify the sender immediately and
 destroy it. As its integrity
  cannot be secured on the Internet, the Atos Origin
 group liability cannot be
  triggered for the message content. Although the sender
 endeavours to
  maintain a computer virus-free network, the sender
 does not warrant that
  this transmission is virus-free and will not be liable
 for any damages
  resulting from any virus transmitted.
 
 
 
 
 --
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com
 
 
 Ce message et les pièces jointes sont confidentiels et
 réservés à l'usage exclusif de ses destinataires. Il peut
 également être protégé par le secret professionnel. Si
 vous recevez ce message par erreur, merci d'en avertir
 immédiatement l'expéditeur et de le détruire.
 L'intégrité du message ne pouvant être assurée sur
 Internet, la responsabilité du groupe Atos Origin ne pourra
 être recherchée quant au contenu de ce message. Bien que
 les meilleurs efforts soient faits pour maintenir cette
 transmission exempte de tout virus, l'expéditeur ne donne
 aucune garantie à cet égard et sa responsabilité ne
 saurait être recherchée pour tout dommage résultant d'un
 virus transmis.
 
 This e-mail and the documents attached are confidential and
 intended solely for the addressee; it may also be
 privileged. If you receive this e-mail in error, please
 notify the sender immediately and destroy it. As its
 integrity cannot be secured on the Internet, the Atos Origin
 group liability cannot be triggered for the message content.
 Although the sender endeavours to maintain a computer
 virus-free network, the sender does not warrant that this
 transmission is virus-free and will not be liable for any
 damages resulting from any virus transmitted.
 

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


Re: Documentation: first draft

2009-12-01 Thread Mark Struberg
looks pretty fine!

LieGrue,
strub

--- Jean-Louis MONTEIRO jeano...@gmail.com schrieb am Di, 1.12.2009:

 Von: Jean-Louis MONTEIRO jeano...@gmail.com
 Betreff: Re: Documentation: first draft
 An: openwebbeans-dev@incubator.apache.org
 Datum: Dienstag, 1. Dezember 2009, 13:20
 Done https://issues.apache.org/jira/browse/OWB-183
 Gurkan, I was not able to assign it to me, so feel free to
 do it if you
 want.
 
 Jean-Louis
 
 
 2009/12/1 Gurkan Erdogdu cgurkanerdo...@gmail.com
 
  Better is to create a JIRA issue and attach artifacts
 to it.
 
  You could create a issue here : http://issues.apache.org/jira/browse/OWB
 
  Thanks;
 
  --Gurkan
 
  2009/12/1 Jean-Louis MONTEIRO jeano...@gmail.com
 
   Sorry for the spam
   it should work better with my gmail.
  
   Jean-Louis
  
   2009/12/1 Monteiro Jean-Louis jean-louis.monte...@atosorigin.com
  
  
  
  
  
   *De :* Monteiro Jean-Louis
   *Envoyé :* mardi 1 décembre 2009 10:28
  
   *À :* openwebbeans-dev@incubator.apache.org
   *Objet :* Documentation: first draft
  
  
  
   Hi all,
  
  
  
   I’ve been working on the documentation.
  
   I refactored a lot of things to make all more
 sexy and professional.
  
  
  
   Before submitting a patch, I’d like to have
 your opinion.
  
   I’m ready to change whatever you want.
  
  
  
   Any feedback is welcome.
  
  
  
   * *
  
   *Jean-Louis*
  
   --
  
   Ce message et les pièces jointes sont
 confidentiels et réservés à
  l'usage
   exclusif de ses destinataires. Il peut
 également être protégé par le
  secret
   professionnel. Si vous recevez ce message par
 erreur, merci d'en avertir
   immédiatement l'expéditeur et de le
 détruire. L'intégrité du message ne
   pouvant être assurée sur Internet, la
 responsabilité du groupe Atos
  Origin
   ne pourra être recherchée quant au contenu
 de ce message. Bien que les
   meilleurs efforts soient faits pour maintenir
 cette transmission exempte
  de
   tout virus, l'expéditeur ne donne aucune
 garantie à cet égard et sa
   responsabilité ne saurait être recherchée
 pour tout dommage résultant
  d'un
   virus transmis.
  
   This e-mail and the documents attached are
 confidential and intended
   solely for the addressee; it may also be
 privileged. If you receive this
   e-mail in error, please notify the sender
 immediately and destroy it. As
  its
   integrity cannot be secured on the Internet,
 the Atos Origin group
  liability
   cannot be triggered for the message content.
 Although the sender
  endeavours
   to maintain a computer virus-free network,
 the sender does not warrant
  that
   this transmission is virus-free and will not
 be liable for any damages
   resulting from any virus transmitted.
  
  
  
  
 
 
  --
  Gurkan Erdogdu
  http://gurkanerdogdu.blogspot.com
 
 

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


AW: [VOTE] Graduation as TLP

2009-12-01 Thread Mark Struberg
+1 

LieGrue,
strub

--- Gurkan Erdogdu gurkanerdo...@yahoo.com schrieb am Di, 1.12.2009:

 Von: Gurkan Erdogdu gurkanerdo...@yahoo.com
 Betreff: [VOTE] Graduation as TLP
 An: openwebbeans-dev@incubator.apache.org
 Datum: Dienstag, 1. Dezember 2009, 20:13
 Hi;
 
 I would like to start a VOTE for graduating OWB as TLP.
 
 Please cast your VOTEs here. VOTE is open for 72 hours.
  
  [-1] Do not graduate as TLP
  [0 ] Do not care TLP or not
  [+1] Graduate as TLP
  
 Here's my +1.
 
 Incubator Status Page
 ---
 http://incubator.apache.org/projects/openwebbeans.html
 (I have updated checklists, it will appear in a couple of
 hours)
 
 Board Resolution Report
 ---
 
 WHEREAS, the Board of Directors deems it to be in the best
 interests of the
 Foundation and consistent with the Foundation's purpose to
 establish a Project,
 to be known as Apache OpenWebBeans, related to the
 implementation of the
 JSR-299,i.e Contexts and Dependency Injection for the Java
 EE platform, for
 distribution at no charge to the public.
 
 NOW, THEREFORE, BE IT RESOLVED, that a Project Management
 Committee (PMC) is
 hereby established pursuant to Bylaws of the Foundation;
 and be it further
 
 RESOLVED, that the Apache OpenWebBeans Project be and
 hereby is
 responsible for the creation and maintenance of a software
 project related to JSR299, Context and Dependency Injection
 for the
 Java EE Platform; and be it further
 
 RESOLVED, that the Apache OpenWebBeans PMC be and hereby is
 charged with the
 creation and maintenance of Apache OpenWebBeans; and be it
 further
 
 RESOLVED, that the office of Vice President, Apache
 OpenWebBeans be and hereby
 is created, the person holding such office to serve at the
 direction of the
 Board of Directors as the chair of Apache OpenWebBeans, and
 to have primary
 responsibility for management of the projects within the
 scope of responsibility
 of the Apache OpenWebBeans PMC; and be it further
 
 RESOLVED, that the persons listed immediately below be and
 hereby are appointed
 to serve as the initial members of the Apache OpenWebBeans
 PMC:
 
 * Gurkan Erdogdu (gurkanerdogdu at yahoo dot com)
 * Kevan Miller  (kevan dot miller at gmail dot com)
 * Mark Struberg  (struberg at yahoo dot com)
 * Joe Bergmark  (bergmark at gmail dot com)
 * Eric Covener (covener at gmail dot com)
 * David Blevins (david dot blevins at visi dot com)
 
 NOW, THEREFORE, BE IT FURTHER RESOLVED, that Gurkan Erdogdu
 be appointed to the
 office of Vice President, Apache OpenWebBeans, to serve in
 accordance with and
 subject to the direction of the Board of Directors and the
 Bylaws of the
 Foundation until death, resignation, retirement, removal or
 disqualification, or
 until a successor is appointed; and be it further
 
 RESOLVED, that Apache OpenWebBeans be and hereby is tasked
 with the migration
 and rationalization of the Apache Incubator OpenWebBeans
 podling; and be it
 further
 
 RESOLVED, that all responsibilities pertaining to the
 Apache Incubator
 OpenWebBeans podling encumbered upon the Apache Incubator
 PMC are hereafter
 discharged.
 
 
 
       

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


Re: tons of skipped TCK tests

2009-11-30 Thread Mark Struberg
Thanks Gurkan!

It's still not really clear to me, so maybe I should try to sum it up again:

ad 1) I moved the OpenEJB.init() to StandaloneContainersImpl#setup() so this 
initialisation will only be performed if we dont test against tomcat. It simply 
doesn't work here after a clean checkout. Do you have JBossAS in your 
classpath? Maybe I oversee something...

ad 2)
Still it is not really clear to me how the TCK suite works on your computer. 
With a standard tomcat-6.0.18 I experienced exactly the same 
DeploymentException (and thus skipped tests) as when running in a standalone 
mode. The few Exceptions I fixed yesterday (package scope constructor) have 
nothing to do with EJB at all. And they aborted almost all the TCK tests.
Can you please try to clean your .m2/repository? Maybe we face some artifact 
clash?

For the unpacking vs dependency: the only thing which matters is if the jars 
are on the classpath. This is the case in both ways. The only subtle difference 
is if we would like to apply some kind of byte code enhancement (which we don't 
do).


LieGrue,
strub

--- Gurkan Erdogdu gurkanerdo...@yahoo.com schrieb am Mo, 30.11.2009:

 Von: Gurkan Erdogdu gurkanerdo...@yahoo.com
 Betreff: Re: tons of skipped TCK tests
 An: openwebbeans-dev@incubator.apache.org
 Datum: Montag, 30. November 2009, 18:22
 For question 1 :
 OpenEJB is used with Apache Tomcat as an embeddable. It is
 not enabled as default. If you deploy WAR archive that
 contains EJB classes, EJBs are deployed by the OpenEJB
 before contextInitialized() is called.  We configure
 OWB in contextInitialized so we can get that which class
 is EJB or not. There is no start-up logic beyon this.
 
 For question 2 :
 We must run TCK in embeddable OpenEJB in Tomcat. So
 dependency:copy adds all necessary jar into each test WAR
 archive lib folder. I do not see any skipped test in my
 environment. Maybe your Tomcat configuration is wrong. 
 
 --Gurkan
 
 
 
 
 
 From: Mark Struberg strub...@yahoo.de
 To: openwebbeans-dev@incubator.apache.org
 Sent: Sat, November 28, 2009 11:27:02 AM
 Subject: tons of skipped TCK tests
 
 Hi!
 
 I'm playing around with the TCK suite for a few days and
 almost all tests got skipped. I tried this with tomcat and
 also as standalone, and both give similar results.
 
 Let's stick with the standalone container for now:
 
 1.) The webbeans-ejb plugin (which we should rename to
 webbeans-openejb imho, because it uses a lot internal
 OpenEJB functionality) doesn't get startet up correctly. I
 fixed that part in the PluginLoader and added a starup logic
 to the EJBPlugin. I'm not sure about this part since OpenEJB
 should already be started up, isn't? In the TCK it isn't so
 I got a NullPointerException because 
 SystemInstance.get().getComponent(ContainerSystem.class);
 returned null.
 
 We should sum up in which scenarios OpenEJB gets started up
 at which point in time/bootstrapped from which component.
 
 2.) I'm not sure why all the dependencies got copied over
 with dependency:copy instead of simply setting the test
 dependencies? Imho the only thing we have to dependency:copy
 are those parts which are accessed via a file path instead
 of getting it via the classloader (afaik only the
 testng-suite.xml)
 
 Oki, that should be it for now ;)
 
 I'll continue to figure out why most of the TCK tests get
 skipped.
 
 LieGrue,
 strub
 
 __
 Do You Yahoo!?
 Sie sind Spam leid? Yahoo! Mail verfügt über einen
 herausragenden Schutz gegen Massenmails. 
 http://mail.yahoo.com
 
 
 
       

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


Re: tons of skipped TCK tests

2009-11-30 Thread Mark Struberg
 ad 1) I moved the
 OpenEJB.init() to StandaloneContainersImpl#setup() so this
 initialisation will only be performed if
 It is not necessary to call OpenEJB.init in standalone
 mode. We do not provide EJB functionality in standalone
 mode. It works only in container mode.

The effect I had: IF the webbeans-ejb module is on the classpath, the EjbPlugin 
gets picked up and tries to ask the EJB Container for information. Since we 
don't change the dependencies (or currently: the unpacking) if we run as 
StandaloneContainers, it's the same as running in tomcat. And therefore OpenEJB 
must be started up even in this mode.

LieGrue,
strub


--- Gurkan Erdogdu gurkanerdo...@yahoo.com schrieb am Di, 1.12.2009:

 Von: Gurkan Erdogdu gurkanerdo...@yahoo.com
 Betreff: Re: tons of skipped TCK tests
 An: openwebbeans-dev@incubator.apache.org
 Datum: Dienstag, 1. Dezember 2009, 6:18
 ad 1) I moved the
 OpenEJB.init() to StandaloneContainersImpl#setup() so this
 initialisation will only be performed if
 It is not necessary to call OpenEJB.init in standalone
 mode. We do not provide EJB functionality in standalone
 mode. It works only in container mode.
 
 
 ad 2)Still it is not really clear to me how the
 TCK suite works on your computer.
 Will look at again.
 
 For the unpacking vs dependency: the only thing
 which matters is if the jars are on the classpath
 Ok, then,  current way for doing that is fine.
 
 
 
 
 From: Mark Struberg strub...@yahoo.de
 To: openwebbeans-dev@incubator.apache.org
 Sent: Tue, December 1, 2009 12:13:57 AM
 Subject: Re: tons of skipped TCK tests
 
 Thanks Gurkan!
 
 It's still not really clear to me, so maybe I should try to
 sum it up again:
 
 ad 1) I moved the OpenEJB.init() to
 StandaloneContainersImpl#setup() so this initialisation will
 only be performed if we dont test against tomcat. It simply
 doesn't work here after a clean checkout. Do you have
 JBossAS in your classpath? Maybe I oversee something...
 
 ad 2)
 Still it is not really clear to me how the TCK suite works
 on your computer. With a standard tomcat-6.0.18 I
 experienced exactly the same DeploymentException (and thus
 skipped tests) as when running in a standalone mode. The few
 Exceptions I fixed yesterday (package scope constructor)
 have nothing to do with EJB at all. And they aborted almost
 all the TCK tests.
 Can you please try to clean your .m2/repository? Maybe we
 face some artifact clash?
 
 For the unpacking vs dependency: the only thing which
 matters is if the jars are on the classpath. This is the
 case in both ways. The only subtle difference is if we would
 like to apply some kind of byte code enhancement (which we
 don't do).
 
 
 LieGrue,
 strub
 
 --- Gurkan Erdogdu gurkanerdo...@yahoo.com
 schrieb am Mo, 30.11.2009:
 
  Von: Gurkan Erdogdu gurkanerdo...@yahoo.com
  Betreff: Re: tons of skipped TCK tests
  An: openwebbeans-dev@incubator.apache.org
  Datum: Montag, 30. November 2009, 18:22
  For question 1 :
  OpenEJB is used with Apache Tomcat as an embeddable.
 It is
  not enabled as default. If you deploy WAR archive
 that
  contains EJB classes, EJBs are deployed by the
 OpenEJB
  before contextInitialized() is called.  We
 configure
  OWB in contextInitialized so we can get that which
 class
  is EJB or not. There is no start-up logic beyon this.
  
  For question 2 :
  We must run TCK in embeddable OpenEJB in Tomcat. So
  dependency:copy adds all necessary jar into each test
 WAR
  archive lib folder. I do not see any skipped test in
 my
  environment. Maybe your Tomcat configuration is wrong.
 
  
  --Gurkan
  
  
  
  
  
  From: Mark Struberg strub...@yahoo.de
  To: openwebbeans-dev@incubator.apache.org
  Sent: Sat, November 28, 2009 11:27:02 AM
  Subject: tons of skipped TCK tests
  
  Hi!
  
  I'm playing around with the TCK suite for a few days
 and
  almost all tests got skipped. I tried this with tomcat
 and
  also as standalone, and both give similar results.
  
  Let's stick with the standalone container for now:
  
  1.) The webbeans-ejb plugin (which we should rename
 to
  webbeans-openejb imho, because it uses a lot internal
  OpenEJB functionality) doesn't get startet up
 correctly. I
  fixed that part in the PluginLoader and added a starup
 logic
  to the EJBPlugin. I'm not sure about this part since
 OpenEJB
  should already be started up, isn't? In the TCK it
 isn't so
  I got a NullPointerException because 
 
 SystemInstance.get().getComponent(ContainerSystem.class);
  returned null.
  
  We should sum up in which scenarios OpenEJB gets
 started up
  at which point in time/bootstrapped from which
 component.
  
  2.) I'm not sure why all the dependencies got copied
 over
  with dependency:copy instead of simply setting the
 test
  dependencies? Imho the only thing we have to
 dependency:copy
  are those parts which are accessed via a file path
 instead
  of getting it via the classloader (afaik only the
  testng

[jira] Resolved: (OWB-179) PluginLoader need to actually startUp each plugin at load time

2009-11-29 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-179.
---

Resolution: Fixed

 PluginLoader need to actually startUp each plugin at load time
 --

 Key: OWB-179
 URL: https://issues.apache.org/jira/browse/OWB-179
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Core
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 PluginLoader need to call startUp() on each plugin while starting up

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OWB-180) remove e.printStackTrace() and use proper logging

2009-11-29 Thread Mark Struberg (JIRA)
remove e.printStackTrace() and use proper logging
-

 Key: OWB-180
 URL: https://issues.apache.org/jira/browse/OWB-180
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Core
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Gurkan Erdogdu
 Fix For: M4


Found in BeansDeployer

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OWB-181) TCK requires to create newInstance of hidden constructors

2009-11-29 Thread Mark Struberg (JIRA)
TCK requires to create newInstance of hidden constructors
-

 Key: OWB-181
 URL: https://issues.apache.org/jira/browse/OWB-181
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Interceptor and Decorators
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


The JSR-299 TCK defines a interceptors (e.g. MissileInterceptor) which have 
only package scope.
This means we have to manually set the constructor to be accessible before we 
construct the interceptor.
The same problem might happen in other areas too...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OWB-182) Even if @PreDestroy is used in an Interceptor, it doesn't need an InvoicationContext parameter

2009-11-29 Thread Mark Struberg (JIRA)
Even if @PreDestroy is used in an Interceptor, it doesn't need an 
InvoicationContext parameter
--

 Key: OWB-182
 URL: https://issues.apache.org/jira/browse/OWB-182
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


thus we must disable the check in WebBeansUtils#configureInterceptorMethods

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-182) Even if @PreDestroy is used in an Interceptor, it doesn't need an InvoicationContext parameter

2009-11-29 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-182.
---

Resolution: Fixed

 Even if @PreDestroy is used in an Interceptor, it doesn't need an 
 InvoicationContext parameter
 --

 Key: OWB-182
 URL: https://issues.apache.org/jira/browse/OWB-182
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 thus we must disable the check in WebBeansUtils#configureInterceptorMethods

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Review of WebBeansPhaseListener

2009-11-23 Thread Mark Struberg
Imho it should.

And it must also work for AJAX requests and partial submits.

LieGrue,
strub

--- Gurkan Erdogdu cgurkanerdo...@gmail.com schrieb am Mo, 23.11.2009:

 Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Betreff: Re: Review of WebBeansPhaseListener
 An: openwebbeans-dev@incubator.apache.org
 Datum: Montag, 23. November 2009, 8:04
 Hi Sven;
 
 AFAIK, conversation is defined for using it in pure JSF in
 the
 specification. I do not know whether it supports tag
 handlers or not.
 
 --Gurkan
 
 2009/11/23 Sven Linstaedt sven.linsta...@googlemail.com
 
  I have found a issue, that makes the second point
 necessary to implement:
 
  If one uses a conversation scoped bean in an
 expression, which is evaluated
  during restore view as part of a tag handler (e.g. in
 c:forEach), we need
  the conversation already to be restored, because
 otherwise two
  conversations
  will be in action during one request: one from the
 beginning the request
  till after restore view phase, and another one (the
 right one actually)
  in
  the other phases.
 
  Because before restore view no view and therefore no
 cid is available
  (well,
  sound reasonable ;) our only chance is to retrieve the
 cid from something
  else. The current implementation attaches the cid to
 every form's action
  url
  due to ConversationAwareViewHandler, so we could use
 this information for
  restoring the conversation. Does anybody has
 objections or a better
  solution
  regarding this point in mind?
 
  br, Sven
 
 
 
  2009/11/15 Gurkan Erdogdu gurkanerdo...@yahoo.com
 
   Hi Sven;
  
   Very good points :) I will try to correct those
 issues.
  
   PS: If you would like to patch, you are always
 welcome :)
  
   Thanks again for helping us!
  
   --Gurkan
  
  
  
  
   
   From: Sven Linstaedt sven.linsta...@googlemail.com
   To: openwebbeans-dev@incubator.apache.org
   Sent: Sun, November 15, 2009 4:02:57 PM
   Subject: Review of WebBeansPhaseListener
  
   Hi,
  
   I have some questions about the JSF integration
 of OWB, which come to my
   mind when dealing with the source code:
  
   _ JSF PhaseListener have to be threadsafe (see
 JSF 2.0 spec, chapter
   12.3.),
   but WebBeansPhaseListener references a obvious
 context dependent
   conversation. A quick look at mojarra indicates
 there is a singleton
   instantiated for each PhaseListener, so I supose
  WebBeansPhaseListenerwill
   get into troubles when serving multiple requests.
 - Use a ThreadLocal
   instead?
  
   _ Conversation scoped beans might be accessed
 *during* restore view
  during
   a
   FaceletHandler evaluation. But the
 ConversationContext is restored
  *after*
   restore view. - Are there any limitations or
 drawbacks restoring the
   ConversationContext *before* restore view? Weld
 is also doing this as far
   as
   I remember.
  
   _ Make sure the ViewRoot's initial state is
 marked *before* modifying
  it's
   attributes, because otherwise the stored
 information may be lost.
  
   _ WebBeansPhaseListener.fromRedirect ThreadLocal
 seems not to be resetted
   anywhere. Furthermore the initializer of this
 ThreadLocal is done once
  (?)
   in a static block, and not per created Thread
 using something like
  
   public static ThreadLocalBoolean
 fromRedirect = new
   ThreadLocalBoolean()
   {
    protected Boolean initialValue() {
          return false;
      }
   }
  
   In addition, if this static field is public, it
 should at least be final.
  
  
   br, Sven
  
  
  
  
  
 
 
 
 
 -- 
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com
 

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


[jira] Created: (OWB-177) Handling of InterceptionType#POST_ACTIVATE, PRE_PASSIVATE and AROUND_TIMEOUT is missing

2009-11-22 Thread Mark Struberg (JIRA)
Handling of InterceptionType#POST_ACTIVATE, PRE_PASSIVATE and AROUND_TIMEOUT is 
missing
---

 Key: OWB-177
 URL: https://issues.apache.org/jira/browse/OWB-177
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Interceptor and Decorators
Affects Versions: M3
Reporter: Mark Struberg
 Fix For: M4


those interceptor types allow handling of the new ones defined in EJB-3.1.

Where do we handle them? 
This turns out to be a very basic decision whether to pull in the EE api or not.

If we handle them in the in openwebbeans-geronimo or openwebbeans-ejb only, 
then we'd loose this functionality if we are running in e.g. a pure 
ServletContainer. But although it's defined in the EJB spec, I personally think 
this functionality might be interesting for SE applications too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (OWB-178) update Bean interface to fit the latest spec

2009-11-22 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg reassigned OWB-178:
-

Assignee: Mark Struberg  (was: Gurkan Erdogdu)

 update Bean interface to fit the latest spec
 

 Key: OWB-178
 URL: https://issues.apache.org/jira/browse/OWB-178
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Core
Affects Versions: M4
Reporter: Mark Struberg
Assignee: Mark Struberg
Priority: Blocker
 Fix For: M3


 e.g. remove isSerialisable(), 
 We have to fix this in order to get the TCK running.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OWB-178) update Bean interface to fit the latest spec

2009-11-22 Thread Mark Struberg (JIRA)
update Bean interface to fit the latest spec


 Key: OWB-178
 URL: https://issues.apache.org/jira/browse/OWB-178
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Core
Affects Versions: M4
Reporter: Mark Struberg
Assignee: Gurkan Erdogdu
Priority: Blocker
 Fix For: M3


e.g. remove isSerialisable(), 

We have to fix this in order to get the TCK running.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-154) remove Bean#getDeploymentType()

2009-11-22 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-154.
---

Resolution: Fixed

 remove Bean#getDeploymentType()
 ---

 Key: OWB-154
 URL: https://issues.apache.org/jira/browse/OWB-154
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Simple Web Beans
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Gurkan Erdogdu
 Fix For: M4


 this function is not in the interface of the spec anymore, thus causing the 
 TCK to fail.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Time to move atinject-api over to geronimo?

2009-11-20 Thread Mark Struberg
Hi!

I think our atinject-api is pretty stable now.

Wdyt about adding a bit more documentation and finally moving it over to 
geronimo-specs?

LieGrue,
strub

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


sporadic test failures

2009-11-20 Thread Mark Struberg
any1 seen this before?

testGenericBeanInjection(org.apache.webbeans.test.unittests.inject.generic.GenericBeanTest)
  Time elapsed: 0.004 sec   ERROR!
javax.enterprise.context.ContextNotActiveException: WebBeans context with scope 
type annotation @ApplicationScoped does not exist within current thread
at 
org.apache.webbeans.container.BeanManagerImpl.getContext(BeanManagerImpl.java:249)
at 
org.apache.webbeans.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:166)
at 
org.apache.webbeans.event.NotificationManager.fireEvent(NotificationManager.java:240)
at 
org.apache.webbeans.container.BeanManagerImpl.fireEvent(BeanManagerImpl.java:302)
at 
org.apache.webbeans.test.mock.MockManager.fireEvent(MockManager.java:105)
at 
org.apache.webbeans.test.TestContext.defineManagedBean(TestContext.java:327)
at 
org.apache.webbeans.test.unittests.inject.generic.GenericBeanTest.testGenericBeanInjection(GenericBeanTest.java:41)


LieGrue,
strub

__
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen 
Massenmails. 
http://mail.yahoo.com


[jira] Resolved: (OWB-150) remove ActivityManager from OWB

2009-11-20 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-150.
---

Resolution: Fixed

 remove ActivityManager from OWB
 ---

 Key: OWB-150
 URL: https://issues.apache.org/jira/browse/OWB-150
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 The ActivityManager has been dropped from the spec a while ago.
 We should reflect this within OWB too.
 We should also remove the BeanManager#getParent and #setParent functions 
 which belong to this area. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



AW: [VOTE] Gradutation

2009-11-16 Thread Mark Struberg
+1

LieGrue,
strub

--- Gurkan Erdogdu gurkanerdo...@yahoo.com schrieb am Mo, 16.11.2009:

 Von: Gurkan Erdogdu gurkanerdo...@yahoo.com
 Betreff: [VOTE] Gradutation
 An: openwebbeans-dev@incubator.apache.org
 Datum: Montag, 16. November 2009, 21:50
 Hi folks,
 
 There were some discussions related with graduation of the
 OpenWebBeans podling from incubator. Last time we discussed
 graduation, main barrier is the lack of community around
 it.  Over couple of weeks, we have diverted and
 increased our community around the project. 
 
 Generally,  it seems that community would like to
 graduate as a TLP.   To do formal process, I
 would like to start a VOTE for graduating OWB as TLP.
 
 Please cast your VOTEs here. VOTE is open for 72 hours.
 
 [-1] Do not graduate as TLP
 [0 ] Do not care TLP or not
 [+1] Graduate as TLP
 
 This is my +1;
 
 Thanks;
 
 --Gurkan
 
 
 
       





[jira] Created: (OWB-169) PrimitiveProducerTest creates a NullPointerException

2009-11-16 Thread Mark Struberg (JIRA)
PrimitiveProducerTest creates a NullPointerException


 Key: OWB-169
 URL: https://issues.apache.org/jira/browse/OWB-169
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


testPrimitiveProducer(org.apache.webbeans.test.unittests.producer.primitive.PrimitiveProducerTest)
  Time elapsed: 0.007 sec   ERROR!
java.lang.NullPointerException
at 
org.apache.webbeans.util.AnnotationUtil.isResourceAnnotation(AnnotationUtil.java:869)
at 
org.apache.webbeans.util.AnnotationUtil.hasResourceAnnotation(AnnotationUtil.java:832)
at 
org.apache.webbeans.util.AnnotationUtil.hasResourceAnnotation(AnnotationUtil.java:91)
at 
org.apache.webbeans.config.DefinitionUtil.defineInternalInjectedMethods(DefinitionUtil.java:943)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



CDI final draft released

2009-11-11 Thread Mark Struberg
Hi!

Gavin today released the final draft of the CDI specification:

http://in.relation.to/Bloggers/JSR299FinalDraftSubmitted


LieGrue,
strub






AW: graduation

2009-11-11 Thread Mark Struberg
What do we have to do in order to get OWB graduated?

LieGrue,
strub



- Ursprüngliche Mail 
 Von: Kevan Miller kevan.mil...@gmail.com
 An: openwebbeans-dev@incubator.apache.org
 Gesendet: Mittwoch, den 11. November 2009, 18:00:50 Uhr
 Betreff: graduation
 
 It's been a while since the community has discussed graduation. What are your 
 current thoughts?
 
 I've mentored about all that I can mentor... ; -)
 
 From the last time I kicked off the discussion:
 
 On Sep 8, 2009, at 11:00 AM, Kevan Miller wrote:
 
  IMO, this community displays nearly all of the characteristics that I would 
 look for from a successful Incubator project: you've successfully created 
 several releases while operating in a clear, open, and welcoming manner. All 
 of 
 this while facing some significant challenges as the JSR 299 spec has been an 
 ever shifting target.
  
  I'd like to see us moving towards graduation. To start things off, is the 
 community interested in becoming a top-level project? Or would you rather 
 graduate as a sub-project of an existing TLP?
 
 I think we're ready. Graduation is going to take a concerted effort by the 
 community. I'm certainly willing to help, but the community is going to need 
 to 
 help drive this.
 
 --kevan






[jira] Created: (OWB-152) @New needs a value parameter for the Class it should create

2009-10-30 Thread Mark Struberg (JIRA)
@New needs a value parameter for the Class it should create
---

 Key: OWB-152
 URL: https://issues.apache.org/jira/browse/OWB-152
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


from a sample of the spec:

{noformat}
 Produces @ConversationScoped
 @Special Order getSpecialOrder(@New(Order.class) Order order) 
{noformat}



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OWB-153) javax.enterprise.inject.spi.Decorator#getDelegateBindings() must be renamed to getDelegateQualifiers();

2009-10-30 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg updated OWB-153:
--

Affects Version/s: M3
Fix Version/s: M4
 Assignee: Mark Struberg  (was: Gurkan Erdogdu)

 javax.enterprise.inject.spi.Decorator#getDelegateBindings() must be renamed 
 to getDelegateQualifiers();
 ---

 Key: OWB-153
 URL: https://issues.apache.org/jira/browse/OWB-153
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 the interface from the spec:
 {noformat}
 public interface DecoratorT extends BeanT {
 public SetType getDecoratedTypes();
 public Type getDelegateType();
 public SetAnnotation getDelegateQualifiers();
 }
 {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OWB-154) remove Bean#getDeploymentType()

2009-10-30 Thread Mark Struberg (JIRA)

[ 
https://issues.apache.org/jira/browse/OWB-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12771930#action_12771930
 ] 

Mark Struberg commented on OWB-154:
---

Gurkan, I saw this is still pretty often used in our implementation.

We must not rely on it, because this would render the whole SPI idea senseless!

So I strongly vote for finally switching over all this stuff to the 
'Alternatives' as written in the spec.

 remove Bean#getDeploymentType()
 ---

 Key: OWB-154
 URL: https://issues.apache.org/jira/browse/OWB-154
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Simple Web Beans
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Gurkan Erdogdu
 Fix For: M4


 this function is not in the interface of the spec anymore, thus causing the 
 TCK to fail.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OWB-155) Conversation#isLongRunning() logic must be converted to isTransient();

2009-10-30 Thread Mark Struberg (JIRA)
Conversation#isLongRunning() logic must be converted to isTransient();
--

 Key: OWB-155
 URL: https://issues.apache.org/jira/browse/OWB-155
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Context and Scopes
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


from the latest spec:

bq. Conversation#isTransient() returns true if the conversation is marked 
transient, or false if it is marked long-running.

so the logic got inverted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-155) Conversation#isLongRunning() logic must be converted to isTransient();

2009-10-30 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-155.
---

Resolution: Fixed

 Conversation#isLongRunning() logic must be converted to isTransient();
 --

 Key: OWB-155
 URL: https://issues.apache.org/jira/browse/OWB-155
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Context and Scopes
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 from the latest spec:
 bq. Conversation#isTransient() returns true if the conversation is marked 
 transient, or false if it is marked long-running.
 so the logic got inverted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OWB-156) ProcessSessionBean SPI interface needs to be updated to the latest spec

2009-10-30 Thread Mark Struberg (JIRA)
ProcessSessionBean SPI interface needs to be updated to the latest spec
---

 Key: OWB-156
 URL: https://issues.apache.org/jira/browse/OWB-156
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


currently is:
{noformat}
public interface ProcessSessionBeanX extends ProcessBeanObject
{
public AnnotatedTypeX getAnnotatedBeanClass();
...
{noformat}

and spec defines:
{noformat}
public interface ProcessSessionBeanX  extends ProcessManagedBeanObject {
public AnnotatedTypeX getAnnotatedSessionBeanClass();
...
}
{noformat}


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-156) ProcessSessionBean SPI interface needs to be updated to the latest spec

2009-10-30 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-156.
---

Resolution: Fixed

 ProcessSessionBean SPI interface needs to be updated to the latest spec
 ---

 Key: OWB-156
 URL: https://issues.apache.org/jira/browse/OWB-156
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: M4


 currently is:
 {noformat}
 public interface ProcessSessionBeanX extends ProcessBeanObject
 {
 public AnnotatedTypeX getAnnotatedBeanClass();
 ...
 {noformat}
 and spec defines:
 {noformat}
 public interface ProcessSessionBeanX  extends ProcessManagedBeanObject {
 public AnnotatedTypeX getAnnotatedSessionBeanClass();
 ...
 }
 {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OWB-148) create a test case for the BeforeShutDown event

2009-10-29 Thread Mark Struberg (JIRA)

[ 
https://issues.apache.org/jira/browse/OWB-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12771325#action_12771325
 ] 

Mark Struberg commented on OWB-148:
---

In fact currently only the ProcessAnnotatedBean event got tested, so we have to 
add tests for all lifecycle events.

But first we have to BeansDeployer#defineManagedBean instead of 
ManagedBeanConfigurator#define (which is currently used) for setting up the 
test container, because the currently used functionality doesn't fire all 
necessary events.

 create a test case for the BeforeShutDown event
 ---

 Key: OWB-148
 URL: https://issues.apache.org/jira/browse/OWB-148
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Events
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg

 It seems that the BeforeShutDown event doesn't get received, so we first have 
 to create a proper JUnit test case for it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



AW: divergence between ManagedBeanConfigurator#define and BeansDeployer#defineManagedBean

2009-10-29 Thread Mark Struberg
Txs Gurkan!

Just for getting an an idea of what I like to test. I've now checked in the 
following changes of the extension test:
webbeans-impl/src/test/java/org/apache/webbeans/test/component/portable/events/MyExtension.java

As you see there are a lot of lifecycle events and I already found a few which 
we do not fire (even in the 'real' lifecycles).
That's the reason why I like to switch over to the 'real thing' ;) Maybe it 
will be tricky in a few parts of the TestContext, but it should be doable.

I think we can even drop the whole ManagedBeanConfigurator at some point, don't 
we?


LieGrue,
strub


- Ursprüngliche Mail 
 Von: Gurkan Erdogdu gurkanerdo...@yahoo.com
 An: openwebbeans-dev@incubator.apache.org
 Gesendet: Donnerstag, den 29. Oktober 2009, 7:10:02 Uhr
 Betreff: Re: divergence between ManagedBeanConfigurator#define and 
 BeansDeployer#defineManagedBean
 
 Somehow those 2 functions cover pretty much of the same functionality, 
 isn't?
 Actually ManagedBeanConfigurator#define was used for defining managed beans 
 without lifecycle events etc. before specification containing Portable 
 Integration chapter. After implementing portable integration, I replaced 
 managed 
 bean creation to BeansDeployer#defineManagedBean and 
 ManagedBeanConfigurator#define was deperecated.  It is still used in some 
 places 
 that contains TestContext class. 
 
 Gurkan, do you think we can merge the functionalities somehow?
 It is not necessary to merge them from code implementation becuase 
 BeansDeployer#defineManagedBean already contains 
 ManagedBeanConfigurator#define 
 functionality. But we can update our code to replace old 
 ManagedBeanConfigurator#define within several places.
 
 E.g. for the tests we could use BeansDeployer#deploy with a special
 MetaDataDiscoveryService which only returns the one bean class under
 test.
 
 Currently tests do not work in the simulating container. Each test uses 
 TestContext methods to do something . As you specified, we can implement 
 simple Lifecycle implemetation using for the tests. It can be used fır 
 future 
 tests . 
 
 Currently we have two implementation of Lifecycle that you can get help 
 from 
 their implementation.
 
 EnterpriseLifecycle -- org.apache.webbeans.lifecycle.EnterpriseLifecycle 
 uses 
 WarMetaDataDiscoveryImpl
 StandaloneLifecycle--org.apache.webbeans.lifecycle.StandaloneLifecycle uses 
 MetaDataDiscoveryStandard
 
 We can implement whatever funtionality in TestLifecycle using 
 TestMetaDataDisceovery.
 
 Thanks;
 
 --Gurkan
 
 
 
 From: Mark Struberg 
 To: openwebbeans-dev@incubator.apache.org
 Sent: Thu, October 29, 2009 12:29:43 AM
 Subject: divergence between ManagedBeanConfigurator#define and 
 BeansDeployer#defineManagedBean
 
 Hi!
 
 Somehow those 2 functions cover pretty much of the same functionality, isn't?
 
 Gurkan, do you think we can merge the functionalities somehow?
 
 E.g. for the tests we could use BeansDeployer#deploy with a special 
 MetaDataDiscoveryService which only returns the one bean class under test.
 
 something like: 
 
 TestContext#defineSimpleWebBean(Classclazz) {
   BeansDeployer bd = getBeansDeployer();
   MetaDataDiscoveryService mockMdd = new MockMetaDataDiscoveryService(clazz);
   bd.deploy(mockMdd);
 }
 
 similar stuff for XML, etc. got me?
 
 This way we could test all the lifecycle events and stuff. For my gut feeling 
 the test container code is way too far from the 'real' lifecycle code 
 currently.
 
 Should I try it, or do you see any problem which will be a show stopper?
 
 LieGrue,
 strub



   


AW: drop ActivityManager

2009-10-29 Thread Mark Struberg
Why wait if we can break something today? :)

I think the earlier, the better. Should be not too problematic.

LieGrue,
strub



- Ursprüngliche Mail 
 Von: Gurkan Erdogdu gurkanerdo...@yahoo.com
 An: openwebbeans-dev@incubator.apache.org
 Gesendet: Donnerstag, den 29. Oktober 2009, 7:14:16 Uhr
 Betreff: Re: drop ActivityManager
 
 Hi Mark;
 
 Actually ActivityManager is used in several critical places. It can broke 
 something if not managed carefully :)
 
 We can delay its removing at a later state or do it now :)
 
 
 Thanks;
 
 -Gurkan
 
 
 
 From: Mark Struberg 
 To: openwebbeans-dev@incubator.apache.org
 Sent: Wed, October 28, 2009 11:23:24 PM
 Subject: drop ActivityManager
 
 Hi!
 
 Activities have been dropped from the spec a long time ago.
 
 We should finally also drop the ActivityManager from our code. This would 
 really 
 make the code much cleaner again.
 
 Any reservations?
 
 LieGrue,
 strub






[jira] Created: (OWB-148) create a test case for the BeforeShutDown event

2009-10-28 Thread Mark Struberg (JIRA)
create a test case for the BeforeShutDown event
---

 Key: OWB-148
 URL: https://issues.apache.org/jira/browse/OWB-148
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Events
Affects Versions: M3
Reporter: Mark Struberg
Assignee: Mark Struberg


It seems that the BeforeShutDown event doesn't get received, so we first have 
to create a proper JUnit test case for it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (OWB-149) BeforeShutDown (in current code) should be BeforeShutdown to match spec.

2009-10-28 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg reassigned OWB-149:
-

Assignee: Mark Struberg  (was: Gurkan Erdogdu)

 BeforeShutDown (in current code) should be BeforeShutdown to match spec.
 

 Key: OWB-149
 URL: https://issues.apache.org/jira/browse/OWB-149
 Project: OpenWebBeans
  Issue Type: Bug
Reporter: Paul J. Reder
Assignee: Mark Struberg
Priority: Minor

 Currently the code uses BeforeShutDown (with a capital D) where the spec uses 
 BeforeShutdown. The code needs to fire the event that beans will expect to 
 observe.
 I'll be submitting a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-149) BeforeShutDown (in current code) should be BeforeShutdown to match spec.

2009-10-28 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-149.
---

   Resolution: Fixed
Fix Version/s: M4

I renamed it to BeforeShutdownImpl. txs!

 BeforeShutDown (in current code) should be BeforeShutdown to match spec.
 

 Key: OWB-149
 URL: https://issues.apache.org/jira/browse/OWB-149
 Project: OpenWebBeans
  Issue Type: Bug
Reporter: Paul J. Reder
Assignee: Mark Struberg
Priority: Minor
 Fix For: M4


 Currently the code uses BeforeShutDown (with a capital D) where the spec uses 
 BeforeShutdown. The code needs to fire the event that beans will expect to 
 observe.
 I'll be submitting a patch shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



drop ActivityManager

2009-10-28 Thread Mark Struberg
Hi!

Activities have been dropped from the spec a long time ago.

We should finally also drop the ActivityManager from our code. This would 
really make the code much cleaner again.

Any reservations?

LieGrue,
strub






divergence between ManagedBeanConfigurator#define and BeansDeployer#defineManagedBean

2009-10-28 Thread Mark Struberg
Hi!

Somehow those 2 functions cover pretty much of the same functionality, isn't?

Gurkan, do you think we can merge the functionalities somehow?

E.g. for the tests we could use BeansDeployer#deploy with a special 
MetaDataDiscoveryService which only returns the one bean class under test.

something like: 

TestContext#defineSimpleWebBean(ClassT clazz) {
  BeansDeployer bd = getBeansDeployer();
  MetaDataDiscoveryService mockMdd = new MockMetaDataDiscoveryService(clazz);
  bd.deploy(mockMdd);
}

similar stuff for XML, etc. got me?

This way we could test all the lifecycle events and stuff. For my gut feeling 
the test container code is way too far from the 'real' lifecycle code currently.

Should I try it, or do you see any problem which will be a show stopper?

LieGrue,
strub





AW: svn commit: r830063 - /incubator/openwebbeans/trunk/samples/pom.xml

2009-10-27 Thread Mark Struberg
we could simply use the api from MyFaces.

LieGrue,
strub



- Ursprüngliche Mail 
 Von: gerdo...@apache.org gerdo...@apache.org
 An: openwebbeans-comm...@incubator.apache.org
 Gesendet: Dienstag, den 27. Oktober 2009, 6:33:20 Uhr
 Betreff: svn commit: r830063 - /incubator/openwebbeans/trunk/samples/pom.xml
 
 Author: gerdogdu
 Date: Tue Oct 27 05:33:20 2009
 New Revision: 830063
 
 URL: http://svn.apache.org/viewvc?rev=830063view=rev
 Log:
 Remove jsf2sample. Does not able to get jsf-api,impl from java.net2 
 (http://download.java.net/maven/2)
 
 Modified:
 incubator/openwebbeans/trunk/samples/pom.xml
 
 Modified: incubator/openwebbeans/trunk/samples/pom.xml
 URL: 
 http://svn.apache.org/viewvc/incubator/openwebbeans/trunk/samples/pom.xml?rev=830063r1=830062r2=830063view=diff
 ==
 --- incubator/openwebbeans/trunk/samples/pom.xml (original)
 +++ incubator/openwebbeans/trunk/samples/pom.xml Tue Oct 27 05:33:20 2009
 @@ -29,7 +29,7 @@
 Contains samples project for openwebbeans.
 
 guess
 -  jsf2sample
 +  
 ejb-sample
 jms-sample
 reservation






AW: svn commit: r830063 - /incubator/openwebbeans/trunk/samples/pom.xml

2009-10-27 Thread Mark Struberg
yes, since ~ 1 year now.

In fact the MyFaces team did a big part of the work on the JSF2 spec ;)

LieGrue,
strub



- Ursprüngliche Mail 
 Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
 An: openwebbeans-dev@incubator.apache.org
 Gesendet: Dienstag, den 27. Oktober 2009, 8:48:21 Uhr
 Betreff: Re: svn commit: r830063 - 
 /incubator/openwebbeans/trunk/samples/pom.xml
 
 More correclty, MyFaces supports JSF 2.0 specification?
 
 -Gurkan
 
 2009/10/27 Gurkan Erdogdu 
 
  Does MyFaces Api support JSF 2.0 Specification?
 
  Thanks;
 
  --Gurkan
 
  2009/10/27 Mark Struberg 
 
  we could simply use the api from MyFaces.
 
  LieGrue,
  strub
 
 
 
  - Ursprüngliche Mail 
   Von: gerdo...@apache.org 
   An: openwebbeans-comm...@incubator.apache.org
   Gesendet: Dienstag, den 27. Oktober 2009, 6:33:20 Uhr
   Betreff: svn commit: r830063 -
  /incubator/openwebbeans/trunk/samples/pom.xml
  
   Author: gerdogdu
   Date: Tue Oct 27 05:33:20 2009
   New Revision: 830063
  
   URL: http://svn.apache.org/viewvc?rev=830063view=rev
   Log:
   Remove jsf2sample. Does not able to get jsf-api,impl from java.net2
   (http://download.java.net/maven/2)
  
   Modified:
   incubator/openwebbeans/trunk/samples/pom.xml
  
   Modified: incubator/openwebbeans/trunk/samples/pom.xml
   URL:
  
  
 http://svn.apache.org/viewvc/incubator/openwebbeans/trunk/samples/pom.xml?rev=830063r1=830062r2=830063view=diff
  
  
 ==
   --- incubator/openwebbeans/trunk/samples/pom.xml (original)
   +++ incubator/openwebbeans/trunk/samples/pom.xml Tue Oct 27 05:33:20
  2009
   @@ -29,7 +29,7 @@
   Contains samples project for openwebbeans.
  
   guess
   -  jsf2sample
   +
   ejb-sample
   jms-sample
   reservation
 
 
 
 
 
 
 
  --
  Gurkan Erdogdu
  http://gurkanerdogdu.blogspot.com
 
 
 
 
 -- 
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com






AW: svn commit: r830063 - /incubator/openwebbeans/trunk/samples/pom.xml

2009-10-27 Thread Mark Struberg
Yes, apologise - that was my problem as a poor from-source-compiler ;)

We could itmt use the snapshots from 
http://people.apache.org/repo/m2-snapshot-repository/org/apache/myfaces/core/myfaces-api/2.0.0-SNAPSHOT/
Not perfect but better than nothing!

I already dropped a request for a milestone build of MyFaces-2.0 on their list.


LieGrue,
strub


- Ursprüngliche Mail 
 Von: Gurkan Erdogdu cgurkanerdo...@gmail.com
 An: openwebbeans-dev@incubator.apache.org
 Gesendet: Dienstag, den 27. Oktober 2009, 14:19:06 Uhr
 Betreff: Re: svn commit: r830063 - 
 /incubator/openwebbeans/trunk/samples/pom.xml
 
 That is why I include Sun specific maven artifacts.
 
 Thanks;
 
 --Gurkan
 
 2009/10/27 Mark Struberg 
 
  gnah sorry, I was wrong.
  Althouth the MyFaces team works on JSF-2 for over a year now (and being
  pretty stable) they have still no final release. Their spec seems to be as
  volatile as ours ;)
 
  I'll drop them a mail and ask if they wanna do a milestone release of
  MyFaces-2.0 for us.
 
  sorry,
  strub
 
 
  - Ursprüngliche Mail 
   Von: Gurkan Erdogdu 
   An: openwebbeans-dev@incubator.apache.org
   Gesendet: Dienstag, den 27. Oktober 2009, 9:39:01 Uhr
   Betreff: Re: svn commit: r830063 -
  /incubator/openwebbeans/trunk/samples/pom.xml
  
   Do you know where is the location of artifacts?
  
   Thanks;
  
   2009/10/27 Gurkan Erdogdu
  
Olee, awesome!
   
   
2009/10/27 Mark Struberg
   
yes, since ~ 1 year now.
   
In fact the MyFaces team did a big part of the work on the JSF2 spec
  ;)
   
LieGrue,
strub
   
   
   
- Ursprüngliche Mail 
 Von: Gurkan Erdogdu
 An: openwebbeans-dev@incubator.apache.org
 Gesendet: Dienstag, den 27. Oktober 2009, 8:48:21 Uhr
 Betreff: Re: svn commit: r830063 -
/incubator/openwebbeans/trunk/samples/pom.xml

 More correclty, MyFaces supports JSF 2.0 specification?

 -Gurkan

 2009/10/27 Gurkan Erdogdu

  Does MyFaces Api support JSF 2.0 Specification?
 
  Thanks;
 
  --Gurkan
 
  2009/10/27 Mark Struberg
 
  we could simply use the api from MyFaces.
 
  LieGrue,
  strub
 
 
 
  - Ursprüngliche Mail 
   Von: gerdo...@apache.org
   An: openwebbeans-comm...@incubator.apache.org
   Gesendet: Dienstag, den 27. Oktober 2009, 6:33:20 Uhr
   Betreff: svn commit: r830063 -
  /incubator/openwebbeans/trunk/samples/pom.xml
  
   Author: gerdogdu
   Date: Tue Oct 27 05:33:20 2009
   New Revision: 830063
  
   URL: http://svn.apache.org/viewvc?rev=830063view=rev
   Log:
   Remove jsf2sample. Does not able to get jsf-api,impl from
  java.net2
   (http://download.java.net/maven/2)
  
   Modified:
   incubator/openwebbeans/trunk/samples/pom.xml
  
   Modified: incubator/openwebbeans/trunk/samples/pom.xml
   URL:
  
 

   
  
  
 http://svn.apache.org/viewvc/incubator/openwebbeans/trunk/samples/pom.xml?rev=830063r1=830062r2=830063view=diff
  
 

   
  
  ==
   --- incubator/openwebbeans/trunk/samples/pom.xml (original)
   +++ incubator/openwebbeans/trunk/samples/pom.xml Tue Oct 27
05:33:20
  2009
   @@ -29,7 +29,7 @@
   Contains samples project for openwebbeans.
  
   guess
   -  jsf2sample
   +
   ejb-sample
   jms-sample
   reservation
 
 
 
 
 
 
 
  --
  Gurkan Erdogdu
  http://gurkanerdogdu.blogspot.com
 



 --
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com
   
   
   
   
   
   
   
--
Gurkan Erdogdu
http://gurkanerdogdu.blogspot.com
   
  
  
  
   --
   Gurkan Erdogdu
   http://gurkanerdogdu.blogspot.com
 
 
 
 
 
 
 
 -- 
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com






Re: @AroundInvoke -- JCDI vs EJB3 and return type Object?

2009-10-23 Thread Mark Struberg
Hi!

Haven't looked at it, but if you think it's a bug in the spec, then drop Gavin 
or the weld-dev list a mail.

LieGrue,
strub



- Original Message 
 From: Sven Linstaedt sven.linsta...@googlemail.com
 To: openwebbeans-dev@incubator.apache.org
 Sent: Fri, October 23, 2009 5:53:28 PM
 Subject: Re: @AroundInvoke -- JCDI vs EJB3 and return type Object?
 
 At a first glance I would consider this a bug in the example. I can not
 imagine Gavin introduced some kind of special interceptors for void
 returning methods. This would rather be a use case for decorators.
 I will forward your question to the jboss list, if you don't mind.
 Besides... thanks for for the review.
 
 br, Sven
 
 
 2009/10/22 Eric Covener 
 
  Interceptor methods with @AroundInvoke in EJB3 requires a return type
  of Object, which is enforced by
  WebBeansUtil.java::checkAroundInvokeAnnotationCriterias().In EJB3,
  Interceptors return InvocationContext.proceed() to their caller.
 
  However it seems that @AroundInvoke in JCDI is documented somewhat
  differently -- in the JCDI spec (1.3.6) the example has a void return
  type and just calls InvocationContext.proceed().
 
  Should the JCDI spec example look just like EJB3, or is this an
  OWB-specific restriction?
 
  --
  Eric Covener
  cove...@gmail.com
 






a few Observer changes

2009-10-23 Thread Mark Struberg
Hi!

I think we have a slight bug in 
AnnotationUtil#checkQualifierConditions(Annotation...)
We currently only check for Annotation dupplications between 2 'neighbour' 
qualifiers.
But dupplicated annotations like @Default @Special @Default will not be 
detected correctly.

I fixed that by creating a Set from the Annotation... and check if the size is 
still the same.

Another thing which caused problems with the eventing: When do we prune the 
@Default annotation?
It seems that the current code prunes it in NotificationManager#toQualifierSet 
and thus the filterObservers cannot find an @Default annotated ObserverMethod.
I now add the @Default if nothing else is specified, so the default lookup 
mechanism should work again

Another thing concerns the @Any Qualifier. We didn't  check this in 
NotificationManager.filterByQualifiers
I now hacked the code to also evaluate @Any, would be cool if anyone can take a 
look at it!

I just do a bit of reformatting and stuff and will check this in today.

LieGrue,
strub





[jira] Assigned: (OWB-140) Remove javax.enterprise.event.Observer

2009-10-23 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg reassigned OWB-140:
-

Assignee: Mark Struberg  (was: Gurkan Erdogdu)

 Remove javax.enterprise.event.Observer
 --

 Key: OWB-140
 URL: https://issues.apache.org/jira/browse/OWB-140
 Project: OpenWebBeans
  Issue Type: Sub-task
  Components: Core, Events
Affects Versions: M3
Reporter: David Blevins
Assignee: Mark Struberg
 Fix For: M4




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



code readability and JavaDoc

2009-10-20 Thread Mark Struberg
Hiho!

Just a quick bid: 

fn(Annotation... annotations) {...}

is not the most descriptive parameter naming ;)
Would also help if we write a quick JavaDoc for such functions.

I'm currently (still) reworking the whole Observer to ObserverMethod.
Sorry for taking so long, but I have not looked at that piece of code for a 
long time and only have a few spare hours per week currently.

Btw, what shall we do with our 'reformatted'  ASL headers?
I used the default ASL headers in the atinject-api, and hopefully fixed all 
headers in the webbeans-api. But webbeans-impl and the plugins imho still needs 
fixing. Should we?

LieGrue,
strub





Re: svn commit: r825636 - /incubator/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/AnnotationUtil.java

2009-10-16 Thread Mark Struberg
yups, you are right. With @Inject this pain has gone away.

The question is: is there still a reason for having the @Default annotation at 
all?

If not we should ask Gavin.

LieGrue,
strub



- Original Message 
 From: David Blevins david.blev...@visi.com
 To: openwebbeans-dev@incubator.apache.org
 Sent: Thu, October 15, 2009 11:42:25 PM
 Subject: Re: svn commit: r825636 - 
 /incubator/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/AnnotationUtil.java
 
 What Mark mentions used to be the case.  Before there was no @Inject 
 annotation 
 so you didn't explicitly know if a field was a target for dependency 
 injection 
 and therefore in the absence of an explicit qualifier you had to assume it 
 was 
 not.
 
 Now with @Inject as a required annotation, you know definitively and can 
 assume 
 @Default.  And really, the @Default annotation is simply not needed anymore 
 and 
 could very well be removed -- as far as I can see anyway.
 
 -David
 
 On Oct 15, 2009, at 2:30 PM, Joseph Bergmark wrote:
 
  Where is that mentioned?  I seems like in 3.10 it is saying @Default is
  assumed for all InjectionPoints.  It even gives an example that looks like
  field injection at the very bottom of that section.
  
  Sincerely,
  
  Joe Bergmark
  
  On Thu, Oct 15, 2009 at 4:37 PM, Mark Struberg wrote:
  
  I hope we did take care that this rule must not be applied for field
  InjectionPoints?
  
  I know the spec is a bit cryptic for this case, but for fields, @Default is
  not assumed if no other annotation exists.
  
  just to make sure...
  
  LieGrue,
  strub
  
  
  
  - Original Message 
  From: gerdo...@apache.org 
  To: openwebbeans-comm...@incubator.apache.org
  Sent: Thu, October 15, 2009 10:24:33 PM
  Subject: svn commit: r825636 -
  
 /incubator/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/AnnotationUtil.java
  
  Author: gerdogdu
  Date: Thu Oct 15 20:24:32 2009
  New Revision: 825636
  
  URL: http://svn.apache.org/viewvc?rev=825636view=rev
  Log:
  [OWB-142] If an injection point declares no qualifier, then @Default
  should be
  assumed. Thanks to Joe Bergmark
  
  Modified:
  
  
  
 incubator/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/AnnotationUtil.java
  
  Modified:
  
  
 incubator/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/AnnotationUtil.java
  URL:
  
  
 http://svn.apache.org/viewvc/incubator/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/AnnotationUtil.java?rev=825636r1=825635r2=825636view=diff
  
  
 ==
  ---
  
  
 incubator/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/AnnotationUtil.java
  (original)
  +++
  
  
 incubator/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/util/AnnotationUtil.java
  Thu Oct 15 20:24:32 2009
  @@ -32,6 +32,7 @@
  import javax.inject.Qualifier;
  import javax.interceptor.InterceptorBinding;
  
  +import org.apache.webbeans.annotation.DefaultLiteral;
  import org.apache.webbeans.exception.WebBeansConfigurationException;
  import org.apache.webbeans.plugins.OpenWebBeansPlugin;
  import org.apache.webbeans.plugins.PluginLoader;
  @@ -509,6 +510,13 @@
  set.add(annot);
  }
  }
  +
  +//Add the default qualifier if no others exist.  Section 3.10,
  OWB-142///
  +if(set.size() == 0)
  +{
  +set.add(new DefaultLiteral());
  +}
  +
  
  
  Annotation[] a = new Annotation[set.size()];
  a = set.toArray(a);
  
  
  
  
  






Re: Interceptors and Decorators

2009-10-15 Thread Mark Struberg
If it helps, I think I enabled cobertura for the site plugin.

I will do a site deploy-staged to my peo...@ao in the afternoon. 
The public site needs to be updated too I think.

LieGrue,
strub



- Original Message 
 From: David Blevins david.blev...@visi.com
 To: openwebbeans-dev@incubator.apache.org
 Sent: Thu, October 15, 2009 11:18:20 AM
 Subject: Interceptors and Decorators
 
 As Mark is hammering on the observer code (thanks, Mark!), I moved over to 
 Interceptors and am mulling over that code.  For those that like to follow 
 along, most the code is in InterceptorHandler.  Ran into some related 
 Decorator 
 stuff as well.
 
 INTERCEPTOR RELATED
 
 First a small note, in the current code there is one interceptor stack per 
 component, rather than per method.  I see how we copy the list on each invoke 
 and filter out the interceptors that do not apply to the method being 
 invoked, 
 but I didn't see if we were maintaining order in that list.  Figured I'd just 
 ask where the original list was created so I could take a look -- faster than 
 digging.  Pointer is welcome.
 
 A side note on the above, I think we could use some more diversity in the 
 related tests.  So far we don't have any components that have more than one 
 interceptable method, so most the above logic is unchallenged.  We should 
 definitely add some tests that verify you only get interceptors that were 
 declared in your method and not ones from other methods as well as verifying 
 the 
 order is as declared on the method.  The current code shouldn't have a 
 problem 
 with that, but if someone wanted something to do, that'd be a great 
 contribution.
 
 One area not implemented is something barely mentioned in the interceptor 
 spec, 
 but I know is tested in the EJB spec at least, is the concept of Disable via 
 override.  If an @AroundInvoke method is overridden in a subclass without 
 also 
 being annotated @AroundInvoke, then this must dissable the around invoke 
 method 
 and it should not be called.  This applies to @AroundInvoke methods in beans 
 and 
 interceptors.  It also applies to @PostConstruct and @PreDestroy callbacks.
 
 INTERCEPTORS and DECORATORS
 
 It looks as though the part of the spec that says Decorators are called 
 after 
 interceptors was taken differently than intended.  Currently, the 
 interceptor 
 stack wraps the target bean and the decorator stack more or less just gets 
 a 
 notification of the invocation as a separate after thought.  As well 
 Decorators 
 were implemented as a list that is iterated over, rather than as a stack 
 where 
 one decorator calls the next in the chain.
 
 Interceptors and Decorators are completely identical and part of the same 
 overall invocation stack.  They both wrap an object and delegate to it.  They 
 both can manipulate the method parameters and both can manipulate the return 
 value (or exception).  The only difference is Interceptors are very 
 reflection-like and Decorators are strongly typed.
 
 So what Decorators are called after interceptors means is that one stack is 
 created and in that stack interceptors are invoked first, decorators are 
 invoked 
 second, and the target bean method is invoked last.  The wording is 
 unfortunate 
 as it also means that the opposite is true on the way out: the bean returns 
 and 
 that value propagates back up the stack to the decorators, then the 
 interceptors.  So Interceptors and Decorators all wrap each other like one 
 big 
 onion.  Interceptors are the outer most layers of the onion, the decorator 
 layers follow, and finally the bean itself is the center.
 
 From an implementation standpoint what it means is that the last interceptor 
 in 
 the interceptor part of the stack is actually going to invoke the first 
 decorator in that part of the stack and the invocation will continue.  Code 
 wise 
 there's no real way for that last interceptor to know if its invoking the 
 bean 
 or a decorator that implements the same interface and method as the bean.  It 
 just calls what it was given.  So we just need to make an actual stack out of 
 the decorators and pass that into the interceptor stack in place of where we 
 pass the bean now.
 
 If someone has time that's another good area for contribution.
 
 
 -David






Re: atinject-api is available at maven-central

2009-10-14 Thread Mark Struberg
Hi Gurkan!

For what I know the reason why most of the other J2EE apis are not used by e.g. 
geronimo is mostly caused by license problems, isn't? Kevan, David? 

If the license is ASL compatible I see no problem, but I'm not experienced in 
this case. At least Jason is Apache member and maven PMC, so I guess he 
wouldn't push any incompatible license to maven-central.

Whats the official ASF line in this case?

LieGrue,
strub

--- On Wed, 10/14/09, Gurkan Erdogdu cgurkanerdo...@gmail.com wrote:

 From: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Subject: Re: atinject-api is available at maven-central
 To: openwebbeans-dev@incubator.apache.org
 Date: Wednesday, October 14, 2009, 10:07 AM
 Hi;
 
 Why would you like to drop our module?
 
 I think we must use our module api instead of using theirs.
 We can not
 depend any api for our implementation. If you see other
 projects in Apache,
 you see lot of API modules for Java EE specs.
 
 If you look at jboss impl. it is also Apache License but it
 is copyrighted
 by jboss.(if you look at source code, there is an
 @Copyright etc..)
 
 So, I would like to stick with our apis including at-inject
 and
 webbeans-api.
 
 Thanks;
 
 --Gurkan
 
 
 2009/10/14 Mark Struberg strub...@yahoo.de
 
  Hi!
 
  Bob and Jason today pushed the tagged v1 of the
 atinject-api to mavens
  central repository.
 
  I will again check the license, but think it was
 released under ASL2. So we
  could now theoretically drop our atinject-api module
 and use the one from
  central instead.
 
  TODOs:
  .) again check the license
  .) adopt LICENSE and NOTICE files where needed
  .) drop our the atinject-api module
 
  anything else?
 
  LieGrue,
  strub
 
 
 
 
 
 
 -- 
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com
 


  


Re: atinject-api is available at maven-central

2009-10-14 Thread Mark Struberg
yea, I also have no idea about whether we are allowed to use it or not.

FYI: the artifact pom says it's ASL2 licensed 
http://repo2.maven.org/maven2/javax/inject/javax.inject/1/

In any case we should keep our atinject module in SVN but should mark it as 
'development only' and remove it from the modules list (so it doesn't get 
deployed and packaged anymore). 
The argument pro keeping it in SVN is: what to do if atinject-2-snapshot will 
be developed some day and we need to release a atinject-2-beta or something?

LieGrue,
strub

--- On Wed, 10/14/09, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote:

 From: Gurkan Erdogdu gurkanerdo...@yahoo.com
 Subject: Re: atinject-api is available at maven-central
 To: openwebbeans-dev@incubator.apache.org
 Date: Wednesday, October 14, 2009, 11:45 AM
 I just want to stick with our
 implementation and apis.
 
 On the other hand, I have no very detailed information
 about licensing issues however.
 
 Thanks;
 
 --Gurkan
 
 
 
 
 
 From: Mark Struberg strub...@yahoo.de
 To: openwebbeans-dev@incubator.apache.org
 Sent: Wed, October 14, 2009 12:27:13 PM
 Subject: Re: atinject-api is available at maven-central
 
 Hi Gurkan!
 
 For what I know the reason why most of the other J2EE apis
 are not used by e.g. geronimo is mostly caused by license
 problems, isn't? Kevan, David? 
 
 If the license is ASL compatible I see no problem, but I'm
 not experienced in this case. At least Jason is Apache
 member and maven PMC, so I guess he wouldn't push any
 incompatible license to maven-central.
 
 Whats the official ASF line in this case?
 
 LieGrue,
 strub
 
 --- On Wed, 10/14/09, Gurkan Erdogdu cgurkanerdo...@gmail.com
 wrote:
 
  From: Gurkan Erdogdu cgurkanerdo...@gmail.com
  Subject: Re: atinject-api is available at
 maven-central
  To: openwebbeans-dev@incubator.apache.org
  Date: Wednesday, October 14, 2009, 10:07 AM
  Hi;
  
  Why would you like to drop our module?
  
  I think we must use our module api instead of using
 theirs.
  We can not
  depend any api for our implementation. If you see
 other
  projects in Apache,
  you see lot of API modules for Java EE specs.
  
  If you look at jboss impl. it is also Apache License
 but it
  is copyrighted
  by jboss.(if you look at source code, there is an
  @Copyright etc..)
  
  So, I would like to stick with our apis including
 at-inject
  and
  webbeans-api.
  
  Thanks;
  
  --Gurkan
  
  
  2009/10/14 Mark Struberg strub...@yahoo.de
  
   Hi!
  
   Bob and Jason today pushed the tagged v1 of the
  atinject-api to mavens
   central repository.
  
   I will again check the license, but think it was
  released under ASL2. So we
   could now theoretically drop our atinject-api
 module
  and use the one from
   central instead.
  
   TODOs:
   .) again check the license
   .) adopt LICENSE and NOTICE files where needed
   .) drop our the atinject-api module
  
   anything else?
  
   LieGrue,
   strub
  
  
  
  
  
  
  -- 
  Gurkan Erdogdu
  http://gurkanerdogdu.blogspot.com
  
 
 
       


   


Re: [jira] Commented: (OWB-140) Remove javax.enterprise.event.Observer

2009-10-12 Thread Mark Struberg
Hi Gurkan!

Thanks for catching this!

As I said in the Jira, this is not yet finished. But I tried to implement this 
since weeks because the spec changed a lot in PFD2. And every time I tried to 
commit, I had to merge and redo my work again ;)

For the TCK: the latest TCK only contains ObserverMethod and no Observer 
anymore, so the old code didn't even run with the latest TCK without throwing 
ClassNotFoundExceptions - so I think at least I didn't make things worse ;)

We really must be copmliant with the latest spec and finally throw all unused 
(changed) definitions out of the API. I marked a few methods with @Deprecated, 
but these also must be gone finally.

@all: whenever you see something in the webbeans-api which is not in the spec 
anymore, please also mark those things as deprecated!

Hope to continue hacking today in the night (but will be online late, today is 
Jiu training again)

LieGrue,
strub


--- On Mon, 10/12/09, Gurkan Erdogdu cgurkanerdo...@gmail.com wrote:

 From: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Subject: Re: [jira] Commented: (OWB-140) Remove 
 javax.enterprise.event.Observer
 To: openwebbeans-dev@incubator.apache.org
 Date: Monday, October 12, 2009, 8:28 AM
 Hey Mark;
 
 In the BeanObserverImpl#notify method, you removed
 conditional exception
 throwing. But spec. specifies that in 10.5 Observer
 notification that you
 must catch and log all transactional exceptions and throw
 other exceptions
 as Runtime exception.
 
 You can see SVN difference here:
 
 http://svn.apache.org/viewvc/incubator/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/BeanObserverImpl.java?p2=%2Fincubator%2Fopenwebbeans%2Ftrunk%2Fwebbeans-impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fwebbeans%2Fevent%2FBeanObserverImpl.javap1=%2Fincubator%2Fopenwebbeans%2Ftrunk%2Fwebbeans-impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fwebbeans%2Fevent%2FBeanObserverImpl.javar1=824190r2=824189view=diffpathrev=824190
 
 Besides this, what are the TODOs that you have mentioned?
 
 Could you run TCK event tests over our event
 implementation?
 
 Thanks;
 
 -Gurkan
 
 
 2009/10/12 Mark Struberg (JIRA) j...@apache.org
 
 
     [
  https://issues.apache.org/jira/browse/OWB-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12764517#action_12764517]
 
  Mark Struberg commented on OWB-140:
  ---
 
  only partly fixed!
 
  I removed the Observer and a few other classes which
 are not in the JSR-299
  spec anymore, but there are still a few TODOs.
 
  All tests succeed though - so I think we simply miss a
 few tests ;)
 
   Remove javax.enterprise.event.Observer
   --
  
               
    Key: OWB-140
               
    URL: https://issues.apache.org/jira/browse/OWB-140
           
    Project: OpenWebBeans
            Issue Type:
 Sub-task
            Components:
 Core, Events
      Affects Versions: M3
             
 Reporter: David Blevins
             
 Assignee: Gurkan Erdogdu
           
    Fix For: M4
  
  
 
 
  --
  This message is automatically generated by JIRA.
  -
  You can reply to this email to add a comment to the
 issue online.
 
 
 
 
 -- 
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com
 





[jira] Commented: (OWB-140) Remove javax.enterprise.event.Observer

2009-10-11 Thread Mark Struberg (JIRA)

[ 
https://issues.apache.org/jira/browse/OWB-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12764517#action_12764517
 ] 

Mark Struberg commented on OWB-140:
---

only partly fixed!

I removed the Observer and a few other classes which are not in the JSR-299 
spec anymore, but there are still a few TODOs. 

All tests succeed though - so I think we simply miss a few tests ;)

 Remove javax.enterprise.event.Observer
 --

 Key: OWB-140
 URL: https://issues.apache.org/jira/browse/OWB-140
 Project: OpenWebBeans
  Issue Type: Sub-task
  Components: Core, Events
Affects Versions: M3
Reporter: David Blevins
Assignee: Gurkan Erdogdu
 Fix For: M4




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



still missing Observer changes:

2009-10-10 Thread Mark Struberg
Hi!

I checked the latest spec against our implementation and found the following 
differences:


* javax.enterprise.event.Observer got dropped from the Spec

* public T SetObserverT resolveObservers(T event, Annotation... 
qualifiers); 
got refactored to
public T SetObserverMethod? super T resolveObserverMethods(T event, 
Annotation... qualifiers);

But especially removing the Observer requires a lot of changes in our code. I 
start working on it, but not sure if I succeed :)

LieGrue,
strub


  


Re: [VOTE][RESULT] Release OpenWebBeans M3 (RC2)

2009-09-23 Thread Mark Struberg
and a post-vote +1 from me too.

Sorry, that I didn't find time earlier :(

LieGrue,
strub

--- On Wed, 9/23/09, Gurkan Erdogdu cgurkanerdo...@gmail.com wrote:

 From: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Subject: [VOTE][RESULT] Release OpenWebBeans M3 (RC2)
 To: openwebbeans-dev@incubator.apache.org
 Date: Wednesday, September 23, 2009, 8:03 PM
 72 hours is over.
 
 Vote is successful with following +1s
 
 Kevan Miller (IPMC)
 Gurkan Erdogdu (PPMC)
 Mohammad Nour El-Din (PPMC)
 
 --Gurkan
 
 2009/9/18 Gurkan Erdogdu gurkanerdo...@yahoo.com
 
  Hi;
 
  I were responded from the gene...@... that after
 correcting the blocker
  issues of the release candidate, we have to vote again
 it here.
 
  Also there was a comment for removing all 
 distribution bundle from the
  artifacts so  I removed all bundle.
 
  RC-2 Artifacts
  -
 
  Plugins repository
  --
 
  http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M3-rc2/plugins/org/apache/openwebbeanshttp://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-incubating-M3-rc2/plugins/org/apache/openwebbeans
 
  Distribution content
  
 
  http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M3-rc2/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M3/http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-incubating-M3-rc2/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M3/
 
  SVN Tag
  
 
  http://svn.apache.org/repos/asf/incubator/openwebbeans/tags/openwebbeans-1.0.0-incubating-M3-rc2/
 
 
  This vote is open for 72 hours.
 
  This is my +1
 
  Thanks;
 
  -- Gurkan
 
 
 
 
 
 
 
 
 -- 
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com
 





Re: [ANNOOUNCE] Welcome David Blevins as a new OpenWebBeans Committer

2009-09-15 Thread Mark Struberg
Congratulations, and thanks in advance for your highly welcome help :)


LieGrue,
strub


--- On Tue, 9/15/09, Kevan Miller kevan.mil...@gmail.com wrote:

 From: Kevan Miller kevan.mil...@gmail.com
 Subject: [ANNOOUNCE] Welcome David Blevins as a new OpenWebBeans Committer
 To: openwebbeans-dev@incubator.apache.org
 Date: Tuesday, September 15, 2009, 1:54 AM
 All,
 The Apache OpenWebBeans PMC is pleased to announce that
 David Blevins has accepted our invitation to become an
 OpenWebBeans committer.
 
 It's great to have David joining our project. Welcome
 David!
 
 --kevan
 


  


jsr-330 TCK

2009-09-14 Thread Mark Struberg
Hi!

Bob today announced that they will release a TCK for JSR-330.

My Question: I'm still not sure if JSR-299 is 100% 330 compliant or if we only 
use the same annotations to have some 'basic' similarity.

So, should OWB (and other 299 containers) also comply with this TCK or only 
with the 299er suite?

LieGrue,
strub


  


Re: jsr-330 TCK

2009-09-14 Thread Mark Struberg
My thoughts were into the direction: is the JSR-299 spec really designed to be 
100% based on (and compatible with) JSR-330?

There are a few oddities (e.g. @NormalScope vs pseudoscope) where I'm note 
sure...

LieGrue,
strub

--- On Mon, 9/14/09, Mohammad Nour El-Din nour.moham...@gmail.com wrote:

 From: Mohammad Nour El-Din nour.moham...@gmail.com
 Subject: Re: jsr-330 TCK
 To: openwebbeans-dev@incubator.apache.org
 Date: Monday, September 14, 2009, 11:43 AM
 IMHO, yes. As long as this JSR is
 accepted in JCP we should comply
 with it to respect and the layered dependency on such
 standard
 dependency injection specs. As long as we are providing a
 dependency
 injection service so IMHO we should comply with this
 specs.
 
 But the question now, I think, is when we are going to be
 fully
 compliant with it ? I mean we have to discuss this point.
 
 On Mon, Sep 14, 2009 at 11:32 AM, Mark Struberg strub...@yahoo.de
 wrote:
  Hi!
 
  Bob today announced that they will release a TCK for
 JSR-330.
 
  My Question: I'm still not sure if JSR-299 is 100% 330
 compliant or if we only use the same annotations to have
 some 'basic' similarity.
 
  So, should OWB (and other 299 containers) also comply
 with this TCK or only with the 299er suite?
 
  LieGrue,
  strub
 
 
 
 
 
 
 
 -- 
 Thanks
 - Mohammad Nour
 - LinkedIn: http://www.linkedin.com/in/mnour
 
 Life is like riding a bicycle. To keep your balance you
 must keep moving
 - Albert Einstein
 


  


Re: jsr-330 TCK

2009-09-14 Thread Mark Struberg
 Well, I am rather curious, how this
 TCK will look like ;)
that's another point. The 330 is _very_ thin (others may say 'vague'). So we'd 
have to make sure that the TCK doesn't require anything which isn't defined in 
the spec itself.

LieGrue,
strub


--- On Mon, 9/14/09, Sven Linstaedt sven.linsta...@googlemail.com wrote:

 From: Sven Linstaedt sven.linsta...@googlemail.com
 Subject: Re: jsr-330 TCK
 To: openwebbeans-dev@incubator.apache.org
 Date: Monday, September 14, 2009, 11:53 AM
 Well, I am rather curious, how this
 TCK will look like ;)
 
 But besides that I really would like to know, whether
 jsr299 is gonna become
 jsr330 compliant. The point with annotations is, they have
 not any
 behaviour, so it is just up to the environment to interpret
 them. If the
 same annotation types are used in different environments,
 they should share
 a common sense about there meaning and not just reuse a
 class which name
 approximately matches the desired intention. If jsr299 can
 not comply with
 330, I rather would like to see 330's annotations in jsr299
 being dropped
 than being re(mis)used.
 
 On the other side... if jsr299 complies, I have not found
 any argument why
 jsr299 implementations should not also comply with jsr330's
 TCK.
 
 br, Sven
 
 
 
 
 2009/9/14 Mark Struberg strub...@yahoo.de
 
  Hi!
 
  Bob today announced that they will release a TCK for
 JSR-330.
 
  My Question: I'm still not sure if JSR-299 is 100% 330
 compliant or if we
  only use the same annotations to have some 'basic'
 similarity.
 
  So, should OWB (and other 299 containers) also comply
 with this TCK or only
  with the 299er suite?
 
  LieGrue,
  strub
 
 
 
 
 

__
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 


Re: jsr-330 TCK

2009-09-14 Thread Mark Struberg
Got answers from Pete:

* JSR-299 _IS_ JSR-330 compliant
* the JSR-299 TCK will include the 330 TCK _only_ as _textual_ requirement and 
not as technical include.
* the ref guide will say to be 299 compliant you must pass the 330 TCK and the 
299 TCK


LieGrue,
strub

--- On Mon, 9/14/09, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote:

 From: Gurkan Erdogdu gurkanerdo...@yahoo.com
 Subject: Re: jsr-330 TCK
 To: openwebbeans-dev@incubator.apache.org
 Date: Monday, September 14, 2009, 12:15 PM
 Have they mentioned
 anything yet?
 Not so far.
 
 --Gurkan
 
 
 
 
 
 From: Mark Struberg strub...@yahoo.de
 To: openwebbeans-dev@incubator.apache.org
 Sent: Monday, September 14, 2009 12:55:07 PM
 Subject: Re: jsr-330 TCK
 
  But if  the JSR-299 TCK implies that any
 compatible 
  implementation must also pass the JSR-330 TCK
 
 right, that's exactly what I'd like to know. It's not about
 OWB, but more a question to the 299 EG. Have they mentioned
 anything yet?
 
 LieGrue,
 strub
 
 
 --- On Mon, 9/14/09, Gurkan Erdogdu gurkanerdo...@yahoo.com
 wrote:
 
  From: Gurkan Erdogdu gurkanerdo...@yahoo.com
  Subject: Re: jsr-330 TCK
  To: openwebbeans-dev@incubator.apache.org
  Date: Monday, September 14, 2009, 11:49 AM
  Folks,
  
  We have been implementing the JSR-299 specification
 not
  JSR-330. So we have to pass the JSR-299 TCK. But if 
  the JSR-299 TCK implies that any compatible
 implementation
  must also pass the JSR-330 TCK, then it may necessary
 ti
  implement it.
  
  --Gurkan
  
  
  
  
  
  From: Mohammad Nour El-Din nour.moham...@gmail.com
  To: openwebbeans-dev@incubator.apache.org
  Sent: Monday, September 14, 2009 12:43:10 PM
  Subject: Re: jsr-330 TCK
  
  IMHO, yes. As long as this JSR is accepted in JCP we
 should
  comply
  with it to respect and the layered dependency on such
  standard
  dependency injection specs. As long as we are
 providing a
  dependency
  injection service so IMHO we should comply with this
  specs.
  
  But the question now, I think, is when we are going to
 be
  fully
  compliant with it ? I mean we have to discuss this
 point.
  
  On Mon, Sep 14, 2009 at 11:32 AM, Mark Struberg strub...@yahoo.de
  wrote:
   Hi!
  
   Bob today announced that they will release a TCK
 for
  JSR-330.
  
   My Question: I'm still not sure if JSR-299 is
 100% 330
  compliant or if we only use the same annotations to
 have
  some 'basic' similarity.
  
   So, should OWB (and other 299 containers) also
 comply
  with this TCK or only with the 299er suite?
  
   LieGrue,
   strub
  
  
  
  
  
  
  
  -- 
  Thanks
  - Mohammad Nour
  - LinkedIn: http://www.linkedin.com/in/mnour
  
  Life is like riding a bicycle. To keep your balance
 you
  must keep moving
  - Albert Einstein
  
  
  
        
 
 
       





Re: [VOTE][Third Try] Release OpenWebBeans 1.0.0-incubating-M3

2009-09-10 Thread Mark Struberg
heh, I just realised that this is actually the first time we didn't release an 
already outdated implementation.

The last times, whenever we were going to release, the spec changed 
dramatically ;)

LieGrue,
strub

--- On Thu, 9/10/09, Kevan Miller kevan.mil...@gmail.com wrote:

 From: Kevan Miller kevan.mil...@gmail.com
 Subject: Re: [VOTE][Third Try] Release OpenWebBeans 1.0.0-incubating-M3
 To: openwebbeans-dev@incubator.apache.org
 Date: Thursday, September 10, 2009, 7:10 PM
 +1
 
 --kevan
 On Sep 8, 2009, at 4:41 PM, Gurkan Erdogdu wrote:
 
 
 
  Hi;
 
 
  This is the OpenWebBeans M3 release [VOTE] process
 with corrected  
  artifacts. Artifact locations are the same as before.
 
  I've staged the releases artifacts here:
 
  Plugins repository
  --
  http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M3-rc1/plugins/org/apache/openwebbeans
 
  Distribution content
  
  http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M3-rc1/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M3/
 
  SVN Tag (Revision: 812680)
  
  http://svn.apache.org/repos/asf/incubator/openwebbeans/tags/openwebbeans-1.0.0-incubating-M3-rc1/
 
 
  Please verify that this release package is correct and
 vote for the
  motion to publish this as a openwebbeans M3 release.
 All votes are  
  welcome and
  will be counted.
 
  This vote is open for 72 hours.
 
  This is my +1
 
  Thanks;
 
  /Gurkan
 
 
 
 





Re: Graduation?

2009-09-09 Thread Mark Struberg
Sorry for repeating myself: I think we should wait for the 330 and 299 specs to 
settle, and THEN we can decide what to do. I feel uncomfortable with being 
promoted from incubator without having the API pretty stable.

Once this point is reached, I look pretty confident that OWB will find a well 
established place in the community.

LieGrue,
strub

--- On Wed, 9/9/09, Kevan Miller kevan.mil...@gmail.com wrote:

 From: Kevan Miller kevan.mil...@gmail.com
 Subject: Re: Graduation?
 To: openwebbeans-dev@incubator.apache.org
 Date: Wednesday, September 9, 2009, 6:11 PM
 
 On Sep 8, 2009, at 8:11 PM, Mohammad Nour El-Din wrote:
 
  -1
  
  Allow me to disagree with you Gurkan, IMHO I think OWN
 should be a TLP
  project. I know it is to some extent related to JEE
 but IMO it defines
  a generic and extensible model for dependency
 injection and contextual
  programming which is not restricted to JEE, so being a
 sub-project to
  Geronimo will give the community users the impression
 that we only
  support JEE. I think we should follow the model of
 Tomcat and OpenEJB,
  which is a separate TLP and being integrable with
 other ASF projects
  like Geronimo for example.
 
 Will note that being a sub-project does not prevent OWB
 from providing the same independent functionality, a unique
 mailing list, web site, etc.
 
  
  And for the communit, being a separate TLP will not be
 affected and we
  could get more contributers and committers and a big
 example on that
  is DBlevins.
 
 That's great. But it does mean, IMO, that the community has
 to work on growing and becoming more diverse. I'll note that
 by my tally, so far in 2009, only two committers have
 committed code to OpenWebBeans. Admittedly, this does not
 include code patches. But I don't think I could back a TLP
 proposal without some increased diversity in the community.
 
 Hopefully with the 299 and EE6 spec issues settling down,
 we'll see an increased interest in OpenWebBeans.
 
 As long as the community is working towards graduation, I'm
 with you...
 
 --kevan
 


  


Re: [VOTE][Third Try] Release OpenWebBeans 1.0.0-incubating-M3

2009-09-09 Thread Mark Struberg

+1

looks good.

LieGrue,
strub

--- On Tue, 9/8/09, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote:

 From: Gurkan Erdogdu gurkanerdo...@yahoo.com
 Subject: [VOTE][Third Try] Release OpenWebBeans 1.0.0-incubating-M3
 To: openwebbeans-dev@incubator.apache.org
 Date: Tuesday, September 8, 2009, 10:41 PM
 
 
 Hi;
 
 
 This is the OpenWebBeans M3 release [VOTE] process with
 corrected artifacts. Artifact locations are the same as
 before. 
 
 I've staged the releases artifacts here:
 
 Plugins repository 
 --
 http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M3-rc1/plugins/org/apache/openwebbeans
 
 Distribution content
 
 http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M3-rc1/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M3/
 
 SVN Tag (Revision: 812680)
 
 http://svn.apache.org/repos/asf/incubator/openwebbeans/tags/openwebbeans-1.0.0-incubating-M3-rc1/
 
 
 Please verify that this release package is correct and vote
 for the
 motion to publish this as a openwebbeans M3 release. All
 votes are welcome and
 will be counted.
 
 This vote is open for 72 hours. 
 
 This is my +1
 
 Thanks;
 
 /Gurkan
 
 
       





Re: [VOTE][Second Try] Release OpenWebBeans 1.0.0-incubating-M3

2009-09-07 Thread Mark Struberg
sorry for the delay, will look at it today in the night.

LieGrue,
strub

--- On Mon, 9/7/09, Gurkan Erdogdu cgurkanerdo...@gmail.com wrote:

 From: Gurkan Erdogdu cgurkanerdo...@gmail.com
 Subject: Re: [VOTE][Second Try] Release OpenWebBeans 1.0.0-incubating-M3
 To: openwebbeans-dev@incubator.apache.org
 Date: Monday, September 7, 2009, 9:48 AM
 Hey folks,
 
 Please push the VOTE process. Otherwise it takes a long
 time to release
 milestone. (As you know, we also require to post voting
 mail to gene...@..
 list to get an one more IPMC +1).
 
 Thanks for your understanding;
 
 --Gurkan
 
 2009/9/2 Gurkan Erdogdu gurkanerdo...@yahoo.com
 
 
  Hi;
 
  This is the OpenWebBeans M3 release [VOTE] process
 with corrected
  artifacts.
 
  I've staged the releases artifacts here:
 
  Plugins repository
  --
 
  http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M3-rc1/plugins/org/apache/openwebbeanshttp://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-incubating-M3-rc1/plugins/org/apache/openwebbeans
 
  Distribution content
  
 
  http://people.apache.org/~gerdogdu/staging-repo/OWB/1.0.0-incubating-M3-rc1/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M3/http://people.apache.org/%7Egerdogdu/staging-repo/OWB/1.0.0-incubating-M3-rc1/distribution/org/apache/openwebbeans/apache-openwebbeans-distribution/1.0.0-incubating-M3/
 
  SVN Tag (Revision: 810694)
  
 
  http://svn.apache.org/repos/asf/incubator/openwebbeans/tags/openwebbeans-1.0.0-incubating-M3-rc1/
 
 
  Please verify that this release package is correct and
 vote for the
  motion to publish this as a openwebbeans M3 release.
 All votes are welcome
  and
  will be counted.
 
 
  This is my +1
 
  Thanks;
 
  /Gurkan
 
 
 
 
 
 
 
 -- 
 Gurkan Erdogdu
 http://gurkanerdogdu.blogspot.com
 


  


[jira] Commented: (OWB-134) Remaining 299 draft spec API changes

2009-09-04 Thread Mark Struberg (JIRA)

[ 
https://issues.apache.org/jira/browse/OWB-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12751342#action_12751342
 ] 

Mark Struberg commented on OWB-134:
---

yea cool patch - txs!

Hmm David, since OpenEjb is reasonably stable, may we ask you to become an OWB 
committer too?
It would be a huge honour for us, and hacking on DIs seems to be one of your 
favourite areas anyway ;)

 Remaining 299 draft spec API changes
 

 Key: OWB-134
 URL: https://issues.apache.org/jira/browse/OWB-134
 Project: OpenWebBeans
  Issue Type: Task
Reporter: David Blevins
Assignee: Gurkan Erdogdu
 Attachments: OWB-134-samples.patch.txt, OWB-134.patch.txt


 Still some API changes needed after the 330 impact on the 299 spec.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



  1   2   3   >