Re: [OpenWrt-Devel] [PATCH] enable Cisco Aironet on PCI systems

2008-07-26 Thread Alexandros C. Couloumbis
1). This is a duplicate (comes with age)
http://lists.openwrt.org/pipermail/openwrt-devel/2007-December/001459.html

2). According to this:
http://www.kernel.org/pub/linux/kernel/v2.6/snapshots/old/patch-2.6.14-rc4-git4.log


commit 6593b58cfb54138781c5cd88f605e2ae663301b0
tree 32ebcd01bb2eda36d83628d3a490555475c7e06c
parent e26148d934762b61133a64b6862f870624ff617d
author Matteo Croce [EMAIL PROTECTED] Fri, 14 Oct 2005 15:59:06 -0700
committer Linus Torvalds [EMAIL PROTECTED] Fri, 14 Oct 2005 17:10:12 -0700

[PATCH] wireless/airo: Build fix

The aironet PCI driver has a build dependency on ISA that prevent the
driver to compile on systems that doesn't support ISA, like x86_64.  The
driver really doesn't depend on ISA, it does some ISA stuff in the
initialization code, since the driver supports both ISA and PCI cards.  So
the driver should depend on ISA_DMA_API to build on all systems, and this
will not hurt PCI at all.

Signed-off-by: Matteo Croce [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
Signed-off-by: Linus Torvalds [EMAIL PROTECTED]


ISA_DMA_API appeard on 2.6.12 kernel:
http://www.linuxhq.com/kernel/v2.6/12/arch/mips/Kconfig
and was removed on kernel 2.6.15 for reasons that I am not
aware of (perhaps for less kernel size):
http://www.linuxhq.com/kernel/v2.6/15/arch/mips/Kconfig 

According to the above, the previous patch is not correct.
in order for a cisco airo miniPCI to work on a mips system 
the following patch needs to be applied.  another option will
be to totally remove the ISA related code from the driver 
itself.

Signed-off-by: Alexandros C. Couloumbis alex at ozo.com

---

diff -Nrub a/arch/mips/Kconfig b/arch/mips/Kconfig
--- a/arch/mips/Kconfig 2008-07-26 14:53:11.0 +0300
+++ b/arch/mips/Kconfig 2008-07-26 14:52:58.0 +0300
@@ -2126,3 +2126,18 @@
 source crypto/Kconfig

 source lib/Kconfig
+
+#
+# Use the generic interrupt handling code in kernel/irq/:
+#
+#config GENERIC_HARDIRQS
+#   bool
+#   default y
+
+#config GENERIC_IRQ_PROBE
+#   bool
+#   default y
+
+config ISA_DMA_API
+   bool
+   default y

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] Missing wireless and DHCP server on fresh SVN build?

2008-07-26 Thread Felix Fietkau
Steven Van Ingelgem wrote:
 Hi Stephen,
 
 
 I know 2.6 doesn't support yet the broadcom driver :(... I completely
 bricked (and yes, I tried everything but the JTAG method) my router with
 flashing an SVN image of the 2.6 kernel :).
 
 When I flash the original firmware or dd-wrt, it has wireless... But not
 with the latest SVN version of OpenWRT?
 
 When I do ifup wl0 it says the interface is unknown, and when I run
 something like iwconfig (I can't remember exactly anymore, but it's the
 program started by /etc/init.d/network to check for wireless) it says wl0
 is disabled?
Take a look at /etc/config/wireless
There's a line 'option disabled 1' in there by default

OpenWrt disables wireless by default in order to not start up the first time
giving unprotected and unrestricted access to the LAN.
After you've commented out that one, run 'wifi' and it should bring up wifi

- Felix

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] Etrax support

2008-07-26 Thread MichelinoK
Have you tryed someting? 



___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [BUG] dnsmasq broken on ixp4xx

2008-07-26 Thread Harald Schioeberg
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

dnsmasq doesn't work properly on ixp4xx if the highest bit on the lan ip
is set (ip = 128.0.0.0)
(may be a big-endian issue)

the bug is in /usr/lib/common.awk
ip2int and int2ip

here is the output of ipcalc.sh:

[EMAIL PROTECTED]:/usr/lib# ipcalc.sh 1.2.3.4 255.255.255.0 100 150
IP=1.2.3.4
NETMASK=0.0.0.0
BROADCAST=1.2.3.255
NETWORK=1.2.3.0
PREFIX=24
START=1.2.3.100
END=1.2.3.249
[EMAIL PROTECTED]:/usr/lib# ipcalc.sh 128.2.3.4 255.255.255.0 100 150
IP=0.0.0.4
NETMASK=0.0.0.0
BROADCAST=0.0.0.255
NETWORK=0.0.0.0
PREFIX=24
START=0.0.0.100
END=0.0.0.249
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIi3wLJgyxs71kcx4RAv5VAJ9YB2M+Cuc96YpnbAA6sBJVsvZiNwCgi+hF
sbvKCWs68B8RvMkN3B8vyWA=
=OXGi
-END PGP SIGNATURE-
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] uci glitch

2008-07-26 Thread Harald Schioeberg
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

uci conf-file parsing has a small glitch:


config 'interface' 'lan'
option 'type'  'bridge'
 ^^

leads to

network.lan.type= bridge
 ^

note the 2 whitespace between 'type' and 'bridge' and the whitespace
between = and bridge

seems that quotes are not handled the way they are meant.
its worth reporting, since broken quotes often draw a lot of security
implications

harald

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIi5uhJgyxs71kcx4RAnywAKDb7l/LCcRhbi48t1KjYRgdDhnpAQCgpDqJ
zx1wui5DJQUzXXvsVHWNpCk=
=b95Q
-END PGP SIGNATURE-
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH] Dynamic Apache - 1/3 libapr (resubmit)

2008-07-26 Thread Michael Geddes
This set starts off with patches to libapr  to support Apache with modules 
rather than static.  With 
modules, it is more versatile, and more compact for a required feature set.

Much of this work was borrowed from optware.

Signed-off-by: Michael Geddes michael at frog dot wheelycreek dot net
---
Index: packages/libs/apr/Makefile
===
--- packages/libs/apr/Makefile  (revision 11372)
+++ packages/libs/apr/Makefile  (working copy)
@@ -29,9 +29,7 @@
 endef
 
 CONFIGURE_ARGS += \
-   --with-devrandom=/dev/urandom \
-   --disable-dso \
-   --enable-ipv6
+   --with-devrandom=/dev/urandom
 
 CONFIGURE_VARS += \
ac_cv_file__dev_zero=yes \
@@ -39,36 +37,53 @@
apr_cv_mutex_robust_shared=no \
apr_cv_tcp_nodelay_with_cork=yes \
ac_cv_sizeof_ssize_t=4 \
-   LDFLAGS=LDFLAGS -lpthread \
+   LDFLAGS=LDFLAGS -lpthread
 
-define Build/Compile
+ifneq ($(CONFIG_PACKAGE_libapr),)
+define Build/Compile/libapr
+   echo configuring APR Dynamic
+   $(call Build/Configure/Default, \
+   --disable-static \
+   --enable-layout=GNU \
+   --enable-lfs \
+   --enable-ipv6 \
+   )
+   echo Building APR Dynamic
$(MAKE) -C $(PKG_BUILD_DIR) DESTDIR=$(PKG_INSTALL_DIR) all install
 endef
+endif
 
+define Build/Compile
+   $(call Build/Compile/libapr)
+endef
+
+define Build/Configure
+   echo NOT configuring APR
+endef
+
 define Build/InstallDev
-   $(INSTALL_DIR) $(1)/usr/bin $(1)/usr/include/apr-1 $(1)/usr/lib 
$(1)/usr/lib/pkgconfig 
$(1)/usr/share/build-1
-   $(CP)   $(PKG_INSTALL_DIR)/usr/bin/apr-1-config \
-   $(1)/usr/bin/
-   $(CP)   $(PKG_INSTALL_DIR)/usr/include/apr-1/* \
-   $(1)/usr/include/apr-1/
-   $(CP)   $(PKG_INSTALL_DIR)/usr/lib/libapr-1.{la,a,so*} \
-   $(1)/usr/lib/
-   $(CP)   $(PKG_INSTALL_DIR)/usr/lib/pkgconfig/apr-1.pc \
-   $(1)/usr/lib/pkgconfig/
-   $(CP)   $(PKG_INSTALL_DIR)/usr/share/build-1/* \
-   $(1)/usr/share/build-1/
-   $(SED) 
's,^datadir=\/usr/share\,datadir=\$(STAGING_DIR)/usr/share\,g' 
$(1)/usr/bin/apr-1-config
-   
$(SED) 
's,^installbuilddir=\/usr/share/build-1\,installbuilddir=\$(STAGING_DIR)/usr/share/build-1\,g'
 
$(1)/usr/bin/apr-1-config
-   $(SED) 
's,^libdir=\{exec_prefix}/lib,libdir=\$(STAGING_DIR)/usr/lib,g' 
$(1)/usr/bin/apr-1-config
-   $(SED) 
's,^includedir=\{prefix}/include/,includedir=\$(STAGING_DIR)/usr/include/,g'
 
$(1)/usr/bin/apr-1-config
-   $(SED) 's,-Llibdir,,g' $(1)/usr/bin/apr-1-config
-   $(SED) 's,-Rlibdir,,g' $(1)/usr/bin/apr-1-config
+   $(INSTALL_DIR) $(1)/usr/bin $(1)/usr/include/apr-1 $(1)/usr/lib 
$(1)/usr/lib/pkgconfig 
$(1)/usr/share/build-1 $(1)/usr/include/apache2
+   $(CP)   $(PKG_INSTALL_DIR)/usr/bin/apr-1-config*    $(1)/usr/bin || true
+   $(CP)   $(PKG_INSTALL_DIR)/usr/include/apr-1/*      
$(1)/usr/include/apr-1 || true
+   $(CP)   $(PKG_INSTALL_DIR)/usr/include/apache2/*    
$(1)/usr/include/apache2 || true
+   $(CP)   $(PKG_INSTALL_DIR)/usr/lib/lib{apr-1,apr}.{la,a,so*} 
$(1)/usr/lib || true
+   $(CP)   $(PKG_INSTALL_DIR)/usr/lib/pkgconfig/apr-1.pc 
$(1)/usr/lib/pkgconfig || true 
+   $(CP)   $(PKG_INSTALL_DIR)/usr/share/build-1/*      
$(1)/usr/share/build-1 || true
+   for i in $(1)/usr/bin/apr-1-config* ; do \
+     $(SED) 
's,^datadir=\/usr/share\,datadir=\$(STAGING_DIR)/usr/share\,g' i; \
+     
$(SED) 
's,^installbuilddir=\/usr/share/build-1\,installbuilddir=\$(STAGING_DIR)/usr/share/build-1\,g'
 
i ; \
+     $(SED) 
's,^libdir=\{exec_prefix}/lib,libdir=\$(STAGING_DIR)/usr/lib,g' i ; \
+     $(SED) 
's,^includedir=\{prefix}/include/,includedir=\$(STAGING_DIR)/usr/include/,g'
 
i ; \
+     $(SED) 's,-Llibdir,,g' i ; \
+     $(SED) 's,-Rlibdir,,g' i ; \
+   done
$(SED) 's,/usr/share/build-1,$(STAGING_DIR)/usr/share/build-1,g' 
$(1)/usr/share/build-1/apr_rules.mk
 endef
 
 define Package/libapr/install
$(INSTALL_DIR) $(1)/usr/lib
-   $(CP) $(PKG_INSTALL_DIR)/usr/lib/libapr-1.so.* $(1)/usr/lib/
+   $(CP) $(PKG_INSTALL_DIR)/usr/lib/libapr.so.* $(1)/usr/lib/
 endef
 
 $(eval $(call BuildPackage,libapr))
+
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH] Dynamic Apache - 2/3 l ibapr-util   (resubmit)

2008-07-26 Thread Michael Geddes
Patches to libapr-util  to support apache with modules.

Signed-off-by: Michael Geddes michael at frog dot wheelycreek dot net
---
Index: packages/libs/apr-util/Makefile
===
--- packages/libs/apr-util/Makefile (revision 11372)
+++ packages/libs/apr-util/Makefile (working copy)
@@ -42,18 +42,21 @@
APR_BUILD_DIR=$(STAGING_DIR)/usr/share/build-1 \
 
 define Build/Compile
-   $(MAKE) -C $(PKG_BUILD_DIR) 
APRUTIL_LIBS=-lsqlite3 -L$(STAGING_DIR)/usr/lib -lexpat -liconv -lapr-1 -luuid 
-lm -lcrypt all
+   $(MAKE) -C $(PKG_BUILD_DIR) 
APRUTIL_LIBS=-lsqlite3 -L$(STAGING_DIR)/usr/lib -lexpat -liconv -lapr -luuid 
-lm -lcrypt all
$(MAKE) -C $(PKG_BUILD_DIR) DESTDIR=$(PKG_INSTALL_DIR) install
 endef
 
 define Build/InstallDev
$(INSTALL_DIR) $(1)/usr/bin $(1)/usr/include/apr-1/ $(1)/usr/lib  
$(1)/usr/lib/pkgconfig/
$(CP)   $(PKG_INSTALL_DIR)/usr/bin/apu-1-config \
-   $(1)/usr/bin/
+   $(1)/usr/bin
$(CP)   $(PKG_INSTALL_DIR)/usr/include/apr-1/* \
$(1)/usr/include/apr-1/
-   $(CP)   $(PKG_INSTALL_DIR)/usr/lib/libaprutil-1.{la,a,so*} \
+   $(CP)   $(PKG_INSTALL_DIR)/usr/lib/libaprutil-1.{la,so*} \
$(1)/usr/lib/
+   [ ! -e $(PKG_INSTALL_DIR)/usr/lib/libaprutil-1.a ] \
+   || $(CP)   $(PKG_INSTALL_DIR)/usr/lib/libaprutil-1.a \
+   $(1)/usr/lib/
$(CP)   $(PKG_INSTALL_DIR)/usr/lib/pkgconfig/apr-util-1.pc \
$(1)/usr/lib/pkgconfig/
$(SED) 's, -e \s -Iprefix/lib  g\,,g' $(1)/usr/bin/apu-1-config
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH] Dynamic Apache - 3/3 a pache   (resubmit)

2008-07-26 Thread Michael Geddes
The patches to apache itself. Including all the modules as separate packages.

Signed-off-by: Michael Geddes michael at frog dot wheelycreek dot net

---
Index: packages/net/apache/patches/005-apxs_optware.patch
===
--- packages/net/apache/patches/005-apxs_optware.patch  (revision 0)
+++ packages/net/apache/patches/005-apxs_optware.patch  (revision 0)
@@ -0,0 +1,46 @@
+--- httpd-2.2.4.orig/support/apxs.in   2005-02-04 12:21:18.0 -0800
 httpd-2.2.4/support/apxs.in2005-02-20 09:53:13.861402759 -0800
+@@ -199,18 +199,19 @@
+ ($httpd = $0) =~ s:support/apxs$::;
+ }
+ 
+-unless (-x $httpd) {
+-  error($httpd not found or not executable);
+-  exit 1;
+-}
+-
+-unless (grep /mod_so/, `. $envvars  $httpd -l`) {
+-error(Sorry, no shared object support for Apache);
+-error(available under your platform. Make sure);
+-error(the Apache module mod_so is compiled into);
+-error(your server binary `$httpd'.);
+-exit 1;
+-}
++### these checks will not work when cross-compiling into a staging area!
++#unless (-x $httpd) {
++# error($httpd not found or not executable);
++# exit 1;
++#}
++#
++#unless (grep /mod_so/, `. $envvars  $httpd -l`) {
++#error(Sorry, no shared object support for Apache);
++#error(available under your platform. Make sure);
++#error(the Apache module mod_so is compiled into);
++#error(your server binary `$httpd'.);
++#exit 1;
++#}
+ 
+ sub get_config_vars{
+ my ($file, $rh_config) = @_;
+@@ -528,9 +529,10 @@
+ 
+ #   activate module via LoadModule/AddModule directive
+ if ($opt_a or $opt_A) {
++  ### when staging, this should be non-fatal
+ if (not -f $CFG_SYSCONFDIR/$CFG_TARGET.conf) {
+ error(Config file $CFG_SYSCONFDIR/$CFG_TARGET.conf not found);
+-exit(1);
++exit(0);
+ }
+ 
+ open(FP, $CFG_SYSCONFDIR/$CFG_TARGET.conf) || die;
Index: packages/net/apache/Makefile
===
--- packages/net/apache/Makefile(revision 11801)
+++ packages/net/apache/Makefile(working copy)
@@ -45,9 +45,279 @@
 define Package/apache-server
   $(call Package/apache/Default)
   TITLE:=The Apache Web Server and some tools
-  DEPENDS:=apache
+  DEPENDS:=+libapr +libaprutil +zlib +libexpat +libpcre +libopenssl 
+libsqlite3
 endef
 
+define Package/apache-mod_actions
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_actions
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_alias
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_alias
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_asis
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_asis
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_auth_basic
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_auth_basic
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_auth_digest
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_auth_digest
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_authn
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_authn
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_authn_db
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_authn_db
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_authz
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_authz
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_authz_dbm
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_authz_dbm
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_autoindex
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_autoindex
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_cache
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_cache
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_cern_meta
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_cern_meta
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_cgi
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_cgi
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_dav_fs
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_dav_fs
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_dbd
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_dbd
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_deflate
+  $(call Package/apache/Default)
+  Title:= Module for apache server - mod_deflate
+  DEPENDS:=+apache-server
+endef
+
+define Package/apache-mod_dir
+  $(call Package/apache/Default)
+  Title:= Module for 

[OpenWrt-Devel] [PATCH] Asterisk update - 1/4 Add speexdsp library (resubmit)

2008-07-26 Thread Michael Geddes
The speexdsp library is required by the latest asterisk

Signed-off-by: Michael Geddes michael at frog dot wheelycreek dot net

---
Index: packages/libs/speex/Makefile
===
--- packages/libs/speex/Makefile(revision 11372)
+++ packages/libs/speex/Makefile(working copy)
@@ -29,6 +29,13 @@
   URL:=http://www.speex.org/
 endef
 
+define Package/libspeexdsp
+  SECTION:=libs
+  CATEGORY:=Libraries
+  TITLE:=Open source speech compression codec library output to DSP
+  URL:=http://www.speex.org/
+endef
+
 define Package/libspeex/description
Open source patent-free speech compression codec library.
Speex is an Open Source/Free Software patent-free audio compression 
@@ -41,6 +48,18 @@
This package contains the shared codec library, needed by other 
programs.
 endef
 
+define Package/libspeexdsp/description
+   Open source patent-free speech compression codec library.
+   Speex is an Open Source/Free Software patent-free audio compression 
+   format designed for speech. The Speex Project aims to lower the 
+   barrier of entry for voice applications by providing a free 
+   alternative to expensive proprietary speech codecs. Moreover, Speex 
+   is well-adapted to Internet applications and provides useful features 
+   that are not present in most other codecs.
+
+   This package contains the shared dsp library, needed by other programs.
+endef
+
 TARGET_LDFLAGS:=$(TARGET_LDFLAGS) -lnotimpl
 
 define Build/Configure
@@ -62,12 +81,14 @@
 endef
 
 define Build/InstallDev
-   mkdir -p $(1)/usr/include
+   $(INSTALL_DIR) $(1)/usr/include
$(CP) $(PKG_INSTALL_DIR)/usr/include/speex $(1)/usr/include/
-   mkdir -p $(1)/usr/lib
+   $(INSTALL_DIR) $(1)/usr/lib
$(CP) $(PKG_INSTALL_DIR)/usr/lib/libspeex.{a,so*} $(1)/usr/lib/
-   mkdir -p $(1)/usr/lib/pkgconfig
+   $(CP) $(PKG_INSTALL_DIR)/usr/lib/libspeexdsp.{a,so*} $(1)/usr/lib/
+   $(INSTALL_DIR) $(1)/usr/lib/pkgconfig
$(CP) $(PKG_INSTALL_DIR)/usr/lib/pkgconfig/speex.pc 
$(1)/usr/lib/pkgconfig/
+   $(CP) $(PKG_INSTALL_DIR)/usr/lib/pkgconfig/speexdsp.pc 
$(1)/usr/lib/pkgconfig/
 endef
 
 define Package/libspeex/install
@@ -75,4 +96,11 @@
$(CP) $(PKG_INSTALL_DIR)/usr/lib/libspeex.so.* $(1)/usr/lib/
 endef
 
+define Package/libspeexdsp/install
+   $(INSTALL_DIR) $(1)/usr/lib
+   $(CP) $(PKG_INSTALL_DIR)/usr/lib/libspeexdsp.so.* $(1)/usr/lib/
+endef
+
 $(eval $(call BuildPackage,libspeex))
+$(eval $(call BuildPackage,libspeexdsp))
+
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] never ending story of patches not being applied

2008-07-26 Thread Brian J. Murrell
On Sun, 2008-07-27 at 01:48 +0200, Frédéric Moulins wrote:
 It is not the case, but Trac remains a good system for tracking issues
 (categories, search), visualizing (diff, browse), and linking things
 together.

Then Trac is not a good system.  I'm certainly no bugzilla fanboy but
given your observations about Trac I can say that bugzilla does all of
this.  At my workplace we use Bugzilla exactly for this purpose.
Customers file bugs, developers create patches as bugzilla attachments.
Other engineers comment on such patches in the same bug.  Patches come
to resolution and then they land on branches.  The bug even tracks which
branches they land on.

 Contributors should be advised to first submit patches in the issue
 tracker. 
 
 Then, 
 * if they have questions

They being the patch submitters or the reviewers?

 while submitting their patches, they should
 be told to send patches to the mailing list by following the
 established conventions (To and CC, formatting, Signed-off-by,...) *and*
 with questions in order to get a review, nack, ack or can't look at it
 for the moment

No.  I disagree.  Requiring contributors to post patches to more than
one place is burdensome on the community you are trying to attract and
confusing for new members.

Choose one: a good tracking system or e-mail.  Not both.

 * if someone asks for it (by commenting the issue), they should know
 they may have to re-submit the patch to the mailing list.

Maybe in my case it's no great loss (but maybe for other contributors
the loss would be greater and measurable) I would simply refuse to
contribute patches if I knew the process were going to be so cumbersome.

Your goal here is to keep the barrier low and encourage contribution,
not to make it a PITA to contribute.
 
 I think it could work this way because patches needing a review -
 therefore a discussion, so emails - are either patch series or patches
 from people not experts on what they are modifying (first time,
 hack, not so much documentation...). In both case, patches are
 accompagnied by questions (either call for review, or expression
 of doubt) - therefore discussion... *But*, not so many submissions are
 patch series or complex hacks that could'nt be commented in Trac :
 think package updates, one liners. And people do not ask much questions
 because they tend to think if it works it is ok (at least, I do, most
 of the time).

All of this tracking and questions and commenting, etc. can be carried
out in a better tracker (on the assumption that your position that Trac
doesn't do it well) and not have to be a bastardized process mishmash of
half-Trac and half e-mail.  Seriously, if a screwdriver isn't the right
tool, adding a hammer to it doesn't make it right tool.

 Is it possible to let the submitter modify ticket properties after
 submission ? (like component: quite frustrating when ticket created
 with package instead of base system or else). It could help
 classification to be done by more people.

Like bugzilla lets one do?

Seriously, again I'm no bugzilla fanboy, but it's a mature product that
has been doing what it does for many many years -- enough to at least
get the workflow aspects right.

b.



signature.asc
Description: This is a digitally signed message part
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel