Re: [OpenWrt-Devel] [PATCH] Kernel is downloaded although "Advanced configuration options (for developers) -> Use external kernel tree" is selected.

2009-12-10 Thread Erdem Ergen
Diff file is attached.

 

Erdem.

 

From: Erdem Ergen 
Sent: Friday, December 11, 2009 12:12 AM
To: 'openwrt-devel@lists.openwrt.org'
Subject: [PATCH] Kernel is downloaded although "Advanced configuration
options (for developers) -> Use external kernel tree" is selected.

 

This patch fixes/prevents unnecessary download of Linux kernel if
"Advanced configuration options (for developers) -> Use external kernel
tree" is selected.

 

As you know, there is an option "Advanced configuration options (for
developers) -> Use external kernel tree", and if we select and type the
directory of special kernel it uses this kernel. This configuration does
not require downloading kernel, but it does. So that patch prevents
unnecessary download of kernel.

 

Signed-off-by: Erdem Ergen  

 

diff --git a/include/host-build.mk b/include/host-build.mk

index 8eb49c8..09ec42e 100644

--- a/include/host-build.mk

+++ b/include/host-build.mk

@@ -112,10 +112,20 @@ define Host/Exports/Default

 endef

 Host/Exports=$(Host/Exports/Default)

 

+iflinux:=

+ifeq ($(strip $(PKG_NAME)),linux)

+ifneq ($(strip $(CONFIG_EXTERNAL_KERNEL_TREE)),"")

+DownloadPackage = 

+else

+DownloadPackage = $(call Download,default)

+endif

+endif

+

 ifndef DUMP

   define HostBuild

   $(if $(HOST_QUILT),$(Host/Quilt))

-  $(if $(if $(PKG_HOST_ONLY),,$(STAMP_PREPARED)),,$(if $(strip
$(PKG_SOURCE_URL)),$(call Download,default)))

+  $(eval $(call iflinux))

+  $(if $(if $(PKG_HOST_ONLY),,$(STAMP_PREPARED)),,$(if $(strip
$(PKG_SOURCE_URL)),$(DownloadPackage)))

   $(if $(DUMP),,$(call HostHost/Autoclean))

 

   $(HOST_STAMP_PREPARED):

 

 



diff_kerneldownload
Description: diff_kerneldownload
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] Porting WNR3500L into Kamikaze-8.09.1

2009-12-10 Thread Tathagata Das
I am still waiting any response. Any help regarding this is appreciated.

Tathagata

On Wed, Dec 9, 2009 at 3:46 PM, Tathagata Das wrote:

> Hi All,
>  I want to port WNR3500L onto Kamikaze-8.09.1 with kernel-2.6.25 which has
> ssb driver. But in WNR3500L, ssb has been changes. So to port WNR3500L I
> need to modify the ssb driver in the kernel along with some files under
> arch/mips/bcm47xx directory.
> Hence before modifying anything I just want to check that is there anybody
> who is already working on it ? If no work has been done then could somebody
> please tell what should be the approach of porting this ?
>
> Thanks in advance.
>
> Tathagata
>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] my patches being ignored?

2009-12-10 Thread Felix Fietkau
On 2009-12-11 5:04 AM, Brian J. Murrell wrote:
>> I took care of that now for the shorewall patches and fixed
>> some minor compile errors in there.
> Yeah.  I guess I don't have a non-GNU system to have weeded those out.
> Sorry.
No problem. It might have been broken before your changes already,
I didn't test.

>> Did you post any other patches that we overlooked and that you would
>> like us to merge?
> 
> Well it seems you got the "add shorewall6-lite" as well as the "update
> shorewall-lite to 4.2.11" but there was a third patch in message with
> subject "[PATCH] Default logfile to be non-local" that didn't seem to
> get applied.
Done.

- Felix
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] my patches being ignored?

2009-12-10 Thread Brian J. Murrell
On Fri, 2009-12-11 at 03:10 +0100, Felix Fietkau wrote: 
> Sorry for the delay,

No worries.  I understand busy.  I was trying to be patient but that
only lasted until I saw other commits.  :-/

> I took care of that now for the shorewall patches and fixed
> some minor compile errors in there.

Yeah.  I guess I don't have a non-GNU system to have weeded those out.
Sorry.

> Did you post any other patches that we overlooked and that you would
> like us to merge?

Well it seems you got the "add shorewall6-lite" as well as the "update
shorewall-lite to 4.2.11" but there was a third patch in message with
subject "[PATCH] Default logfile to be non-local" that didn't seem to
get applied.

Thanx much for applying those though!

b.





signature.asc
Description: This is a digitally signed message part
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] my patches being ignored?

2009-12-10 Thread Felix Fietkau
On 2009-12-11 1:52 AM, Brian J. Murrell wrote:
> Is there any reason in particular that my patches to this list are being
> ignored?  I thought it was everyone's but I saw some commits today, yet
> not my patches which were sent here prior the patches that were
> committed today.
> 
> This seems to be my (and others from messages I have seen posted here in
> the past) history with this list.  I take the time to make and send
> patches and they get ignored despite others' being committed.  It's
> really quite discouraging to contribute to a project only to have one's
> contribution ignored.
> 
> If there is something wrong with my patches, would somebody please tell
> me what it is rather than simply ignoring them?  Ignoring mistakes won't
> get them corrected.
> 
> Thanx for your time and attention.
Sorry for the delay, they probably got overlooked, or nobody had time to
apply them. I took care of that now for the shorewall patches and fixed
some minor compile errors in there.
Did you post any other patches that we overlooked and that you would
like us to merge?

- Felix
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] my patches being ignored?

2009-12-10 Thread Brian J. Murrell
Is there any reason in particular that my patches to this list are being
ignored?  I thought it was everyone's but I saw some commits today, yet
not my patches which were sent here prior the patches that were
committed today.

This seems to be my (and others from messages I have seen posted here in
the past) history with this list.  I take the time to make and send
patches and they get ignored despite others' being committed.  It's
really quite discouraging to contribute to a project only to have one's
contribution ignored.

If there is something wrong with my patches, would somebody please tell
me what it is rather than simply ignoring them?  Ignoring mistakes won't
get them corrected.

Thanx for your time and attention.

b.



signature.asc
Description: This is a digitally signed message part
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] Kernel is downloaded although "Advanced configuration options (for developers) -> Use external kernel tree" is selected.

2009-12-10 Thread Felix Fietkau
On 2009-12-10 11:12 PM, Erdem Ergen wrote:
> 
> This patch fixes/prevents unnecessary download of Linux kernel if
> "Advanced configuration options (for developers) -> Use external kernel
> tree" is selected. 
> 
> As you know, there is an option "Advanced configuration options (for
> developers) -> Use external kernel tree", and if we select and type the
> directory of special kernel it uses this kernel. This configuration does
> not require downloading kernel, but it does. So that patch prevents
> unnecessary download of kernel.
> 
> Signed-off-by: Erdem Ergen 
Please resend as pure plain text email or add the patch as an
attachment, as your mail client seems to have seriously damaged the
formatting of this patch.

- Felix
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH] Kernel is downloaded although "Advanced configuration options (for developers) -> Use external kernel tree" is selected.

2009-12-10 Thread Erdem Ergen
This patch fixes/prevents unnecessary download of Linux kernel if
"Advanced configuration options (for developers) -> Use external kernel
tree" is selected.

 

As you know, there is an option "Advanced configuration options (for
developers) -> Use external kernel tree", and if we select and type the
directory of special kernel it uses this kernel. This configuration does
not require downloading kernel, but it does. So that patch prevents
unnecessary download of kernel.

 

Signed-off-by: Erdem Ergen  

 

diff --git a/include/host-build.mk b/include/host-build.mk

index 8eb49c8..09ec42e 100644

--- a/include/host-build.mk

+++ b/include/host-build.mk

@@ -112,10 +112,20 @@ define Host/Exports/Default

 endef

 Host/Exports=$(Host/Exports/Default)

 

+iflinux:=

+ifeq ($(strip $(PKG_NAME)),linux)

+ifneq ($(strip $(CONFIG_EXTERNAL_KERNEL_TREE)),"")

+DownloadPackage = 

+else

+DownloadPackage = $(call Download,default)

+endif

+endif

+

 ifndef DUMP

   define HostBuild

   $(if $(HOST_QUILT),$(Host/Quilt))

-  $(if $(if $(PKG_HOST_ONLY),,$(STAMP_PREPARED)),,$(if $(strip
$(PKG_SOURCE_URL)),$(call Download,default)))

+  $(eval $(call iflinux))

+  $(if $(if $(PKG_HOST_ONLY),,$(STAMP_PREPARED)),,$(if $(strip
$(PKG_SOURCE_URL)),$(DownloadPackage)))

   $(if $(DUMP),,$(call HostHost/Autoclean))

 

   $(HOST_STAMP_PREPARED):

 

 

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] OpenWRT uml snapshot branch

2009-12-10 Thread Adrian Terranova
On Thu, Dec 10, 2009 at 11:34 AM, Adrian Terranova  wrote:
> I don't see any reason why it couldn't just be another build target -
> I can futz with it when I get time. You can also just use the binaries
> from the x86 image like this.

(sorry - meant to nip as portion of my writeup.)

[snip]

1) d/l the latest openwrt for uml from

http://kamikaze.openwrt.org/8.09.1/x86/openwrt-x86-ext2.image

I really really wish - they had a CURRENT link here for this.

2) modify that puppy to your hearts content - for instance

mkdir /tmp/foo
mount -o loop ./openwrt.x86-ext2.image /tmp/foo
cd /tmp/foo
chroot . /bin/ash
echo "nameserver x.x.x.x" > /etc/nameserver
opkg update
opkg install BLAH
mkdir /etc/dropbear

echo "VTYSH_PAGER=/usr/bin/less" > /root/.profile

exit <--- moved this to the right spot.
umount /tmp/foo
cp ./openwrt.x86-ext2.image $CLOOMIX_HOME/bulk/openwrt_uml


(and then just boot the uml image with the kernel in the snapshot tree.)

--Adrian

>
> Where is the makefile for the binaries / packges? ( I can poke thru.)
>
> if you need a specific example install clownix - but I installed
> quagga  / vtysh (and could have installed anything I wanted (I
> think).. I tried with xwrt images and openwrt 8.09 ... and it all
> seemed to work - but YMMV
>
> for pointers see.
>
> http://www.vlcg.net/content/clownix-update
>
> --Adrian
>
> On Thu, Dec 10, 2009 at 9:24 AM, Benjamin Henrion  wrote:
>> On Thu, Dec 10, 2009 at 2:47 PM, Bastian Bittorf  
>> wrote:
>>> * Benjamin Henrion  [10.12.2009 14:30]:

 It is a pain to have to setup its own webserver if you want to install
 packages for openwrt-uml.
>>>
>>> Just run 'httpd -h /mydir' and place your packages there.
>>> It's not openWRT's fault, that your windows does not have a simple httpd.
>>
>> It seems that the developers does not provide binaries for UML,
>> because of the libc6 dependency of different linux distributions.
>>
>> Why not provide binaries with the libc6 in static?
>>
>> --
>> Benjamin Henrion 
>> FFII Brussels - +32-484-566109 - +32-2-4148403
>> "In July 2005, after several failed attempts to legalise software
>> patents in Europe, the patent establishment changed its strategy.
>> Instead of explicitly seeking to sanction the patentability of
>> software, they are now seeking to create a central European patent
>> court, which would establish and enforce patentability rules in their
>> favor, without any possibility of correction by competing courts or
>> democratically elected legislators."
>> ___
>> openwrt-devel mailing list
>> openwrt-devel@lists.openwrt.org
>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>>
>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] OpenWRT uml snapshot branch

2009-12-10 Thread Adrian Terranova
I don't see any reason why it couldn't just be another build target -
I can futz with it when I get time. You can also just use the binaries
from the x86 image like this.

Where is the makefile for the binaries / packges? ( I can poke thru.)

if you need a specific example install clownix - but I installed
quagga  / vtysh (and could have installed anything I wanted (I
think).. I tried with xwrt images and openwrt 8.09 ... and it all
seemed to work - but YMMV

for pointers see.

http://www.vlcg.net/content/clownix-update

--Adrian

On Thu, Dec 10, 2009 at 9:24 AM, Benjamin Henrion  wrote:
> On Thu, Dec 10, 2009 at 2:47 PM, Bastian Bittorf  
> wrote:
>> * Benjamin Henrion  [10.12.2009 14:30]:
>>>
>>> It is a pain to have to setup its own webserver if you want to install
>>> packages for openwrt-uml.
>>
>> Just run 'httpd -h /mydir' and place your packages there.
>> It's not openWRT's fault, that your windows does not have a simple httpd.
>
> It seems that the developers does not provide binaries for UML,
> because of the libc6 dependency of different linux distributions.
>
> Why not provide binaries with the libc6 in static?
>
> --
> Benjamin Henrion 
> FFII Brussels - +32-484-566109 - +32-2-4148403
> "In July 2005, after several failed attempts to legalise software
> patents in Europe, the patent establishment changed its strategy.
> Instead of explicitly seeking to sanction the patentability of
> software, they are now seeking to create a central European patent
> court, which would establish and enforce patentability rules in their
> favor, without any possibility of correction by competing courts or
> democratically elected legislators."
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [Netkit.users] OpenWRT UML integrated into Netkit

2009-12-10 Thread ZioPRoTo (Saverio Proto)
> very interesting!
> The page you mention has been linked from the Netkit web site:
> http://wiki.netkit.org/index.php/Labs_Links.

Massimo there is a little wrong detail on the web site.

I did not use only the OpenWRT kernel. I used both OpenWRT kernel AND
filesystem ! :)

Saverio
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [Netkit.users] OpenWRT UML integrated into Netkit

2009-12-10 Thread ZioPRoTo (Saverio Proto)
> very interesting!
> The page you mention has been linked from the Netkit web site:
> http://wiki.netkit.org/index.php/Labs_Links.

thanks ! :)

> About the tap, host-side setup is performed by the
> $NETKIT_HOME/bin/manage_tuntap script, and this is almost all that is
> required to get it running. The only thing that is left to do inside the
> guest is to add a default route, which is performed by the
> /etc/init.d/netkit-phase1 script.

Yes, that's what I realized reading the scripts :) However there is
something I'm missing to make the all thing work.

If I run a default netkit UML debian machine everything works perfect.

When I run the OpenWRT UML Machine:

 * I configure by hand the IP address and the default route on the
OpenWRT virtual Machine
 * I flush any default iptables rule on the OpenWRT virtual machine
 * I try to ping 10.0.0.1

If I tcpdump from OpenWRT I only see ARP requests for 10.0.0.1. So I
see only the traffic generated from the UML OpenWRT machine.

On the host machine sniffing on the tap I see the ARP requests and I
see also the ARP reply being generated, but those answer never
actually get back to the OpenWRT guest machine.

Iptables rules on the host machine also have been checked and they look fine.

Maybe I'm missing some kernel module in the UML OpenWRT guest machine ?

So the problem is that the traffic generated from the host machine on
the tap interface is not heard by the guest machine... I have no idea
how to debug deeper in this problem :(

Saverio
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] OpenWRT uml snapshot branch

2009-12-10 Thread Benjamin Henrion
On Thu, Dec 10, 2009 at 2:47 PM, Bastian Bittorf  wrote:
> * Benjamin Henrion  [10.12.2009 14:30]:
>>
>> It is a pain to have to setup its own webserver if you want to install
>> packages for openwrt-uml.
>
> Just run 'httpd -h /mydir' and place your packages there.
> It's not openWRT's fault, that your windows does not have a simple httpd.

It seems that the developers does not provide binaries for UML,
because of the libc6 dependency of different linux distributions.

Why not provide binaries with the libc6 in static?

-- 
Benjamin Henrion 
FFII Brussels - +32-484-566109 - +32-2-4148403
"In July 2005, after several failed attempts to legalise software
patents in Europe, the patent establishment changed its strategy.
Instead of explicitly seeking to sanction the patentability of
software, they are now seeking to create a central European patent
court, which would establish and enforce patentability rules in their
favor, without any possibility of correction by competing courts or
democratically elected legislators."
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] OpenWRT UML integrated into Netkit

2009-12-10 Thread ZioPRoTo (Saverio Proto)
>> Are there any other uml openwrt users out there? What are you doing
>> with the new uml releases (aside from developing openwrt?)

Hello,

sorry if you receive this email twice because you are in both mailing lists.

I successfully compiled a OpenWRT UML Image and used it in the Netkit [0]

I got some notes here:
http://wiki.ninux.org/OpenWRT-UML-Netkit

For the OpenWRT-devs:
I'm using OpenWRT trunk because I can't compile the UML for OpenWRT
8.09.1 :( Looks like there is some problem when compiling uClibc,
there are many headers files missing. This happens on my x86_64
host... but trying on a x86 32bit host the 8.09.1 works.

With trunk it compiled the all thing on x86_64 (just a little hack
because scripts were expecting a lib64 folder)

Basically what I did is some changes to inittab and I had to disable
the kmod-mac8011-hwsim that was causing some weird problems ... netkit
machines not talking to each other.

For the Netkit devs:
right now I'm working to integrate the netkit-phase1 and netkit-phase2 scripts.

there is another thing actually not working, connecting Netkit virtual
hosts with tap (with the --eth0=tap,ip1,ip2 syntax).

So the question to the Netkit guys is, how to make the tap feature
work ? It is necessary to have the netkit-phasex scripts working first
?

Saverio

[0] - http://wiki.netkit.org/index.php/Main_Page
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] OpenWRT uml snapshot branch

2009-12-10 Thread Bastian Bittorf
* Benjamin Henrion  [10.12.2009 14:30]:
> 
> It is a pain to have to setup its own webserver if you want to install
> packages for openwrt-uml.

Just run 'httpd -h /mydir' and place your packages there.
It's not openWRT's fault, that your windows does not have a simple httpd.

bye, Bastian.


signature.asc
Description: Digital signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] OpenWRT uml snapshot branch

2009-12-10 Thread Benjamin Henrion
On Tue, Dec 8, 2009 at 8:33 AM, Florian Fainelli  wrote:
> Hello Adrian,
>
> Le mardi 8 décembre 2009 01:52:52, Adrian Terranova a écrit :
>> Hi, (this is a repost post from openwrt-users which got no reply :( )
>>
>> could someone share the  tell me the genealogy / plans for the openwrt
>> uml port that showed up in the xwrt/openwrt snapshot tree? I'm thrilled
>>  that it's there - I extended the clownix router simulation platform with
>>  generic images to build single host  - 10-20 UML / quagga setups using
>>  openwrt as a base image - but I'd like to make sure the thing is going to
>>  be around for a while.
>>
>> Are there any other uml openwrt users out there? What are you doing
>> with the new uml releases (aside from developing openwrt?)
>
> Nico and I use UML regularly to test various OpenWrt stuff whenever hardware
> is not required or we do not have access to it. We will continue maintaining
> it.

Too bad there are no binaries available.

It is a pain to have to setup its own webserver if you want to install
packages for openwrt-uml.

-- 
Benjamin Henrion 
FFII Brussels - +32-484-566109 - +32-2-4148403
"In July 2005, after several failed attempts to legalise software
patents in Europe, the patent establishment changed its strategy.
Instead of explicitly seeking to sanction the patentability of
software, they are now seeking to create a central European patent
court, which would establish and enforce patentability rules in their
favor, without any possibility of correction by competing courts or
democratically elected legislators."
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] add vars for uci firewall include scripts

2009-12-10 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hey.

> well, it wouldn't hurt and maybe somebody might need it in the
> future.

Exactly.

> But, I have problems to figure out where the scripts gets the network
> values from. It's not in the general nvram vars available by 'uci
> show'.

Most of the variables are in a temporary state overly, you can see them
with this command:

  uci -P /var/state show network


HTH,
JoW
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksgyvsACgkQdputYINPTPNHSgCgiB/jz/QKO206egunWVqbQN2z
am0An14tU8R3URoxWIe1NTF0BQSu8mWe
=RJI1
-END PGP SIGNATURE-
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] add vars for uci firewall include scripts

2009-12-10 Thread edgar . soldin
well, it wouldn't hurt and maybe somebody might need it in the future. 
Also maybe some other variables for wireless and the like. But, I have 
problems to figure out where the scripts gets the network values from. 
It's not in the general nvram vars available by 'uci show'.


... ede

On 09.12.2009 22:28, Jo-Philipp Wich wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


I copied it over from 7.09's /etc/init.d/firewall init script ... and it
worked for my script.. LAV doesn't seem to be set there. Would you like
me to add LANDEV?


No, I was just curious. But it seems to make sense :)

~ JoW


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] firewall/iptables

2009-12-10 Thread Ugur DOGRU

Felix Fietkau wrote:

On 2009-12-08 1:36 PM, Ugur DOGRU wrote:
  

Hi,

After getting busybox 1.15.2, "local" macro is not a problem now. So I 
removed all modifications that removes local.
To remind it, these changes are for ubicom32 platform, but for all 
no-mmu platforms in general.

As ash cannot run on no-mmu system, we are using hush instead.

There are still not compatible features between ash/hush. I've listed 
them below. Please note that these are only

problems that I've encountered in firewall/iptables scripts.

1/ hush needs "eval" to substitute string.
2/ hush doesn't handle line concatenation : "\"


Are you sure that these two kinds of changes are still necessary? I
tried to reproduce your issues by writing small test cases with hush
here, but every test case I come up with seems to work fine.
I also tested parameter expansion such as ${var:+-p $var}, and I also
cannot get it to fail with hush.
If hush still has issues with some of these expansions, could you please
reduce it down to a small test case, so that I can verify it and maybe
fix it in hush directly instead of the scripts?
  
Yes. I had some troubles about them. I can not get for now a console 
prompt on my board

to test it. I think you can get fragments from uci_firewall.sh to test.

For line concatenation. I think below script will show problem by 
running with/without line concat sign.

I will try if I will be able to get a shell prompt.

#!/bin/sh

src_port=100-200
  
src_port_first=${src_port%-*}

src_port_last=${src_port#*-}
[ "$src_port_first" -ne "$src_port_last" ] && { \
   src_port="$src_port_first:$src_port_last"; }


3/ hush crashes if two scripts include each other. (uci_firewall.sh and 
/etc/hotplug.d/iface/20-firewall includes each other)


I replaced that today without duplicating the hotplug script's code.

As to some of your other changes:
  

-   config_get exists $ZONE_LIST $1
+eval_ZONE_LIST=$(eval "echo $ZONE_LIST")
+config_get exists $eval_ZONE_LIST $1


Why is this necessary?
  

This is about eval problem.

- Felix
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
  


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel