Re: [OpenWrt-Devel] [PATCH] firewall/iptables

[Ugur DOGRU]

Hi Felix,

I am attaching two scripts that showing problems I reported.
there are script results below, that I got.
I am using BusyBox v1.15.3 from latest trunk code(r18874).

Thanks
ugur



/tmp # ./test_sh1.sh
WITHOUT_EVAL:  $proto
WITH_EVAL:  tcp
/tmp #



/tmp # ./test_sh2.sh
CONCATTED:
sh: can't execute ' ': No such file or directory
END
NOT CONCATTED:
END




Felix Fietkau wrote:

On 2009-12-08 1:36 PM, Ugur DOGRU wrote:
  

Hi,

After getting busybox 1.15.2, local macro is not a problem now. So I 
removed all modifications that removes local.
To remind it, these changes are for ubicom32 platform, but for all 
no-mmu platforms in general.

As ash cannot run on no-mmu system, we are using hush instead.

There are still not compatible features between ash/hush. I've listed 
them below. Please note that these are only

problems that I've encountered in firewall/iptables scripts.

1/ hush needs eval to substitute string.
2/ hush doesn't handle line concatenation : \


Are you sure that these two kinds of changes are still necessary? I
tried to reproduce your issues by writing small test cases with hush
here, but every test case I come up with seems to work fine.
I also tested parameter expansion such as ${var:+-p $var}, and I also
cannot get it to fail with hush.
If hush still has issues with some of these expansions, could you please
reduce it down to a small test case, so that I can verify it and maybe
fix it in hush directly instead of the scripts?

  
3/ hush crashes if two scripts include each other. (uci_firewall.sh and 
/etc/hotplug.d/iface/20-firewall includes each other)


I replaced that today without duplicating the hotplug script's code.

As to some of your other changes:
  

-   config_get exists $ZONE_LIST $1
+eval_ZONE_LIST=$(eval echo $ZONE_LIST)
+config_get exists $eval_ZONE_LIST $1


Why is this necessary?

- Felix
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
  




test_sh1.sh
Description: Bourne shell script


test_sh2.sh
Description: Bourne shell script
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] ePoint HotSpot package

[Brian J. Murrell]

On Mon, 2009-12-21 at 06:32 +0100, Daniel A. Nagy wrote: 
 Hello,

Hi Daniel,

 Well, only the three packages together, including their OpenWrt Makefiles (but
 excluding the sources of qrencode library). I haven't made any attempts at
 making the software portable beyond OpenWrt; right now it is very
 OpenWrt-specific and I don't see that changing.

A.  I see.  That's quite a different story than most packages then.

 That is an interesting question and honestly, I have never considered it, 
 since
 our software does not make much sense outside of the context of OpenWrt.

Yes.  I see.  I was not aware of this.  So given that you maintain your
software in the context of OpenWRT, perhaps a full source inclusion is
the better way to go.

 As I have mentioned, our software is very OpenWrt-specific. We, as a company,
 are perfectly willing to maintain it within the framework of OpenWrt with 
 either
 myself or the developer (his name is Rooslan Khayrov), who actually wrote most
 of the code, acting as the package maintainer.

Fair enough then.

 Of course, the above does not hold for the Code128 barcode stuff, which I am
 perfectly prepared to rip out into a separate source tarball. But what would 
 you
 recommend with the rest that is entirely dependent on OpenWrt?

I'd probably be fine with it remaining in full source, but I am not a
maintainer here, so somebody who is will have to step up and make that
decision.

 Thanks in advance for your suggestions!

NP.

b.



signature.asc
Description: This is a digitally signed message part
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel