Re: [OpenWrt-Devel] [PATCH] Update tinc init script with new variable names

2012-05-17 Thread ZioPRoTo (Saverio Proto)
Hello,

please can you resend to me the patch as attachment ? my email client
mangled the patch.

I will review it today. thanks

Saverio


2012/5/17 Moritz Warning moritzwarn...@web.de:
 The tinc init script needs to know all valid options used in /etc/conf/tinc.
 This patch updates that list to tinc 0.18 (current version).

 Signed-off-by: Moritz Warning moritzwarn...@web.de

 ---

 Index: net/tinc/files/tinc.init
 ===
 --- net/tinc/files/tinc.init    (revision 31761)
 +++ net/tinc/files/tinc.init    (working copy)
 @@ -98,11 +98,12 @@

        # append flags
        append_conf_bools $s $TMP_TINC/$n/hosts/$s \
 -               ClampMSS IndirectData PMTUDiscovery
 +               ClampMSS IndirectData PMTUDiscovery TCPOnly

        # append params
        append_conf_params $s $TMP_TINC/$n/hosts/$s \
 -               Address Cipher Compression Digest MACLength PMTU Port Subnet
 +               Address Cipher Compression Digest MACLength PMTU \
 +               Port PublicKey PublicKeyFile Subnet
  }

  check_gen_own_key() {
 @@ -139,17 +140,20 @@

        # append flags
        append_conf_bools $s $TMP_TINC/$s/tinc.conf \
 -               DirectOnly Hostnames IffOneQueue PriorityInheritance \
 -               StrictSubnets TunnelServer \
 -               ClampMSS IndirectData PMTUDiscovery
 +               DecrementTTL DirectOnly Hostnames IffOneQueue \
 +               LocalDiscovery PriorityInheritance StrictSubnets TunnelServer 
 \
 +               ClampMSS IndirectData PMTUDiscovery TCPOnly

        # append params
        append_conf_params $s $TMP_TINC/$s/tinc.conf \
 -               AddressFamily BindToAddress ConnectTo BindToInterface \
 -               Forwarding GraphDumpFile Interface KeyExpire MACExpire \
 -               MaxTimeout Mode Name PingInterval PingTimeout PrivateKeyFile \
 -               ProcessPriority ReplayWindow UDPRcvBuf UDPSndBuf \
 -               Address Cipher Compression Digest MACLength PMTU Port Subnet
 +               AddressFamily BindToAddress BindToInterface \
 +               Broadcast ConnectTo Device DeviceType Forwarding \
 +               GraphDumpFile Interface KeyExpire MACExpire \
 +               MaxTimeout Mode Name PingInterval PingTimeout \
 +               PrivateKey PrivateKeyFile ProcessPriority ReplayWindow \
 +               UDPRcvBuf UDPSndBuf \
 +               Address Cipher Compression Digest MACLength PMTU \
 +               Port PublicKey PublicKeyFile Subnet

        check_gen_own_key $s  return 0
  }
 ___
 openwrt-devel mailing list
 openwrt-devel@lists.openwrt.org
 https://lists.openwrt.org/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] lantiq: failsafe mode not sound

2012-05-17 Thread Conor O'Gorman

There is mod in the target/lantiq/base-files.mk to remove the
standard /etc/config/network. There is then a runtime script to
determine defaults. 

This does not seem to work for failsafe mode, where /etc/config/network
cannot be created. At least that's what I see on a test. No eth0/lan
interface defined.

+define Package/base-files/install-target
+   rm -f $(1)/etc/config/network
+endef

I'll look at making a change to this. Are there any suggestions for a
preferred method?

Thanks,
Conor O'Gorman

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] lantiq: failsafe mode not sound

2012-05-17 Thread Conor O'Gorman
On Thu, 2012-05-17 at 15:57 +0100, Conor O'Gorman wrote:

 This does not seem to work for failsafe mode, where /etc/config/network
 cannot be created. At least that's what I see on a test. No eth0/lan
 interface defined.

OK, this is rubbish because /etc/init.d/network doesn't run during in
failsafe?

Conor



___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] lantiq: failsafe mode not sound

2012-05-17 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

 OK, this is rubbish because /etc/init.d/network doesn't run during in
 failsafe?

No because the overlay is not mounted in failsafe, thats quite normal
and also seen on e.g. brcm47xx or ar71xx.

Tried mount_root when in failsafe?

~ Jow
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk+1HGQACgkQdputYINPTPPbswCeOgyImJWZ5CGIKGcFEMvN3mgX
VC0An2jyTi5n/XIpqmDfDDqdPLzRZX0P
=MaXh
-END PGP SIGNATURE-
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH] rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER respectively

2012-05-17 Thread Tobias Diedrich
rt2800: Initialize max_txpower to MAX_G_TXPOWER and MAX_A_TXPOWER
respectively, similar to how it is already done in rt2[45]00pci.c

rt2800lib.c doesn't initialize max_power and thus after
http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next.git;a=commitdiff;h=eccc068e8e84c8fe997115629925e0422a98e4de
was applied txpower is limited to 0 for these devices.

This should be the proper fix compared to the net/wireless/reg.c
hack in http://patchwork.openwrt.org/patch/2165/

(Patch against the OpenWRT compat-wireless version, but applies
equally well against wireless-next with a 19-line offset)

Signed-off-by: Tobias Diedrich ranma+open...@tdiedrich.de


Index: compat-wireless-2012-04-17/drivers/net/wireless/rt2x00/rt2800lib.c
===
--- compat-wireless-2012-04-17.orig/drivers/net/wireless/rt2x00/rt2800lib.c 
2012-05-18 00:25:22.515271380 +0200
+++ compat-wireless-2012-04-17/drivers/net/wireless/rt2x00/rt2800lib.c  
2012-05-18 00:28:48.809658951 +0200
@@ -4622,6 +4622,7 @@
default_power2 = rt2x00_eeprom_addr(rt2x00dev, EEPROM_TXPOWER_BG2);
 
for (i = 0; i  14; i++) {
+   info[i].max_power = MAX_G_TXPOWER;
info[i].default_power1 = default_power1[i];
info[i].default_power2 = default_power2[i];
}
@@ -4631,6 +4632,7 @@
default_power2 = rt2x00_eeprom_addr(rt2x00dev, 
EEPROM_TXPOWER_A2);
 
for (i = 14; i  spec-num_channels; i++) {
+   info[i].max_power = MAX_A_TXPOWER;
info[i].default_power1 = default_power1[i];
info[i].default_power2 = default_power2[i];
}

-- 
Tobias  PGP: http://8ef7ddba.uguu.de
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] rt28xx AP-mode problem with commit 3edaf3e61fda3aa9ff8d38445bf92f2bec23bf63 mac80211: manage AP netdev carrier state

2012-05-17 Thread Tobias Diedrich
Johannes Berg wrote:
 On Thu, 2012-05-10 at 10:15 +0200, Johannes Berg wrote:
  On Wed, 2012-05-09 at 23:04 +0200, Tobias Diedrich wrote:
  
PKG_REV:=1f0cc27eb98f7d1af9c64d0752238184cbdb9a24
  
  Ok.
  
   When associating to the AP works 
   (3edaf3e61fda3aa9ff8d38445bf92f2bec23bf63 reverted):
   root@OpenWrt:/# ip monitor
   dev eth0.1 lladdr 00:50:5b:04:05:7e REACHABLE
   dev wlan0 lladdr a0:0b:ba:c6:9f:88 REACHABLE
  
  Ah, well, I wanted ip monitor (and maybe restrict to ip monitor
  link) while you start/stop hostapd. Sorry for not being clear on that.
  Also could be useful to look at it with the tcpdump thing, which is very
  very strange.
  
  I wonder if things like broadcast addresses are only added upon
  netif_carrier_on() and that would reprogram filters and cause issues for
  rt2x00... For that we'd need to do some more debugging inside mac80211
  though.
 
 I don't see anything like that happening upon netif_carrier_on(), the
 only thing that really seems to happen is attaching and starting qdiscs,
 which shouldn't make a difference across drivers...
 
 Is this using compat-wireless? But then, so do I right now, against 3.1
 base kernel.

It's with compat-wireless, as I wrote earlier.  Against 3.3.6 base
kernel.

ip_monitor_link.ok.log
|nn: wlan0: BROADCAST,MULTICAST mtu 1500 qdisc noop state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST,UP mtu 1500 qdisc mq state UNKNOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP mtu 1500 qdisc mq state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST mtu 1500 qdisc mq state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST mtu 1500 qdisc mq state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST mtu 1500 master br-lan state DOWN 
|link/ether 1c:af:f7:49:50:56
|nn: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 qdisc mq 
master br-lan state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan 
state DOWN 
|link/ether 1c:af:f7:49:50:56
|nn: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan 
state DOWN 
|link/ether 1c:af:f7:49:50:56
|nn: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan 
state DOWN 
|link/ether 1c:af:f7:49:50:56
|nn: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan 
state DORMANT 
|link/ether 1c:af:f7:49:50:56
|nn: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 qdisc mq 
master br-lan state DORMANT 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan state UP 
|link/ether 1c:af:f7:49:50:56
|nn: wlan0: BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 qdisc mq master br-lan 
state UP 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan state UP 
|link/ether 1c:af:f7:49:50:56
|Deleted nn: wlan0: BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan 
state UP 
|link/ether 1c:af:f7:49:50:56
|nn: wlan0: BROADCAST,MULTICAST mtu 1500 qdisc mq state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST mtu 1500 qdisc mq state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 qdisc mq state UP 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan state UP 
|link/ether 1c:af:f7:49:50:56
|nn: wlan0: BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan state UP 
|link/ether 1c:af:f7:49:50:56
|nn: wlan0: BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan state UP 
|link/ether 1c:af:f7:49:50:56

ip_monitor_link.borked.log
|nn: wlan0: BROADCAST,MULTICAST mtu 1500 qdisc noop state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST,UP mtu 1500 qdisc mq state UNKNOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP mtu 1500 qdisc mq state DORMANT 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP mtu 1500 qdisc mq state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST mtu 1500 qdisc mq state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST mtu 1500 qdisc mq state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|nn: wlan0: BROADCAST,MULTICAST mtu 1500 master br-lan state DOWN 
|link/ether 1c:af:f7:49:50:56
|nn: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP mtu 1500 qdisc mq master br-lan 
state DOWN 
|link/ether 1c:af:f7:49:50:56 brd 

Re: [OpenWrt-Devel] rt28xx AP-mode problem with commit 3edaf3e61fda3aa9ff8d38445bf92f2bec23bf63 mac80211: manage AP netdev carrier state

2012-05-17 Thread Tobias Diedrich
Johannes Berg wrote:
 On Thu, 2012-05-10 at 10:15 +0200, Johannes Berg wrote:
  On Wed, 2012-05-09 at 23:04 +0200, Tobias Diedrich wrote:
  
PKG_REV:=1f0cc27eb98f7d1af9c64d0752238184cbdb9a24
  
  Ok.
  
   When associating to the AP works 
   (3edaf3e61fda3aa9ff8d38445bf92f2bec23bf63 reverted):
   root@OpenWrt:/# ip monitor
   dev eth0.1 lladdr 00:50:5b:04:05:7e REACHABLE
   dev wlan0 lladdr a0:0b:ba:c6:9f:88 REACHABLE
  
  Ah, well, I wanted ip monitor (and maybe restrict to ip monitor
  link) while you start/stop hostapd. Sorry for not being clear on that.
  Also could be useful to look at it with the tcpdump thing, which is very
  very strange.
  
  I wonder if things like broadcast addresses are only added upon
  netif_carrier_on() and that would reprogram filters and cause issues for
  rt2x00... For that we'd need to do some more debugging inside mac80211
  though.
 
 I don't see anything like that happening upon netif_carrier_on(), the
 only thing that really seems to happen is attaching and starting qdiscs,
 which shouldn't make a difference across drivers...
 
 Is this using compat-wireless? But then, so do I right now, against 3.1
 base kernel.

One more clue:
I think this has to do with the order in which the OpenWRT wifi
script does things:

hostapd -P /var/run/wifi-phy0.pid -B /var/run/hostapd-phy0.conf
hostapd_ctrl=/var/run/hostapd-phy0/wlan0
ifconfig wlan0
ifconfig wlan0 down
ifconfig wlan0 hw ether 1c:af:f7:49:50:56 up
ifconfig wlan0 0.0.0.0
ifconfig wlan0
ifconfig br-lan
ifconfig wlan0 0.0.0.0
ifconfig wlan0 hw ether 1c:af:f7:49:50:56 up
iw dev wlan0 set txpower fixed 2000


i.e. if I restart hostapd by hand the interface comes up:

|[  791.57] br-lan: port 2(wlan0) entered disabled state
|14: wlan0: BROADCAST,MULTICAST mtu 1500 qdisc mq master br-lan state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|14: wlan0: BROADCAST,MULTICAST mtu 1500 master br-lan state DOWN 
|link/ether 1c:af:f7:49:50:56
|14: wlan0: BROADCAST,MULTICAST mtu 1500 master br-lan state DOWN 
|link/ether 1c:af:f7:49:50:56
|14: wlan0: BROADCAST,MULTICAST mtu 1500 qdisc mq master br-lan state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|14: wlan0: BROADCAST,MULTICAST mtu 1500 master br-lan state DOWN 
|link/ether 1c:af:f7:49:50:56
|14: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP mtu 1500 qdisc mq master br-lan 
state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|14: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP mtu 1500 master br-lan state 
DOWN 
|link/ether 1c:af:f7:49:50:56
|[  792.13] br-lan: port 2(wlan0) entered forwarding state
|[  792.14] br-lan: port 2(wlan0) entered forwarding state
|14: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan 
state DORMANT 
|link/ether 1c:af:f7:49:50:56
|14: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan 
state DORMANT 
|link/ether 1c:af:f7:49:50:56
|14: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan 
state DORMANT 
|link/ether 1c:af:f7:49:50:56
|14: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 qdisc mq 
master br-lan state DORMANT 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|14: wlan0: BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 master br-lan state UP 
|link/ether 1c:af:f7:49:50:56
|14: wlan0: BROADCAST,MULTICAST,UP,LOWER_UP mtu 1500 qdisc mq master br-lan 
state UP 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff

Then I do ifconfig wlan0 down
|4: wlan0: BROA[  829.62] br-lan: port 2(wlan0) entered disabled state
|DCAST,MULTICAST mtu 1500 qdisc mq master br-lan state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|14: wlan0: BROADCAST,MULTICAST mtu 1500 master br-lan state DOWN 
|link/ether 1c:af:f7:49:50:56
|14: wlan0: BROADCAST,MULTICAST mtu 1500 master br-lan state DOWN 
|link/ether 1c:af:f7:49:50:56

Followed by ifconfig wlan0 up
|14: wlan0: BROADCAST,MULTICAST,UP mtu 1500 qdisc mq master br-lan state UP 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff
|14: wlan0: BROADCAST,MULTICAST,UP mtu 1500 master br-lan state UP 
|link/ether 1c:af:f7:49:50:56
|14: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP mtu 1500 master br-lan state 
DOWN 
|link/ether 1c:af:f7:49:50:56
|14: wlan0: NO-CARRIER,BROADCAST,MULTICAST,UP mtu 1500 qdisc mq master br-lan 
state DOWN 
|link/ether 1c:af:f7:49:50:56 brd ff:ff:ff:ff:ff:ff

And it stays down with NO-CARRIER.

HTH,

-- 
Tobias  PGP: http://8ef7ddba.uguu.de
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] ramips: rt305x: add add support for the Asus WL-330N3G board

2012-05-17 Thread LEO Airwarosu Yoichi Shinoda

Hi.

It looks like the current ramips config only generates sysupgrade.bin version
of the image for WL-330N3G. Is there any pointer to an write-up describing
how to put this image into the real hw?

Any info would be appreciated.

Thanks in advance.

--- shinoda

On 2012/04/22, at 18:31, Frédéric Leroy wrote:

 This patch adds support for the ASUS WL-330N3G
 
 Comparing to the WL-330N, It have 32MB ram, usb support and a bicolor led.
 
 The bi-color led is driven by 2 gpio.
 I don't know how to handle this, so I simply made 2 leds : one red, one blue. 
 But the red light takes precedence over the blue one according to the chart 
 below.
 
 r = led is red
 b = led is blue
 0 = led is off
 
 xy= x-r for red, b for blue led, y-value of brightness in 
 /sys/class/leds/x/brughtness
 
 initial state action   ledgpio state
 
 r0b0  r0-r1   r  r0  b0
 r0b0  b0-b1   b  r0  b1
 
 r1b0  r1-r0   0  r0  b0
 r1b0  b0-b1   r  r1  *b1*
 
 r1b1  r1-r0   b  r0  b1
 r1b1  b1-b0   r  r1  b0
 
 r0b1  r0-r1   r  r1  *b1*
 r0b1  b1-b0   0  r0  r0
 
 Signed-off-by: Frédéric Leroy fr...@starox.org
 ---
 target/linux/ramips/base-files/etc/diag.sh |2 +-
 .../etc/hotplug.d/firmware/10-rt2x00-eeprom|1 +
 .../ramips/base-files/lib/preinit/06_set_iface_mac |1 +
 target/linux/ramips/base-files/lib/ramips.sh   |3 +
 .../arch/mips/include/asm/mach-ralink/machine.h|1 +
 .../ramips/files/arch/mips/ralink/rt305x/Kconfig   |5 +
 .../ramips/files/arch/mips/ralink/rt305x/Makefile  |1 +
 .../files/arch/mips/ralink/rt305x/mach-wl-330n3g.c |  100 
 target/linux/ramips/image/Makefile |5 +
 target/linux/ramips/rt305x/config-3.2  |1 +
 10 files changed, 119 insertions(+), 1 deletions(-)
 create mode 100644 
 target/linux/ramips/files/arch/mips/ralink/rt305x/mach-wl-330n3g.c
 
 diff --git a/target/linux/ramips/base-files/etc/diag.sh 
 b/target/linux/ramips/base-files/etc/diag.sh
 index 95f608a..aa02721 100755
 --- a/target/linux/ramips/base-files/etc/diag.sh
 +++ b/target/linux/ramips/base-files/etc/diag.sh
 @@ -69,7 +69,7 @@ get_status_led() {
   rt-n10-plus)
   status_led=asus:green:wps
   ;;
 - rt-n56u | wl-330n )
 + rt-n56u | wl-330n | wl-330n3g)
   status_led=asus:blue:power
   ;;
   sl-r7205)
 diff --git 
 a/target/linux/ramips/base-files/etc/hotplug.d/firmware/10-rt2x00-eeprom 
 b/target/linux/ramips/base-files/etc/hotplug.d/firmware/10-rt2x00-eeprom
 index 62788cd..3a602f7 100644
 --- a/target/linux/ramips/base-files/etc/hotplug.d/firmware/10-rt2x00-eeprom
 +++ b/target/linux/ramips/base-files/etc/hotplug.d/firmware/10-rt2x00-eeprom
 @@ -69,6 +69,7 @@ case $FIRMWARE in
   wcr-150gn | \
   whr-g300n | \
   wl-330n | \
 + wl-330n3g | \
   wl-351 | \
   wli-tx4-ag300n | \
   wr512-3gn | \
 diff --git a/target/linux/ramips/base-files/lib/preinit/06_set_iface_mac 
 b/target/linux/ramips/base-files/lib/preinit/06_set_iface_mac
 index f523d69..131c9ba 100644
 --- a/target/linux/ramips/base-files/lib/preinit/06_set_iface_mac
 +++ b/target/linux/ramips/base-files/lib/preinit/06_set_iface_mac
 @@ -30,6 +30,7 @@ preinit_set_mac_address() {
   omni-emb |\
   w502u|\
   wl-330n |\
 + wl-330n3g |\
   wr6202 |\
   xdxrn502j)
   mac=$(ramips_get_mac_binary factory 40)
 diff --git a/target/linux/ramips/base-files/lib/ramips.sh 
 b/target/linux/ramips/base-files/lib/ramips.sh
 index 1298ebd..801a134 100755
 --- a/target/linux/ramips/base-files/lib/ramips.sh
 +++ b/target/linux/ramips/base-files/lib/ramips.sh
 @@ -59,6 +59,9 @@ ramips_board_name() {
   *Asus WL-330N)
   name=wl-330n
   ;;
 + *Asus WL-330N3G)
 + name=wl-330n3g
 + ;;
   *Aztech HW550-3G)
   name=hw550-3g
   ;;
 diff --git 
 a/target/linux/ramips/files/arch/mips/include/asm/mach-ralink/machine.h 
 b/target/linux/ramips/files/arch/mips/include/asm/mach-ralink/machine.h
 index c2ec146..46a091b 100644
 --- a/target/linux/ramips/files/arch/mips/include/asm/mach-ralink/machine.h
 +++ b/target/linux/ramips/files/arch/mips/include/asm/mach-ralink/machine.h
 @@ -30,6 +30,7 @@ enum ramips_mach_type {
   RAMIPS_MACH_RT_N10_PLUS,/* Asus RT-N10+ */
   RAMIPS_MACH_NW718,  /* Netcore NW718 */
   RAMIPS_MACH_WL_330N,/* Asus WL-330N */
 + RAMIPS_MACH_WL_330N3G,  /* Asus WL-330N3G */
 
   /* RT3052 based machines */
   RAMIPS_MACH_ARGUS_ATP52B,   /* Argus ATP-52B */
 diff --git a/target/linux/ramips/files/arch/mips/ralink/rt305x/Kconfig 
 b/target/linux/ramips/files/arch/mips/ralink/rt305x/Kconfig
 index ef4ddf4..5c86de3 100644
 --- a/target/linux/ramips/files/arch/mips/ralink/rt305x/Kconfig
 +++