Re: [OpenWrt-Devel] [PATCH][netifd] fix error checking of asprintf
On 2012-11-22 3:03 PM, Frank Meerkötter wrote: Hi, while building with -D_FORTIFY_SOURCE i noticed a small problem in how netifd is using asprintf(). To check if an allocation by asprintf() worked or not the return value must be checked. Checking the pointer argument is undefined. Please review and apply (for now i have created a patch against the package, fixing it upstream might be the way to go). Please send a patch that I can 'git am' in the netifd git tree. I don't want to have any files in netifd/patches in trunk. - Felix ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH 7/7] [package] uci: Alternate dir for uci_get and friends
On 2012-11-13 11:43 PM, Daniel Dickinson wrote:
On 10/11/2012 8:35 AM, Felix Fietkau wrote:
On 2012-11-09 11:10 PM, Daniel Dickinson wrote:
---
package/uci/files/lib/config/uci.sh |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/package/uci/files/lib/config/uci.sh
b/package/uci/files/lib/config/uci.sh
index db84c83..0002917 100644
--- a/package/uci/files/lib/config/uci.sh
+++ b/package/uci/files/lib/config/uci.sh
@@ -36,8 +36,9 @@ uci_load() {
export ${NO_EXPORT:+-n} CONFIG_NUM_SECTIONS=0
export ${NO_EXPORT:+-n} CONFIG_SECTION=
fi
-
- DATA=$(/sbin/uci ${UCI_CONFIG_DIR:+-c $UCI_CONFIG_DIR}
${LOAD_STATE:+-P /var/state} -S -n export $PACKAGE 2/dev/null)
+
+ LOAD_STATE_DIR=${LOAD_STATE_DIR:-/var/state}
+ DATA=$(/sbin/uci ${UCI_CONFIG_DIR:+-c $UCI_CONFIG_DIR}
${LOAD_STATE:+-P $LOAD_STATE_DIR} -S -n export $PACKAGE 2/dev/null)
RET=$?
[ $RET != 0 -o -z $DATA ] || eval $DATA
unset DATA
Why?
Because we use it? Seriously though, we find it useful for
our use of UCI and thought it didn't harm anything so why not
offer it if it could be useful to others.
I'd like to know what specifically it's being used for. Especially since
I'd like to migrate away from /var/state in the long run.
- Felix
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH][netifd] fix error checking of asprintf
On 03/12/12 10:43, Felix Fietkau wrote: On 2012-11-22 3:03 PM, Frank Meerkötter wrote: Hi, while building with -D_FORTIFY_SOURCE i noticed a small problem in how netifd is using asprintf(). To check if an allocation by asprintf() worked or not the return value must be checked. Checking the pointer argument is undefined. Please review and apply (for now i have created a patch against the package, fixing it upstream might be the way to go). Please send a patch that I can 'git am' in the netifd git tree. I don't want to have any files in netifd/patches in trunk. Patch follows: see man asprintf [...] RETURN VALUE When successful, these functions return the number of bytes printed, just like sprintf(3). If memory allocation wasn't possible, or some other error occurs, these functions will return -1, and the contents of strp is undefined. Signed-off-by: Frank Meerkötter fr...@meerkoetter.org --- ubus.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ubus.c b/ubus.c index 7b85930..d6d4188 100644 --- a/ubus.c +++ b/ubus.c @@ -727,8 +727,7 @@ netifd_ubus_add_interface(struct interface *iface) struct ubus_object *obj = iface-ubus; char *name = NULL; - asprintf(name, %s.interface.%s, main_object.name, iface-name); - if (!name) + if (asprintf(name, %s.interface.%s, main_object.name, iface-name) == -1) return; obj-name = name; -- 1.7.10.4 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH][netifd] corner case: make sure strings are always 0-terminated
Hi,
i noticed that strncpy wasn't used correctly here.
Please review/apply.
Patch follows:
From the man page:
[...]
The strncpy() function is similar, except that at most n
bytes of src are copied. Warning: If there is no null byte
among the first n bytes of src, the string placed in dest
will not be null-terminated.
[...]
Signed-off-by: Frank Meerkötter fr...@meerkoetter.org
---
system-linux.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/system-linux.c b/system-linux.c
index eb73e95..17143cb 100644
--- a/system-linux.c
+++ b/system-linux.c
@@ -284,7 +284,7 @@ static int system_bridge_if(const char *bridge, struct
device *dev, int cmd, voi
ifr.ifr_ifindex = dev-ifindex;
else
ifr.ifr_data = data;
- strncpy(ifr.ifr_name, bridge, sizeof(ifr.ifr_name));
+ strncpy(ifr.ifr_name, bridge, sizeof(ifr.ifr_name) - 1);
return ioctl(sock_ioctl, cmd, ifr);
}
@@ -345,7 +345,7 @@ int system_bridge_delif(struct device *bridge, struct
device *dev)
static int system_if_resolve(struct device *dev)
{
struct ifreq ifr;
- strncpy(ifr.ifr_name, dev-ifname, sizeof(ifr.ifr_name));
+ strncpy(ifr.ifr_name, dev-ifname, sizeof(ifr.ifr_name) - 1);
if (!ioctl(sock_ioctl, SIOCGIFINDEX, ifr))
return ifr.ifr_ifindex;
else
@@ -357,7 +357,7 @@ static int system_if_flags(const char *ifname, unsigned
add, unsigned rem)
struct ifreq ifr;
memset(ifr, 0, sizeof(ifr));
- strncpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name));
+ strncpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name) - 1);
ioctl(sock_ioctl, SIOCGIFFLAGS, ifr);
ifr.ifr_flags |= add;
ifr.ifr_flags = ~rem;
@@ -599,7 +599,7 @@ static int system_vlan(struct device *dev, int id)
ifr.cmd = ADD_VLAN_CMD;
ifr.u.VID = id;
}
- strncpy(ifr.device1, dev-ifname, sizeof(ifr.device1));
+ strncpy(ifr.device1, dev-ifname, sizeof(ifr.device1) - 1);
return ioctl(sock_ioctl, SIOCSIFVLAN, ifr);
}
@@ -619,7 +619,7 @@ system_if_get_settings(struct device *dev, struct
device_settings *s)
struct ifreq ifr;
memset(ifr, 0, sizeof(ifr));
- strncpy(ifr.ifr_name, dev-ifname, sizeof(ifr.ifr_name));
+ strncpy(ifr.ifr_name, dev-ifname, sizeof(ifr.ifr_name) - 1);
if (ioctl(sock_ioctl, SIOCGIFMTU, ifr) == 0) {
s-mtu = ifr.ifr_mtu;
@@ -643,7 +643,7 @@ system_if_apply_settings(struct device *dev, struct
device_settings *s)
struct ifreq ifr;
memset(ifr, 0, sizeof(ifr));
- strncpy(ifr.ifr_name, dev-ifname, sizeof(ifr.ifr_name));
+ strncpy(ifr.ifr_name, dev-ifname, sizeof(ifr.ifr_name) - 1);
if (s-flags DEV_OPT_MTU) {
ifr.ifr_mtu = s-mtu;
if (ioctl(sock_ioctl, SIOCSIFMTU, ifr) 0)
@@ -1010,7 +1010,7 @@ static int tunnel_ioctl(const char *name, int cmd, void
*p)
struct ifreq ifr;
memset(ifr, 0, sizeof(ifr));
- strncpy(ifr.ifr_name, name, sizeof(ifr.ifr_name));
+ strncpy(ifr.ifr_name, name, sizeof(ifr.ifr_name) - 1);
ifr.ifr_ifru.ifru_data = p;
return ioctl(sock_ioctl, cmd, ifr);
}
@@ -1073,7 +1073,7 @@ int system_add_ip_tunnel(const char *name, struct
blob_attr *attr)
p.iph.ttl = val;
}
- strncpy(p.name, name, sizeof(p.name));
+ strncpy(p.name, name, sizeof(p.name) - 1);
if (tunnel_ioctl(base, SIOCADDTUNNEL, p) 0)
return -1;
--
1.7.10.4
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH][package] make ltq-dsl-app compile with an eglibc-based toolchain
On 11/22/2012 10:22 AM, Frank Meerkötter wrote: Hi, i had problems building the ltq-dsl-app when switching from uclibc to eglibc. This patch is adding a needed include, adds a configure test to figure out where clock_gettime() is located and runs autoreconfigurer afterwards. Please review/apply. Signed-Off-By: Frank Meerkötter fr...@meerkoetter.org Patch follows: [..] Applied in 34468 - thanks! mirko ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH][netifd] corner case: make sure strings are always 0-terminated
On Monday 03 December 2012 13:42:23 Frank Meerkötter wrote: Hi, i noticed that strncpy wasn't used correctly here. Please review/apply. Patch follows: From the man page: [...] The strncpy() function is similar, except that at most n bytes of src are copied. Warning: If there is no null byte among the first n bytes of src, the string placed in dest will not be null-terminated. [...] Signed-off-by: Frank Meerkötter fr...@meerkoetter.org I would rather link with libbsd and use strlcpy(). Felix what do you think? -- Florian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH][netifd] corner case: make sure strings are always 0-terminated
On 2012-12-03 1:42 PM, Frank Meerkötter wrote: Hi, i noticed that strncpy wasn't used correctly here. Please review/apply. Patch follows: From the man page: [...] The strncpy() function is similar, except that at most n bytes of src are copied. Warning: If there is no null byte among the first n bytes of src, the string placed in dest will not be null-terminated. [...] As far as I know, this is not a problem for these ioctls. The kernel should handle this corner case properly. - Felix ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH][netifd] fix error checking of asprintf
On 2012-12-03 1:21 PM, Frank Meerkötter wrote: On 03/12/12 10:43, Felix Fietkau wrote: On 2012-11-22 3:03 PM, Frank Meerkötter wrote: Hi, while building with -D_FORTIFY_SOURCE i noticed a small problem in how netifd is using asprintf(). To check if an allocation by asprintf() worked or not the return value must be checked. Checking the pointer argument is undefined. Please review and apply (for now i have created a patch against the package, fixing it upstream might be the way to go). Please send a patch that I can 'git am' in the netifd git tree. I don't want to have any files in netifd/patches in trunk. Patch follows: see man asprintf [...] RETURN VALUE When successful, these functions return the number of bytes printed, just like sprintf(3). If memory allocation wasn't possible, or some other error occurs, these functions will return -1, and the contents of strp is undefined. Signed-off-by: Frank Meerkötter fr...@meerkoetter.org --- ubus.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ubus.c b/ubus.c index 7b85930..d6d4188 100644 --- a/ubus.c +++ b/ubus.c @@ -727,8 +727,7 @@ netifd_ubus_add_interface(struct interface *iface) struct ubus_object *obj = iface-ubus; char *name = NULL; - asprintf(name, %s.interface.%s, main_object.name, iface-name); - if (!name) + if (asprintf(name, %s.interface.%s, main_object.name, iface-name) == -1) return; obj-name = name; Patch does not apply. Please use git-send-email - Felix ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH][netifd] corner case: make sure strings are always 0-terminated
On 03/12/12 13:56, Felix Fietkau wrote: On 2012-12-03 1:42 PM, Frank Meerkötter wrote: Hi, i noticed that strncpy wasn't used correctly here. Please review/apply. Patch follows: From the man page: [...] The strncpy() function is similar, except that at most n bytes of src are copied. Warning: If there is no null byte among the first n bytes of src, the string placed in dest will not be null-terminated. [...] As far as I know, this is not a problem for these ioctls. The kernel should handle this corner case properly. I agree that it is not a real problem but i would argue that the patch still has value. By using the canonical form of strncpy() its easy for everyone reading the source to verify that its correct without inspecting other layers. It is also giving a bad example which might get reused at other places where it would matter. Kind Regards, Frank ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code
Hi, Brian Epstein br...@deepbluecommunications.com writes: Assuming Gold’s Gym is now the official Gym sponsor for all Wyndham hotels. Now for example when anyone searches for the word “Gym” or “step class” on Google.com at any Super8 from behind our equipment, the search is modified prior to being sent to Google.com such that the search now says “step class golds gym”. Am I reading that right that when somebody wants to send a search query to Google you hijack it and modify however you want? Seriously? -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercer...@gmail.com ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code
Paul Fertser fercer...@gmail.com wrote: Brian Epstein br...@deepbluecommunications.com writes: Assuming Gold’s Gym is now the official Gym sponsor for all Wyndham hotels. Now for example when anyone searches for the word “Gym” or “step class” on Google.com at any Super8 from behind our equipment, the search is modified prior to being sent to Google.com such that the search now says “step class golds gym”. Am I reading that right that when somebody wants to send a search query to Google you hijack it and modify however you want? Seriously? That's how I read it. If that happened to me on a free hotel internet connection (which I am paying for with my room charge), I would NOT stay at that hotel again (I would leave after that night if possible) and (at minimum) the following people would be informed why I left: The hotel manager, corporate headquarters (if the hotel was part of a chain), my friends who keep up with me on various social media sites, Google Maps and any other place that I could find online that did reviews on that hotel, anyone who asked me about my trip. If I am on a public network, most anything important is running back home over a OpenVPN or connecting via HTTPS, but messing with guests searches will only lose you goodwill... Aaron Z ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] fix error checking of asprintf
see man asprintf [...] RETURN VALUE When successful, these functions return the number of bytes printed, just like sprintf(3). If memory allocation wasn't possible, or some other error occurs, these functions will return -1, and the contents of strp is undefined. Signed-off-by: Frank Meerkötter fr...@meerkoetter.org --- ubus.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ubus.c b/ubus.c index 7b85930..d6d4188 100644 --- a/ubus.c +++ b/ubus.c @@ -727,8 +727,7 @@ netifd_ubus_add_interface(struct interface *iface) struct ubus_object *obj = iface-ubus; char *name = NULL; - asprintf(name, %s.interface.%s, main_object.name, iface-name); - if (!name) + if (asprintf(name, %s.interface.%s, main_object.name, iface-name) == -1) return; obj-name = name; -- 1.7.10.4 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] fix error checking of asprintf
On 2012-12-03 7:29 PM, Frank Meerkötter wrote: see man asprintf [...] RETURN VALUE When successful, these functions return the number of bytes printed, just like sprintf(3). If memory allocation wasn't possible, or some other error occurs, these functions will return -1, and the contents of strp is undefined. Signed-off-by: Frank Meerkötter fr...@meerkoetter.org Added to git, will be included in the next netifd update in trunk. Thanks, - Felix ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code
That's how I read it too. You are assuming you would catch it, and know what is causing it... Might be subtle enough that it just looks like an google ranked ad. (I would probably not notice, as I tend to always vpn back to home servers and vpn back for even general internet traffic despite the extra delay...) Not to mention, google tends to switch most searching to https if you ever used any sort of google account on the computer before. Of course ssl can be disabled for google searches, as many schools started blocking google because of incompatibility with content filters... and child protection laws trump privacy issues, so google had to put in a disable option or be completely blocked... Still, google displays a pretty clear note when that happens. Personally, I wouldn't mind my searches being slightly modified if it meant free internet instead of the $5+/night they might otherwise charge per room. If there was a room charge for internet, they best not be messing with it in such a way... - Original Message - From: Aaron Z aar...@pls-net.org To: OpenWrt Development List openwrt-devel@lists.openwrt.org Sent: Monday, December 3, 2012 11:56:46 AM Subject: Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code Paul Fertser fercer...@gmail.com wrote: Brian Epstein br...@deepbluecommunications.com writes: Assuming Gold’s Gym is now the official Gym sponsor for all Wyndham hotels. Now for example when anyone searches for the word “Gym” or “step class” on Google.com at any Super8 from behind our equipment, the search is modified prior to being sent to Google.com such that the search now says “step class golds gym”. Am I reading that right that when somebody wants to send a search query to Google you hijack it and modify however you want? Seriously? That's how I read it. If that happened to me on a free hotel internet connection (which I am paying for with my room charge), I would NOT stay at that hotel again (I would leave after that night if possible) and (at minimum) the following people would be informed why I left: The hotel manager, corporate headquarters (if the hotel was part of a chain), my friends who keep up with me on various social media sites, Google Maps and any other place that I could find online that did reviews on that hotel, anyone who asked me about my trip. If I am on a public network, most anything important is running back home over a OpenVPN or connecting via HTTPS, but messing with guests searches will only lose you goodwill... Aaron Z ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] ramips: Add support for Hauppauge Broadway
From: Devin Heitmueller dheitmuel...@kernellabs.com
This patch introduces OpenWRT support for the base Hauppauge/PCTV Broadway
platform. It doesn't deal with the TV tuner or transcoder at this point,
but the core functionality is working (Ethernet, wireless, USB, buttons,
LEDs, etc).
Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com
Index: target/linux/ramips/files/arch/mips/ralink/rt305x/Kconfig
===
--- target/linux/ramips/files/arch/mips/ralink/rt305x/Kconfig (revision
34165)
+++ target/linux/ramips/files/arch/mips/ralink/rt305x/Kconfig (working
copy)
@@ -91,6 +91,11 @@
select RALINK_DEV_GPIO_BUTTONS
select RALINK_DEV_GPIO_LEDS
+config RT305X_MACH_BROADWAY
+bool Hauppauge Broadway support
+select RALINK_DEV_GPIO_BUTTONS
+select RALINK_DEV_GPIO_LEDS
+
config RT305X_MACH_FONERA20N
bool La Fonera20N board support
select RALINK_DEV_GPIO_BUTTONS
Index: target/linux/ramips/files/arch/mips/ralink/rt305x/mach-broadway.c
===
--- target/linux/ramips/files/arch/mips/ralink/rt305x/mach-broadway.c
(revision 0)
+++ target/linux/ramips/files/arch/mips/ralink/rt305x/mach-broadway.c
(revision 0)
@@ -0,0 +1,87 @@
+/*
+ * Hauppauge/PCTV Broadway Support
+ *
+ * Copyright (C) 2012 Devin Heitmueller dheitmuel...@kernellabs.com
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as
published
+ * by the Free Software Foundation.
+ */
+
+#include linux/init.h
+#include linux/platform_device.h
+
+#include asm/mach-ralink/machine.h
+#include asm/mach-ralink/dev-gpio-buttons.h
+#include asm/mach-ralink/dev-gpio-leds.h
+#include asm/mach-ralink/rt305x.h
+#include asm/mach-ralink/rt305x_regs.h
+
+#include devices.h
+
+#define BROADWAY_GPIO_LED_DISKMOUNT9
+#define BROADWAY_GPIO_LED_WPS14
+
+#define BROADWAY_GPIO_BUTTON_WPS0
+#define BROADWAY_GPIO_BUTTON_FACTORYRESET13
+
+#define BROADWAY_KEYS_POLL_INTERVAL20
+#define BROADWAY_KEYS_DEBOUNCE_INTERVAL(3 *
BROADWAY_KEYS_POLL_INTERVAL)
+
+static struct gpio_led broadway_leds_gpio[] __initdata = {
+{
+.name= red:diskmounted,
+.gpio= BROADWAY_GPIO_LED_DISKMOUNT,
+.active_low= 1,
+},
+{
+.name= red:wps_active,
+.gpio= BROADWAY_GPIO_LED_WPS,
+.active_low= 1,
+},
+};
+
+static struct gpio_keys_button broadway_gpio_buttons[] __initdata = {
+{
+.desc= Factory Reset button,
+.type= EV_KEY,
+.code= KEY_RESTART,
+.debounce_interval = BROADWAY_KEYS_DEBOUNCE_INTERVAL,
+.gpio= BROADWAY_GPIO_BUTTON_FACTORYRESET,
+.active_low= 1,
+},
+#ifdef DJH_WPS_BUTTON_NOT_WIRED_TO_GPIO
+{
+.desc= WPS button,
+.type= EV_KEY,
+.code= KEY_WPS_BUTTON,
+.debounce_interval = BROADWAY_KEYS_DEBOUNCE_INTERVAL,
+.gpio= BROADWAY_GPIO_BUTTON_WPS,
+.active_low= 1,
+},
+#endif
+};
+
+static void __init broadway_init(void)
+{
+rt305x_gpio_init((RT305X_GPIO_MODE_GPIO
+ RT305X_GPIO_MODE_UART0_SHIFT));
+
+rt305x_register_flash(0);
+
+rt305x_esw_data.vlan_config = RT305X_ESW_VLAN_CONFIG_W;
+rt305x_register_ethernet();
+
+ramips_register_gpio_leds(-1, ARRAY_SIZE(broadway_leds_gpio),
+ broadway_leds_gpio);
+ramips_register_gpio_buttons(-1, BROADWAY_KEYS_POLL_INTERVAL,
+ ARRAY_SIZE(broadway_gpio_buttons),
+ broadway_gpio_buttons);
+
+rt305x_register_wifi();
+rt305x_register_wdt();
+rt305x_register_usb();
+}
+
+MIPS_MACHINE(RAMIPS_MACH_BROADWAY, BROADWAY, Hauppauge Broadway,
+ broadway_init);
Index: target/linux/ramips/files/arch/mips/ralink/rt305x/Makefile
===
--- target/linux/ramips/files/arch/mips/ralink/rt305x/Makefile
(revision 34165)
+++ target/linux/ramips/files/arch/mips/ralink/rt305x/Makefile (working
copy)
@@ -16,6 +16,7 @@
obj-$(CONFIG_RT305X_MACH_BC2)+= mach-bc2.o
obj-$(CONFIG_RT305X_MACH_ALL0256N)+= mach-all0256n.o
obj-$(CONFIG_RT305X_MACH_ALL5002)+= mach-all5002.o
+obj-$(CONFIG_RT305X_MACH_BROADWAY)+= mach-broadway.o
obj-$(CONFIG_RT305X_MACH_CARAMBOLA)+= mach-carambola.o
obj-$(CONFIG_RT305X_MACH_DIR_300_REVB)+= mach-dir-300-revb.o
obj-$(CONFIG_RT305X_MACH_DIR_615_H1)+= mach-dir-615-h1.o
Index: target/linux/ramips/files/arch/mips/include/asm/mach-ralink/machine.h
===
---
target/linux/ramips/files/arch/mips/include/asm/mach-ralink/machine.h
(revision 34165)
+++
target/linux/ramips/files/arch/mips/include/asm/mach-ralink/machine.h
Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code
You hit the nail on the head. Occasional modification of searches in exchange for free Internet at hotels. -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of John Lauro Sent: Monday, December 03, 2012 4:41 PM To: OpenWrt Development List Subject: Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code That's how I read it too. You are assuming you would catch it, and know what is causing it... Might be subtle enough that it just looks like an google ranked ad. (I would probably not notice, as I tend to always vpn back to home servers and vpn back for even general internet traffic despite the extra delay...) Not to mention, google tends to switch most searching to https if you ever used any sort of google account on the computer before. Of course ssl can be disabled for google searches, as many schools started blocking google because of incompatibility with content filters... and child protection laws trump privacy issues, so google had to put in a disable option or be completely blocked... Still, google displays a pretty clear note when that happens. Personally, I wouldn't mind my searches being slightly modified if it meant free internet instead of the $5+/night they might otherwise charge per room. If there was a room charge for internet, they best not be messing with it in such a way... - Original Message - From: Aaron Z aar...@pls-net.org To: OpenWrt Development List openwrt-devel@lists.openwrt.org Sent: Monday, December 3, 2012 11:56:46 AM Subject: Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code Paul Fertser fercer...@gmail.com wrote: Brian Epstein br...@deepbluecommunications.com writes: Assuming Gold’s Gym is now the official Gym sponsor for all Wyndham hotels. Now for example when anyone searches for the word “Gym” or “step class” on Google.com at any Super8 from behind our equipment, the search is modified prior to being sent to Google.com such that the search now says “step class golds gym”. Am I reading that right that when somebody wants to send a search query to Google you hijack it and modify however you want? Seriously? That's how I read it. If that happened to me on a free hotel internet connection (which I am paying for with my room charge), I would NOT stay at that hotel again (I would leave after that night if possible) and (at minimum) the following people would be informed why I left: The hotel manager, corporate headquarters (if the hotel was part of a chain), my friends who keep up with me on various social media sites, Google Maps and any other place that I could find online that did reviews on that hotel, anyone who asked me about my trip. If I am on a public network, most anything important is running back home over a OpenVPN or connecting via HTTPS, but messing with guests searches will only lose you goodwill... Aaron Z ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code
Although the general idea is certainly valid, and even though Open-Mesh.com is on-board, I would recommend doing to some research about whether Google itself might find issue with 3rd parties intercepting and modifying users' search queries sent to google.com. Especially since this has now been posted to an email list with public archives. Google is likely rather protective of the ad revenue streams they derive from analyzing users' search queries, so have those queries modified en-route might not sit well with them. -- Ben West http://gowasabi.net b...@gowasabi.net 314-246-9434 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] how add 'print' to /usr/lib/lua/luci/model/uci.lua??
. Elvis szx7...@gmail.com [2012-12-03 10:28:25]: Hi all, when i add above 'print(hello)' in /usr/lib/lua/luci/model/uci.lua You need to define it first at the top of the file: diff --git a/libs/core/luasrc/model/uci.lua b/libs/core/luasrc/model/uci.lua index a394563..f513c77 100644 --- a/libs/core/luasrc/model/uci.lua +++ b/libs/core/luasrc/model/uci.lua @@ -27,6 +27,7 @@ local os= require os local uci = require uci local util = require luci.util local table = require table +local print = print Why? It's because of the following function call: module luci.model.uci For the details, read the fine Lua manual[1]. BTW, it's better to use file for debugging output, since you can easily loose some hairs with stdout/stderr debugging in the Luci development :-) 1. http://www.lua.org/manual/5.1/manual.html#pdf-module -- ynezz ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code
I believe the key is to give the visitor/user notice... so they know their searches are being weighted toward a location/retailer and can decide if that is something worth the free access. I don't think it is any more 'man in the middle' as Google itself or in violation of any terms of service provided that it's the users decision to use Google (or any other search engine). On Mon, 2012-12-03 at 16:40 -0500, John Lauro wrote: That's how I read it too. You are assuming you would catch it, and know what is causing it... Might be subtle enough that it just looks like an google ranked ad. (I would probably not notice, as I tend to always vpn back to home servers and vpn back for even general internet traffic despite the extra delay...) Not to mention, google tends to switch most searching to https if you ever used any sort of google account on the computer before. Of course ssl can be disabled for google searches, as many schools started blocking google because of incompatibility with content filters... and child protection laws trump privacy issues, so google had to put in a disable option or be completely blocked... Still, google displays a pretty clear note when that happens. Personally, I wouldn't mind my searches being slightly modified if it meant free internet instead of the $5+/night they might otherwise charge per room. If there was a room charge for internet, they best not be messing with it in such a way... - Original Message - From: Aaron Z aar...@pls-net.org To: OpenWrt Development List openwrt-devel@lists.openwrt.org Sent: Monday, December 3, 2012 11:56:46 AM Subject: Re: [OpenWrt-Devel] Looking for Openwrt programmers to customize Open-Mesh router code Paul Fertser fercer...@gmail.com wrote: Brian Epstein br...@deepbluecommunications.com writes: Assuming Gold’s Gym is now the official Gym sponsor for all Wyndham hotels. Now for example when anyone searches for the word “Gym” or “step class” on Google.com at any Super8 from behind our equipment, the search is modified prior to being sent to Google.com such that the search now says “step class golds gym”. Am I reading that right that when somebody wants to send a search query to Google you hijack it and modify however you want? Seriously? That's how I read it. If that happened to me on a free hotel internet connection (which I am paying for with my room charge), I would NOT stay at that hotel again (I would leave after that night if possible) and (at minimum) the following people would be informed why I left: The hotel manager, corporate headquarters (if the hotel was part of a chain), my friends who keep up with me on various social media sites, Google Maps and any other place that I could find online that did reviews on that hotel, anyone who asked me about my trip. If I am on a public network, most anything important is running back home over a OpenVPN or connecting via HTTPS, but messing with guests searches will only lose you goodwill... Aaron Z ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] how add 'print' to /usr/lib/lua/luci/model/uci.lua??
thank you ynezz!! elvis 2012/12/4 Petr Štetiar yn...@true.cz . Elvis szx7...@gmail.com [2012-12-03 10:28:25]: Hi all, when i add above 'print(hello)' in /usr/lib/lua/luci/model/uci.lua You need to define it first at the top of the file: diff --git a/libs/core/luasrc/model/uci.lua b/libs/core/luasrc/model/uci.lua index a394563..f513c77 100644 --- a/libs/core/luasrc/model/uci.lua +++ b/libs/core/luasrc/model/uci.lua @@ -27,6 +27,7 @@ local os= require os local uci = require uci local util = require luci.util local table = require table +local print = print Why? It's because of the following function call: module luci.model.uci For the details, read the fine Lua manual[1]. BTW, it's better to use file for debugging output, since you can easily loose some hairs with stdout/stderr debugging in the Luci development :-) 1. http://www.lua.org/manual/5.1/manual.html#pdf-module -- ynezz ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] ramips: Add support for Hauppauge Broadway
On 03/12/12 23:23, Devin Heitmueller wrote: From: Devin Heitmueller dheitmuel...@kernellabs.com This patch introduces OpenWRT support for the base Hauppauge/PCTV Broadway platform. It doesn't deal with the TV tuner or transcoder at this point, but the core functionality is working (Ethernet, wireless, USB, buttons, LEDs, etc). Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com Hi Devin, what kind of tuner is inisde the unit ? can you upload a photo of the pcb some where ? John ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
