[OpenWrt-Devel] [PATCH] Fix install of iptables pkg-config files.

[Danny Baumann]

libiptc.pc depends on libip[4|6]tc.pc, thus all of those need to be
installed.
Should fix collectd build and thus #13146; which should make collectd
appear in snapshots again.

Signed-off-by: Danny Baumann 
---
 package/network/utils/iptables/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/network/utils/iptables/Makefile 
b/package/network/utils/iptables/Makefile
index 371153f..4140acb 100644
--- a/package/network/utils/iptables/Makefile
+++ b/package/network/utils/iptables/Makefile
@@ -376,7 +376,7 @@ define Build/InstallDev
$(CP) $(PKG_INSTALL_DIR)/usr/lib/libip*tc.so* $(1)/usr/lib/
$(INSTALL_DIR) $(1)/usr/lib/pkgconfig
$(CP) $(PKG_INSTALL_DIR)/usr/lib/pkgconfig/xtables.pc 
$(1)/usr/lib/pkgconfig/
-   $(CP) $(PKG_INSTALL_DIR)/usr/lib/pkgconfig/libiptc.pc 
$(1)/usr/lib/pkgconfig/
+   $(CP) $(PKG_INSTALL_DIR)/usr/lib/pkgconfig/libip*tc.pc 
$(1)/usr/lib/pkgconfig/
 endef
 
 define Package/iptables/install
-- 
1.8.1.4

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH][include] Reduce configuration file entropy

[Matthias Buecher / Germany]

On 01.05.2013 01:21, Jonh Wendell wrote:
> didn't try the patch, but I'm all for it, as it fixes a really annoying
> behavior.
> 
> 
> 2013/4/30 Sergey Ryazanov  >
> 
> Reducing entropy of configuration file, which is introduced by find
> utility, by applying sorting to its output.
> 
> Find is used here to scan packages and targets subdirectories. Its
> output, known for its random ordering, determines the base order of
> configuration options. So let's fix that.
> 
> Signed-off-by: Sergey Ryazanov  >
> ---
> I develop a custom firmware and I keep configuration file along with
> sources in repository. I was faced with following situation: after I
> modify the configuration by 'make menuconfig', some untouched
> configuration options could change its position in the file, what caused
> svn to generate very long diff. This patch is the attempt to solve this
> situation.
> 
> Index: include/scan.mk 
> ===
> --- include/scan.mk  (revision 36502)
> +++ include/scan.mk  (working copy)
> @@ -39,7 +39,7 @@
> 
>  $(FILELIST):
> rm -f $(TMP_DIR)/info/.files-$(SCAN_TARGET)-*
> -   $(call FIND_L, $(SCAN_DIR)) $(SCAN_EXTRA) -mindepth 1 $(if
> $(SCAN_DEPTH),-maxdepth $(SCAN_DEPTH)) -name Makefile | xargs grep
> -HE 'call (Build/DefaultTargets|Build(Package|Target)|.+Package)' |
> sed -e 's#^$(SCAN_DIR)/##' -e 's#/Makefile:.*##' | uniq > $@
> +   $(call FIND_L, $(SCAN_DIR)) $(SCAN_EXTRA) -mindepth 1 $(if
> $(SCAN_DEPTH),-maxdepth $(SCAN_DEPTH)) -name Makefile | xargs grep
> -HE 'call (Build/DefaultTargets|Build(Package|Target)|.+Package)' |
> sed -e 's#^$(SCAN_DIR)/##' -e 's#/Makefile:.*##' | uniq | sort > $@

What about `sort -u` instead of `uniq | sort` ?

>  $(TMP_DIR)/info/.files-$(SCAN_TARGET).mk: $(FILELIST)
> ( \
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] [packages] tinc: fix init.d/tinc parameter generation and logfile config name

[Sandy McArthur Jr]

tinc expects long parameters to be in the form "--name=value" and the
current init scripts generate "--name value" parameters. See `tincd
--help` to confirm. Also, the config/tinc and init.d/tinc incorrectly
use the parameter "log" when it should be "logfile".

Signed-off-by: Sandy McArthur, Jr. 
---
Attempting a resubmit that patchwork.openwrt.org will pick up. Patch
is included inline instead of as attachment.


diff --git a/net/tinc/files/tinc.config b/net/tinc/files/tinc.config
index f9f2b53..1894078 100644
--- a/net/tinc/files/tinc.config
+++ b/net/tinc/files/tinc.config
@@ -4,7 +4,7 @@ config tinc-net NETNAME
  ## Daemon Configuration (cmd arguments)
  #option generate_keys 0
  #option key_size 2048
- #option log /tmp/log/tinc.NETNAME.log
+ #option logfile /tmp/log/tinc.NETNAME.log
  #option debug 3

  ## Server Configuration (tinc.conf)
diff --git a/net/tinc/files/tinc.init b/net/tinc/files/tinc.init
index 9ab1bd0..b24bc68 100644
--- a/net/tinc/files/tinc.init
+++ b/net/tinc/files/tinc.init
@@ -42,7 +42,7 @@ append_params() {
  config_get v "$s" "$p"
  IFS="$LIST_SEP"
  for v in $v; do
- [ -n "$v" ] && append_param "$p" && ARGS="$ARGS $v"
+ [ -n "$v" ] && append_param "$p" && ARGS="$ARGS=$v"
  done
  unset IFS
  done
@@ -169,7 +169,7 @@ start_instance() {
  ARGS=""

  # append params
- append_params "$s" log debug
+ append_params "$s" logfile debug

  SERVICE_PID_FILE="/var/run/tinc.$s.pid"
  service_start $BIN -c "$TMP_TINC/$s" -n $s $ARGS --pidfile="$SERVICE_PID_FILE"


On Tue, Apr 30, 2013 at 12:36 PM, Sandy McArthur Jr  wrote:
> Luka,
> I tried your suggestion as it made sense but when I tried the extra quoting 
> of:
>
> [ -n "$v" ] && append_param "$p" && ARGS="$ARGS=\"$v\""
>
> I get the error:
>
> # /etc/init.d/tinc start
> Could not open log file "/tmp/log/tinc.thelans.log-test": No such file
> or directory
>
>
> The patch I sent was discovered in my attempt to get Tinc working as
> described here:
> https://forum.openwrt.org/viewtopic.php?id=43869 (I could still use some 
> help.)
>
>
> Without my patch using these relevant config settings:
>
> config tinc-net thelans
> option log /tmp/log/tinc.thelans.log-test
> option debug 3
>
> I get:
>
> # ps w | grep tinc
>  9587 root  3128 S/usr/sbin/tincd -c /tmp/tinc/thelans -n
> thelans --log /tmp/log/tinc.thelans.log-test --debug 3
> --pidfile=/var/run/tin
>
> # head -n 1 /tmp/log/tinc.thelans.log-test
> head: /tmp/log/tinc.thelans.log-test: No such file or directory
>
> # ls /tmp/log/tinc.*
> /tmp/log/tinc.thelans.log
>
> # head -n 1 /tmp/log/tinc.thelans.log
> 2013-04-30 12:14:15 tinc.thelans[9587]: tincd 1.0.19 (Mar 14 2013
> 12:15:49) starting, debug level 1
>
> Note that the log file name was not used and the start of the log file
> indicates a debug level of 1. `tincd --help` says "-d, --debug[=LEVEL]
>Increase debug level or set it to LEVEL." which means the
> "--debug 3" only increased the debug level by one.
>
>
> With the patch I suggested using this relevant config:
>
> config tinc-net thelans
> option logfile /tmp/log/tinc.thelans.log-test
> option debug 3
>
> I get:
>
> # ps w | grep tinc
>  9665 root  3128 S/usr/sbin/tincd -c /tmp/tinc/thelans -n
> thelans --logfile=/tmp/log/tinc.thelans.log-test --debug=3
> --pidfile=/var/run
>
> # head -n 1 /tmp/log/tinc.thelans.log-test
> 2013-04-30 12:19:43 tinc.thelans[9665]: tincd 1.0.19 (Mar 14 2013
> 12:15:49) starting, debug level 3
>
> Note that the log file name was used and the debug level was set to 3
> as specified in the config file.
>
>
> After collecting the examples above I thought to test if
> --log=/tmp/log/tinc.thelans.log-test worked and it does seem to. I
> still feel it's best to use --logfile as that is what the tinc
> help/docs say to use.
>
> Relevant tinc docs:
> http://www.tinc-vpn.org/documentation/tinc_5.html#Runtime-options
> or
> # tincd --help
> Usage: tincd [option]...
>
>   -c, --config=DIR   Read configuration options from DIR.
>   -D, --no-detachDon't fork and detach.
>   -d, --debug[=LEVEL]Increase debug level or set it to LEVEL.
>   -k, --kill[=SIGNAL]Attempt to kill a running tincd and exit.
>   -n, --net=NETNAME  Connect to net NETNAME.
>   -K, --generate-keys[=BITS] Generate public/private RSA keypair.
>   -L, --mlockLock tinc into main memory.
>   --logfile[=FILENAME]   Write log entries to a logfile.
>   --pidfile=FILENAME Write PID to FILENAME.
>   -o, --option=[HOST.]KEY=VALUE  Set global/host configuration value.
>   -R, --chroot   chroot to NET dir at startup.
>   -U, --user=USERsetuid to given USER at startup.
>   --help Display this help and exit.
>   --version  Output version information and exit.
>
>
>
> On Tue, Apr 30, 2013 at 3:47 AM, Luka Perkov  wrote:
>> Hi Sandy,
>>
>> On Mon, Apr 29, 2013 at 11:00:00

Re: [OpenWrt-Devel] [PATCH] [packages] tinc: fix init.d/tinc parameter generation and logfile config name

[Luka Perkov]

On Wed, May 01, 2013 at 08:19:19PM -0400, Sandy McArthur Jr wrote:
> tinc expects long parameters to be in the form "--name=value" and the
> current init scripts generate "--name value" parameters. See `tincd
> --help` to confirm. Also, the config/tinc and init.d/tinc incorrectly
> use the parameter "log" when it should be "logfile".
> 
> Signed-off-by: Sandy McArthur, Jr. 
> ---
> Attempting a resubmit that patchwork.openwrt.org will pick up. Patch
> is included inline instead of as attachment.

I could not apply this patch. I took the one from the previous email
where it was attached. Anyway, this is applied in r36508.

Thanks!

Luka
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] how to enable openssl hardware encryption engine ?

[valent.turko...@gmail.com]

On Wed, May 1, 2013 at 12:52 AM, valent.turko...@gmail.com
 wrote:
> On Tue, Apr 30, 2013 at 10:46 PM, Jiri Slachta  wrote:
>> Dne 30.4.2013 22:08, valent.turko...@gmail.com napsal(a):
>>> On Tue, Apr 30, 2013 at 9:36 PM, valent.turko...@gmail.com
>>>  wrote:
 I had missed package with engines ;)
 Now I got images built correctly and installed on CF card.

 Can you or somebody else check out what is the issue?

 Please connect to:
 ssh r...@valentt.no-ip.org -p 22001 password is "openwrt"
>>>
>>> I see few connections, did anybody get debug logs?
>>> ___
>>> openwrt-devel mailing list
>>> openwrt-devel@lists.openwrt.org
>>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
>>>
>>
>> Hey,
>>
>> the first thing I see is:
>>
>> [8.341688] padlock_aes: Unknown symbol blkcipher_walk_done (err 0)
>> [8.360643] padlock_aes: Unknown symbol blkcipher_walk_virt (err 0)
>> [8.379562] padlock_aes: Unknown symbol crypto_blkcipher_type (err 0)
>>
>> Could you try to enable package kmod-crypto-manager that enables 
>> CONFIG_CRYPTO_BLKCIPHER in kernel config and loads specific kernel modules? 
>> I actually do not know, where the problem is, but the "uknown symbol" error 
>> messages should disappear.
>>
>> Jiri
>
> New fimware is now on CF card with kmod-crypto-manager, I still see
> same issue, but please check it yourself.

What do strace logs show? How long ago were engines removed from
openssl? Did upstream change some things that introduces bugs in
openwrt?
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel