Re: [OpenWrt-Devel] [PATCH v2 0/7] uclient: Handle memory allocation failures

2018-02-19 Thread John Crispin 



On 18/02/18 13:46, Tobias Schramm wrote:

Hi John,

I've implemented the suggested improvements and performed some more
reformatting to match the codestyle of uclient more closely.

Regards

Tobias Schramm


Hi Tobias,

merged most of them alread, please fix/resend 4/7 and 6/7

    John



Changes since v1:
Fix codestyle
Fix memory leak in uclient_http_add_auth_digest
Honour return value of auth header functions
Fix wrong goto in open_output_file
Fix wrong patch subject

Tobias Schramm (7):
   uclient-fetch: Check for nullpointer returned by
 uclient_get_url_filename
   uclient-http: basic auth: Handle memory allocation failure
   uclient-http: auth digest: Handle multiple possible memory allocation
 failures
   uclient-http: Implement error handling for header-sending
   uclient-http: Handle memory allocation failure
   uclient-utils: Handle memory allocation failure for url file name
   uclient: Handle memory allocation failure for url

  uclient-fetch.c |  6 
  uclient-http.c  | 87 ++---
  uclient-utils.c |  9 --
  uclient.c   |  3 ++
  4 files changed, 80 insertions(+), 25 deletions(-)


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v2 4/7] uclient-http: Implement error handling for header-sending

2018-02-19 Thread John Crispin 



On 18/02/18 13:46, Tobias Schramm wrote:

Add some error handling for errors during assembly of headers

Signed-off-by: Tobias Schramm 

Hi,

3  nitpicks inline ...


---
  uclient-http.c | 32 
  1 file changed, 20 insertions(+), 12 deletions(-)

diff --git a/uclient-http.c b/uclient-http.c
index 20b8a9a..04f16a3 100644
--- a/uclient-http.c
+++ b/uclient-http.c
@@ -568,36 +568,36 @@ fail:
return err;
  }
  

[...]

@@ -620,11 +620,14 @@ uclient_http_send_headers(struct uclient_http *uh)
if (uclient_request_supports_body(uh->req_type))
ustream_printf(uh->us, "Transfer-Encoding: chunked\r\n");
  
-	uclient_http_add_auth_header(uh);

+   if ((err = uclient_http_add_auth_header(uh)))
+   return err;

please use this style ...

err = ...;
if (err)
    return err;

[...]

@@ -1020,12 +1023,14 @@ uclient_http_set_header(struct uclient *cl, const char 
*name, const char *value)
  static int
  uclient_http_send_data(struct uclient *cl, const char *buf, unsigned int len)
  {
+   int err;
struct uclient_http *uh = container_of(cl, struct uclient_http, uc);
  
  	if (uh->state >= HTTP_STATE_REQUEST_DONE)

return -1;
  
-	uclient_http_send_headers(uh);

+   if ((err = uclient_http_send_headers(uh)))
+   return err;
  


and here aswell


if (len > 0) {
ustream_printf(uh->us, "%X\r\n", len);
@@ -1039,12 +1044,15 @@ uclient_http_send_data(struct uclient *cl, const char 
*buf, unsigned int len)
  static int
  uclient_http_request_done(struct uclient *cl)
  {
+   int err;
struct uclient_http *uh = container_of(cl, struct uclient_http, uc);
  
  	if (uh->state >= HTTP_STATE_REQUEST_DONE)

return -1;
  
-	uclient_http_send_headers(uh);

+   if ((err = uclient_http_send_headers(uh)))
+   return err;


and here aswell

    John



+
if (uclient_request_supports_body(uh->req_type))
ustream_printf(uh->us, "0\r\n\r\n");
uh->state = HTTP_STATE_REQUEST_DONE;

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] kernel version status

2018-02-19 Thread Maciej Soltysiak 
On Mon, Feb 19, 2018 at 3:41 PM, John Crispin  wrote:
> please dont top post.
Apologies! Thank you for the kind reminder.

> ath79 is the same as ar71xx but uses dts files instead of mach files
Right, does that mean there might be an ath79 target, which is not
ready yet, or am I confusing things?

> John
Maciej
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [LEDE-DEV] kernel version status

2018-02-19 Thread Michael Heimpold 
Hi,

Am Sonntag, 18. Februar 2018, 22:43:42 CET schrieb Hauke Mehrtens:
> ...
> 
> The following targets are on kernel 4.9 and are fine:
> ...
> * mxs
> ...

a few weeks ago, I was in contact with Zoltan who started working
on 4.14 support for mxs. I found some patches in his staging repo
and added some patches on top.
I've pushed this in a Github branch:
https://github.com/mhei/source/tree/mxs-4.14

I run tested this on both I2SE Duckbill devices and Olimex OLinuXino
Maxi boards - no obvious problems so far, so I think we can go ahead
for this platform with 4.14.

Regards,
Michael
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] kernel version status

2018-02-19 Thread John Crispin 



On 19/02/18 13:54, Maciej Soltysiak wrote:

Hi John,

As a user of an ar71xx (WNDR3800) on OpenWrt, I'd like to ask if your 
desire is that ar71xx never gets bumped up to anything higher than 4.9 
or it's just not 4.14 because of some specific reasons related to 4.14?


IOW, shall I be looking for a replacement because I'll stay on 4.9 
forever?


Best regards,
Maciej

On Mon, Feb 19, 2018 at 7:41 AM, John Crispin > wrote:




On 18/02/18 22:43, Hauke Mehrtens wrote:

The next OpenWrt release will use kernel 4.9 and kernel 4.14
depending
on the target. All targets that are *not* on either kernel 4.9
or 4.14
will not be included in the next release.

I did some overview of the kernel version some months ago here:
http://lists.infradead.org/pipermail/lede-dev/2017-October/009446.html


Here is the current situation as of today:

The following targets are on kernel 4.14 and are fine:
* apm821xx
* archs38
* armvirt
* cns3xxx
* malta
* mediatek
* octeon
* octeontx
* sunxi
* x86

The following targets are on kernel 4.9 and are fine:
* ar71xx
* ar7
* arc770
* at91
        There are some patches for kernel 4.14 on the mailing list
        waiting for response from author
* ath25
* bcm53xx
        patches for 4.14 are available in master
* brcm2708
* brcm47xx
* brcm63xx
        patches for 4.14 are available in master
* imx6
        There are some patches for kernel 4.14 on the mailing list
        which is being worked on
* ipq806x
* ixp4xx
* kirkwood
* lantiq
        patches for 4.14 are in Mathias Kresin's staging tree.
* layerscape
* mpc85xx
* mvebu
        patches for 4.14 are available in master
        I would like to get this to kernel 4.14 by default soon.
* mxs
* omap
* orion
* pistachio
* ramips
        patches for 4.14 are available in master
* rb532
* uml

The following targets are on kernel 4.4 and will probably not be
included in the next release:
* gemini
* oxnas
* zynq

The following targets are on kernel 3.18 and will probably not be
included in the next release:
* adm5120
* adm8668
* au1000
* mcs814x
        I have patches which port this target to 4.4 in my
tree, but
        nobody tested them.

https://git.lede-project.org/?p=lede/hauke/staging.git;a=shortlog;h=refs/heads/kernel-4.4


* ppc40x
* ppc44x
* xburst
        I have patches which port this target to 4.4 in my
tree, but
        nobody tested them

https://git.lede-project.org/?p=lede/hauke/staging.git;a=shortlog;h=refs/heads/kernel-4.4



This target is on kernel 4.1 (WTF):
* omap24xx

All the targets which are not on kernel 4.9 or 4.14 will
probably not be
included in the next release, I also haven't seen any activity
for any
of them to get support for more recent kernel versions, if you
need them
please take care now.

Hauke


Hi Hauke,

I planned to make that list today, thanks for taking care of it !.
I would like to see ar71xx and ramips stay on v4.9, regardless of
there being patches for v4.14. I would also like to see ar71xx
never being bumped to v4.14, I spent a few days last week
revamping my old ath79 port and would like to see a hard cut,
moving QCA mips target to OF only post release.

    John

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org

https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel




Hi Maciej

please dont top post.

ath79 is the same as ar71xx but uses dts files instead of mach files

    John
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] kernel version status

2018-02-19 Thread Maciej Soltysiak 
Hi John,

As a user of an ar71xx (WNDR3800) on OpenWrt, I'd like to ask if your
desire is that ar71xx never gets bumped up to anything higher than 4.9 or
it's just not 4.14 because of some specific reasons related to 4.14?

IOW, shall I be looking for a replacement because I'll stay on 4.9 forever?

Best regards,
Maciej

On Mon, Feb 19, 2018 at 7:41 AM, John Crispin  wrote:

>
>
> On 18/02/18 22:43, Hauke Mehrtens wrote:
>
>> The next OpenWrt release will use kernel 4.9 and kernel 4.14 depending
>> on the target. All targets that are *not* on either kernel 4.9 or 4.14
>> will not be included in the next release.
>>
>> I did some overview of the kernel version some months ago here:
>> http://lists.infradead.org/pipermail/lede-dev/2017-October/009446.html
>>
>> Here is the current situation as of today:
>>
>> The following targets are on kernel 4.14 and are fine:
>> * apm821xx
>> * archs38
>> * armvirt
>> * cns3xxx
>> * malta
>> * mediatek
>> * octeon
>> * octeontx
>> * sunxi
>> * x86
>>
>> The following targets are on kernel 4.9 and are fine:
>> * ar71xx
>> * ar7
>> * arc770
>> * at91
>> There are some patches for kernel 4.14 on the mailing list
>> waiting for response from author
>> * ath25
>> * bcm53xx
>> patches for 4.14 are available in master
>> * brcm2708
>> * brcm47xx
>> * brcm63xx
>> patches for 4.14 are available in master
>> * imx6
>> There are some patches for kernel 4.14 on the mailing list
>> which is being worked on
>> * ipq806x
>> * ixp4xx
>> * kirkwood
>> * lantiq
>> patches for 4.14 are in Mathias Kresin's staging tree.
>> * layerscape
>> * mpc85xx
>> * mvebu
>> patches for 4.14 are available in master
>> I would like to get this to kernel 4.14 by default soon.
>> * mxs
>> * omap
>> * orion
>> * pistachio
>> * ramips
>> patches for 4.14 are available in master
>> * rb532
>> * uml
>>
>> The following targets are on kernel 4.4 and will probably not be
>> included in the next release:
>> * gemini
>> * oxnas
>> * zynq
>>
>> The following targets are on kernel 3.18 and will probably not be
>> included in the next release:
>> * adm5120
>> * adm8668
>> * au1000
>> * mcs814x
>> I have patches which port this target to 4.4 in my tree, but
>> nobody tested them.
>> https://git.lede-project.org/?p=lede/hauke/staging.git;a=sho
>> rtlog;h=refs/heads/kernel-4.4
>> * ppc40x
>> * ppc44x
>> * xburst
>> I have patches which port this target to 4.4 in my tree, but
>> nobody tested them
>> https://git.lede-project.org/?p=lede/hauke/staging.git;a=sho
>> rtlog;h=refs/heads/kernel-4.4
>>
>> This target is on kernel 4.1 (WTF):
>> * omap24xx
>>
>> All the targets which are not on kernel 4.9 or 4.14 will probably not be
>> included in the next release, I also haven't seen any activity for any
>> of them to get support for more recent kernel versions, if you need them
>> please take care now.
>>
>> Hauke
>>
>
> Hi Hauke,
>
> I planned to make that list today, thanks for taking care of it !. I would
> like to see ar71xx and ramips stay on v4.9, regardless of there being
> patches for v4.14. I would also like to see ar71xx never being bumped to
> v4.14, I spent a few days last week revamping my old ath79 port and would
> like to see a hard cut, moving QCA mips target to OF only post release.
>
> John
>
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] kernel version status

2018-02-19 Thread Karl Palsson 

Hauke Mehrtens  wrote:
> The following targets are on kernel 4.4 and will probably not
> be included in the next release:
> * gemini

This is a platform that upstream seems to be actually working on,
would it not be at least polite to keep it alive while it's
landing in mainline? I don't have any hardware or care myself, it
just seems odd to kill the one that's being worked on.

Cheers,
Karl P


signature.html
Description: OpenPGP Digital Signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] kernel version status

2018-02-19 Thread John Crispin 



On 19/02/18 09:12, Lucian Cristian wrote:

On 19.02.2018 08:41, John Crispin wrote:



On 18/02/18 22:43, Hauke Mehrtens wrote:

The next OpenWrt release will use kernel 4.9 and kernel 4.14 depending
on the target. All targets that are *not* on either kernel 4.9 or 4.14
will not be included in the next release.

I did some overview of the kernel version some months ago here:
http://lists.infradead.org/pipermail/lede-dev/2017-October/009446.html

Here is the current situation as of today:

The following targets are on kernel 4.14 and are fine:
* apm821xx
* archs38
* armvirt
* cns3xxx
* malta
* mediatek
* octeon
* octeontx
* sunxi
* x86

The following targets are on kernel 4.9 and are fine:
* ar71xx
* ar7
* arc770
* at91
There are some patches for kernel 4.14 on the mailing list
waiting for response from author
* ath25
* bcm53xx
patches for 4.14 are available in master
* brcm2708
* brcm47xx
* brcm63xx
patches for 4.14 are available in master
* imx6
There are some patches for kernel 4.14 on the mailing list
which is being worked on
* ipq806x
* ixp4xx
* kirkwood
* lantiq
patches for 4.14 are in Mathias Kresin's staging tree.
* layerscape
* mpc85xx
* mvebu
patches for 4.14 are available in master
I would like to get this to kernel 4.14 by default soon.
* mxs
* omap
* orion
* pistachio
* ramips
patches for 4.14 are available in master
* rb532
* uml

The following targets are on kernel 4.4 and will probably not be
included in the next release:
* gemini
* oxnas
* zynq

The following targets are on kernel 3.18 and will probably not be
included in the next release:
* adm5120
* adm8668
* au1000
* mcs814x
I have patches which port this target to 4.4 in my tree, but
nobody tested them.
https://git.lede-project.org/?p=lede/hauke/staging.git;a=shortlog;h=refs/heads/kernel-4.4 


* ppc40x
* ppc44x
* xburst
I have patches which port this target to 4.4 in my tree, but
nobody tested them
https://git.lede-project.org/?p=lede/hauke/staging.git;a=shortlog;h=refs/heads/kernel-4.4 



This target is on kernel 4.1 (WTF):
* omap24xx

All the targets which are not on kernel 4.9 or 4.14 will probably 
not be

included in the next release, I also haven't seen any activity for any
of them to get support for more recent kernel versions, if you need 
them

please take care now.

Hauke


Hi Hauke,

I planned to make that list today, thanks for taking care of it !. I 
would like to see ar71xx and ramips stay on v4.9, regardless of there 
being patches for v4.14. I would also like to see ar71xx never being 
bumped to v4.14, I spent a few days last week revamping my old ath79 
port and would like to see a hard cut, moving QCA mips target to OF 
only post release.


    John
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Omap is working by just changing the kernel version (tested on beagle 
bone black)



Regards


send a patch please ...

    John
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] kernel version status

2018-02-19 Thread Lucian Cristian 

On 19.02.2018 08:41, John Crispin wrote:



On 18/02/18 22:43, Hauke Mehrtens wrote:

The next OpenWrt release will use kernel 4.9 and kernel 4.14 depending
on the target. All targets that are *not* on either kernel 4.9 or 4.14
will not be included in the next release.

I did some overview of the kernel version some months ago here:
http://lists.infradead.org/pipermail/lede-dev/2017-October/009446.html

Here is the current situation as of today:

The following targets are on kernel 4.14 and are fine:
* apm821xx
* archs38
* armvirt
* cns3xxx
* malta
* mediatek
* octeon
* octeontx
* sunxi
* x86

The following targets are on kernel 4.9 and are fine:
* ar71xx
* ar7
* arc770
* at91
There are some patches for kernel 4.14 on the mailing list
waiting for response from author
* ath25
* bcm53xx
patches for 4.14 are available in master
* brcm2708
* brcm47xx
* brcm63xx
patches for 4.14 are available in master
* imx6
There are some patches for kernel 4.14 on the mailing list
which is being worked on
* ipq806x
* ixp4xx
* kirkwood
* lantiq
patches for 4.14 are in Mathias Kresin's staging tree.
* layerscape
* mpc85xx
* mvebu
patches for 4.14 are available in master
I would like to get this to kernel 4.14 by default soon.
* mxs
* omap
* orion
* pistachio
* ramips
patches for 4.14 are available in master
* rb532
* uml

The following targets are on kernel 4.4 and will probably not be
included in the next release:
* gemini
* oxnas
* zynq

The following targets are on kernel 3.18 and will probably not be
included in the next release:
* adm5120
* adm8668
* au1000
* mcs814x
I have patches which port this target to 4.4 in my tree, but
nobody tested them.
https://git.lede-project.org/?p=lede/hauke/staging.git;a=shortlog;h=refs/heads/kernel-4.4 


* ppc40x
* ppc44x
* xburst
I have patches which port this target to 4.4 in my tree, but
nobody tested them
https://git.lede-project.org/?p=lede/hauke/staging.git;a=shortlog;h=refs/heads/kernel-4.4 



This target is on kernel 4.1 (WTF):
* omap24xx

All the targets which are not on kernel 4.9 or 4.14 will probably not be
included in the next release, I also haven't seen any activity for any
of them to get support for more recent kernel versions, if you need them
please take care now.

Hauke


Hi Hauke,

I planned to make that list today, thanks for taking care of it !. I 
would like to see ar71xx and ramips stay on v4.9, regardless of there 
being patches for v4.14. I would also like to see ar71xx never being 
bumped to v4.14, I spent a few days last week revamping my old ath79 
port and would like to see a hard cut, moving QCA mips target to OF 
only post release.


    John
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Omap is working by just changing the kernel version (tested on beagle 
bone black)



Regards
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel