Re: [PATCH] uqmi: Move to community packages repo
On 01.07.2021 21:50, Arjun AK wrote: Signed-off-by: Arjun AK Nacked-by: Rafał Miłecki No proper explanation. Package is included by default in few device images. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH 21.02] ipq806x: backport cpufreq changes to 5.4
On 6/28/21 2:10 AM, Shane Synan wrote: > On 6/27/21 6:10 PM, Ansuel Smith wrote: >> It's good but consider that also the dts changes are required and also there >> is a pending pr that has to be merged or ipq8065 device will run at lower >> speed. >> The new cpufreq have changed the node definition >> This is the pr I'm talking about. >> https://github.com/openwrt/openwrt/pull/4192 >> >> So in short this backport lacks the dts changes and the pr4192 is mandatory >> or >> we will introduce perf regression in 21 >> > > Thank you for pointing out the details of the DTS changes and CPU > performance. Originally I was trying to achieve the smallest > backport, but in hindsight, it makes far more sense to avoid > frankensteining with partial changes. I appreciate your patience and > advice! > > Meanwhile, until PR #4192 can be reviewed/merged to master (so there's > commits to actually backport), I've thrown together a rough draft of > what changes would need backported: Now that https://github.com/openwrt/openwrt/pull/4192 is merged, including four successful tests on Linux kernel v5.4, I've tried backporting all the CPU frequency/DTS/etc changes that appeared relevant, as shown here: https://github.com/openwrt/openwrt/compare/openwrt-21.02...digitalcircuit:openwrt-21.02-cpufreq-dtsivolt-cache (some commits were modified to drop kernel v5.10 patches) Unfortunately, my initial attempt is unstable again. I've gotten 3 reboots so far within a few hours of SFTP testing. Unlike before, nothing displays on the router's soldered-on serial console headers. Given these commits work just fine on the "master" branch, and on "21.02" it worked to change the CPU governor *without* the DTSI backports and cache (i.e. only the first commit), I strongly suspect I goofed up and missed backporting something important. Ansuel, do you have any suggestions on what else I should look for or try tinkering with? Meanwhile, just to see what happens in an attempt to narrow things down, I'm testing a build without the DTSI backports (all commits linked above except for "ipq806x: refresh dtsi patches" and "ipq806x: apply correct voltage tolerance"). So far, it boots, though I haven't run a full test. Regardless, it's not a proper solution, just a troubleshooting attempt. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] uqmi: Move to community packages repo
On 02/07/21 1:42 am, Arjun wrote: On 02/07/21 1:36 am, David Bauer wrote: [resend, as I've missed to keep the list CC'ed] Hi Arjun On 7/1/21 9:50 PM, Arjun AK wrote: Signed-off-by: Arjun AK And just my personal opinion: While I think it makes sense to move optional packages to the packages feed, this is clearly a core functional dependency for multiple targets. We win absolutely nothing by moving it to packages, but lose the ability to build images providing seamless ootb internet connectivity without pulling in packages feed. Just because a lot of packages were moved in the not-so-distant past means this has to be done to each and every packages in core. Best David For now i would be happy with the patch titled "uim: add --uim-get-sim-state" be merged in. Also the current maintainers (Matti Laakso ) server is not accepting emails anymore. -- Arjun ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] uqmi: Move to community packages repo
On 02/07/21 1:36 am, David Bauer wrote: [resend, as I've missed to keep the list CC'ed] Hi Arjun On 7/1/21 9:50 PM, Arjun AK wrote: Signed-off-by: Arjun AK And just my personal opinion: While I think it makes sense to move optional packages to the packages feed, this is clearly a core functional dependency for multiple targets. We win absolutely nothing by moving it to packages, but lose the ability to build images providing seamless ootb internet connectivity without pulling in packages feed. Just because a lot of packages were moved in the not-so-distant past means this has to be done to each and every packages in core. Best David For now i would be happy with the patch titled "uim: add --uim-get-sim-state" be merged in. -- - Arjun ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] uqmi: Move to community packages repo
Hi Arjun,
On 01.07.2021 21:50, Arjun AK wrote:
Signed-off-by: Arjun AK
There are many devices with uqmi dependency (more than 10?).
Personally, I would prefer to keep this one in the core packages set.
--
Cheers,
Piotr
---
package/network/utils/uqmi/Makefile | 48 --
.../utils/uqmi/files/lib/netifd/proto/qmi.sh | 471 --
2 files changed, 519 deletions(-)
delete mode 100644 package/network/utils/uqmi/Makefile
delete mode 100755 package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
diff --git a/package/network/utils/uqmi/Makefile
b/package/network/utils/uqmi/Makefile
deleted file mode 100644
index 53ca67230b..00
--- a/package/network/utils/uqmi/Makefile
+++ /dev/null
@@ -1,48 +0,0 @@
-include $(TOPDIR)/rules.mk
-
-PKG_NAME:=uqmi
-PKG_RELEASE:=3
-
-PKG_SOURCE_PROTO:=git
-PKG_SOURCE_URL=$(PROJECT_GIT)/project/uqmi.git
-PKG_SOURCE_DATE:=2020-11-22
-PKG_SOURCE_VERSION:=0a19b5b77140465c29e2afa7d611fe93abc9672f
-PKG_MIRROR_HASH:=0a6641f8e167efd21d464b0b2aeb1fec5f974dddcdb8822fbd5d7190d0b741b4
-PKG_MAINTAINER:=Matti Laakso
-
-PKG_LICENSE:=GPL-2.0
-PKG_LICENSE_FILES:=
-
-PKG_FLAGS:=nonshared
-
-include $(INCLUDE_DIR)/package.mk
-include $(INCLUDE_DIR)/cmake.mk
-
-define Package/uqmi
- SECTION:=net
- CATEGORY:=Network
- SUBMENU:=WWAN
- DEPENDS:=+libubox +libblobmsg-json +kmod-usb-net +kmod-usb-net-qmi-wwan +wwan
- TITLE:=Control utility for mobile broadband modems
-endef
-
-define Package/uqmi/description
- uqmi is a command line tool for controlling mobile broadband modems using
- the QMI-protocol.
-endef
-
-TARGET_CFLAGS += \
- -I$(STAGING_DIR)/usr/include -ffunction-sections -fdata-sections
-
-TARGET_LDFLAGS += -Wl,--gc-sections
-
-CMAKE_OPTIONS += \
- -DDEBUG=1
-
-define Package/uqmi/install
- $(INSTALL_DIR) $(1)/sbin
- $(INSTALL_BIN) $(PKG_BUILD_DIR)/uqmi $(1)/sbin/
- $(CP) ./files/* $(1)/
-endef
-
-$(eval $(call BuildPackage,uqmi))
diff --git a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
deleted file mode 100755
index c0134f44dd..00
--- a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
+++ /dev/null
@@ -1,471 +0,0 @@
-#!/bin/sh
-
-[ -n "$INCLUDE_ONLY" ] || {
- . /lib/functions.sh
- . ../netifd-proto.sh
- init_proto "$@"
-}
-
-proto_qmi_init_config() {
- available=1
- no_device=1
- proto_config_add_string "device:device"
- proto_config_add_string apn
- proto_config_add_string auth
- proto_config_add_string username
- proto_config_add_string password
- proto_config_add_string pincode
- proto_config_add_int delay
- proto_config_add_string modes
- proto_config_add_string pdptype
- proto_config_add_int profile
- proto_config_add_boolean dhcp
- proto_config_add_boolean dhcpv6
- proto_config_add_boolean autoconnect
- proto_config_add_int plmn
- proto_config_add_int timeout
- proto_config_add_int mtu
- proto_config_add_defaults
-}
-
-proto_qmi_setup() {
- local interface="$1"
- local dataformat connstat plmn_mode mcc mnc
- local device apn auth username password pincode delay modes pdptype
- local profile dhcp dhcpv6 autoconnect plmn timeout mtu
$PROTO_DEFAULT_OPTIONS
- local ip4table ip6table
- local cid_4 pdh_4 cid_6 pdh_6
- local ip_6 ip_prefix_length gateway_6 dns1_6 dns2_6
-
- json_get_vars device apn auth username password pincode delay modes
- json_get_vars pdptype profile dhcp dhcpv6 autoconnect plmn ip4table
- json_get_vars ip6table timeout mtu $PROTO_DEFAULT_OPTIONS
-
- [ "$timeout" = "" ] && timeout="10"
-
- [ "$metric" = "" ] && metric="0"
-
- [ -n "$ctl_device" ] && device=$ctl_device
-
- [ -n "$device" ] || {
- echo "No control device specified"
- proto_notify_error "$interface" NO_DEVICE
- proto_set_available "$interface" 0
- return 1
- }
-
- [ -n "$delay" ] && sleep "$delay"
-
- device="$(readlink -f $device)"
- [ -c "$device" ] || {
- echo "The specified control device does not exist"
- proto_notify_error "$interface" NO_DEVICE
- proto_set_available "$interface" 0
- return 1
- }
-
- devname="$(basename "$device")"
- devpath="$(readlink -f /sys/class/usbmisc/$devname/device/)"
- ifname="$( ls "$devpath"/net )"
- [ -n "$ifname" ] || {
- echo "The interface could not be found."
- proto_notify_error "$interface" NO_IFACE
- proto_set_available "$interface" 0
- return 1
- }
-
- [ -n "$mtu" ] && {
- echo "Setting MTU to $mtu"
- /sbin/ip link set dev $ifname mtu $mtu
- }
-
- echo "Waiting for SIM initialization"
- local
Re: [PATCH] uqmi: Move to community packages repo
[resend, as I've missed to keep the list CC'ed]
Hi Arjun
On 7/1/21 9:50 PM, Arjun AK wrote:
Signed-off-by: Arjun AK
Describing the rationale of this change would've been nice. This package
is used on most boards with a cellular modem to provide ootb internet
capability, so please explain how you intend to deal with that.
And just my personal opinion: While I think it makes sense to move
optional packages to the packages feed, this is clearly a core
functional dependency for multiple targets. We win absolutely nothing by
moving it to packages, but lose the ability to build images providing
seamless ootb internet connectivity without pulling in packages feed.
Just because a lot of packages were moved in the not-so-distant past
means this has to be done to each and every packages in core.
Best
David
---
package/network/utils/uqmi/Makefile | 48 --
.../utils/uqmi/files/lib/netifd/proto/qmi.sh | 471 --
2 files changed, 519 deletions(-)
delete mode 100644 package/network/utils/uqmi/Makefile
delete mode 100755 package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
diff --git a/package/network/utils/uqmi/Makefile
b/package/network/utils/uqmi/Makefile
deleted file mode 100644
index 53ca67230b..00
--- a/package/network/utils/uqmi/Makefile
+++ /dev/null
@@ -1,48 +0,0 @@
-include $(TOPDIR)/rules.mk
-
-PKG_NAME:=uqmi
-PKG_RELEASE:=3
-
-PKG_SOURCE_PROTO:=git
-PKG_SOURCE_URL=$(PROJECT_GIT)/project/uqmi.git
-PKG_SOURCE_DATE:=2020-11-22
-PKG_SOURCE_VERSION:=0a19b5b77140465c29e2afa7d611fe93abc9672f
-PKG_MIRROR_HASH:=0a6641f8e167efd21d464b0b2aeb1fec5f974dddcdb8822fbd5d7190d0b741b4
-PKG_MAINTAINER:=Matti Laakso
-
-PKG_LICENSE:=GPL-2.0
-PKG_LICENSE_FILES:=
-
-PKG_FLAGS:=nonshared
-
-include $(INCLUDE_DIR)/package.mk
-include $(INCLUDE_DIR)/cmake.mk
-
-define Package/uqmi
- SECTION:=net
- CATEGORY:=Network
- SUBMENU:=WWAN
- DEPENDS:=+libubox +libblobmsg-json +kmod-usb-net +kmod-usb-net-qmi-wwan +wwan
- TITLE:=Control utility for mobile broadband modems
-endef
-
-define Package/uqmi/description
- uqmi is a command line tool for controlling mobile broadband modems using
- the QMI-protocol.
-endef
-
-TARGET_CFLAGS += \
- -I$(STAGING_DIR)/usr/include -ffunction-sections -fdata-sections
-
-TARGET_LDFLAGS += -Wl,--gc-sections
-
-CMAKE_OPTIONS += \
- -DDEBUG=1
-
-define Package/uqmi/install
- $(INSTALL_DIR) $(1)/sbin
- $(INSTALL_BIN) $(PKG_BUILD_DIR)/uqmi $(1)/sbin/
- $(CP) ./files/* $(1)/
-endef
-
-$(eval $(call BuildPackage,uqmi))
diff --git a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
deleted file mode 100755
index c0134f44dd..00
--- a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
+++ /dev/null
@@ -1,471 +0,0 @@
-#!/bin/sh
-
-[ -n "$INCLUDE_ONLY" ] || {
- . /lib/functions.sh
- . ../netifd-proto.sh
- init_proto "$@"
-}
-
-proto_qmi_init_config() {
- available=1
- no_device=1
- proto_config_add_string "device:device"
- proto_config_add_string apn
- proto_config_add_string auth
- proto_config_add_string username
- proto_config_add_string password
- proto_config_add_string pincode
- proto_config_add_int delay
- proto_config_add_string modes
- proto_config_add_string pdptype
- proto_config_add_int profile
- proto_config_add_boolean dhcp
- proto_config_add_boolean dhcpv6
- proto_config_add_boolean autoconnect
- proto_config_add_int plmn
- proto_config_add_int timeout
- proto_config_add_int mtu
- proto_config_add_defaults
-}
-
-proto_qmi_setup() {
- local interface="$1"
- local dataformat connstat plmn_mode mcc mnc
- local device apn auth username password pincode delay modes pdptype
- local profile dhcp dhcpv6 autoconnect plmn timeout mtu
$PROTO_DEFAULT_OPTIONS
- local ip4table ip6table
- local cid_4 pdh_4 cid_6 pdh_6
- local ip_6 ip_prefix_length gateway_6 dns1_6 dns2_6
-
- json_get_vars device apn auth username password pincode delay modes
- json_get_vars pdptype profile dhcp dhcpv6 autoconnect plmn ip4table
- json_get_vars ip6table timeout mtu $PROTO_DEFAULT_OPTIONS
-
- [ "$timeout" = "" ] && timeout="10"
-
- [ "$metric" = "" ] && metric="0"
-
- [ -n "$ctl_device" ] && device=$ctl_device
-
- [ -n "$device" ] || {
- echo "No control device specified"
- proto_notify_error "$interface" NO_DEVICE
- proto_set_available "$interface" 0
- return 1
- }
-
- [ -n "$delay" ] && sleep "$delay"
-
- device="$(readlink -f $device)"
- [ -c "$device" ] || {
- echo "The specified control device does not exist"
- proto_notify_error "$interface" NO_DEVICE
- proto_set_available "$interface" 0
- return 1
-
Re: [PATCH 19.07 4/4] treewide: mark selected packages nonshared
On 7/1/21 9:51 AM, Petr Štetiar wrote: Paul Spooren [2021-07-01 07:45:02]: +++ b/package/libs/libjson-c/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=json-c PKG_VERSION:=0.12.1 -PKG_RELEASE:=3.1 +PKG_RELEASE:=3.2 I've never seen a non integer release, is there a special reason for this? package/base-files/Makefile:PKG_RELEASE:=204.4 package/boot/uboot-envtools/Makefile:PKG_RELEASE:=3.1 package/libs/libjson-c/Makefile:PKG_RELEASE:=3.2 package/libs/libpcap/Makefile:PKG_RELEASE:=2.1 package/network/services/dnsmasq/Makefile:PKG_RELEASE:=16.3 package/network/utils/iproute2/Makefile:PKG_RELEASE:=2.1 Thanks for the lookup. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] uqmi: Move to community packages repo
On 7/1/21 9:50 AM, Arjun AK wrote:
Signed-off-by: Arjun AK
---
Could you please add a brief commit message describing why this package
isn't needed in core?
I'm all for moving it, don't get me wrong, we just try to have commit
messages everywhere to keep context over time.
package/network/utils/uqmi/Makefile | 48 --
.../utils/uqmi/files/lib/netifd/proto/qmi.sh | 471 --
2 files changed, 519 deletions(-)
delete mode 100644 package/network/utils/uqmi/Makefile
delete mode 100755 package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
diff --git a/package/network/utils/uqmi/Makefile
b/package/network/utils/uqmi/Makefile
deleted file mode 100644
index 53ca67230b..00
--- a/package/network/utils/uqmi/Makefile
+++ /dev/null
@@ -1,48 +0,0 @@
-include $(TOPDIR)/rules.mk
-
-PKG_NAME:=uqmi
-PKG_RELEASE:=3
-
-PKG_SOURCE_PROTO:=git
-PKG_SOURCE_URL=$(PROJECT_GIT)/project/uqmi.git
-PKG_SOURCE_DATE:=2020-11-22
-PKG_SOURCE_VERSION:=0a19b5b77140465c29e2afa7d611fe93abc9672f
-PKG_MIRROR_HASH:=0a6641f8e167efd21d464b0b2aeb1fec5f974dddcdb8822fbd5d7190d0b741b4
-PKG_MAINTAINER:=Matti Laakso
-
-PKG_LICENSE:=GPL-2.0
-PKG_LICENSE_FILES:=
-
-PKG_FLAGS:=nonshared
-
-include $(INCLUDE_DIR)/package.mk
-include $(INCLUDE_DIR)/cmake.mk
-
-define Package/uqmi
- SECTION:=net
- CATEGORY:=Network
- SUBMENU:=WWAN
- DEPENDS:=+libubox +libblobmsg-json +kmod-usb-net +kmod-usb-net-qmi-wwan +wwan
- TITLE:=Control utility for mobile broadband modems
-endef
-
-define Package/uqmi/description
- uqmi is a command line tool for controlling mobile broadband modems using
- the QMI-protocol.
-endef
-
-TARGET_CFLAGS += \
- -I$(STAGING_DIR)/usr/include -ffunction-sections -fdata-sections
-
-TARGET_LDFLAGS += -Wl,--gc-sections
-
-CMAKE_OPTIONS += \
- -DDEBUG=1
-
-define Package/uqmi/install
- $(INSTALL_DIR) $(1)/sbin
- $(INSTALL_BIN) $(PKG_BUILD_DIR)/uqmi $(1)/sbin/
- $(CP) ./files/* $(1)/
-endef
-
-$(eval $(call BuildPackage,uqmi))
diff --git a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
deleted file mode 100755
index c0134f44dd..00
--- a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
+++ /dev/null
@@ -1,471 +0,0 @@
-#!/bin/sh
-
-[ -n "$INCLUDE_ONLY" ] || {
- . /lib/functions.sh
- . ../netifd-proto.sh
- init_proto "$@"
-}
-
-proto_qmi_init_config() {
- available=1
- no_device=1
- proto_config_add_string "device:device"
- proto_config_add_string apn
- proto_config_add_string auth
- proto_config_add_string username
- proto_config_add_string password
- proto_config_add_string pincode
- proto_config_add_int delay
- proto_config_add_string modes
- proto_config_add_string pdptype
- proto_config_add_int profile
- proto_config_add_boolean dhcp
- proto_config_add_boolean dhcpv6
- proto_config_add_boolean autoconnect
- proto_config_add_int plmn
- proto_config_add_int timeout
- proto_config_add_int mtu
- proto_config_add_defaults
-}
-
-proto_qmi_setup() {
- local interface="$1"
- local dataformat connstat plmn_mode mcc mnc
- local device apn auth username password pincode delay modes pdptype
- local profile dhcp dhcpv6 autoconnect plmn timeout mtu
$PROTO_DEFAULT_OPTIONS
- local ip4table ip6table
- local cid_4 pdh_4 cid_6 pdh_6
- local ip_6 ip_prefix_length gateway_6 dns1_6 dns2_6
-
- json_get_vars device apn auth username password pincode delay modes
- json_get_vars pdptype profile dhcp dhcpv6 autoconnect plmn ip4table
- json_get_vars ip6table timeout mtu $PROTO_DEFAULT_OPTIONS
-
- [ "$timeout" = "" ] && timeout="10"
-
- [ "$metric" = "" ] && metric="0"
-
- [ -n "$ctl_device" ] && device=$ctl_device
-
- [ -n "$device" ] || {
- echo "No control device specified"
- proto_notify_error "$interface" NO_DEVICE
- proto_set_available "$interface" 0
- return 1
- }
-
- [ -n "$delay" ] && sleep "$delay"
-
- device="$(readlink -f $device)"
- [ -c "$device" ] || {
- echo "The specified control device does not exist"
- proto_notify_error "$interface" NO_DEVICE
- proto_set_available "$interface" 0
- return 1
- }
-
- devname="$(basename "$device")"
- devpath="$(readlink -f /sys/class/usbmisc/$devname/device/)"
- ifname="$( ls "$devpath"/net )"
- [ -n "$ifname" ] || {
- echo "The interface could not be found."
- proto_notify_error "$interface" NO_IFACE
- proto_set_available "$interface" 0
- return 1
- }
-
- [ -n "$mtu" ] && {
- echo "Setting MTU to $mtu"
- /sbin/ip link set dev $ifname mtu $mtu
- }
-
- echo "Waiting
Re: [PATCH 19.07 4/4] treewide: mark selected packages nonshared
Paul Spooren [2021-07-01 07:45:02]: > > +++ b/package/libs/libjson-c/Makefile > > @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk > > PKG_NAME:=json-c > > PKG_VERSION:=0.12.1 > > -PKG_RELEASE:=3.1 > > +PKG_RELEASE:=3.2 > > I've never seen a non integer release, is there a special reason for this? package/base-files/Makefile:PKG_RELEASE:=204.4 package/boot/uboot-envtools/Makefile:PKG_RELEASE:=3.1 package/libs/libjson-c/Makefile:PKG_RELEASE:=3.2 package/libs/libpcap/Makefile:PKG_RELEASE:=2.1 package/network/services/dnsmasq/Makefile:PKG_RELEASE:=16.3 package/network/utils/iproute2/Makefile:PKG_RELEASE:=2.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH] uqmi: Move to community packages repo
Signed-off-by: Arjun AK
---
package/network/utils/uqmi/Makefile | 48 --
.../utils/uqmi/files/lib/netifd/proto/qmi.sh | 471 --
2 files changed, 519 deletions(-)
delete mode 100644 package/network/utils/uqmi/Makefile
delete mode 100755 package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
diff --git a/package/network/utils/uqmi/Makefile
b/package/network/utils/uqmi/Makefile
deleted file mode 100644
index 53ca67230b..00
--- a/package/network/utils/uqmi/Makefile
+++ /dev/null
@@ -1,48 +0,0 @@
-include $(TOPDIR)/rules.mk
-
-PKG_NAME:=uqmi
-PKG_RELEASE:=3
-
-PKG_SOURCE_PROTO:=git
-PKG_SOURCE_URL=$(PROJECT_GIT)/project/uqmi.git
-PKG_SOURCE_DATE:=2020-11-22
-PKG_SOURCE_VERSION:=0a19b5b77140465c29e2afa7d611fe93abc9672f
-PKG_MIRROR_HASH:=0a6641f8e167efd21d464b0b2aeb1fec5f974dddcdb8822fbd5d7190d0b741b4
-PKG_MAINTAINER:=Matti Laakso
-
-PKG_LICENSE:=GPL-2.0
-PKG_LICENSE_FILES:=
-
-PKG_FLAGS:=nonshared
-
-include $(INCLUDE_DIR)/package.mk
-include $(INCLUDE_DIR)/cmake.mk
-
-define Package/uqmi
- SECTION:=net
- CATEGORY:=Network
- SUBMENU:=WWAN
- DEPENDS:=+libubox +libblobmsg-json +kmod-usb-net +kmod-usb-net-qmi-wwan +wwan
- TITLE:=Control utility for mobile broadband modems
-endef
-
-define Package/uqmi/description
- uqmi is a command line tool for controlling mobile broadband modems using
- the QMI-protocol.
-endef
-
-TARGET_CFLAGS += \
- -I$(STAGING_DIR)/usr/include -ffunction-sections -fdata-sections
-
-TARGET_LDFLAGS += -Wl,--gc-sections
-
-CMAKE_OPTIONS += \
- -DDEBUG=1
-
-define Package/uqmi/install
- $(INSTALL_DIR) $(1)/sbin
- $(INSTALL_BIN) $(PKG_BUILD_DIR)/uqmi $(1)/sbin/
- $(CP) ./files/* $(1)/
-endef
-
-$(eval $(call BuildPackage,uqmi))
diff --git a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
b/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
deleted file mode 100755
index c0134f44dd..00
--- a/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh
+++ /dev/null
@@ -1,471 +0,0 @@
-#!/bin/sh
-
-[ -n "$INCLUDE_ONLY" ] || {
- . /lib/functions.sh
- . ../netifd-proto.sh
- init_proto "$@"
-}
-
-proto_qmi_init_config() {
- available=1
- no_device=1
- proto_config_add_string "device:device"
- proto_config_add_string apn
- proto_config_add_string auth
- proto_config_add_string username
- proto_config_add_string password
- proto_config_add_string pincode
- proto_config_add_int delay
- proto_config_add_string modes
- proto_config_add_string pdptype
- proto_config_add_int profile
- proto_config_add_boolean dhcp
- proto_config_add_boolean dhcpv6
- proto_config_add_boolean autoconnect
- proto_config_add_int plmn
- proto_config_add_int timeout
- proto_config_add_int mtu
- proto_config_add_defaults
-}
-
-proto_qmi_setup() {
- local interface="$1"
- local dataformat connstat plmn_mode mcc mnc
- local device apn auth username password pincode delay modes pdptype
- local profile dhcp dhcpv6 autoconnect plmn timeout mtu
$PROTO_DEFAULT_OPTIONS
- local ip4table ip6table
- local cid_4 pdh_4 cid_6 pdh_6
- local ip_6 ip_prefix_length gateway_6 dns1_6 dns2_6
-
- json_get_vars device apn auth username password pincode delay modes
- json_get_vars pdptype profile dhcp dhcpv6 autoconnect plmn ip4table
- json_get_vars ip6table timeout mtu $PROTO_DEFAULT_OPTIONS
-
- [ "$timeout" = "" ] && timeout="10"
-
- [ "$metric" = "" ] && metric="0"
-
- [ -n "$ctl_device" ] && device=$ctl_device
-
- [ -n "$device" ] || {
- echo "No control device specified"
- proto_notify_error "$interface" NO_DEVICE
- proto_set_available "$interface" 0
- return 1
- }
-
- [ -n "$delay" ] && sleep "$delay"
-
- device="$(readlink -f $device)"
- [ -c "$device" ] || {
- echo "The specified control device does not exist"
- proto_notify_error "$interface" NO_DEVICE
- proto_set_available "$interface" 0
- return 1
- }
-
- devname="$(basename "$device")"
- devpath="$(readlink -f /sys/class/usbmisc/$devname/device/)"
- ifname="$( ls "$devpath"/net )"
- [ -n "$ifname" ] || {
- echo "The interface could not be found."
- proto_notify_error "$interface" NO_IFACE
- proto_set_available "$interface" 0
- return 1
- }
-
- [ -n "$mtu" ] && {
- echo "Setting MTU to $mtu"
- /sbin/ip link set dev $ifname mtu $mtu
- }
-
- echo "Waiting for SIM initialization"
- local uninitialized_timeout=0
- while uqmi -s -d "$device" --get-pin-status | grep '"UIM
uninitialized"' > /dev/null; do
- [ -e "$device" ] || return 1
- if [ "$uninitialized_timeout" -lt "$timeout"
[PATCH] DWR-512B: Remove dependency on comgt package
comgt package is being moved to the packages repo Signed-off-by: Arjun AK --- target/linux/ramips/image/rt305x.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/ramips/image/rt305x.mk b/target/linux/ramips/image/rt305x.mk index 4edc2eb3c4..f87dc633a0 100644 --- a/target/linux/ramips/image/rt305x.mk +++ b/target/linux/ramips/image/rt305x.mk @@ -473,7 +473,7 @@ define Device/dlink_dwr-512-b DEVICE_MODEL := DWR-512 DEVICE_VARIANT := B DEVICE_PACKAGES := jboot-tools kmod-usb2 kmod-spi-dev \ - kmod-usb-serial-option kmod-usb-net-cdc-ether comgt-ncm + kmod-usb-serial-option kmod-usb-net-cdc-ether DLINK_ROM_ID := DLK6E2412001 DLINK_FAMILY_MEMBER := 0x6E24 DLINK_FIRMWARE_SIZE := 0x7E -- 2.20.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH 19.07 4/4] treewide: mark selected packages nonshared
On 7/1/21 3:09 AM, Petr Štetiar wrote: From: Hannu Nyman Mark uci, ubus, libubox, lua, libnl-tiny and libjson-c as nonshared packages. This helps to keep coherent dependencies if these ABI versioned packages are later updated. Before this commit it is possible to get missing dependencies in target-specific nonshared packages (like iwinfo) that depend on these shared ABI versioned packages. If these are later updated and rebuilt, only the new ABI version will be available for download, while the target-specific packages in releases continue to depend on the old ABI version. After this commit the packages are built along the other nonshared packages by the phase1 images buildbot and will be available at the target/ download directories instead of packages/base dir. That will help to keep a coherent set available. Signed-off-by: Hannu Nyman Signed-off-by: Petr Štetiar [backport] (backported from commit 72cc44958ef4e0df1a152178514c92899d6a957a) Signed-off-by: Petr Štetiar --- package/libs/libjson-c/Makefile | 3 ++- package/libs/libnl-tiny/Makefile | 4 +++- package/libs/libubox/Makefile| 4 +++- package/system/ubus/Makefile | 3 ++- package/system/uci/Makefile | 3 ++- package/utils/lua/Makefile | 3 ++- 6 files changed, 14 insertions(+), 6 deletions(-) diff --git a/package/libs/libjson-c/Makefile b/package/libs/libjson-c/Makefile index 522de0698423..49e9d01a12a9 100644 --- a/package/libs/libjson-c/Makefile +++ b/package/libs/libjson-c/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=json-c PKG_VERSION:=0.12.1 -PKG_RELEASE:=3.1 +PKG_RELEASE:=3.2 I've never seen a non integer release, is there a special reason for this? PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION)-nodoc.tar.gz PKG_SOURCE_URL:=https://s3.amazonaws.com/json-c_releases/releases/ @@ -21,6 +21,7 @@ PKG_LICENSE:=MIT PKG_LICENSE_FILES:=COPYING PKG_CPE_ID:=cpe:/a:json-c_project:json-c +PKG_FLAGS:=nonshared PKG_FIXUP:=autoreconf PKG_INSTALL:=1 diff --git a/package/libs/libnl-tiny/Makefile b/package/libs/libnl-tiny/Makefile index cabbb084218f..79c3bdcb2eef 100644 --- a/package/libs/libnl-tiny/Makefile +++ b/package/libs/libnl-tiny/Makefile @@ -9,7 +9,9 @@ include $(TOPDIR)/rules.mk PKG_NAME:=libnl-tiny PKG_VERSION:=0.1 -PKG_RELEASE:=5 +PKG_RELEASE:=6 + +PKG_FLAGS:=nonshared PKG_LICENSE:=LGPL-2.1 PKG_MAINTAINER:=Felix Fietkau diff --git a/package/libs/libubox/Makefile b/package/libs/libubox/Makefile index 49bf58374266..8f1ce50b5827 100644 --- a/package/libs/libubox/Makefile +++ b/package/libs/libubox/Makefile @@ -1,7 +1,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=libubox -PKG_RELEASE=1 +PKG_RELEASE=2 PKG_SOURCE_PROTO:=git PKG_SOURCE_URL=$(PROJECT_GIT)/project/libubox.git @@ -10,6 +10,8 @@ PKG_SOURCE_DATE:=2020-05-25 PKG_SOURCE_VERSION:=66195aee50424cbda0c2d858014e4cc58a2dc029 CMAKE_INSTALL:=1 +PKG_FLAGS:=nonshared + PKG_LICENSE:=ISC PKG_LICENSE_FILES:= diff --git a/package/system/ubus/Makefile b/package/system/ubus/Makefile index 2c116ae6f852..f0833663a8a9 100644 --- a/package/system/ubus/Makefile +++ b/package/system/ubus/Makefile @@ -1,7 +1,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=ubus -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_SOURCE_PROTO:=git PKG_SOURCE_URL=$(PROJECT_GIT)/project/ubus.git @@ -13,6 +13,7 @@ CMAKE_INSTALL:=1 PKG_LICENSE:=LGPL-2.1 PKG_LICENSE_FILES:= +PKG_FLAGS:=nonshared PKG_MAINTAINER:=Felix Fietkau diff --git a/package/system/uci/Makefile b/package/system/uci/Makefile index 903d4c50ca3a..2c75f270c078 100644 --- a/package/system/uci/Makefile +++ b/package/system/uci/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=uci -PKG_RELEASE:=4 +PKG_RELEASE:=5 PKG_SOURCE_URL=$(PROJECT_GIT)/project/uci.git PKG_SOURCE_PROTO:=git @@ -23,6 +23,7 @@ PKG_LICENSE_FILES:= PKG_MAINTAINER:=Felix Fietkau PKG_BUILD_PARALLEL:=0 +PKG_FLAGS:=nonshared include $(INCLUDE_DIR)/package.mk include $(INCLUDE_DIR)/cmake.mk diff --git a/package/utils/lua/Makefile b/package/utils/lua/Makefile index 077a60fbf3e8..73358c540714 100644 --- a/package/utils/lua/Makefile +++ b/package/utils/lua/Makefile @@ -9,13 +9,14 @@ include $(TOPDIR)/rules.mk PKG_NAME:=lua PKG_VERSION:=5.1.5 -PKG_RELEASE:=3 +PKG_RELEASE:=4 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz PKG_SOURCE_URL:=http://www.lua.org/ftp/ \ http://www.tecgraf.puc-rio.br/lua/ftp/ PKG_HASH:=2640fc56a795f29d28ef15e13c34a47e223960b0240e8cb0a82d9b0738695333 PKG_BUILD_PARALLEL:=1 +PKG_FLAGS:=nonshared PKG_LICENSE:=MIT PKG_LICENSE_FILES:=COPYRIGHT ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH 19.07 0/4] ubus fixes backports
Hi, this patch series backports various ubus related fixes and additionally marks various default packages as nonshared in order to avoid further ABI issues[1]. 1. https://github.com/openwrt/openwrt/pull/4233 -- ynezz Hannu Nyman (1): treewide: mark selected packages nonshared Petr Štetiar (3): ubus: backport SOVERSION support ubus: update to version 2021-06-03 ubus: update to version 2021-07-01 package/libs/libjson-c/Makefile | 3 ++- package/libs/libnl-tiny/Makefile | 4 +++- package/libs/libubox/Makefile| 4 +++- package/system/ubus/Makefile | 17 ++--- package/system/uci/Makefile | 3 ++- package/utils/lua/Makefile | 3 ++- 6 files changed, 22 insertions(+), 12 deletions(-) ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH 19.07 2/4] ubus: update to version 2021-06-03
This update cherry picks following changes: * cmake: add a possibility to set library version * ubusd: protect against too-short messages * ubusd: add per-client tx queue limit * ubusd: convert tx_queue to linked list * lua: avoid truncation of large numeric values Fixes: FS#1525 Signed-off-by: Petr Štetiar --- package/system/ubus/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package/system/ubus/Makefile b/package/system/ubus/Makefile index 5e3bbd120dc6..702a78214e8c 100644 --- a/package/system/ubus/Makefile +++ b/package/system/ubus/Makefile @@ -5,10 +5,10 @@ PKG_RELEASE:=1 PKG_SOURCE_PROTO:=git PKG_SOURCE_URL=$(PROJECT_GIT)/project/ubus.git -PKG_SOURCE_DATE:=2019-12-27 -PKG_SOURCE_VERSION:=041c9d1c052bb4936fd03240f7d0dd64aedda972 -PKG_MIRROR_HASH:=7febbe78dd178d8d7ccacff54c00fb2d19a53624005920db8cd85236f54f8324 -PKG_ABI_VERSION:=20191227 +PKG_SOURCE_DATE:=2021-06-03 +PKG_SOURCE_VERSION:=90fb56c00bbd911d929227528e679b174b1f4cec +PKG_MIRROR_HASH:=cec3ce8a2b952f08ed26d7f7e230cbbac34e66f0bcf11a03c3edaef1d0390490 +PKG_ABI_VERSION:=20210603 CMAKE_INSTALL:=1 PKG_LICENSE:=LGPL-2.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH 19.07 4/4] treewide: mark selected packages nonshared
From: Hannu Nyman Mark uci, ubus, libubox, lua, libnl-tiny and libjson-c as nonshared packages. This helps to keep coherent dependencies if these ABI versioned packages are later updated. Before this commit it is possible to get missing dependencies in target-specific nonshared packages (like iwinfo) that depend on these shared ABI versioned packages. If these are later updated and rebuilt, only the new ABI version will be available for download, while the target-specific packages in releases continue to depend on the old ABI version. After this commit the packages are built along the other nonshared packages by the phase1 images buildbot and will be available at the target/ download directories instead of packages/base dir. That will help to keep a coherent set available. Signed-off-by: Hannu Nyman Signed-off-by: Petr Štetiar [backport] (backported from commit 72cc44958ef4e0df1a152178514c92899d6a957a) Signed-off-by: Petr Štetiar --- package/libs/libjson-c/Makefile | 3 ++- package/libs/libnl-tiny/Makefile | 4 +++- package/libs/libubox/Makefile| 4 +++- package/system/ubus/Makefile | 3 ++- package/system/uci/Makefile | 3 ++- package/utils/lua/Makefile | 3 ++- 6 files changed, 14 insertions(+), 6 deletions(-) diff --git a/package/libs/libjson-c/Makefile b/package/libs/libjson-c/Makefile index 522de0698423..49e9d01a12a9 100644 --- a/package/libs/libjson-c/Makefile +++ b/package/libs/libjson-c/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=json-c PKG_VERSION:=0.12.1 -PKG_RELEASE:=3.1 +PKG_RELEASE:=3.2 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION)-nodoc.tar.gz PKG_SOURCE_URL:=https://s3.amazonaws.com/json-c_releases/releases/ @@ -21,6 +21,7 @@ PKG_LICENSE:=MIT PKG_LICENSE_FILES:=COPYING PKG_CPE_ID:=cpe:/a:json-c_project:json-c +PKG_FLAGS:=nonshared PKG_FIXUP:=autoreconf PKG_INSTALL:=1 diff --git a/package/libs/libnl-tiny/Makefile b/package/libs/libnl-tiny/Makefile index cabbb084218f..79c3bdcb2eef 100644 --- a/package/libs/libnl-tiny/Makefile +++ b/package/libs/libnl-tiny/Makefile @@ -9,7 +9,9 @@ include $(TOPDIR)/rules.mk PKG_NAME:=libnl-tiny PKG_VERSION:=0.1 -PKG_RELEASE:=5 +PKG_RELEASE:=6 + +PKG_FLAGS:=nonshared PKG_LICENSE:=LGPL-2.1 PKG_MAINTAINER:=Felix Fietkau diff --git a/package/libs/libubox/Makefile b/package/libs/libubox/Makefile index 49bf58374266..8f1ce50b5827 100644 --- a/package/libs/libubox/Makefile +++ b/package/libs/libubox/Makefile @@ -1,7 +1,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=libubox -PKG_RELEASE=1 +PKG_RELEASE=2 PKG_SOURCE_PROTO:=git PKG_SOURCE_URL=$(PROJECT_GIT)/project/libubox.git @@ -10,6 +10,8 @@ PKG_SOURCE_DATE:=2020-05-25 PKG_SOURCE_VERSION:=66195aee50424cbda0c2d858014e4cc58a2dc029 CMAKE_INSTALL:=1 +PKG_FLAGS:=nonshared + PKG_LICENSE:=ISC PKG_LICENSE_FILES:= diff --git a/package/system/ubus/Makefile b/package/system/ubus/Makefile index 2c116ae6f852..f0833663a8a9 100644 --- a/package/system/ubus/Makefile +++ b/package/system/ubus/Makefile @@ -1,7 +1,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=ubus -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_SOURCE_PROTO:=git PKG_SOURCE_URL=$(PROJECT_GIT)/project/ubus.git @@ -13,6 +13,7 @@ CMAKE_INSTALL:=1 PKG_LICENSE:=LGPL-2.1 PKG_LICENSE_FILES:= +PKG_FLAGS:=nonshared PKG_MAINTAINER:=Felix Fietkau diff --git a/package/system/uci/Makefile b/package/system/uci/Makefile index 903d4c50ca3a..2c75f270c078 100644 --- a/package/system/uci/Makefile +++ b/package/system/uci/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=uci -PKG_RELEASE:=4 +PKG_RELEASE:=5 PKG_SOURCE_URL=$(PROJECT_GIT)/project/uci.git PKG_SOURCE_PROTO:=git @@ -23,6 +23,7 @@ PKG_LICENSE_FILES:= PKG_MAINTAINER:=Felix Fietkau PKG_BUILD_PARALLEL:=0 +PKG_FLAGS:=nonshared include $(INCLUDE_DIR)/package.mk include $(INCLUDE_DIR)/cmake.mk diff --git a/package/utils/lua/Makefile b/package/utils/lua/Makefile index 077a60fbf3e8..73358c540714 100644 --- a/package/utils/lua/Makefile +++ b/package/utils/lua/Makefile @@ -9,13 +9,14 @@ include $(TOPDIR)/rules.mk PKG_NAME:=lua PKG_VERSION:=5.1.5 -PKG_RELEASE:=3 +PKG_RELEASE:=4 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz PKG_SOURCE_URL:=http://www.lua.org/ftp/ \ http://www.tecgraf.puc-rio.br/lua/ftp/ PKG_HASH:=2640fc56a795f29d28ef15e13c34a47e223960b0240e8cb0a82d9b0738695333 PKG_BUILD_PARALLEL:=1 +PKG_FLAGS:=nonshared PKG_LICENSE:=MIT PKG_LICENSE_FILES:=COPYRIGHT ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH 19.07 1/4] ubus: backport SOVERSION support
Add a support for setting of new `ABIVERSION` CMake define which allows to control the SOVERSION used for the built shared library. This is needed for downstream packaging to properly track breaking ABI changes when updating to newer versions of the library. Signed-off-by: Felix Fietkau Signed-off-by: Petr Štetiar [backport] (backported from commit 8edb1797d55d259c6eda18c89784f152328436fc) Signed-off-by: Petr Štetiar --- package/system/ubus/Makefile | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/package/system/ubus/Makefile b/package/system/ubus/Makefile index d3fe45225228..5e3bbd120dc6 100644 --- a/package/system/ubus/Makefile +++ b/package/system/ubus/Makefile @@ -8,6 +8,7 @@ PKG_SOURCE_URL=$(PROJECT_GIT)/project/ubus.git PKG_SOURCE_DATE:=2019-12-27 PKG_SOURCE_VERSION:=041c9d1c052bb4936fd03240f7d0dd64aedda972 PKG_MIRROR_HASH:=7febbe78dd178d8d7ccacff54c00fb2d19a53624005920db8cd85236f54f8324 +PKG_ABI_VERSION:=20191227 CMAKE_INSTALL:=1 PKG_LICENSE:=LGPL-2.1 @@ -36,7 +37,7 @@ define Package/libubus SECTION:=libs CATEGORY:=Libraries DEPENDS:=+libubox - ABI_VERSION:=20191227 + ABI_VERSION:=$(PKG_ABI_VERSION) TITLE:=OpenWrt RPC client library endef @@ -51,7 +52,8 @@ TARGET_CFLAGS += -I$(STAGING_DIR)/usr/include -flto TARGET_LDFLAGS += -flto CMAKE_OPTIONS = \ - -DLUAPATH=/usr/lib/lua + -DLUAPATH=/usr/lib/lua \ + -DABIVERSION="$(PKG_ABI_VERSION)" define Package/ubus/install $(INSTALL_DIR) $(1)/bin @@ -65,7 +67,7 @@ endef define Package/libubus/install $(INSTALL_DIR) $(1)/lib - $(CP) $(PKG_INSTALL_DIR)/usr/lib/*.so $(1)/lib/ + $(CP) $(PKG_INSTALL_DIR)/usr/lib/libubus.so.* $(1)/lib/ endef define Package/libubus-lua/install ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH 19.07 3/4] ubus: update to version 2021-07-01
This update cherry picks following fix: * ubusd: fix tx_queue linked list usage Signed-off-by: Petr Štetiar --- package/system/ubus/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/system/ubus/Makefile b/package/system/ubus/Makefile index 702a78214e8c..2c116ae6f852 100644 --- a/package/system/ubus/Makefile +++ b/package/system/ubus/Makefile @@ -5,9 +5,9 @@ PKG_RELEASE:=1 PKG_SOURCE_PROTO:=git PKG_SOURCE_URL=$(PROJECT_GIT)/project/ubus.git -PKG_SOURCE_DATE:=2021-06-03 -PKG_SOURCE_VERSION:=90fb56c00bbd911d929227528e679b174b1f4cec -PKG_MIRROR_HASH:=cec3ce8a2b952f08ed26d7f7e230cbbac34e66f0bcf11a03c3edaef1d0390490 +PKG_SOURCE_DATE:=2021-07-01 +PKG_SOURCE_VERSION:=38c7fdd8991366cd2f9ccbc47625f9b51b1d318a +PKG_MIRROR_HASH:=5ff9baa2ba3c7b2b53a477ed2a0f3dd8828051389f3d759cf5a694fbccc4c05b PKG_ABI_VERSION:=20210603 CMAKE_INSTALL:=1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: mvebu: armada 3720 cpufreq reverts
On Thu, Jul 1, 2021 at 12:42 AM Marek Behun wrote: > > On Wed, 30 Jun 2021 17:51:24 +0200 > Robert Marko wrote: > > > On Wed, Jun 30, 2021 at 3:19 PM Marek Behún wrote: > > > > > > Hello Robert, > > > > > > I am writing regarding commit > > > mvebu: 5.10 fix DVFS caused random boot crashes > > > > > > https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=080a0b74e39d159eecf69c468debec42f28bf4d8 > > > in OpenWRT. > > > > > > This commit reverts the one patch of a3720 cpufreq driver, but not > > > the subsequent ones. > > > > > > Your commit message says that some 1.2 GHz SOCs are unstable with the > > > fix. Did you also test this with the subsequent patches, which are now > > > in stable kernels? I guess the answer is yes, because all these patches > > > were backported to 5.10.37. > > > > Hi Marek, > > > > Yes, the rest of the patches were there as well. > > > > > > I am of the opinion that a better approach would be to > > > - either disable cpufreq for 1.2 GHz variants > > > - fix a3720 cpufreq driver to only scale up to 1 GHz on 1.2 GHz variant > > > > I would prefer limiting it to 1GHz as that would not cause performance > > issues, > > but 1GHz models could have the same issue as well. > > This is because the voltages that are set as a minimum are from the testing > > that > > Pali and the Turris guys did, but it really depends on the SoC batch > > you receive. > > > > > > Since the approach you've taken now (reverting the patch) basically > > > changes the CPU parnet clock to DDR clock, which is just wrong. > > > Worse is that you are doing this for everybody, not just for the 1.2 > > > GHz variants. > > > > > > What do you think? > > > > I understand that it was not the best solution, but something had to be > > done as > > I was not able to even finish booting on multiple boards before crashing. > > It just reverted the things back to the previous state. > > > > I really could not figure a proper solution even after being in touch > > with Pali, and contacting > > GlobalScale. > > > > This is an issue caused by Marvell simply ignoring the issue and > > refusing to publish > > a fix or release the OTP and AVS docs as they all have a validated > > voltage in the OTP > > somewhere. > > Robert, we've found this table in linux-marvell repository: > > https://github.com/MarvellEmbeddedProcessors/linux-marvell/blob/dc33b62c90696afb6adc7dbcc4ebbd48bedec269/drivers/regulator/armada-37xx-regulator.c#L99-L105 > > Do you still have the 1.2 GHz boards which were crashing? Would you be > willing to test whether those boards are stable if we provided patch > for you? Yes, I tested on 4 boards If I remember correctly and they all crashed with the voltages that are set, only by manually raising to at least 1.1902V one got stable while other required 1.2+V I would be glad to test a possible solution. Regards, Robert > > Marek -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 1 Zagreb, Croatia Email: robert.ma...@sartura.hr Web: www.sartura.hr ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: OpenWrt 21.02: backport lantiq xrx200 DSA switch
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Hi Martin, On Thu, Jul 1, 2021 at 8:02 AM Martin Schiller wrote: > > Hello all! > > Now that the Lantiq xrx200 DSA switch has finally made it into the > master, I would like to ask whether we also want to pack this switch > into the 21.02 release. The DSA changes were tested on multiple devices (before the pull request was merged). Also I think backporting this to 21.02 would make many people in the Home Hub 5A community happy, as they've been waiting for this for some time now. > The topic "DSA Support" is one of the key points of the 21.02 release > and therefore this would fit very well. > > Any opinions? In general I am fine with backporting this. The part that I am not sure about is the OpenWrt release schedule for 21.02 - so I'll let others comment on this. Best regards, Martin --- End Message --- ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
OpenWrt 21.02: backport lantiq xrx200 DSA switch
Hello all! Now that the Lantiq xrx200 DSA switch has finally made it into the master, I would like to ask whether we also want to pack this switch into the 21.02 release. The topic "DSA Support" is one of the key points of the 21.02 release and therefore this would fit very well. Any opinions? Thanks, Martin ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
