Re: [PATCH 4/5] kernel: netsupport: Add kmod-sched-act-sample

2022-07-21 Thread Hauke Mehrtens

On 7/21/22 18:42, Stijn Tintel wrote:

Hi,

On 18/07/2022 17:01, Hauke Mehrtens wrote:

From: Thomas Langer 

This adds the act_sample.ko and psample.ko kernel module which allows
traffic sampling.

Signed-off-by: Thomas Langer 
Signed-off-by: Hauke Mehrtens 
---
  package/kernel/linux/modules/netsupport.mk | 18 ++
  1 file changed, 18 insertions(+)

diff --git a/package/kernel/linux/modules/netsupport.mk 
b/package/kernel/linux/modules/netsupport.mk

index 40d304c52f..54c8d2dacd 100644
--- a/package/kernel/linux/modules/netsupport.mk
+++ b/package/kernel/linux/modules/netsupport.mk
@@ -855,6 +855,24 @@ endef
  $(eval $(call KernelPackage,sched-flower))
+define KernelPackage/sched-act-sample
+  SUBMENU:=$(NETWORK_SUPPORT_MENU)
+  TITLE:=Traffic Sampling
+  DEPENDS:=+kmod-sched-core
+  KCONFIG:=CONFIG_NET_ACT_SAMPLE CONFIG_PSAMPLE
+  FILES:= \
+    $(LINUX_DIR)/net/sched/act_sample.ko \
+    $(LINUX_DIR)/net/psample/psample.ko
+  AUTOLOAD:=$(call AutoProbe, psample act_sample)


We generally try to maintain alphabetical order in lists, so please 
order paths and module names alphabetically.


I think there are already some others in the wrong position, but I will 
at least try to put this into a better position. It should be before the 
other kmod-sched-* modules.


Hauke

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH 4/5] kernel: netsupport: Add kmod-sched-act-sample

2022-07-21 Thread Stijn Tintel

Hi,

On 18/07/2022 17:01, Hauke Mehrtens wrote:

From: Thomas Langer 

This adds the act_sample.ko and psample.ko kernel module which allows
traffic sampling.

Signed-off-by: Thomas Langer 
Signed-off-by: Hauke Mehrtens 
---
  package/kernel/linux/modules/netsupport.mk | 18 ++
  1 file changed, 18 insertions(+)

diff --git a/package/kernel/linux/modules/netsupport.mk 
b/package/kernel/linux/modules/netsupport.mk
index 40d304c52f..54c8d2dacd 100644
--- a/package/kernel/linux/modules/netsupport.mk
+++ b/package/kernel/linux/modules/netsupport.mk
@@ -855,6 +855,24 @@ endef
  $(eval $(call KernelPackage,sched-flower))
  
  
+define KernelPackage/sched-act-sample

+  SUBMENU:=$(NETWORK_SUPPORT_MENU)
+  TITLE:=Traffic Sampling
+  DEPENDS:=+kmod-sched-core
+  KCONFIG:=CONFIG_NET_ACT_SAMPLE CONFIG_PSAMPLE
+  FILES:= \
+   $(LINUX_DIR)/net/sched/act_sample.ko \
+   $(LINUX_DIR)/net/psample/psample.ko
+  AUTOLOAD:=$(call AutoProbe, psample act_sample)


We generally try to maintain alphabetical order in lists, so please 
order paths and module names alphabetically.


Thanks,
Stijn



___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH 1/5] kernel: netsupport: kmod-sched: explicitly define included modules

2022-07-21 Thread Stijn Tintel

Hi,

On 18/07/2022 17:01, Hauke Mehrtens wrote:

From: Thomas Langer 

Change SCHED_MODULES_EXTRA to an explicit list of modules
instead of taking everything that is not filtered out.
This removes the need of updating the filter each time an extra
sch_*, act_* or similar is added with an own kmod definition.

CONFIG_NET_SCH_FQ_CODEL and CONFIG_NET_SCH_FIFO are already compiled
into the kernel using the generic linux configuration.

CONFIG_NET_EMATCH_TEXT depends on the kmod-lib-textsearch package.


Ideally these last 2 changes go in separate commits, as they are 
unrelated to the main changes of this commit.


Thanks,
Stijn


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH] kernel/crypto: fix crypto-lib-curve25519 x86_64 build

2022-07-21 Thread Stijn Tintel

On 21/07/2022 15:17, Florian Eckert wrote:

The crypto-lib-curve25519 dependency for x86_64 could not be met,
because the package for for the architecture x86_64 was not added to
crypto-lib-curve package. Also the package arch definition for x86/64
does not exist. It musst be change to x86_64 to get added.


Can you please elaborate why this is needed? My x86/64 image contains 
curve25519_x86_64.ko without this change. It works with x86/64 because 
of [1] and BOARD is x86 for the x86 target.


Thanks,
Stijn

[1] 
https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=include/kernel.mk;h=001718d89d8b77bf7843c5cba77ef519f808e085;hb=HEAD#l213



___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[PATCH] kernel/crypto: fix crypto-lib-curve25519 x86_64 build

2022-07-21 Thread Florian Eckert
The crypto-lib-curve25519 dependency for x86_64 could not be met,
because the package for for the architecture x86_64 was not added to
crypto-lib-curve package. Also the package arch definition for x86/64
does not exist. It musst be change to x86_64 to get added.

Signed-off-by: Florian Eckert 
---
 package/kernel/linux/modules/crypto.mk | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/package/kernel/linux/modules/crypto.mk 
b/package/kernel/linux/modules/crypto.mk
index ed4e51079e..f31c4d5949 100644
--- a/package/kernel/linux/modules/crypto.mk
+++ b/package/kernel/linux/modules/crypto.mk
@@ -526,11 +526,16 @@ define KernelPackage/crypto-lib-curve25519/config
   imply PACKAGE_kmod-crypto-kpp
 endef
 
-define KernelPackage/crypto-lib-curve25519/x86/64
+define KernelPackage/crypto-lib-curve25519/x86_64
   KCONFIG+=CONFIG_CRYPTO_CURVE25519_X86
   FILES+=$(LINUX_DIR)/arch/x86/crypto/curve25519-x86_64.ko
 endef
 
+ifdef KernelPackage/crypto-lib-curve25519/$(ARCH)
+  KernelPackage/crypto-lib-curve25519/$(CRYPTO_TARGET)=\
+ $(KernelPackage/crypto-lib-curve25519/$(ARCH))
+endif
+
 define KernelPackage/crypto-lib-curve25519/arm-neon
   KCONFIG+=CONFIG_CRYPTO_CURVE25519_NEON
   FILES+=$(LINUX_DIR)/arch/arm/crypto/curve25519-neon.ko
-- 
2.30.2


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel