Re: [PATCH RESEND 06/11] Revert "x86/geode: enable X86_INTEL_LPSS to select PINCTRL"
On Tue, Dec 12, 2023 at 04:54:05PM +0100, Jonas Gorski wrote: > > On Sun, 10 Dec 2023 at 18:51, Elliott Mitchell wrote: > > > > Date: Fri, 3 Nov 2023 22:57:43 -0700 > > > > Enabling an Intel chipset feature on a platform originally made by > > National Semiconductor and later bought by AMD. Could we cut the Intel > > enthusiasm? > > > > This reverts commit 4eda2fddf2995c8ade2b1e0faddc8ce1f1e0ec5f. > > commit 4eda2fddf2995c8ade2b1e0faddc8ce1f1e0ec5f says "This makes it > possible to use the MCP23S08 i/o expander on geode platforms with > linux 4.14." Problem is this is nonsensical. A Geode processor CANNOT be paired with an Intel chipset (the original Geode GX1 came out of National Semiconductor/Cyrix and was later bought by AMD). > So we don't need to enable PINCTRL (via other symbols) anymore for this? No idea, I wasn't able to find very much information when I looked at this. I did find: https://lists.openwrt.org/pipermail/openwrt-devel/2018-August/019479.html This doesn't tell me what platform Martin Schiller was trying for. 17f30bfcf7 makes me suspect Martin Schiller was simply trying to do this to all x86 platforms and didn't realize geode was a specialized target. Alternatively Martin Schiller may have been trying to use a MCP23S08 on a Geode processor. Unfortunately using CONFIG_X86_INTEL_LPSS is a bizzare choice since CONFIG_X86_AMD_PLATFORM_DEVICE has fewer side-effects and then current Geodes were AMD processors. With sparse information the former is my present belief. Is anyone reading this list using a Geode processor with a MCP23S08? Otherwise my present belief is only people with Intel x86 processors are interested in the MCP23S08. -- (\___(\___(\__ --=> 8-) EHM <=-- __/)___/)___/) \BS (| ehem+sig...@m5p.com PGP 87145445 |) / \_CS\ | _ -O #include O- _ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH RESEND 02/11] kernel/generic: remove CONFIG_FB_NOTIFY
On Tue, Dec 12, 2023 at 04:48:32PM +0100, Jonas Gorski wrote: > > On Sun, 10 Dec 2023 at 18:49, Elliott Mitchell wrote: > > > > Date: Tue, 25 Apr 2023 16:23:20 -0700 > > > > This option is automatically enabled by CONFIG_FB=y. There is no > > reason to specifically enable it. > > Unfortunately this change will cause the symbol to appear in target > configs when using make kernel_*config. Ideally a make kernel_*config > without any changes should result in no changed files (currently it > does so for many targets). I strongly dislike this approach. Problem is forces the configuration files to contain both values which were deliberately chosen and values which are simply defaults (and defaults can change due to drivers becoming mature). Perhaps my other project could invalidate the reasoning behind this choice. Hmm. > To avoid that, I guess adding the symbol to > target/linux/generic/config-filter should do the trick so it becomes > properly ignored for config management. I'm okay with that. Presently have this is in my repository. -- (\___(\___(\__ --=> 8-) EHM <=-- __/)___/)___/) \BS (| ehem+sig...@m5p.com PGP 87145445 |) / \_CS\ | _ -O #include O- _ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: Migrating ISC to Kea DHCP blocked on related PR's
> On Dec 11, 2023, at 5:49 AM, Paul D wrote: > > On 2023-12-09 23:47, Philip Prindeville wrote: >> Hi all, >> I'm working on a drop-in for Kea that will parse existing ISC-DHCP >> configurations in UCI and crank out the derivative JSON config files for >> Kea, but I have a couple of PR's that are necessary to making this happen >> that have been pending for several weeks: >> https://github.com/openwrt/openwrt/pull/13765 >> https://github.com/openwrt/libubox/pull/6 > > For those who don't know: Kea DHCP is ISC's replacement for its own ISC DHCP > daemon. ISC DHCP reached end of life 2022. Yes, thanks for pointing that out. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH RESEND 06/11] Revert "x86/geode: enable X86_INTEL_LPSS to select PINCTRL"
Hi, On Sun, 10 Dec 2023 at 18:51, Elliott Mitchell wrote: > > Date: Fri, 3 Nov 2023 22:57:43 -0700 > > Enabling an Intel chipset feature on a platform originally made by > National Semiconductor and later bought by AMD. Could we cut the Intel > enthusiasm? > > This reverts commit 4eda2fddf2995c8ade2b1e0faddc8ce1f1e0ec5f. commit 4eda2fddf2995c8ade2b1e0faddc8ce1f1e0ec5f says "This makes it possible to use the MCP23S08 i/o expander on geode platforms with linux 4.14." So we don't need to enable PINCTRL (via other symbols) anymore for this? Please add an explanation why this is fine now to the commit message. Best Regards, Jonas ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH RESEND 02/11] kernel/generic: remove CONFIG_FB_NOTIFY
Hi, On Sun, 10 Dec 2023 at 18:49, Elliott Mitchell wrote: > > Date: Tue, 25 Apr 2023 16:23:20 -0700 > > This option is automatically enabled by CONFIG_FB=y. There is no > reason to specifically enable it. Unfortunately this change will cause the symbol to appear in target configs when using make kernel_*config. Ideally a make kernel_*config without any changes should result in no changed files (currently it does so for many targets). To avoid that, I guess adding the symbol to target/linux/generic/config-filter should do the trick so it becomes properly ignored for config management. Best Regards, Jonas ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
