[OpenWrt-Devel] WiFi on RT5350 not performing well
Hello All,
Working on an RT5350 based system with a generic version of CC 15.05 and the also the latest trunk head I noticed that
the WiFi performance was very poor. ssh was very sluggish and file transfers would hang after about 150Kbytes of data
were transferred.
After some investigation I discovered that be deleting this patch
target/linux/ramips/patches-3.18/0011-MIPS-ralink-add-rt2880-wmac-clock.patch
Full WiFi performance and functionality was restored. The question is why. The
patch adds the following
ralink_clk_add("48.wmac", wmac_rate);
to ralink_clk_init()
This looks important. I am not understanding why RT5350 would balk at this when other similar processors don't. The
WiFi for the MT7620 works fine with this patch.
So... is this a bug? is there something I am not understanding here? Is possibly some other code that is missing for the
initialization of the RT5350 that is present in other SoCs? For now I have modified the patch as follows
ralink_clk_add("40.ethernet", cpu_rate / 2);
+#if !defined(CONFIG_RALINK_RT5350)
+ralink_clk_add("48.wmac", wmac_rate);
+#endif
}
A longer description of symptoms can be found here
https://forum.openwrt.org/viewtopic.php?id=61395
Please comment.
Thanks,
--luis
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [OpenWrt] #13951: Revision r36939 breaks support for RT5370 (rt2800usb) in HG556a (brcm6358)
hello all...
i have attached the patch
On 1/29/15 6:39 AM, OpenWrt wrote:
#13951: Revision r36939 breaks support for RT5370 (rt2800usb) in HG556a
(brcm6358)
-+-
Reporter: openwrt@… | Owner: developers
Type: defect | Status: reopened
Priority: normal | Milestone: Chaos Calmer (trunk)
Component: kernel |Version: Trunk
Resolution: | Keywords: r36939 RT5370 rt2800usb HG556a
| brcm6358
-+-
Comment (by lsoltero):
fixed.
910-01-add-support-for-mt7620.patch
modified rt2800_get_txwi_rxwi_size() to add a case statement for the
RT5390. The problem is that the logic added to the case tested for the
7620 but failed to set the values for txwi_size and rxwi_size when the
5390 was not associated with the 7620. So the full function should look
like
void rt2800_get_txwi_rxwi_size(struct rt2x00_dev *rt2x00dev,
unsigned short *txwi_size,
unsigned short *rxwi_size)
{
switch (rt2x00dev->chip.rt) {
case RT3593:
case RT3883:
*txwi_size = TXWI_DESC_SIZE_4WORDS;
*rxwi_size = RXWI_DESC_SIZE_5WORDS;
break;
case RT5390:
if ( rt2x00dev->chip.rf == RF7620 ) {
*txwi_size = TXWI_DESC_SIZE_5WORDS;
*rxwi_size = RXWI_DESC_SIZE_6WORDS;
} else {
// else clause missing in original patch.
*txwi_size = TXWI_DESC_SIZE_4WORDS;
*rxwi_size = RXWI_DESC_SIZE_4WORDS;
}
break;
case RT5592:
*txwi_size = TXWI_DESC_SIZE_5WORDS;
*rxwi_size = RXWI_DESC_SIZE_6WORDS;
break;
default:
*txwi_size = TXWI_DESC_SIZE_4WORDS;
*rxwi_size = RXWI_DESC_SIZE_4WORDS;
break;
}
}
here is a patch that fixes the problem
package/kernel/mac80211/patches$ cat 910-02-fix-5370-in-add-support-for-
mt7620.patch
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -633,6 +633,9 @@ void rt2800_get_txwi_rxwi_size(struct rt
if ( rt2x00dev->chip.rf == RF7620 ) {
*txwi_size = TXWI_DESC_SIZE_5WORDS;
*rxwi_size = RXWI_DESC_SIZE_6WORDS;
+ } else {
+ *txwi_size = TXWI_DESC_SIZE_4WORDS;
+ *rxwi_size = RXWI_DESC_SIZE_4WORDS;
}
break;
--
Ticket URL: <https://dev.openwrt.org/ticket/13951#comment:17>
OpenWrt <http://openwrt.org>
Opensource Wireless Router Technology
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -633,6 +633,9 @@ void rt2800_get_txwi_rxwi_size(struct rt
if ( rt2x00dev->chip.rf == RF7620 ) {
*txwi_size = TXWI_DESC_SIZE_5WORDS;
*rxwi_size = RXWI_DESC_SIZE_6WORDS;
+ } else {
+ *txwi_size = TXWI_DESC_SIZE_4WORDS;
+ *rxwi_size = RXWI_DESC_SIZE_4WORDS;
}
break;
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] RT5350 UART not working.
Hello All,
it seems that I am not the only one having this issue.
https://dev.openwrt.org/ticket/14211
https://dev.openwrt.org/ticket/16831
any thoughts on how to resolve the UARTF issue on the 5350 is greatly
appreciated.
thanks,
--luis
On 12/1/14 3:49 PM, Luis Soltero wrote:
sorry... i sent the docs for the AWM003 not the AWM002...
On 12/1/14 3:43 PM, Luis Soltero wrote:
Hello John,
this is the AWM002 module...
http://www.asiarf.com/Smallest-Tiny-Ralink-802-11n-Wireless-AP-Router-Module-Board-AWM002-product-view-375.html
with the corresponding AsiaRF IO/Dev/Eval board. Here is pin sharing scheme
for the board. I have attached the docs
RTS I2S_CLK GPIO #7 1 2 GPIO #11 PCM_FS DTR
TXD I2S_WS GPIO #8 3 4 GPIO #12 PCM_CLK DCD
CTS I2S_SDO GPIO #9 5 6 GPIO #13 PCM_DRX DSR
RXD I2S_SDI GPIO #10 7 8 GPIO #14 PCM_DTX RI
I2C_CLK GPIO #2 9 10 GPIO #1 I2C_SD
RX1+ 11 12 TX1+
RX1- 13 14 TX1-
GND 15 16 GND
--luis
On 12/1/14 3:24 PM, John Crispin wrote:
ermmm ... i booted rt5350 on the weekend with uccess .. but that has
nothing to say. which boar is this ? i assume the small asiarf one ?
On 01/12/2014 13:40, Luis Soltero wrote:
anyone have any ideas on how to get the RT5350 UART working?
here is the error in the log.
[0.46] pinctrl core: add 1 pinmux maps
[0.46] rt2880-pinmux pinctrl.1: found group selector 2 for uartf
[0.46] rt2880-pinmux pinctrl.1: request pin 7 (io7) for
1500.uart
[0.46] rt2880-pinmux pinctrl.1: pin io7 already requested by
pinctrl.1; cannot claim for 1500.uart
[0.48] rt2880-pinmux pinctrl.1: pin-7 (1500.uart) status -22
[0.48] rt2880-pinmux pinctrl.1: could not request pin 7 (io7)
from group uartf on device rt2880-pinmux
[0.51] of_serial 1500.uart: Error applying setting, reverse
things back
[0.53] 1500.uart: ttyS1 at MMIO 0x1500 (irq = 13,
base_baud = 250) is a 16550A
here is the DTS config for the uart.
palmbus@1000 {
uart@500 {
status = "okay";
};
i2c@900 {
status = "okay";
};
gpio0: gpio@600 {
status = "okay";
};
gpio1: gpio@660 {
status = "okay";
};
};
pinctrl {
state_default: pinctrl0 {
gpio {
ralink,group = "i2c", "jtag";
ralink,function = "gpio";
};
uartf {
ralink,group = "uartf";
ralink,function = "uartf";
};
};
};
Any info/hints on this are greatly appreciated.
Thanks,
--luis
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] RT5350 UART not working.
anyone have any ideas on how to get the RT5350 UART working?
here is the error in the log.
[0.46] pinctrl core: add 1 pinmux maps
[0.46] rt2880-pinmux pinctrl.1: found group selector 2 for uartf
[0.46] rt2880-pinmux pinctrl.1: request pin 7 (io7) for 1500.uart
[0.46] rt2880-pinmux pinctrl.1: pin io7 already requested by pinctrl.1;
cannot claim for 1500.uart
[0.48] rt2880-pinmux pinctrl.1: pin-7 (1500.uart) status -22
[0.48] rt2880-pinmux pinctrl.1: could not request pin 7 (io7) from
group uartf on device rt2880-pinmux
[0.51] of_serial 1500.uart: Error applying setting, reverse things
back
[0.53] 1500.uart: ttyS1 at MMIO 0x1500 (irq = 13, base_baud =
250) is a 16550A
here is the DTS config for the uart.
palmbus@1000 {
uart@500 {
status = "okay";
};
i2c@900 {
status = "okay";
};
gpio0: gpio@600 {
status = "okay";
};
gpio1: gpio@660 {
status = "okay";
};
};
pinctrl {
state_default: pinctrl0 {
gpio {
ralink,group = "i2c", "jtag";
ralink,function = "gpio";
};
uartf {
ralink,group = "uartf";
ralink,function = "uartf";
};
};
};
Any info/hints on this are greatly appreciated.
Thanks,
--luis
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] ar71xxx + rtl8188eu
] R8188EU: BW40_24G_Diff[0][2] = -2 [ 1422.68] R8188EU: === TxCount 3 === [ 1422.68] R8188EU: CCK_24G_Diff[0][3] = -2 [ 1422.69] R8188EU: OFDM_24G_Diff[0][3] = -2 [ 1422.69] R8188EU: BW20_24G_Diff[0][3] = -2 [ 1422.69] R8188EU: BW40_24G_Diff[0][3] = -2 [ 1422.70] R8188EU: EEPROMRegulatory = 0x0 [ 1422.70] R8188EU: [0x8000,8] [ 1422.71] Hal_EfuseParseEEPROMVer(), EEVer = 1 [ 1422.71] R8188EU: mlmepriv.ChannelPlan = 0x0a [ 1422.72] R8188EU: CrystalCap: 0x20 [ 1422.72] R8188EU: EEPROM Customer ID: 0x 0 [ 1422.72] R8188EU: EEPROM : AntDivCfg = 0, TRxAntDivType = 0 [ 1422.73] R8188EU: Board Type: 0x 0 [ 1422.73] R8188EU: ThermalMeter = 0x18 [ 1422.74] R8188EU: < _ReadAdapterInfo8188EU in 710 ms [ 1422.74] R8188EU: [0x0800,8] [ 1422.75] +rtw_init_drv_sw [ 1422.75] R8188EU: [0x0040,8] [ 1422.75] rtw_alloc_stainfo: index=3R8188EU: [0x0040,8] [ 1422.76] alloc number_1 stainfo with hwaddr = ff:ff:ff:ff:ff:ff [ 1422.77] R8188EU: [0x0010,8] [ 1422.77] pregistrypriv->channel=1, pdev_network->Configuration.DSConfig=0x1 [ 1422.78] R8188EU: [0x0800,8] [ 1422.78] -rtw_init_drv_sw [ 1422.78] R8188EU: rtw_macaddr_cfg MAC Address = 00:e0:4c:81:88:02 [ 1422.79] R8188EU: MAC Address from pnetdev->dev_addr = 00:e0:4c:81:88:02 [ 1422.82] R8188EU: bDriverStopped:1, bSurpriseRemoved:0, bup:0, hw_init_completed:0 [ 1422.83] R8188EU: [0x0010,5] [ 1422.83] -871x_drv - drv_init, success! [ 1474.84] R8188EU: [0x0010,8] [ 1474.84] cmd_code =8b01 [ 1474.84] R8188EU: [0x0010,8] [ 1474.84] rtw_wx_get_essid [ 1474.85] R8188EU: [0x0010,8] [ 1474.85] rtw_wx_get_mode [ 1474.85] R8188EU: [0x0010,8] [ 1474.86] rtw_wx_get_range. cmd_code =8b0b [ 1474.86] R8188EU: [0x0010,8] [ 1474.86] rtw_wx_get_wap Thanks in advanced... --luis -- Luis Soltero, Ph.D., MCS Director of Software Development, CTO Global Marine Networks, LLC StarPilot, LLC Tel: +1.865.379.8723 Fax: +1.865.681.5017 E-Mail: lsolt...@globalmarinenet.net Web: http://www.globalmarinenet.net Web: http://www.redportglobal.com Web: http://www.starpilotllc.com ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] willing to donate a MTK MT7620A/MT7610E-based router to anyone who wants to work on one
Hello Rday, you might check with the folks at asiarf.com. We buy and use several MT7620A and N routers from them. They all run CC fine. Note that the DTS files for their eval boards are supported under the latest CC trunk. Also note that you may need to modify the stock DTS files to support additional IO functionality. Good luck. --luis On 11/21/14 8:27 AM, Robert P. J. Day wrote: [apologies for sending to both lists, i wanted to make sure i caught everyone who might be interested; feel free to delete either recipient when replying.] following up on my earlier pleas for help with getting openwrt onto *any* kind of mediatek-based router or eval board, i'm more than happy to buy anything appropriate and donate it to someone who's in a position to get openwrt onto it. my latest attempt was with a d-link DIR-810L, for which it appeared someone had installed openwrt somehow, but i was unable to do it through the original GUI, and ripping it apart and connecting to the serial port did not give a reliable console port -- partial garbage, even though one could see valid output in the midst of all the garbage. (we tried every combination of baud rate, parity and so on.) so, in short, i have yet to track down either an eval board or commercial router that incorporates the MT7620A SoC and MT7610E 5G radio chip and on which i can install openwrt that i build myself. bonus points if such a thing has a PCIe slot for a broadband modem, that would be delightful. if you can help and want a free modem/eval board out of it, i'm more than happy to supply one in return for instructions on how to do this. rday p.s. if you're an openwrt hacker in the Ottawa area, that would be cool, too, let me know. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel -- Luis Soltero, Ph.D., MCS Director of Software Development, CTO Global Marine Networks, LLC StarPilot, LLC Tel: +1.865.379.8723 Fax: +1.865.681.5017 E-Mail: lsolt...@globalmarinenet.net Web: http://www.globalmarinenet.net Web: http://www.redportglobal.com Web: http://www.starpilotllc.com ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] DIR-657 - D-Link HD Media Router 1000
We are currently using TP-Link WDR 3600 with USB SD drives but would
like to move to an internal drive which is why we have made this
inquiry.
Thanks for your suggestion... We will keep looking.
--luis
On 9/15/14, 3:57 PM, Luis E. Garcia
wrote:
You might be able to get by with the WD MyNet N750.
It has most of the requirements except the Built-in SD -
but instead you get 2 USB ports.
You could use the extra USB with an SD Reader.
Luis G.
On Mon, Sep 15, 2014 at 2:42 PM, Luis
Soltero <lsolt...@globalmarinenet.com>
wrote:
Hello All,
It would be nice to get Ubicom support into OpenWRT.
However.. our specific requirements is for any router that
meets the specifications listed below.
128+M RAM
16+M Flash
Built-in SD card
1+ USB
4 LAN
1 WAN
2.4Ghz WiFi
5.2Ghz WiFi
12V
Any recommendations would greatly appreciated. If
no router meeting this specs is available then we will
need to build one (probably using an MT7620a) although
would really rather not go down this road.
Suggestions are greatly appreciated.
--luis
On 9/15/14, 3:11 PM, Luis E. Garcia wrote:
Ubicom support was removed a while
back.
That specific router is using a Ubicom IP7K
chip.
Within DLinks opensource files for this
router there is a OpenWRT code base but I don't
how old or what version it is.
I have a small pet project to port OpenWRT to
Ubicom but the more recent IP8K chpset.
Luis Garcia
On Mon, Sep 15, 2014 at
1:36 PM, Luis Soltero <lsolt...@globalmarinenet.com>
wrote:
Hello All,
Looking for a router recommendation and
wondering is someone might be able to help.
The D-Link DIR-657 looks perfect but I don't
see any support for this in OpenWRT. Anyone
working on a port to the
D-Link Media Routers?
Looking for the following
128+M RAM
16+M Flash
Built-in SD card
1+ USB
4 LAN
1 WAN
2.4Ghz WiFi
5.2Ghz WiFi
12V
The built-in SD card support is critical.
I appreciate any leads.
Thanks,
--luis
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.
Re: [OpenWrt-Devel] DIR-657 - D-Link HD Media Router 1000
Hello All,
It would be nice to get Ubicom support into OpenWRT. However.. our
specific requirements is for any router that meets the
specifications listed below.
128+M RAM
16+M Flash
Built-in SD card
1+ USB
4 LAN
1 WAN
2.4Ghz WiFi
5.2Ghz WiFi
12V
Any recommendations would greatly appreciated. If no router meeting
this specs is available then we will need to build one (probably
using an MT7620a) although would really rather not go down this
road.
Suggestions are greatly appreciated.
--luis
On 9/15/14, 3:11 PM, Luis E. Garcia
wrote:
Ubicom support was removed a while back.
That specific router is using a Ubicom IP7K chip.
Within DLinks opensource files for this router there is a
OpenWRT code base but I don't how old or what version it is.
I have a small pet project to port OpenWRT to Ubicom but
the more recent IP8K chpset.
Luis Garcia
On Mon, Sep 15, 2014 at 1:36 PM, Luis
Soltero <lsolt...@globalmarinenet.com>
wrote:
Hello All,
Looking for a router recommendation and wondering is someone
might be able to help.
The D-Link DIR-657 looks perfect but I don't see any support
for this in OpenWRT. Anyone working on a port to the
D-Link Media Routers?
Looking for the following
128+M RAM
16+M Flash
Built-in SD card
1+ USB
4 LAN
1 WAN
2.4Ghz WiFi
5.2Ghz WiFi
12V
The built-in SD card support is critical.
I appreciate any leads.
Thanks,
--luis
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] DIR-657 - D-Link HD Media Router 1000
Hello All, Looking for a router recommendation and wondering is someone might be able to help. The D-Link DIR-657 looks perfect but I don't see any support for this in OpenWRT. Anyone working on a port to the D-Link Media Routers? Looking for the following 128+M RAM 16+M Flash Built-in SD card 1+ USB 4 LAN 1 WAN 2.4Ghz WiFi 5.2Ghz WiFi 12V The built-in SD card support is critical. I appreciate any leads. Thanks, --luis -- Luis Soltero, Ph.D., MCS Director of Software Development, CTO Global Marine Networks, LLC StarPilot, LLC Tel: +1.865.379.8723 Fax: +1.865.681.5017 E-Mail: lsolt...@globalmarinenet.net Web: http://www.globalmarinenet.net Web: http://www.redportglobal.com Web: http://www.starpilotllc.com ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] compatible = "ralink,mt7620a-spi", "ralink,rt2880-spi";
#address-cells =
<1>;
#size-cells =
<1>;
status =
"disabled";
pinctrl-names =
"default";
pinctrl-0 =
<&spi_pins>;
};
works for me.
my second spi device is configured correctly.
Thanks,
--luis
On 9/1/14, 11:03 AM, John Crispin wrote
> Hi Luis,
>
> i am planning to look at this during the week as i need to fix up spi
> support for mt7628 anyhow. i will look at this at the same time
>
> John
>
>
>
> On 01/09/2014 16:51, Luis Soltero wrote:
>> Hello John,
>>
>> OK. thanks for our comments. So... is it worth pursuing this to
>> get it right or is it so wrong that we should just forget it and
>> retract the whole thing? Your mesg is unclear. Let me know what
>> you want me to do.
>>
>> Thanks,
>>
>> --luis
>>
>> On 9/1/14, 2:25 AM, John Crispin wrote:
>>> Hi,
>>>
>>> that patch subject is utterly wrong. the real desc would be
>>>
>>> "add support for the 2nd CS line on mt7620a and add a special
>>> device_id for this."
>>>
>>> however, as you only register the CS with the spi driver and are
>>> missing the actuall /cs1 mux init, this patch is wrong/incomplete
>>> as it relies on the bootloader to have setup the cs line already
>>> and has a misleading desription.
>>>
>>> John
>>>
>>> On 31/08/2014 22:55, Luis Soltero wrote:
>>>> Hello All,
>>>>
>>>> the mt7620a.dtsi makes reference to mt7620a-spi but this node
>>>> does not exist in spi.c. The following patch address this.
>>>>
>>>> here is the entry in the dts file... spi@b00 {
>>>>
>>>>
>>>> compatible = "ralink,mt7620a-spi", "ralink,rt2880-spi";
>>>>
>>>>
>>>> reg = <0xb00 0x100>;
>>>>
>>>>
>>>>
>>>>
>>>> resets = <&rstctrl 18>;
>>>>
>>>>
>>>> reset-names = "spi";
>>>>
>>>>
>>>>
>>>>
>>>> #address-cells = <1>;
>>>>
>>>>
>>>> #size-cells = <1>;
>>>>
>>>>
>>>>
>>>>
>>>> status = "disabled";
>>>>
>>>>
>>>>
>>>>
>>>> pinctrl-names = "default";
>>>>
>>>>
>>>> pinctrl-0 = <&spi_pins>;
>>>>
>>>>
>>>> };
>>>>
>>>>
>>>> the following mus be added to the DTS file to use it.
>>>>
>>>> spi@b00 {
>>>>
>>>>
>>>> status = "okay";
>>>>
>>>>
>>>> num-cs = <2>;
>>>>
>>>>
>>>> m25p80@0 { snip
>>>>
>>>> here is the patch.
>>>>
>>>> --luis
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> ___ openwrt-devel
>>>> mailing list openwrt-devel@lists.openwrt.org
>>>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>>>>
> ___
>>> openwrt-devel mailing list openwrt-devel@lists.openwrt.org
>>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>>>
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] compatible = "ralink,mt7620a-spi", "ralink,rt2880-spi";
Hello John,
OK. thanks for our comments. So... is it worth pursuing this to get it right
or is it so wrong that we should just
forget it and retract the whole thing? Your mesg is unclear. Let me know what
you want me to do.
Thanks,
--luis
On 9/1/14, 2:25 AM, John Crispin wrote:
> Hi,
>
> that patch subject is utterly wrong. the real desc would be
>
> "add support for the 2nd CS line on mt7620a and add a special
> device_id for this."
>
> however, as you only register the CS with the spi driver and are
> missing the actuall /cs1 mux init, this patch is wrong/incomplete as
> it relies on the bootloader to have setup the cs line already and has
> a misleading desription.
>
> John
>
> On 31/08/2014 22:55, Luis Soltero wrote:
>> Hello All,
>>
>> the mt7620a.dtsi makes reference to mt7620a-spi but this node does
>> not exist in spi.c. The following patch address this.
>>
>> here is the entry in the dts file... spi@b00 {
>>
>>
>> compatible = "ralink,mt7620a-spi", "ralink,rt2880-spi";
>>
>>
>> reg = <0xb00 0x100>;
>>
>>
>>
>>
>> resets = <&rstctrl 18>;
>>
>>
>> reset-names = "spi";
>>
>>
>>
>>
>> #address-cells = <1>;
>>
>>
>> #size-cells = <1>;
>>
>>
>>
>>
>> status = "disabled";
>>
>>
>>
>>
>> pinctrl-names = "default";
>>
>>
>> pinctrl-0 = <&spi_pins>;
>>
>>
>> };
>>
>>
>> the following mus be added to the DTS file to use it.
>>
>> spi@b00 {
>>
>>
>> status = "okay";
>>
>>
>> num-cs = <2>;
>>
>>
>> m25p80@0 { snip
>>
>> here is the patch.
>>
>> --luis
>>
>>
>>
>>
>>
>>
>> ___ openwrt-devel
>> mailing list openwrt-devel@lists.openwrt.org
>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>>
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] compatible = "ralink,mt7620a-spi", "ralink,rt2880-spi";
Hello All,
the mt7620a.dtsi makes reference to mt7620a-spi but this node does not exist in
spi.c. The following patch address this.
here is the entry in the dts file...
spi@b00
{
compatible = "ralink,mt7620a-spi",
"ralink,rt2880-spi";
reg = <0xb00
0x100>;
resets = <&rstctrl
18>;
reset-names =
"spi";
#address-cells =
<1>;
#size-cells =
<1>;
status =
"disabled";
pinctrl-names =
"default";
pinctrl-0 =
<&spi_pins>;
};
the following mus be added to the DTS file to use it.
spi@b00
{
status =
"okay";
num-cs =
<2>;
m25p80@0 {
snip
here is the patch.
--luis
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
>From 9d18142f0d91e50f0e2249ee4b42ad9da19f186a Mon Sep 17 00:00:00 2001
From: Luis Soltero
Date: Sun, 31 Aug 2014 13:50:32 -0700
Subject: [PATCH] the mt7620a.dtsi makes reference to mt7620a-spi but this
node does not exist in spi.c. The following patch address
this.
here is the entry in the dts file...
spi@b00 {
compatible = "ralink,mt7620a-spi", "ralink,rt2880-spi";
reg = <0xb00 0x100>;
resets = <&rstctrl 18>;
reset-names = "spi";
#address-cells = <1>;
#size-cells = <1>;
status = "disabled";
pinctrl-names = "default";
pinctrl-0 = <&spi_pins>;
};
the following mus be added to the DTS file to use it.
spi@b00 {
status = "okay";
Re: [OpenWrt-Devel] mt7620a serial port driver ordering of nodes uart/uartlite vs ttyS0/ttyS1 patch
Title: The Device Tree: Plug and play for Embedded Linux
this...
aliases
{&
nbsp;&nbs
p;
serial0 =
"/palmbus@1000/uartlite@c00";
};
&nb
sp;
chosen
{&
nbsp;&nbs
p;
bootargs =
"console=ttyS0,57600";
linux,stdout-path =
"/palmbus@1000/uartlite@c00";
};
did not work..
[ 0.34] msgmni has been set to 247
[ 0.35] io scheduler noop registered
[ 0.35] io scheduler deadline registered (default)
[ 0.36] Serial: 8250/16550 driver, 2 ports, IRQ sharing
disabled
[ 0.38] 1500.uart: ttyS0 at MMIO 0x1500 (irq = 13) is
a 16550A
[ 0.39] console [ttyS0] enabled, bootconsole disabled
uart and not uartlite was assigned to /dev/ttyS0
--luis
On 8/30/14, 7:30 AM, Luis Soltero
wrote:
If i am understanding correctly this something added to chosen to
bind the console to a specific uart... as in
/dts-v1/; /{
#address-cells = <1>; #size-cells = <1>;
compatible = "xlnx,zynq-zed"; interrupt-parent = <&gic>;
model = "Xillinux for Zedboard";
aliases {
serial0 = &ps7_uart_1;
};
chosen {
bootargs = "consoleblank=0 root=/dev/mmcblk0p2 rw rootwait
earlyprintk";
linux,stdout-path = "/axi@0/uart@E0001000";
};
but does not solve the problem of binding a specific uart to a
node name. i.e. uartline ==> /dev/ttyS0 and uart ==>
/dev/ttyS1
interestingly the aliases {} in this example catches my
attention. maybe the ordering is handled by aliases{}?
hm... maybe some experimentation is in order here.
--luis
On 8/30/14, 6:07 AM, John Crispin
wrote:
apparently our problem is not new and the existing solution is the
"linux,stdout-path" syntax
so stdout-path = &uartf; should work (... maybe)
jonas just pointed this out to me
On 30/08/2014 11:37, Luis Soltero wrote:
hm... it still seems that the board integrator should be able to determine the node name for the device. Implementing a
scheme based on base address still hard wires the node name to the port and does not provide the flexibility of changing
it.Absolutely depending on the load order is quirky... however knowing that gives you some flexibility in the naming.
I think the real answer is to add a property that allows you to specify the order. Then you can order the devices
however you like.
i worry that implementing something on the base address is actually worse than what we currently have.
look forward to your thoughts.
--luis
On 8/30/14, 2:35 AM, John Crispin wrote:
Hi
On Lantiq we derive the port numbering from the base addr that gets
used for early printk. i will implement a similar solution for ralink.
having to rely on the load order seems quirky.
John
On 29/08/2014 23:56, Luis Soltero wrote:
Hello All,
Most mt7620a routers defined in the target/linux/ramips/dts have
exactly one serial port defined which is used for the console. The
serial port driver links this to node /dev/ttyS0.
However. one (and now 2) devices use the mt7620a serial port lines
for use as a second real serial port (uart@500 in the dts).
Currently when when more than one serial port is defined the boot
sequence starts with the console attached to uartlite but as soon
as the serial port driver driver is loaded it deactivates the
console and assigns it to /dev/ttyS1 (which is the node created for
uartlite). So on these systems using the standard dts
configuration the mt7620a enha
Re: [OpenWrt-Devel] mt7620a serial port driver ordering of nodes uart/uartlite vs ttyS0/ttyS1 patch
Title: The Device Tree: Plug and play for Embedded Linux
If i am understanding correctly this something added to chosen to
bind the console to a specific uart... as in
/dts-v1/; /{
#address-cells = <1>; #size-cells = <1>;
compatible = "xlnx,zynq-zed"; interrupt-parent = <&gic>;
model = "Xillinux for Zedboard";
aliases {
serial0 = &ps7_uart_1;
};
chosen {
bootargs = "consoleblank=0 root=/dev/mmcblk0p2 rw rootwait
earlyprintk";
linux,stdout-path = "/axi@0/uart@E0001000";
};
but does not solve the problem of binding a specific uart to a node
name. i.e. uartline ==> /dev/ttyS0 and uart ==> /dev/ttyS1
interestingly the aliases {} in this example catches my attention.
maybe the ordering is handled by aliases{}?
hm... maybe some experimentation is in order here.
--luis
On 8/30/14, 6:07 AM, John Crispin
wrote:
apparently our problem is not new and the existing solution is the
"linux,stdout-path" syntax
so stdout-path = &uartf; should work (... maybe)
jonas just pointed this out to me
On 30/08/2014 11:37, Luis Soltero wrote:
hm... it still seems that the board integrator should be able to determine the node name for the device. Implementing a
scheme based on base address still hard wires the node name to the port and does not provide the flexibility of changing
it.Absolutely depending on the load order is quirky... however knowing that gives you some flexibility in the naming.
I think the real answer is to add a property that allows you to specify the order. Then you can order the devices
however you like.
i worry that implementing something on the base address is actually worse than what we currently have.
look forward to your thoughts.
--luis
On 8/30/14, 2:35 AM, John Crispin wrote:
Hi
On Lantiq we derive the port numbering from the base addr that gets
used for early printk. i will implement a similar solution for ralink.
having to rely on the load order seems quirky.
John
On 29/08/2014 23:56, Luis Soltero wrote:
Hello All,
Most mt7620a routers defined in the target/linux/ramips/dts have
exactly one serial port defined which is used for the console. The
serial port driver links this to node /dev/ttyS0.
However. one (and now 2) devices use the mt7620a serial port lines
for use as a second real serial port (uart@500 in the dts).
Currently when when more than one serial port is defined the boot
sequence starts with the console attached to uartlite but as soon
as the serial port driver driver is loaded it deactivates the
console and assigns it to /dev/ttyS1 (which is the node created for
uartlite). So on these systems using the standard dts
configuration the mt7620a enhanced uart is bound to /dev/ttyS0 and
uartlite is bound /dev/ttyS1.
This causes the console serial port to stop displaying output
unless the following is added to the dts definition
chosen { bootargs = "console=ttyS1,57600"; };
which redefines the console to /dev/ttyS1... this configuration
works fine. However some (including me) find this very
irritating. These few routers defining a second serial port differ
from all the others in their definition of /dev/ttyS0 as the
console.
So... for consistency it seems that it would be much better for **
ALL ** routers regardless of the number of serial ports define
/dev/ttyS0 as the console port.
The reason for the renumbering is due to the serial port driver to
assign nodes on a first come first basis in the dts definition.
Since in mt7620a.dtsi (included by most/all 7620a router board
definitions) the definition for uart@500 is before that for
uartlite@00. So uart gets assigned /dev/ttyS0 while uartlite gets
/dev/ttyS1. You can't fault the serial driver for doing it. After
all it really doesn't know for what purpose the serial port is to
be used.
A logical extension to the serial port dts properties would be to
add a "node-name" or "node-order" or "node-number" property that
would allow the integrator to specify the node number or the node
name for the serial port. However these properties don't exist (or
at least they were not obvious in either the source code or the
documentation). So... a simple "fix" for the ordering is to
reorder the definitions in mt7620a.dtsi.
This reordering affects exactly one mt7620a router in the dts
definitions as of r42293 (NA930.dts).
Attached you will find a patch which modifies both mt7620a.dtsi and
NA930.dts assigning the console to /dev/ttyS0 for devices with more
than one serial port.
Note that a similar issue applies to the RT5350. Although we are
currently not working with that architecture I am happy to supply a
patch if the commu
Re: [OpenWrt-Devel] mt7620a serial port driver ordering of nodes uart/uartlite vs ttyS0/ttyS1 patch
hm... it still seems that the board integrator should be able to determine the
node name for the device. Implementing a
scheme based on base address still hard wires the node name to the port and
does not provide the flexibility of changing
it.Absolutely depending on the load order is quirky... however knowing that
gives you some flexibility in the naming.
I think the real answer is to add a property that allows you to specify the
order. Then you can order the devices
however you like.
i worry that implementing something on the base address is actually worse than
what we currently have.
look forward to your thoughts.
--luis
On 8/30/14, 2:35 AM, John Crispin wrote:
> Hi
>
> On Lantiq we derive the port numbering from the base addr that gets
> used for early printk. i will implement a similar solution for ralink.
> having to rely on the load order seems quirky.
>
> John
>
> On 29/08/2014 23:56, Luis Soltero wrote:
>> Hello All,
>>
>> Most mt7620a routers defined in the target/linux/ramips/dts have
>> exactly one serial port defined which is used for the console. The
>> serial port driver links this to node /dev/ttyS0.
>>
>> However. one (and now 2) devices use the mt7620a serial port lines
>> for use as a second real serial port (uart@500 in the dts).
>> Currently when when more than one serial port is defined the boot
>> sequence starts with the console attached to uartlite but as soon
>> as the serial port driver driver is loaded it deactivates the
>> console and assigns it to /dev/ttyS1 (which is the node created for
>> uartlite). So on these systems using the standard dts
>> configuration the mt7620a enhanced uart is bound to /dev/ttyS0 and
>> uartlite is bound /dev/ttyS1.
>>
>> This causes the console serial port to stop displaying output
>> unless the following is added to the dts definition
>>
>> chosen { bootargs = "console=ttyS1,57600"; };
>>
>> which redefines the console to /dev/ttyS1... this configuration
>> works fine. However some (including me) find this very
>> irritating. These few routers defining a second serial port differ
>> from all the others in their definition of /dev/ttyS0 as the
>> console.
>>
>> So... for consistency it seems that it would be much better for **
>> ALL ** routers regardless of the number of serial ports define
>> /dev/ttyS0 as the console port.
>>
>> The reason for the renumbering is due to the serial port driver to
>> assign nodes on a first come first basis in the dts definition.
>> Since in mt7620a.dtsi (included by most/all 7620a router board
>> definitions) the definition for uart@500 is before that for
>> uartlite@00. So uart gets assigned /dev/ttyS0 while uartlite gets
>> /dev/ttyS1. You can't fault the serial driver for doing it. After
>> all it really doesn't know for what purpose the serial port is to
>> be used.
>>
>> A logical extension to the serial port dts properties would be to
>> add a "node-name" or "node-order" or "node-number" property that
>> would allow the integrator to specify the node number or the node
>> name for the serial port. However these properties don't exist (or
>> at least they were not obvious in either the source code or the
>> documentation). So... a simple "fix" for the ordering is to
>> reorder the definitions in mt7620a.dtsi.
>>
>> This reordering affects exactly one mt7620a router in the dts
>> definitions as of r42293 (NA930.dts).
>>
>> Attached you will find a patch which modifies both mt7620a.dtsi and
>> NA930.dts assigning the console to /dev/ttyS0 for devices with more
>> than one serial port.
>>
>> Note that a similar issue applies to the RT5350. Although we are
>> currently not working with that architecture I am happy to supply a
>> patch if the community would like one.
>>
>> here is a snippet from the boot log of our mt7620a board showing a
>> console happily bound to /dev/ttyS0 and the second serial port
>> bound to /dev/ttyS1
>>
>> [0.35] Serial: 8250/16550 driver, 2 ports, IRQ sharing
>> disabled [0.37] 1c00.uartlite: ttyS0 at MMIO 0x1c00
>> (irq = 20) is a 16550A [0.38] console [ttyS0] enabled,
>> bootconsole disabled [0.38] console [ttyS0] enabled,
>> bootconsole disabled [0.41] 1500.uart: ttyS1 at MMIO
>> 0x1500 (irq = 13) is a 16550A
>>
>>
>> --luis
>>
>>
>>
>>
>> ___ openwrt-devel
>> mailing list openwrt-devel@lists.
[OpenWrt-Devel] mt7620a serial port driver ordering of nodes uart/uartlite vs ttyS0/ttyS1 patch
Hello All,
Most mt7620a routers defined in the target/linux/ramips/dts have exactly one
serial port defined which is used for the
console. The serial port driver links this to node /dev/ttyS0.
However. one (and now 2) devices use the mt7620a serial port lines for use as
a second real serial port (uart@500 in
the dts). Currently when when more than one serial port is defined the boot
sequence starts with the console attached
to uartlite but as soon as the serial port driver driver is loaded it
deactivates the console and assigns it to
/dev/ttyS1 (which is the node created for uartlite). So on these systems using
the standard dts configuration the
mt7620a enhanced uart is bound to /dev/ttyS0 and uartlite is bound /dev/ttyS1.
This causes the console serial port to stop displaying output unless the
following is added to the dts definition
chosen {
bootargs = "console=ttyS1,57600";
};
which redefines the console to /dev/ttyS1... this configuration works fine.
However some (including me) find this very
irritating. These few routers defining a second serial port differ from all
the others in their definition of
/dev/ttyS0 as the console.
So... for consistency it seems that it would be much better for ** ALL **
routers regardless of the number of serial
ports define /dev/ttyS0 as the console port.
The reason for the renumbering is due to the serial port driver to assign nodes
on a first come first basis in the dts
definition. Since in mt7620a.dtsi (included by most/all 7620a router board
definitions) the definition for uart@500 is
before that for uartlite@00. So uart gets assigned /dev/ttyS0 while uartlite
gets /dev/ttyS1. You can't fault the
serial driver for doing it. After all it really doesn't know for what purpose
the serial port is to be used.
A logical extension to the serial port dts properties would be to add a
"node-name" or "node-order" or "node-number"
property that would allow the integrator to specify the node number or the node
name for the serial port. However these
properties don't exist (or at least they were not obvious in either the source
code or the documentation). So... a
simple "fix" for the ordering is to reorder the definitions in mt7620a.dtsi.
This reordering affects exactly one mt7620a router in the dts definitions as of
r42293 (NA930.dts).
Attached you will find a patch which modifies both mt7620a.dtsi and NA930.dts
assigning the console to /dev/ttyS0 for
devices with more than one serial port.
Note that a similar issue applies to the RT5350. Although we are currently not
working with that architecture I am
happy to supply a patch if the community would like one.
here is a snippet from the boot log of our mt7620a board showing a console
happily bound to /dev/ttyS0 and the second
serial port bound to /dev/ttyS1
[0.35] Serial: 8250/16550 driver, 2 ports, IRQ sharing disabled
[0.37] 1c00.uartlite: ttyS0 at MMIO 0x1c00 (irq = 20) is a
16550A
[0.38] console [ttyS0] enabled, bootconsole disabled
[0.38] console [ttyS0] enabled, bootconsole disabled
[0.41] 1500.uart: ttyS1 at MMIO 0x1500 (irq = 13) is a 16550A
--luis
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
diff --git a/target/linux/ramips/dts/NA930.dts
b/target/linux/ramips/dts/NA930.dts
index 6fe9964..ca25beb 100644
--- a/target/linux/ramips/dts/NA930.dts
+++ b/target/linux/ramips/dts/NA930.dts
@@ -7,7 +7,7 @@
model = "Sercomm NA930";
chosen {
- bootargs = "console=ttyS1,57600";
+ bootargs = "console=ttyS0,57600";
};
pinctrl {
diff --git a/target/linux/ramips/dts/mt7620a.dtsi
b/target/linux/ramips/dts/mt7620a.dtsi
index 9d077ee..669d69c 100644
--- a/target/linux/ramips/dts/mt7620a.dtsi
+++ b/target/linux/ramips/dts/mt7620a.dtsi
@@ -77,6 +77,22 @@
interrupts = <3>;
};
+ uartlite@c00 {
+ compatible = "ralink,mt7620a-uart",
"ralink,rt2880-uart", "ns16550a";
+ reg = <0xc00 0x100>;
+
+ resets = <&rstctrl 19>;
+ reset-names = "uartl";
+
+ interrupt-parent = <&intc>;
+ interrupts = <12>;
+
+ reg-shift = <2>;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&uartlite_pins>;
+ };
+
uart@500 {
[OpenWrt-Devel] GPIO Keys and LED definitions for AsiaRF mt7620a AWV002-001 Rev .1
default
{
ralink,group = "i2c", "uartf",
"ephy",
"wled";
ralink,function =
"gpio";
};
};
&nb
sp;
};
Can some kind person help. I am sure its a simple DTS
misconfiguration.
Thanks,
--luis
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] AsiaRF MT7620a mounting sdhci drive readonly
hello John,
the following patch fixes the write protect issue on the AsiaRF FXS
board (AWV002-001 REV .1)
so the "broken-wp" patch is not required to mount the drive rw once
the pin is grounded.
Not sure if you want to include the broken-wp patch or not in the CC
distribution. It might be useful to others...
Here is hoping you didn't waste too much time on this.
--luis
On 8/24/14, 2:46 AM, Luis Soltero
wrote:
hello john,
thanks for looking into this... just so that you know I forced is_readonly = 0
in sdhci.c as in ...
static int sdhci_check_ro(struct sdhci_host *host)
{
unsigned long flags;
int is_readonly;
spin_lock_irqsave(&host->lock, flags);
if (host->flags & SDHCI_DEVICE_DEAD)
is_readonly = 0;
else if (host->quirks2 & SDHCI_QUIRK2_BROKEN_WRITE_PROTECT)
is_readonly = 0;
else if (host->ops->get_ro)
is_readonly = host->ops->get_ro(host);
else
is_readonly = !(sdhci_readl(host, SDHCI_PRESENT_STATE)
& SDHCI_WRITE_PROTECT);
is_readonly = 0;
spin_unlock_irqrestore(&host->lock, flags);
return 0;
and yet...
root@Optimizer:~# e2fsck /dev/mmcblk0p2
e2fsck 1.42.4 (12-June-2012)
e2fsck: Read-only file system while trying to open /dev/mmcblk0p2
Disk write-protected; use the -n option to do a read-only
check of the device.
so unsure at this time why the driver thinks that this is a read only file system.
look forward to your findings.
--luis
On 8/24/14, 2:07 AM, John Crispin wrote:
Hi Luis,
i have a awm0003 on my desk and will have a look during the week.
John
On 23/08/2014 23:26, Luis Soltero wrote:
Hello All,
Been trying to get an AsiaRF based MT7620a board running using CC
r42230 and having issue getting the MMC SD card reader to mount
rw.
I have been in communication with the manufacturer to discover the
GPIO (if any) used for the WP line for the SDHCI card reader on the
board. They have not gotten back to me. In the mean time I have
attempted to use some of the mmc driver properties such as
wp-inverted to no avail. In desperation I implemented a patch
based on http://permalink.gmane.org/gmane.linux.kernel.mmc/25615
which tells the driver to ignore the write protect line and assume
r/w always... yet the card still mounts read only. note that when
mounting the same SD card using a USB based reader the file system
mounts rw as expected.
here is the mount table showing the ro mount
root@OpenWRT:~# mount rootfs on / type rootfs (rw) snip...
/dev/mmcblk0p2 on /wxa type ext4 (ro,relatime,data=""
here is the DTS definition for the board
sdhci@1013 { status = "okay"; broken-wp; };
following is the patch (some of you might find it useful). Any
thoughts would greatly be appreciated.
$ cat
target/linux/ramips/patches-3.10/0402-mmc-add-broken-wp.patch ---
a/Documentation/devicetree/bindings/mmc/mmc.txt2014-08-23
12:39:54.816004290 -0700 +++
b/Documentation/devicetree/bindings/mmc/mmc.txt2014-08-23
12:40:56.574123135 -0700 @@ -21,6 +21,8 @@ below for the case, when
a GPIO is used for the CD line - wp-inverted: when present,
polarity on the WP line is inverted. See the note below for the
case, when a GPIO is used for the WP line +- broken-wp: when
present, no indication of write protection is available, + and
write protection is assumed always off. - max-frequency: maximum
operating clock frequency - no-1-8-v: when present, denotes that
1.8v card voltage is not supported on this system, even if the
controller claims it is. --- a/drivers/mmc/host/sdhci-pltfm.c
2014-08-23 12:44:02.648454500 -0700 +++
b/drivers/mmc/host/sdhci-pltfm.c2014-08-23 12:45:52.009124011
-0700 @@ -80,7 +80,9 @@ bus_width == 1)) host->quirks |=
SDHCI_QUIRK_FORCE_1_BIT_DATA;
-if (sdhci_of_wp_inverted(np)) +if
(of_get_property(np, "sdhci,broken-wp", NULL) ||
of_get_property(np, "broken-wp", NULL)) +host->quirks2
|= SDHCI_QUIRK2_BROKEN_WRITE_PROTECT; +else if
(sdhci_of_wp_inverted(np)) host->quirks |=
SDHCI_QUIRK_INVERTED_WRITE_PROTECT;
if (of_get_property(np, "broken-cd", NULL)) ---
a/drivers/mmc/host/sdhci.c2014-08-23 12:46:10.028575138 -0700
+++ b/drivers/mmc/host/sdhci.c2014-08-23 12:48:23.588506665
-0700 @@ -1621,6 +1621,8 @@
if (host->flags & SDHCI_DEVICE_DEAD) is_readonly = 0; +else if
(host->quirks2 & SDHCI_QUIRK2_BROKEN_WRITE_PROTECT) +
is_readonly = 0; else if (host->ops->get_ro) is_readonly =
host->ops->get_ro(host); else --- a/include/linux/mmc/sdhci.h
2014-08-23 12:56:38.005445877 -0700 +++ b/include/linux/mmc/sdhci.h
2014-08-23 12:58:58.113178602 -0700 @@ -9
Re: [OpenWrt-Devel] Add Ralink RT3XXX USB OHCI driver
OK. seems to work... driver loaded with out issue. [1.03] rt3xxx-usbphy usbphy.3: loaded [6.18] usbcore: registered new interface driver usbfs [6.20] usbcore: registered new interface driver hub [6.21] usbcore: registered new device driver usb [6.27] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver [6.49] rt3xxx-usbphy usbphy.3: remote usb device wakeup disabled [6.51] rt3xxx-usbphy usbphy.3: UTMI 16bit 30MHz [6.53] ehci-platform 101c.ehci: new USB bus registered, assigned bus number 1 [6.58] ehci-platform 101c.ehci: USB 2.0 started, EHCI 1.00 [6.59] usb usb1: no of_node; not parsing pinctrl DT [6.59] hub 1-0:1.0: USB hub found [6.62] ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver [6.64] ohci-platform 101c1000.ohci: new USB bus registered, assigned bus number 2 [6.73] usb usb2: no of_node; not parsing pinctrl DT [6.73] hub 2-0:1.0: USB hub found here are a few OCHI devices that are recognized without proble. root@Optimizer:~# [ 281.29] usb 1-1: USB disconnect, device number 4 [ 287.74] usb 2-1: new full-speed USB device number 3 using ohci-platform [ 287.97] pl2303 2-1:1.0: pl2303 converter detected [ 288.01] usb 2-1: pl2303 converter now attached to ttyUSB0 root@Optimizer:~# [ 361.07] usb 2-1: new full-speed USB device number 4 using ohci-platform [ 361.30] hub 2-1:1.0: USB hub found [ 361.31] hub 2-1:1.0: 4 ports detected [ 397.72] usb 2-1.2: new full-speed USB device number 5 using ohci-platform [ 397.84] usb 2-1.2: not running at top speed; connect to a high speed hub [ 397.89] usb-storage 2-1.2:1.0: USB Mass Storage device detected [ 397.90] scsi2 : usb-storage 2-1.2:1.0 [ 399.55] scsi 2:0:0:0: Direct-Access USB Flash DISK 1100 PQ: 0 ANSI: 4 [ 399.57] sd 2:0:0:0: Attached scsi generic sg0 type 0 [ 399.59] sd 2:0:0:0: [sdc] 31703040 512-byte logical blocks: (16.2 GB/15.1 GiB) [ 399.61] sd 2:0:0:0: [sdc] Write Protect is off [ 399.62] sd 2:0:0:0: [sdc] No Caching mode page found [ 399.63] sd 2:0:0:0: [sdc] Assuming drive cache: write through [ 399.68] sd 2:0:0:0: [sdc] No Caching mode page found [ 399.69] sd 2:0:0:0: [sdc] Assuming drive cache: write through [ 399.71] sdc: sdc1 sdc2 [ 399.75] sd 2:0:0:0: [sdc] No Caching mode page found [ 399.76] sd 2:0:0:0: [sdc] Assuming drive cache: write through [ 399.78] sd 2:0:0:0: [sdc] Attached SCSI removable disk [ 400.25] Adding 499692k swap on /dev/sdc1. Priority:-3 extents:1 across:499692k [ 400.77] EXT4-fs (sdc2): mounted filesystem with ordered data mode. Opts: reads/writes occur to the drive without error... So... it looks like its fixed. I will do more testing but it seems that this fix addresses defect #14516 https://dev.openwrt.org/ticket/14516 Thank you. --luis On 8/25/14, 2:22 PM, John Crispin wrote: > Hi > > the phy init was missing the bit for the ohci root port. i pushed a > patch to fix this, please retest. > > John > > > On 22/08/2014 06:30, Luis Soltero wrote: >> Hello All, >> >> I has anything happened as far as the MT7620x OHCI USB driver >> issue? The last posted patch for this >> >> From ffb27de4760595c356ef619c97f25722c8db28e7 Mon Sep 17 00:00:00 >> 2001 From: John Crispin Date: Sun, 27 Jul 2014 >> 09:49:07 +0100 Subject: [PATCH 38/57] USB: add OHCI/EHCI OF >> binding >> >> based on f3bc64d6d1f21c1b92d75f233a37b75d77af6963 >> >> Signed-off-by: John Crispin >> >> does not address the issue described here >> https://dev.openwrt.org/ticket/14516 >> >> I have a two different boards MT7620A boards from AsiaRF that I can >> use for testing if someone can provide guidance. One of the has >> one USB port and the other board has a built in Alcor USB hub. >> >> Thanks, >> >> --luis >> >> >> John Crispin >> <http://search.gmane.org/?author=John+Crispin&sort=date> | 31 Jul >> 13:39 2014 >> >> >> Re: [PATCH]ramips: Add Ralink RT3XXX USB OHCI driver >> >> Hi, >> >> no, we wont take this patch. i will instead figure out what is >> wrong with the existing code and fix it. >> >> John >> >> >> -- >> >> >> Luis Soltero, Ph.D., MCS Director of Software Development, CTO >> Global Marine Networks, LLC StarPilot, LLC Tel: +1.865.379.8723 >> Fax: +1.865.681.5017 E-Mail: lsolt...@globalmarinenet.net Web: >> http://www.globalmarinenet.net Web: http://www.redportglobal.com >> Web: http://www.starpilotllc.com >> >> >> >> _______ openwrt-de
Re: [OpenWrt-Devel] AsiaRF MT7620a mounting sdhci drive readonly
hello john,
thanks for looking into this... just so that you know I forced is_readonly = 0
in sdhci.c as in ...
static int sdhci_check_ro(struct sdhci_host *host)
{
unsigned long flags;
int is_readonly;
spin_lock_irqsave(&host->lock, flags);
if (host->flags & SDHCI_DEVICE_DEAD)
is_readonly = 0;
else if (host->quirks2 & SDHCI_QUIRK2_BROKEN_WRITE_PROTECT)
is_readonly = 0;
else if (host->ops->get_ro)
is_readonly = host->ops->get_ro(host);
else
is_readonly = !(sdhci_readl(host, SDHCI_PRESENT_STATE)
& SDHCI_WRITE_PROTECT);
is_readonly = 0;
spin_unlock_irqrestore(&host->lock, flags);
return 0;
and yet...
root@Optimizer:~# e2fsck /dev/mmcblk0p2
e2fsck 1.42.4 (12-June-2012)
e2fsck: Read-only file system while trying to open /dev/mmcblk0p2
Disk write-protected; use the -n option to do a read-only
check of the device.
so unsure at this time why the driver thinks that this is a read only file
system.
look forward to your findings.
--luis
On 8/24/14, 2:07 AM, John Crispin wrote:
> Hi Luis,
>
> i have a awm0003 on my desk and will have a look during the week.
>
> John
>
> On 23/08/2014 23:26, Luis Soltero wrote:
>> Hello All,
>>
>> Been trying to get an AsiaRF based MT7620a board running using CC
>> r42230 and having issue getting the MMC SD card reader to mount
>> rw.
>>
>> I have been in communication with the manufacturer to discover the
>> GPIO (if any) used for the WP line for the SDHCI card reader on the
>> board. They have not gotten back to me. In the mean time I have
>> attempted to use some of the mmc driver properties such as
>> wp-inverted to no avail. In desperation I implemented a patch
>> based on http://permalink.gmane.org/gmane.linux.kernel.mmc/25615
>> which tells the driver to ignore the write protect line and assume
>> r/w always... yet the card still mounts read only. note that when
>> mounting the same SD card using a USB based reader the file system
>> mounts rw as expected.
>>
>> here is the mount table showing the ro mount
>>
>> root@OpenWRT:~# mount rootfs on / type rootfs (rw) snip...
>> /dev/mmcblk0p2 on /wxa type ext4 (ro,relatime,data=ordered)
>>
>>
>> here is the DTS definition for the board
>>
>> sdhci@1013 { status = "okay"; broken-wp; };
>>
>> following is the patch (some of you might find it useful). Any
>> thoughts would greatly be appreciated.
>>
>> $ cat
>> target/linux/ramips/patches-3.10/0402-mmc-add-broken-wp.patch ---
>> a/Documentation/devicetree/bindings/mmc/mmc.txt2014-08-23
>> 12:39:54.816004290 -0700 +++
>> b/Documentation/devicetree/bindings/mmc/mmc.txt2014-08-23
>> 12:40:56.574123135 -0700 @@ -21,6 +21,8 @@ below for the case, when
>> a GPIO is used for the CD line - wp-inverted: when present,
>> polarity on the WP line is inverted. See the note below for the
>> case, when a GPIO is used for the WP line +- broken-wp: when
>> present, no indication of write protection is available, + and
>> write protection is assumed always off. - max-frequency: maximum
>> operating clock frequency - no-1-8-v: when present, denotes that
>> 1.8v card voltage is not supported on this system, even if the
>> controller claims it is. --- a/drivers/mmc/host/sdhci-pltfm.c
>> 2014-08-23 12:44:02.648454500 -0700 +++
>> b/drivers/mmc/host/sdhci-pltfm.c2014-08-23 12:45:52.009124011
>> -0700 @@ -80,7 +80,9 @@ bus_width == 1)) host->quirks |=
>> SDHCI_QUIRK_FORCE_1_BIT_DATA;
>>
>> -if (sdhci_of_wp_inverted(np)) +if
>> (of_get_property(np, "sdhci,broken-wp", NULL) ||
>> of_get_property(np, "broken-wp", NULL)) +host->quirks2
>> |= SDHCI_QUIRK2_BROKEN_WRITE_PROTECT; +else if
>> (sdhci_of_wp_inverted(np)) host->quirks |=
>> SDHCI_QUIRK_INVERTED_WRITE_PROTECT;
>>
>> if (of_get_property(np, "broken-cd", NULL)) ---
>> a/drivers/mmc/host/sdhci.c2014-08-23 12:46:10.028575138 -0700
>> +++ b/drivers/mmc/host/sdhci.c2014-08-23 12:48:23.588506665
>> -0700 @@ -1621,6 +1621,8 @@
>>
>> if (host->flags & SDHCI_DEVICE_DEAD) is_readonly = 0; +else if
>> (host->quirks2 & SDHCI_QUIRK2_BROKEN_WRITE_PROTECT) +
>> is_readonly = 0; else if (host->ops->get_ro) is_readonly =
>> host->ops->get_ro(host); else --- a/include/linux/mmc/sdhci.h
>> 2014-08-23 12:56:38.005445877 -0700 +++ b/include/linux/mmc/sdhci.h
>> 2014-08-23 12:58:58.113178602
[OpenWrt-Devel] AsiaRF MT7620a mounting sdhci drive readonly
Hello All,
Been trying to get an AsiaRF based MT7620a board running using CC r42230 and
having issue getting the MMC SD card reader
to mount rw.
I have been in communication with the manufacturer to discover the GPIO (if
any) used for the WP line for the SDHCI card
reader on the board. They have not gotten back to me. In the mean time I have
attempted to use some of the mmc driver
properties such as wp-inverted to no avail. In desperation I implemented a
patch based on
http://permalink.gmane.org/gmane.linux.kernel.mmc/25615
which tells the driver to ignore the write protect line and assume r/w
always... yet the card still mounts read only.
note that when mounting the same SD card using a USB based reader the file
system mounts rw as expected.
here is the mount table showing the ro mount
root@OpenWRT:~# mount
rootfs on / type rootfs (rw)
snip...
/dev/mmcblk0p2 on /wxa type ext4 (ro,relatime,data=ordered)
here is the DTS definition for the board
sdhci@1013 {
status = "okay";
broken-wp;
};
following is the patch (some of you might find it useful). Any thoughts would
greatly be appreciated.
$ cat target/linux/ramips/patches-3.10/0402-mmc-add-broken-wp.patch
--- a/Documentation/devicetree/bindings/mmc/mmc.txt2014-08-23
12:39:54.816004290 -0700
+++ b/Documentation/devicetree/bindings/mmc/mmc.txt2014-08-23
12:40:56.574123135 -0700
@@ -21,6 +21,8 @@
below for the case, when a GPIO is used for the CD line
- wp-inverted: when present, polarity on the WP line is inverted. See the note
below for the case, when a GPIO is used for the WP line
+- broken-wp: when present, no indication of write protection is available,
+ and write protection is assumed always off.
- max-frequency: maximum operating clock frequency
- no-1-8-v: when present, denotes that 1.8v card voltage is not supported on
this system, even if the controller claims it is.
--- a/drivers/mmc/host/sdhci-pltfm.c2014-08-23 12:44:02.648454500 -0700
+++ b/drivers/mmc/host/sdhci-pltfm.c2014-08-23 12:45:52.009124011 -0700
@@ -80,7 +80,9 @@
bus_width == 1))
host->quirks |= SDHCI_QUIRK_FORCE_1_BIT_DATA;
-if (sdhci_of_wp_inverted(np))
+if (of_get_property(np, "sdhci,broken-wp", NULL) ||
of_get_property(np, "broken-wp", NULL))
+host->quirks2 |= SDHCI_QUIRK2_BROKEN_WRITE_PROTECT;
+else if (sdhci_of_wp_inverted(np))
host->quirks |= SDHCI_QUIRK_INVERTED_WRITE_PROTECT;
if (of_get_property(np, "broken-cd", NULL))
--- a/drivers/mmc/host/sdhci.c2014-08-23 12:46:10.028575138 -0700
+++ b/drivers/mmc/host/sdhci.c2014-08-23 12:48:23.588506665 -0700
@@ -1621,6 +1621,8 @@
if (host->flags & SDHCI_DEVICE_DEAD)
is_readonly = 0;
+else if (host->quirks2 & SDHCI_QUIRK2_BROKEN_WRITE_PROTECT)
+is_readonly = 0;
else if (host->ops->get_ro)
is_readonly = host->ops->get_ro(host);
else
--- a/include/linux/mmc/sdhci.h2014-08-23 12:56:38.005445877 -0700
+++ b/include/linux/mmc/sdhci.h2014-08-23 12:58:58.113178602 -0700
@@ -95,6 +95,8 @@
/* The system physically doesn't support 1.8v, even if the host does */
#define SDHCI_QUIRK2_NO_1_8_V(1<<2)
#define SDHCI_QUIRK2_PRESET_VALUE_BROKEN(1<<3)
+/* There is no indication for write protection at all, assume RW */
+#define SDHCI_QUIRK2_BROKEN_WRITE_PROTECT(1<<4)
int irq;/* Device IRQ */
void __iomem *ioaddr;/* Mapped address */
--
Luis Soltero, Ph.D., MCS
Director of Software Development, CTO
Global Marine Networks, LLC
StarPilot, LLC
Tel: +1.865.379.8723
Fax: +1.865.681.5017
E-Mail: lsolt...@globalmarinenet.net
Web: http://www.globalmarinenet.net
Web: http://www.redportglobal.com
Web: http://www.starpilotllc.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] Add Ralink RT3XXX USB OHCI driver
Hello All, I has anything happened as far as the MT7620x OHCI USB driver issue? The last posted patch for this From ffb27de4760595c356ef619c97f25722c8db28e7 Mon Sep 17 00:00:00 2001 From: John Crispin Date: Sun, 27 Jul 2014 09:49:07 +0100 Subject: [PATCH 38/57] USB: add OHCI/EHCI OF binding based on f3bc64d6d1f21c1b92d75f233a37b75d77af6963 Signed-off-by: John Crispin does not address the issue described here https://dev.openwrt.org/ticket/14516 I have a two different boards MT7620A boards from AsiaRF that I can use for testing if someone can provide guidance. One of the has one USB port and the other board has a built in Alcor USB hub. Thanks, --luis John Crispin | 31 Jul 13:39 2014 Re: [PATCH]ramips: Add Ralink RT3XXX USB OHCI driver Hi, no, we wont take this patch. i will instead figure out what is wrong with the existing code and fix it. John -- Luis Soltero, Ph.D., MCS Director of Software Development, CTO Global Marine Networks, LLC StarPilot, LLC Tel: +1.865.379.8723 Fax: +1.865.681.5017 E-Mail: lsolt...@globalmarinenet.net Web: http://www.globalmarinenet.net Web: http://www.redportglobal.com Web: http://www.starpilotllc.com ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
