Re: [OpenWrt-Devel] [PATCH] [comgt] add support for defining dial number in config file

2014-03-29 Thread Luiz Angelo Daros de Luca 
Do I need to improve anything to get commited?

---
 Luiz Angelo Daros de Luca, Me.
luizl...@gmail.com


2014-03-17 18:13 GMT-03:00 luizl...@gmail.com:

 From: Luiz Angelo Daros de Luca luizl...@gmail.com

 Signed-off-by: Luiz Angelo Daros de Luca luizl...@gmail.com
 ---
  package/network/utils/comgt/Makefile  | 2 +-
  package/network/utils/comgt/files/3g.chat | 2 +-
  package/network/utils/comgt/files/3g.sh   | 9 -
  3 files changed, 10 insertions(+), 3 deletions(-)

 diff --git a/package/network/utils/comgt/Makefile
 b/package/network/utils/comgt/Makefile
 index 5324903..89a21be 100644
 --- a/package/network/utils/comgt/Makefile
 +++ b/package/network/utils/comgt/Makefile
 @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk

  PKG_NAME:=comgt
  PKG_VERSION:=0.32
 -PKG_RELEASE:=21
 +PKG_RELEASE:=22

  PKG_SOURCE:=$(PKG_NAME).$(PKG_VERSION).tgz
  PKG_SOURCE_URL:=@SF/comgt
 diff --git a/package/network/utils/comgt/files/3g.chat
 b/package/network/utils/comgt/files/3g.chat
 index a1fa2a0..6656240 100644
 --- a/package/network/utils/comgt/files/3g.chat
 +++ b/package/network/utils/comgt/files/3g.chat
 @@ -8,5 +8,5 @@ OK  ATE1
  OK  'AT+CGDCONT=1,IP,$USE_APN'
  SAY Calling UMTS/GPRS
  TIMEOUT 30
 -OK  ATD*99***1#
 +OK  ATD$DIALNUMBER
  CONNECT ' '
 diff --git a/package/network/utils/comgt/files/3g.sh
 b/package/network/utils/comgt/files/3g.sh
 index 2dc719b..deca2c9 100644
 --- a/package/network/utils/comgt/files/3g.sh
 +++ b/package/network/utils/comgt/files/3g.sh
 @@ -13,6 +13,7 @@ proto_3g_init_config() {
 proto_config_add_string apn
 proto_config_add_string service
 proto_config_add_string pincode
 +   proto_config_add_string dialnumber
  }

  proto_3g_setup() {
 @@ -23,6 +24,7 @@ proto_3g_setup() {
 json_get_var apn apn
 json_get_var service service
 json_get_var pincode pincode
 +   json_get_var dialnumber dialnumber

 [ -e $device ] || {
 proto_set_available $interface 0
 @@ -74,10 +76,15 @@ proto_3g_setup() {
 [ -n $SIERRA ]  {
 gcom -d $device -s
 /etc/gcom/getcarrier.gcom || return 1
 }
 +
 +   if [ -z $dialnumber ]; then
 +   dialnumber=*99***1#
 +   fi
 +
 ;;
 esac

 -   connect=${apn:+USE_APN=$apn }/usr/sbin/chat -t5 -v -E -f $chat
 +   connect=${apn:+USE_APN=$apn }DIALNUMBER=$dialnumber
 /usr/sbin/chat -t5 -v -E -f $chat
 ppp_generic_setup $interface \
 noaccomp \
 nopcomp \
 --
 1.8.4.5


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] [comgt] add support for defining dial number in config file

2014-03-17 Thread luizluca 
From: Luiz Angelo Daros de Luca luizl...@gmail.com

Signed-off-by: Luiz Angelo Daros de Luca luizl...@gmail.com
---
 package/network/utils/comgt/Makefile  | 2 +-
 package/network/utils/comgt/files/3g.chat | 2 +-
 package/network/utils/comgt/files/3g.sh   | 9 -
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/package/network/utils/comgt/Makefile 
b/package/network/utils/comgt/Makefile
index 5324903..89a21be 100644
--- a/package/network/utils/comgt/Makefile
+++ b/package/network/utils/comgt/Makefile
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
 
 PKG_NAME:=comgt
 PKG_VERSION:=0.32
-PKG_RELEASE:=21
+PKG_RELEASE:=22
 
 PKG_SOURCE:=$(PKG_NAME).$(PKG_VERSION).tgz
 PKG_SOURCE_URL:=@SF/comgt
diff --git a/package/network/utils/comgt/files/3g.chat 
b/package/network/utils/comgt/files/3g.chat
index a1fa2a0..6656240 100644
--- a/package/network/utils/comgt/files/3g.chat
+++ b/package/network/utils/comgt/files/3g.chat
@@ -8,5 +8,5 @@ OK  ATE1
 OK  'AT+CGDCONT=1,IP,$USE_APN'
 SAY Calling UMTS/GPRS
 TIMEOUT 30
-OK  ATD*99***1#
+OK  ATD$DIALNUMBER
 CONNECT ' '
diff --git a/package/network/utils/comgt/files/3g.sh 
b/package/network/utils/comgt/files/3g.sh
index 2dc719b..deca2c9 100644
--- a/package/network/utils/comgt/files/3g.sh
+++ b/package/network/utils/comgt/files/3g.sh
@@ -13,6 +13,7 @@ proto_3g_init_config() {
proto_config_add_string apn
proto_config_add_string service
proto_config_add_string pincode
+   proto_config_add_string dialnumber
 }
 
 proto_3g_setup() {
@@ -23,6 +24,7 @@ proto_3g_setup() {
json_get_var apn apn
json_get_var service service
json_get_var pincode pincode
+   json_get_var dialnumber dialnumber
 
[ -e $device ] || {
proto_set_available $interface 0
@@ -74,10 +76,15 @@ proto_3g_setup() {
[ -n $SIERRA ]  {
gcom -d $device -s /etc/gcom/getcarrier.gcom 
|| return 1
}
+
+   if [ -z $dialnumber ]; then
+   dialnumber=*99***1#
+   fi
+
;;
esac
 
-   connect=${apn:+USE_APN=$apn }/usr/sbin/chat -t5 -v -E -f $chat
+   connect=${apn:+USE_APN=$apn }DIALNUMBER=$dialnumber /usr/sbin/chat -t5 
-v -E -f $chat
ppp_generic_setup $interface \
noaccomp \
nopcomp \
-- 
1.8.4.5
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] [comgt] add support for defining dial number in config file

2014-03-17 Thread luizluca 
Some telcoms requires specific dial number in order to connect 3g dongles.
Currently, the only possible way is to edit /etc/chatscripts/3g.chat, which
is not very userfriendly.

This patch adds the optional option dialnumber to /etc/config/network for 3g.
If provided, it will replace the default dial number *99***1#.

If merged, I'll update wiki doc ASAP.

The next step will be to add this field to Luci interface.

---
     Luiz Angelo Daros de Luca, Me.
            luizl...@gmail.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel