[OpenWrt-Devel] [PATCH] [scripts] Fix typo, replace quotes in comments

2014-09-04 Thread Robert P. J. Day

No functional changes.

Signed-off-by: Robert P. J. Day 

---

  first, admittedly trivial patch just to verify i'm doing this
correctly. it's only because i fixed the typo that i bothered to get
rid of those backquotes -- to me, backquotes mean something quite
special so i prefer to avoid using them unless it's in the specific
context of shell command substitution.

  if this patch is of the correct format, further patches will
eventually be more substantive.

diff --git a/scripts/update-package-md5sum b/scripts/update-package-md5sum
index 1cf1716..3b4e047 100755
--- a/scripts/update-package-md5sum
+++ b/scripts/update-package-md5sum
@@ -2,12 +2,12 @@
 #
 # update-package-md5sum - Updates md5sum of OpenWrt packages
 #
-# update-package-md5sum will update the md5sum for all recusivly found OpenWrt 
packages
-# in a given directory.
+# update-package-md5sum will update the md5sum for all recursively-found
+# OpenWrt packages in a given directory.
 #
 # Usage: scripts/update-package-md5sum 
 #
-# Example: `scripts/update-package-md5sum feeds/packages/python`
+# Example: $ scripts/update-package-md5sum feeds/packages/python

 DL_FOLDER=`grep -Eo '^CONFIG_DOWNLOAD_FOLDER=".*"$' .config | \
 sed 's,^CONFIG_DOWNLOAD_FOLDER="\(.*\)"$,\1,'`

-- 


Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:   http://twitter.com/rpjday
LinkedIn:   http://ca.linkedin.com/in/rpjday

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] [scripts] Fix typo, replace quotes in comments

2014-09-04 Thread Bastian Bittorf
* Robert P. J. Day  [04.09.2014 10:54]:
> -# Example: `scripts/update-package-md5sum feeds/packages/python`
> +# Example: $ scripts/update-package-md5sum feeds/packages/python

if you use '$' instead of '`', you must use e.g. $(...) so

`shell_command` or
$(shell_command)

bye, bastian
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] [scripts] Fix typo, replace quotes in comments

2014-09-04 Thread Robert P. J. Day
On Thu, 4 Sep 2014, Bastian Bittorf wrote:

> * Robert P. J. Day  [04.09.2014 10:54]:
> > -# Example: `scripts/update-package-md5sum feeds/packages/python`
> > +# Example: $ scripts/update-package-md5sum feeds/packages/python
>
> if you use '$' instead of '`', you must use e.g. $(...) so
>
> `shell_command` or
> $(shell_command)

  the "$" i used above is meant to represent just the command-line
prompt, it's not being used for a variable or command line
substitution. i took out the backquotes specifically *because* i
didn't think just showing a command example needed to incorporate
command substitution. perhaps i should have just left the "$" out
entirely.

rday

-- 


Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:   http://twitter.com/rpjday
LinkedIn:   http://ca.linkedin.com/in/rpjday

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel