Re: [OpenWrt-Devel] [PATCH] -fPIC flag for nacl

2012-12-17 Thread Szabolcs Nagy 
* Chris Warner  [2012-12-14 07:33:43 +0430]:
> In order to get cjdns to cross-compile I had to enable -fPIC for the
> nacl package in the makefile. I have included my patch below. I am

last time i checked nacl only provided statically linked
binaries

and it has asm implementations for certain platforms that
are not position independent

so -fPIC is probably not useful
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] -fPIC flag for nacl

2012-12-13 Thread Chris Warner 
Greetings all,
In order to get cjdns to cross-compile I had to enable -fPIC for the
nacl package in the makefile. I have included my patch below. I am
under the impression that including this flag is a standard practice
for many routines like this. Please let me know if I am going about
this correctly or if there is a better method. Thank you.

-Chris


Patch:


Index: feeds/packages/libs/nacl/Makefile
===
--- feeds/packages/libs/nacl/Makefile (revision 34672)
+++ feeds/packages/libs/nacl/Makefile (working copy)
@@ -30,7 +30,7 @@
  cd $(PKG_BUILD_DIR); \
  chmod +x do-openwrt; \
  CC="$(TARGET_CC)" \
- CFLAGS="$(TARGET_CFLAGS) $(TARGET_CPPFLAGS)" \
+ CFLAGS="-fPIC $(TARGET_CFLAGS) $(TARGET_CPPFLAGS)" \
  AR="$(TARGET_CROSS)ar" \
  RANLIB="$(TARGET_CROSS)ranlib" \
  ./do-openwrt \
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel