Re: [OpenWrt-Devel] [PATCH] Upgrade the babel package, renaming it to babeld

2009-11-22 Thread Jan Willies

Hi Edgar,

Am 22.11.2009 19:25, schrieb edgar.sol...@web.de:

You manage the openwrt svn by a git interface?


http://www.nbd.name/gitweb.cgi


 - jan
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] Upgrade the babel package, renaming it to babeld

2009-11-22 Thread edgar . soldin

You manage the openwrt svn by a git interface?

.. ede

I don't know how you can force svn to generate proper patches - I use
git and it's better at handling such things.

- Felix
   


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] Upgrade the babel package, renaming it to babeld

2009-11-21 Thread Felix Fietkau
Gabriel Kerneis wrote:
> Hello,
> 
> the following patch upgrades the babel package to 0.97.
> 
> Babel has been renamed to babeld since 0.96 [1], but the name has not
> been changed in OpenWRT.  The following patch changes every occurrence
> of babel to babeld (this is necessary because upstream changed the names
> of the config files [2], and it might be confusing to have babel in some
> places and babeld in others).
> 
> Unfortunately, svn diff doesn't show the "svn mv" and "svn rm" steps.
> Here is what I did:
> svn mv net/babel net/babeld
> svn mv net/babeld/babel.init net/babeld/babeld.init
> svn mv net/babeld/babel.conf net/babeld/babeld.conf
> svn mv net/babeld/babel.config net/babeld/babeld.config
> svn rm net/babel
> 
> Moreover, there is a spurious ipv6/babel directory in the packages
> repository, forgotten (I guess) during a previous migration:
> 
> svn rm ipv6/babel
> 
> Here is the resulting svn status:
> D   ipv6/babel
> D   ipv6/babel/files
> A  +net/babeld
> D   net/babeld/files/babel.init
> D  +net/babeld/files/babel.conf
> D  +net/babeld/files/babel.config
> A   net/babeld/files/babeld.init
> A  +net/babeld/files/babeld.conf
> A  +net/babeld/files/babeld.config
> M  +net/babeld/Makefile
> 
> In addition, this patch:
> - adds librt dependency to the Makefile,
> - removes duplicated content from the sample babeld.conf file.
> 
> Please let me know if anything looks wrong or if there is a way to send
> a better patch (including the removal steps).
I applied it manually and committed it in r18462
I don't know how you can force svn to generate proper patches - I use
git and it's better at handling such things.

- Felix

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH] Upgrade the babel package, renaming it to babeld

2009-11-16 Thread Gabriel Kerneis
Hello,

the following patch upgrades the babel package to 0.97.

Babel has been renamed to babeld since 0.96 [1], but the name has not
been changed in OpenWRT.  The following patch changes every occurrence
of babel to babeld (this is necessary because upstream changed the names
of the config files [2], and it might be confusing to have babel in some
places and babeld in others).

Unfortunately, svn diff doesn't show the "svn mv" and "svn rm" steps.
Here is what I did:
svn mv net/babel net/babeld
svn mv net/babeld/babel.init net/babeld/babeld.init
svn mv net/babeld/babel.conf net/babeld/babeld.conf
svn mv net/babeld/babel.config net/babeld/babeld.config
svn rm net/babel

Moreover, there is a spurious ipv6/babel directory in the packages
repository, forgotten (I guess) during a previous migration:

svn rm ipv6/babel

Here is the resulting svn status:
D   ipv6/babel
D   ipv6/babel/files
A  +net/babeld
D   net/babeld/files/babel.init
D  +net/babeld/files/babel.conf
D  +net/babeld/files/babel.config
A   net/babeld/files/babeld.init
A  +net/babeld/files/babeld.conf
A  +net/babeld/files/babeld.config
M  +net/babeld/Makefile

In addition, this patch:
- adds librt dependency to the Makefile,
- removes duplicated content from the sample babeld.conf file.

Please let me know if anything looks wrong or if there is a way to send
a better patch (including the removal steps).

[1] 
[http://lists.alioth.debian.org/pipermail/babel-users/2009-August/000269.html]
[2] 
[http://lists.alioth.debian.org/pipermail/babel-users/2009-November/000314.html]

Regards,

Signed-off-by: Gabriel Kerneis 

---

Index: net/babeld/files/babel.init
===
--- net/babeld/files/babel.init (révision 18433)
+++ net/babeld/files/babel.init (copie de travail)
@@ -1,32 +0,0 @@
-#!/bin/sh /etc/rc.common
-
-START=70
-
-pidfile=/var/run/babeld.pid
-
-babel_config() {
-   local cfg="$1"
-   config_get interfaces "$cfg" interfaces
-}
-
-start() {
-   if [ -x /etc/rc.d/S71ahcpd ] ; then
-   echo 'Not starting babel -- will be started by ahcpd.'
-   exit 0
-   fi
-   config_load babel
-   config_foreach babel_config babel
-   mkdir -p /var/lib
-   if [ -e $pidfile ] ; then
-   echo "$pidfile exists -- not starting babel." >&2
-   else
-   /usr/sbin/babeld -D -I $pidfile $interfaces
-   fi
-}
-
-stop() {
-   [ -e $pidfile ] && kill $(cat $pidfile)
-   [ -e $pidfile ] && sleep 2
-   [ -e $pidfile ] && sleep 4
-   [ -e $pidfile ] && echo "Failed to stop babel ($pidfile still exists)."
-}
Index: net/babeld/files/babeld.init
===
--- net/babeld/files/babeld.init(révision 0)
+++ net/babeld/files/babeld.init(révision 0)
@@ -0,0 +1,28 @@
+#!/bin/sh /etc/rc.common
+
+START=70
+
+pidfile=/var/run/babeld.pid
+
+babeld_config() {
+   local cfg="$1"
+   config_get interfaces "$cfg" interfaces
+}
+
+start() {
+   config_load babeld
+   config_foreach babeld_config babeld
+   mkdir -p /var/lib
+   if [ -e $pidfile ] ; then
+   echo "$pidfile exists -- not starting babel." >&2
+   else
+   /usr/sbin/babeld -D -I $pidfile $interfaces
+   fi
+}
+
+stop() {
+   [ -e $pidfile ] && kill $(cat $pidfile)
+   [ -e $pidfile ] && sleep 2
+   [ -e $pidfile ] && sleep 4
+   [ -e $pidfile ] && echo "Failed to stop babel ($pidfile still exists)."
+}

Modification de propriétés sur net/babeld/files/babeld.init
___
Ajouté : svn:executable
   + *

Index: net/babeld/files/babeld.conf
===
--- net/babeld/files/babeld.conf(révision 18353)
+++ net/babeld/files/babeld.conf(copie de travail)
@@ -2,7 +2,7 @@
 # Copyright (C) 2008 Juliusz Chroboczek, L. Aaron Kaplan
 #, 
 #
-# This config file simply docuements sample entries. 
+# This config file simply documents sample entries. 
 # "redistribute" means: redistribute routes from other 
 #  routing protocols into babel. "local" means addresses assigned to local 
interfaces.
 #
@@ -26,31 +26,3 @@
 # no redistribute local rules are going to match
 ## redistribute local ip 192.160.4.0/24 
 ## redistribute local deny
-# babel config file
-# Copyright (C) 2008 Juliusz Chroboczek, L. Aaron Kaplan
-#, 
-#
-# This config file simply docuements sample entries. 
-# "redistribute" means: redistribute routes from other 
-#  routing protocols into babel. "local" means addresses assigned to local 
interfaces.
-#
-# the default rules are:
-#
-## redistribute local 
-## redistribute deny
-#
-# this says, redistribute local addresses but no other routes
-
-
-
-# redistribute IPv4 default route into babel 
-## redistribute local ip 0.0.0.0/0 le 0 metric 128
-
-# same