Re: [OpenWrt-Devel] [PATCH] brcm47xx: drop global description in favour of subtarget ones
On 28 May 2015 at 23:43, Rafał Miłecki zaj...@gmail.com wrote: On 28 May 2015 at 23:35, Michael Heimpold m...@heimpold.de wrote: Defining a description in this makefile prevents the subtarget Target/Description sections to appear in menuconfig's help for the subtargets. However, this also removes the menuconfig's help text for the target itself, but I'm not skilled enough to avoid this. Guys, can we somehow improve (sub)targets handling? I'd expect 1) Target System use brcm47xx/Makefile 2) Subtarget use brcm47xx/*/target.mk Ping? -- Rafał ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] brcm47xx: drop global description in favour of subtarget ones
Defining a description in this makefile prevents the subtarget Target/Description sections to appear in menuconfig's help for the subtargets. However, this also removes the menuconfig's help text for the target itself, but I'm not skilled enough to avoid this. Signed-off-by: Michael Heimpold m...@heimpold.de --- target/linux/brcm47xx/Makefile |5 - 1 file changed, 5 deletions(-) diff --git a/target/linux/brcm47xx/Makefile b/target/linux/brcm47xx/Makefile index 22b8674..4ac644c 100644 --- a/target/linux/brcm47xx/Makefile +++ b/target/linux/brcm47xx/Makefile @@ -17,11 +17,6 @@ KERNEL_PATCHVER:=3.18 include $(INCLUDE_DIR)/target.mk - -define Target/Description - Build firmware images for Broadcom based BCM47xx/53xx routers with MIPS CPU, *not* ARM. -endef - DEFAULT_PACKAGES += swconfig wpad-mini nvram otrx \ kmod-leds-gpio kmod-gpio-button-hotplug \ kmod-ledtrig-default-on kmod-ledtrig-timer kmod-ledtrig-netdev -- 1.7.10.4 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] brcm47xx: drop global description in favour of subtarget ones
On 28 May 2015 at 23:35, Michael Heimpold m...@heimpold.de wrote: Defining a description in this makefile prevents the subtarget Target/Description sections to appear in menuconfig's help for the subtargets. However, this also removes the menuconfig's help text for the target itself, but I'm not skilled enough to avoid this. Guys, can we somehow improve (sub)targets handling? I'd expect 1) Target System use brcm47xx/Makefile 2) Subtarget use brcm47xx/*/target.mk ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
