Hi,
> This is a trial to make it more obvious what the historically
> grown code is actually doing.
when we already refactor the code...
> Signed-off-by: Michael Heimpold
> ---
> inittab.c | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/inittab.c b/inittab.c
> index 4b9..41816b7 100644
> --- a/inittab.c
> +++ b/inittab.c
> @@ -259,12 +259,11 @@ void procd_inittab_run(const char *handler)
>
> list_for_each_entry(a, , list)
> if (!strcmp(a->handler->name, handler)) {
> - if (a->handler->multi) {
> - a->handler->cb(a);
> - continue;
> - }
> a->handler->cb(a);
> - break;
> + if (a->handler->multi)
> + continue;
> + else
> + break;
... why not just change this to:
if (!a->handler->multi)
break;
> }
> }
>
>
Regards,
Jo
signature.asc
Description: OpenPGP digital signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
